)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"ccdcecdb16d080313549f179ce45eb8c7f51fbbc","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rajiv Kumar \u003crajiv.kumar@nectechnologies.in\u003e"},{"line_number":5,"context_line":"CommitDate: 2017-08-23 11:17:03 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Full Sync: Moved resource fetching in corresponding driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I8fd19e9b70e7a95530ef60436c3049207d828d37"},{"line_number":10,"context_line":"Partial-bug: #1711271"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7f287b81_6d856aad","line":7,"updated":"2017-08-23 14:29:50.000000000","message":"It\u0027s a pretty non descriptive commit message. It\u0027s always a good idea to have a \u003c79 characters title and then a longer description where you explain why you are introducing the changes.\n\nSpecially on a change that\u0027s big like this and people without the context of our discussions can\u0027t actually understand it.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"}],"networking_odl/bgpvpn/odl_v2.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"ccdcecdb16d080313549f179ce45eb8c7f51fbbc","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return resources"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":133,"context_line":"        plugin \u003d directory.get_plugin(bgpvpn_const.LABEL)"},{"line_number":134,"context_line":"        if resource_type \u003d\u003d odl_const.ODL_BGPVPN:"},{"line_number":135,"context_line":"            obj_getter \u003d getattr(plugin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_cd457e72","line":132,"range":{"start_line":132,"start_character":4,"end_line":132,"end_character":52},"updated":"2017-08-23 14:29:50.000000000","message":"I would make it a classmethod since it doesn\u0027t depend on the instance attributes and the function it calls is a staticmethod anyways.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":129,"context_line":""},{"line_number":130,"context_line":"        return resources"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":133,"context_line":"        plugin \u003d directory.get_plugin(bgpvpn_const.LABEL)"},{"line_number":134,"context_line":"        if resource_type \u003d\u003d odl_const.ODL_BGPVPN:"},{"line_number":135,"context_line":"            obj_getter \u003d getattr(plugin,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_711bf51a","line":132,"range":{"start_line":132,"start_character":4,"end_line":132,"end_character":52},"in_reply_to":"7f287b81_cd457e72","updated":"2017-08-24 06:38:27.000000000","message":"Done","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fd82e9237aa1ecc9d79def113aa5e4ed1830482d","unresolved":false,"context_lines":[{"line_number":122,"context_line":"        plugin \u003d directory.get_plugin(bgpvpn_const.LABEL)"},{"line_number":123,"context_line":"        if resource_type \u003d\u003d odl_const.ODL_BGPVPN:"},{"line_number":124,"context_line":"            obj_getter \u003d getattr(plugin,"},{"line_number":125,"context_line":"                                 \u0027get_%s\u0027 % BGPVPN_RESOURCES[resource_type])"},{"line_number":126,"context_line":"            return obj_getter(context)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        method_name \u003d \u0027get_%s\u0027 % BGPVPN_RESOURCES[resource_type]"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_4d003902","line":125,"range":{"start_line":125,"start_character":33,"end_line":125,"end_character":75},"updated":"2017-08-25 00:01:13.000000000","message":"This is determined statically.\ngetattr isn\u0027t needed.\njust simle method call can be used.","commit_id":"0683366f7ed4425f935c8e508c6b035887284789"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fd82e9237aa1ecc9d79def113aa5e4ed1830482d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"                                 \u0027get_%s\u0027 % BGPVPN_RESOURCES[resource_type])"},{"line_number":126,"context_line":"            return obj_getter(context)"},{"line_number":127,"context_line":""},{"line_number":128,"context_line":"        method_name \u003d \u0027get_%s\u0027 % BGPVPN_RESOURCES[resource_type]"},{"line_number":129,"context_line":"        return full_sync.get_resources_require_id(plugin, context,"},{"line_number":130,"context_line":"                                                  \u0027get_bgpvpns\u0027, method_name)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_2d03ad0f","line":130,"range":{"start_line":128,"start_character":7,"end_line":130,"end_character":77},"updated":"2017-08-25 00:01:13.000000000","message":"ditto.","commit_id":"0683366f7ed4425f935c8e508c6b035887284789"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1bbd973713f10e8eb9c2bdae710d1c09b91970c4","unresolved":false,"context_lines":[{"line_number":117,"context_line":"        journal.record(context, odl_const.ODL_BGPVPN,"},{"line_number":118,"context_line":"                       bgpvpn[\u0027id\u0027], odl_const.ODL_UPDATE, bgpvpn)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":"    @classmethod"},{"line_number":121,"context_line":"    def get_resources(cls, context, resource_type):"},{"line_number":122,"context_line":"        plugin \u003d directory.get_plugin(bgpvpn_const.LABEL)"},{"line_number":123,"context_line":"        if resource_type \u003d\u003d odl_const.ODL_BGPVPN:"},{"line_number":124,"context_line":"            obj_getter \u003d getattr(plugin,"},{"line_number":125,"context_line":"                                 \u0027get_%s\u0027 % BGPVPN_RESOURCES[resource_type])"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_b1d33660","line":122,"range":{"start_line":120,"start_character":4,"end_line":122,"end_character":57},"updated":"2017-08-28 20:03:35.000000000","message":"Please be consistent on where to put this method in the class definition.\nIn odl_v2, it\u0027s at the last of class definition.\nin lbaas, it\u0027s at the after of record method.","commit_id":"8307bc1f9fee382f66c959a8d829bd449460cf5d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"533a54d55173591331ba8946dba7c2c58af49e1d","unresolved":false,"context_lines":[{"line_number":60,"context_line":"        full_sync.register(bgpvpn_const.LABEL, BGPVPN_RESOURCES,"},{"line_number":61,"context_line":"                           self.get_resources)"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"    @classmethod"},{"line_number":64,"context_line":"    def get_resources(cls, context, resource_type):"},{"line_number":65,"context_line":"        plugin \u003d directory.get_plugin(bgpvpn_const.LABEL)"},{"line_number":66,"context_line":"        if resource_type \u003d\u003d odl_const.ODL_BGPVPN:"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_3665e046","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":16},"updated":"2017-08-29 16:34:41.000000000","message":"why not @staticmethod?\ncls isn\u0027t used.","commit_id":"bd032be462c3166c381edb84f66fbedf0788f783"}],"networking_odl/journal/full_sync.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"ccdcecdb16d080313549f179ce45eb8c7f51fbbc","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f287b81_8ddad6e6","updated":"2017-08-23 14:29:50.000000000","message":"I like how now the code is actually easy to understand, don\u0027t you?","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":1,"id":"7f287b81_5118f91b","in_reply_to":"7f287b81_8ddad6e6","updated":"2017-08-24 06:38:27.000000000","message":"yes","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"ccdcecdb16d080313549f179ce45eb8c7f51fbbc","unresolved":false,"context_lines":[{"line_number":66,"context_line":"FULL_SYNC_RESOURCES \u003d {}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def register_for_full_sync(resource, handler):"},{"line_number":70,"context_line":"    FULL_SYNC_RESOURCES[resource] \u003d handler"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def register(driver, resources, handler):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_8d7d361e","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":43},"updated":"2017-08-23 14:29:50.000000000","message":"no need for a function for this, just do this in the for in L76","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":66,"context_line":"FULL_SYNC_RESOURCES \u003d {}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def register_for_full_sync(resource, handler):"},{"line_number":70,"context_line":"    FULL_SYNC_RESOURCES[resource] \u003d handler"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def register(driver, resources, handler):"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_f1dc8547","line":70,"range":{"start_line":69,"start_character":0,"end_line":70,"end_character":43},"in_reply_to":"7f287b81_8d7d361e","updated":"2017-08-24 06:38:27.000000000","message":"Done","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"ccdcecdb16d080313549f179ce45eb8c7f51fbbc","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    FULL_SYNC_RESOURCES[resource] \u003d handler"},{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def register(driver, resources, handler):"},{"line_number":74,"context_line":"    ALL_RESOURCES[driver] \u003d resources"},{"line_number":75,"context_line":"    for resource in resources:"},{"line_number":76,"context_line":"        register_for_full_sync(resource, handler)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_39f0ccc9","line":73,"range":{"start_line":73,"start_character":31,"end_line":73,"end_character":39},"updated":"2017-08-23 14:29:50.000000000","message":"JUST TO THINK ABOUT IT, NO CHANGE NEEDED\n\nperhaps it\u0027s better to have a subclass of a new ABC driver class that we define? So then the class that subclasses from that ABC could be used for several things, including full_sync.\n\nOr perhaps this should only happen in a refector when we actually need it.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"ccdcecdb16d080313549f179ce45eb8c7f51fbbc","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def register(driver, resources, handler):"},{"line_number":74,"context_line":"    ALL_RESOURCES[driver] \u003d resources"},{"line_number":75,"context_line":"    for resource in resources:"},{"line_number":76,"context_line":"        register_for_full_sync(resource, handler)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_4d486ecb","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":37},"updated":"2017-08-23 14:29:50.000000000","message":"you only maintain this for journal.recovery, which from what I see does the same full_sync was doing and thus might have the same problem we had here in full sync, right?\n\nWanna check this and perhaps see if you can just not create two dictionaries?","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":71,"context_line":""},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"def register(driver, resources, handler):"},{"line_number":74,"context_line":"    ALL_RESOURCES[driver] \u003d resources"},{"line_number":75,"context_line":"    for resource in resources:"},{"line_number":76,"context_line":"        register_for_full_sync(resource, handler)"},{"line_number":77,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_b1e6fd15","line":74,"range":{"start_line":74,"start_character":4,"end_line":74,"end_character":37},"in_reply_to":"7f287b81_4d486ecb","updated":"2017-08-24 06:38:27.000000000","message":"Yeah, i will remove this variable in next patch, where i will be doing similar thing with recovery.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"ccdcecdb16d080313549f179ce45eb8c7f51fbbc","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"    db.delete_pending_rows(context.session, _OPS_TO_DELETE_ON_SYNC)"},{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    for resource_type in _ORDERED_ODL_RESOURCES:"},{"line_number":86,"context_line":"        handler \u003d FULL_SYNC_RESOURCES.get(resource_type)"},{"line_number":87,"context_line":"        if handler:"},{"line_number":88,"context_line":"            _sync_resources(context, resource_type, handler)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_6d69ea23","line":85,"range":{"start_line":85,"start_character":4,"end_line":85,"end_character":47},"updated":"2017-08-23 14:29:50.000000000","message":"I like how you eliminated an unnecesary for :)","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"ccdcecdb16d080313549f179ce45eb8c7f51fbbc","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    for resource_type in _ORDERED_ODL_RESOURCES:"},{"line_number":86,"context_line":"        handler \u003d FULL_SYNC_RESOURCES.get(resource_type)"},{"line_number":87,"context_line":"        if handler:"},{"line_number":88,"context_line":"            _sync_resources(context, resource_type, handler)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    journal.record(context, odl_const.ODL_NETWORK, _CANARY_NETWORK_ID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_cd5b3e85","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":19},"updated":"2017-08-23 14:29:50.000000000","message":"there is nothing we want to do if there is no handler? I guess not, as it wasn\u0027t handled before either.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    for resource_type in _ORDERED_ODL_RESOURCES:"},{"line_number":86,"context_line":"        handler \u003d FULL_SYNC_RESOURCES.get(resource_type)"},{"line_number":87,"context_line":"        if handler:"},{"line_number":88,"context_line":"            _sync_resources(context, resource_type, handler)"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    journal.record(context, odl_const.ODL_NETWORK, _CANARY_NETWORK_ID,"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_91e30106","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":19},"in_reply_to":"7f287b81_cd5b3e85","updated":"2017-08-24 06:38:27.000000000","message":"Line number 81 previous took care of it.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fd82e9237aa1ecc9d79def113aa5e4ed1830482d","unresolved":false,"context_lines":[{"line_number":68,"context_line":"FULL_SYNC_RESOURCES \u003d {}"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def register(driver, resources, handler):"},{"line_number":72,"context_line":"    ALL_RESOURCES[driver] \u003d resources"},{"line_number":73,"context_line":"    for resource in resources:"},{"line_number":74,"context_line":"        FULL_SYNC_RESOURCES[resource] \u003d handler"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_6a551b1d","line":71,"range":{"start_line":71,"start_character":32,"end_line":71,"end_character":39},"updated":"2017-08-25 00:01:13.000000000","message":"Since most cases can be handled in generic way,\nwe can put handler\u003dNone and in None case, we can falls back to generic case.\n\nsomething like this with closure.\ndef default_handler(context, resource_type):\n    return get_handler(context, driver, resources[resource_type])\nhanlder \u003d handler or default_handler","commit_id":"0683366f7ed4425f935c8e508c6b035887284789"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"97502679a2358cec6b3caa1c3a0432e469d3ce17","unresolved":false,"context_lines":[{"line_number":69,"context_line":""},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"def register(driver, resources, handler):"},{"line_number":72,"context_line":"    ALL_RESOURCES[driver] \u003d resources"},{"line_number":73,"context_line":"    for resource in resources:"},{"line_number":74,"context_line":"        FULL_SYNC_RESOURCES[resource] \u003d handler"},{"line_number":75,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_8998751b","line":72,"updated":"2017-08-24 06:53:49.000000000","message":"Put a TODO saying to remove ALL_RESOURCES by modifying recovery","commit_id":"0683366f7ed4425f935c8e508c6b035887284789"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"aa5e387ba9a664de4099d66fa78a4da72b5abcc1","unresolved":false,"context_lines":[{"line_number":63,"context_line":")"},{"line_number":64,"context_line":""},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"ALL_RESOURCES \u003d {}"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"FULL_SYNC_RESOURCES \u003d {}"},{"line_number":69,"context_line":""}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_bb2a1029","line":66,"updated":"2017-08-27 06:55:15.000000000","message":"Add a TODO to remove this when you do the work in `journal.recovery`","commit_id":"81dbc659252a7a6f66874a41aacd24dbe5489b95"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"4a8cf169e394f1ada801ff490c0b67b7614c22bf","unresolved":false,"context_lines":[{"line_number":120,"context_line":"        context.session, _CANARY_NETWORK_ID, operation\u003dodl_const.ODL_CREATE)"},{"line_number":121,"context_line":""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"def get_resources_require_id(plugin, context, get_id_method, method_name):"},{"line_number":124,"context_line":"    dep_id_resources \u003d getattr(plugin, get_id_method)(context)"},{"line_number":125,"context_line":"    resources \u003d []"},{"line_number":126,"context_line":"    for d_resource in dep_id_resources:"}],"source_content_type":"text/x-python","patch_set":4,"id":"7f287b81_a400b968","line":123,"range":{"start_line":123,"start_character":46,"end_line":123,"end_character":72},"updated":"2017-08-25 22:21:27.000000000","message":"name + getattr is redundant.\ncaller can just pass method itself.\nplugin.get_bgpvpn, plugin.get...","commit_id":"81dbc659252a7a6f66874a41aacd24dbe5489b95"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1bbd973713f10e8eb9c2bdae710d1c09b91970c4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"# TODO(rajivk): Remove this variable, while fixing recovery"},{"line_number":64,"context_line":"ALL_RESOURCES \u003d {}"},{"line_number":65,"context_line":""},{"line_number":66,"context_line":"FULL_SYNC_RESOURCES \u003d dict()"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"def register(driver, resources, handler\u003dNone):"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_912efa8f","line":66,"range":{"start_line":66,"start_character":22,"end_line":66,"end_character":28},"updated":"2017-08-28 20:03:35.000000000","message":"Please be consistent to use {} or dict().","commit_id":"8307bc1f9fee382f66c959a8d829bd449460cf5d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"1bbd973713f10e8eb9c2bdae710d1c09b91970c4","unresolved":false,"context_lines":[{"line_number":118,"context_line":"        context.session, _CANARY_NETWORK_ID, operation\u003dodl_const.ODL_CREATE)"},{"line_number":119,"context_line":""},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"def get_resources_require_id(plugin, context, method, method_name):"},{"line_number":122,"context_line":"    dep_id_resources \u003d method(context)"},{"line_number":123,"context_line":"    resources \u003d []"},{"line_number":124,"context_line":"    for d_resource in dep_id_resources:"}],"source_content_type":"text/x-python","patch_set":6,"id":"7f287b81_f18e5e77","line":121,"range":{"start_line":121,"start_character":46,"end_line":121,"end_character":65},"updated":"2017-08-28 20:03:35.000000000","message":"Please name them more descriptive.\nI can\u0027t infer the difference between method and method_name.","commit_id":"8307bc1f9fee382f66c959a8d829bd449460cf5d"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"625075f3ca47fe12c89642f7e3367cde44d2fb37","unresolved":false,"context_lines":[{"line_number":139,"context_line":""},{"line_number":140,"context_line":""},{"line_number":141,"context_line":"def _sync_resources(context, object_type, handler):"},{"line_number":142,"context_line":"    print(object_type, handler)"},{"line_number":143,"context_line":"    resources \u003d handler(context, object_type)"},{"line_number":144,"context_line":"    for resource in resources:"},{"line_number":145,"context_line":"        journal.record(context, object_type, resource[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":7,"id":"7f287b81_3075f632","line":142,"updated":"2017-08-29 05:44:53.000000000","message":"Will remove it.","commit_id":"54026f15199995467a24f956d00667af35d685cf"}],"networking_odl/l2gateway/driver_v2.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"ccdcecdb16d080313549f179ce45eb8c7f51fbbc","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                       odl_const.ODL_DELETE,"},{"line_number":97,"context_line":"                       l2_gateway_connection_id)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":100,"context_line":"        plugin \u003d directory.get_plugin(constants.L2GW)"},{"line_number":101,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % L2GW_RESOURCES[resource_type])"},{"line_number":102,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_cd3a1ee6","line":99,"updated":"2017-08-23 14:29:50.000000000","message":"I would make it a staticmethod","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                       odl_const.ODL_DELETE,"},{"line_number":97,"context_line":"                       l2_gateway_connection_id)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":100,"context_line":"        plugin \u003d directory.get_plugin(constants.L2GW)"},{"line_number":101,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % L2GW_RESOURCES[resource_type])"},{"line_number":102,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_51ed99ed","line":99,"in_reply_to":"7f287b81_88408437","updated":"2017-08-24 06:38:27.000000000","message":"Done","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"99d2c920393ec99fb990de84e8d67ec881ff42cb","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                       odl_const.ODL_DELETE,"},{"line_number":97,"context_line":"                       l2_gateway_connection_id)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":100,"context_line":"        plugin \u003d directory.get_plugin(constants.L2GW)"},{"line_number":101,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % L2GW_RESOURCES[resource_type])"},{"line_number":102,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_88408437","line":99,"in_reply_to":"7f287b81_cd3a1ee6","updated":"2017-08-23 14:34:23.000000000","message":"And pay attention at what I said about repeating code.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":96,"context_line":"                       odl_const.ODL_DELETE,"},{"line_number":97,"context_line":"                       l2_gateway_connection_id)"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":100,"context_line":"        plugin \u003d directory.get_plugin(constants.L2GW)"},{"line_number":101,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % L2GW_RESOURCES[resource_type])"},{"line_number":102,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_71f095ca","line":99,"in_reply_to":"7f287b81_cd3a1ee6","updated":"2017-08-24 06:38:27.000000000","message":"Done","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"}],"networking_odl/l3/l3_odl_v2.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"99d2c920393ec99fb990de84e8d67ec881ff42cb","unresolved":false,"context_lines":[{"line_number":201,"context_line":"            self.dvr_deletens_if_no_port_warned \u003d True"},{"line_number":202,"context_line":"        return []"},{"line_number":203,"context_line":""},{"line_number":204,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":205,"context_line":"        plugin \u003d directory.get_plugin(plugin_constants.L3)"},{"line_number":206,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % L3_RESOURCES[resource_type])"},{"line_number":207,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_a874609a","line":204,"updated":"2017-08-23 14:34:23.000000000","message":"I would make it a staticmethod and pay attention about my comment on repeating code.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"}],"networking_odl/lbaas/lbaasv2_driver_v2.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"99d2c920393ec99fb990de84e8d67ec881ff42cb","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return resources"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":88,"context_line":"        plugin \u003d directory.get_plugin(nlib_const.LOADBALANCERV2)"},{"line_number":89,"context_line":"        if resource_type \u003d\u003d odl_const.ODL_MEMBER:"},{"line_number":90,"context_line":"            return self.get_pool_members(context, plugin)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_e89f08b2","line":87,"updated":"2017-08-23 14:34:23.000000000","message":"I would make it a classmethod and pay attention about my comment on repeating code.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"        return resources"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":88,"context_line":"        plugin \u003d directory.get_plugin(nlib_const.LOADBALANCERV2)"},{"line_number":89,"context_line":"        if resource_type \u003d\u003d odl_const.ODL_MEMBER:"},{"line_number":90,"context_line":"            return self.get_pool_members(context, plugin)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_11c15155","line":87,"in_reply_to":"7f287b81_e89f08b2","updated":"2017-08-24 06:38:27.000000000","message":"Done","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"fd82e9237aa1ecc9d79def113aa5e4ed1830482d","unresolved":false,"context_lines":[{"line_number":81,"context_line":"                                                      \u0027get_pools\u0027,"},{"line_number":82,"context_line":"                                                      \u0027get_pool_members\u0027)"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % LBAAS_RESOURCES[resource_type])"},{"line_number":85,"context_line":"        return obj_getter(context)"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @log_helpers.log_method_call"},{"line_number":88,"context_line":"    @driver_base.driver_op"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f287b81_ad0e7d2f","line":85,"range":{"start_line":84,"start_character":0,"end_line":85,"end_character":34},"updated":"2017-08-25 00:01:13.000000000","message":"getattr isn\u0027t necessary.\nsimple method call can be used.","commit_id":"0683366f7ed4425f935c8e508c6b035887284789"}],"networking_odl/ml2/mech_driver_v2.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"99d2c920393ec99fb990de84e8d67ec881ff42cb","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                   in VLAN_TRANSPARENT_NETWORK_TYPES"},{"line_number":247,"context_line":"                   for segment in segments)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":250,"context_line":"        plugin \u003d directory.get_plugin(nlib_const.CORE)"},{"line_number":251,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % L2_RESOURCES[resource_type])"},{"line_number":252,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_6894388c","line":249,"updated":"2017-08-23 14:34:23.000000000","message":"I would make it a staticmethod and pay attention about my comment on repeating code.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":246,"context_line":"                   in VLAN_TRANSPARENT_NETWORK_TYPES"},{"line_number":247,"context_line":"                   for segment in segments)"},{"line_number":248,"context_line":""},{"line_number":249,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":250,"context_line":"        plugin \u003d directory.get_plugin(nlib_const.CORE)"},{"line_number":251,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % L2_RESOURCES[resource_type])"},{"line_number":252,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_f1b5a5ef","line":249,"in_reply_to":"7f287b81_6894388c","updated":"2017-08-24 06:38:27.000000000","message":"Done","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"}],"networking_odl/qos/qos_driver_v2.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"99d2c920393ec99fb990de84e8d67ec881ff42cb","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def delete_policy(self, context, policy):"},{"line_number":102,"context_line":"        self.journal.set_sync_event()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":105,"context_line":"        plugin \u003d directory.get_plugin(nlib_const.QOS)"},{"line_number":106,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % QOS_RESOURCES[resource_type])"},{"line_number":107,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_08e93419","line":104,"updated":"2017-08-23 14:34:23.000000000","message":"I would make it a staticmethod and pay attention about my comment on repeating code.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":101,"context_line":"    def delete_policy(self, context, policy):"},{"line_number":102,"context_line":"        self.journal.set_sync_event()"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":105,"context_line":"        plugin \u003d directory.get_plugin(nlib_const.QOS)"},{"line_number":106,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % QOS_RESOURCES[resource_type])"},{"line_number":107,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_d1baa9dc","line":104,"in_reply_to":"7f287b81_08e93419","updated":"2017-08-24 06:38:27.000000000","message":"Done","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"}],"networking_odl/sfc/flowclassifier/sfc_flowclassifier_v2.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"99d2c920393ec99fb990de84e8d67ec881ff42cb","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        super(OpenDaylightSFCFlowClassifierDriverV2,"},{"line_number":92,"context_line":"              self).delete_flow_classifier(context)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":95,"context_line":"        plugin \u003d directory.get_plugin(fc_const.FLOW_CLASSIFIER_EXT)"},{"line_number":96,"context_line":"        obj_getter \u003d getattr(plugin,"},{"line_number":97,"context_line":"                             \u0027get_%s\u0027 % SFC_FC_RESOURCES[resource_type])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_68d9d881","line":94,"updated":"2017-08-23 14:34:23.000000000","message":"I would make it a staticmethod and pay attention about my comment on repeating code.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":91,"context_line":"        super(OpenDaylightSFCFlowClassifierDriverV2,"},{"line_number":92,"context_line":"              self).delete_flow_classifier(context)"},{"line_number":93,"context_line":""},{"line_number":94,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":95,"context_line":"        plugin \u003d directory.get_plugin(fc_const.FLOW_CLASSIFIER_EXT)"},{"line_number":96,"context_line":"        obj_getter \u003d getattr(plugin,"},{"line_number":97,"context_line":"                             \u0027get_%s\u0027 % SFC_FC_RESOURCES[resource_type])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_b1cf1d7e","line":94,"in_reply_to":"7f287b81_68d9d881","updated":"2017-08-24 06:38:27.000000000","message":"Done","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"}],"networking_odl/sfc/sfc_driver_v2.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"99d2c920393ec99fb990de84e8d67ec881ff42cb","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def delete_port_chain(self, context):"},{"line_number":145,"context_line":"        super(OpenDaylightSFCDriverV2, self).delete_port_chain(context)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":148,"context_line":"        plugin \u003d directory.get_plugin(sfc_const.SFC_EXT)"},{"line_number":149,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % SFC_RESOURCES[resource_type])"},{"line_number":150,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_08d2545d","line":147,"updated":"2017-08-23 14:34:23.000000000","message":"I would make it a staticmethod and pay attention about my comment on repeating code.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"},{"author":{"_account_id":13912,"name":"rajiv","email":"thenakliman@gmail.com","username":"rajiv.kumar"},"change_message_id":"c4d948d6a985be563005a9fdd3ee0e3c917be7c0","unresolved":false,"context_lines":[{"line_number":144,"context_line":"    def delete_port_chain(self, context):"},{"line_number":145,"context_line":"        super(OpenDaylightSFCDriverV2, self).delete_port_chain(context)"},{"line_number":146,"context_line":""},{"line_number":147,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":148,"context_line":"        plugin \u003d directory.get_plugin(sfc_const.SFC_EXT)"},{"line_number":149,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % SFC_RESOURCES[resource_type])"},{"line_number":150,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_71c9b576","line":147,"in_reply_to":"7f287b81_08d2545d","updated":"2017-08-24 06:38:27.000000000","message":"Done","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"}],"networking_odl/tests/unit/base_v2.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"62e4c4f215c5f8ed47b2372d5de790c7c465f49e","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    def setUp(self):"},{"line_number":31,"context_line":"        self.useFixture(base.OpenDaylightJournalThreadFixture())"},{"line_number":32,"context_line":"        self.useFixture(base.OpenDaylightRestClientFixture())"},{"line_number":33,"context_line":"        self.useFixture(base.OpenDaylightFullSyncFixture())"},{"line_number":34,"context_line":"        super(OpenDaylightConfigBase, self).setUp()"},{"line_number":35,"context_line":"        cfg.CONF.set_override(\u0027mechanism_drivers\u0027,"},{"line_number":36,"context_line":"                              [\u0027logger\u0027, \u0027opendaylight_v2\u0027], \u0027ml2\u0027)"}],"source_content_type":"text/x-python","patch_set":13,"id":"7f287b81_9f77bc09","line":33,"range":{"start_line":33,"start_character":8,"end_line":33,"end_character":59},"updated":"2017-09-01 05:11:46.000000000","message":"Yes. so do we don\u0027t need to sprinkle subclasses of this class.\nPlease check class hiarachy.","commit_id":"aefa13b46d2cfc524c3c23771736c93145bee47b"}],"networking_odl/tests/unit/journal/test_full_sync.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"533a54d55173591331ba8946dba7c2c58af49e1d","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    def _test_no_full_sync_when_canary_in_journal(self, state):"},{"line_number":85,"context_line":"        self._mock_canary_missing()"},{"line_number":86,"context_line":"        self._mock_l2_resources()"},{"line_number":87,"context_line":"        self.addCleanup(self._clean_registered_plugins)"},{"line_number":88,"context_line":"        db.create_pending_row(self.db_session, odl_const.ODL_NETWORK,"},{"line_number":89,"context_line":"                              full_sync._CANARY_NETWORK_ID,"},{"line_number":90,"context_line":"                              odl_const.ODL_CREATE, {})"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_3698401a","line":87,"range":{"start_line":87,"start_character":8,"end_line":87,"end_character":55},"updated":"2017-08-29 16:34:41.000000000","message":"we can call this in setUp method unconditionally.","commit_id":"bd032be462c3166c381edb84f66fbedf0788f783"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"533a54d55173591331ba8946dba7c2c58af49e1d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"    def _test_full_sync_resources(self, expected_journal):"},{"line_number":171,"context_line":"        self._mock_canary_missing()"},{"line_number":172,"context_line":"        directory.add_plugin(constants.CORE, mock.Mock())"},{"line_number":173,"context_line":"        self.addCleanup(self._clean_registered_plugins)"},{"line_number":174,"context_line":"        full_sync.full_sync(self.db_context)"},{"line_number":175,"context_line":""},{"line_number":176,"context_line":"        rows \u003d self._assert_canary_created()"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_9686d4b8","line":173,"range":{"start_line":173,"start_character":0,"end_line":173,"end_character":55},"updated":"2017-08-29 16:34:41.000000000","message":"this can be done in setUp unconditionally.","commit_id":"bd032be462c3166c381edb84f66fbedf0788f783"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"533a54d55173591331ba8946dba7c2c58af49e1d","unresolved":false,"context_lines":[{"line_number":182,"context_line":"                             row[\u0027object_uuid\u0027])"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    def test_full_sync_removes_pending_rows(self):"},{"line_number":185,"context_line":"        full_sync.FULL_SYNC_RESOURCES.clear()"},{"line_number":186,"context_line":"        db.create_pending_row(self.db_session, odl_const.ODL_NETWORK, \"uuid\","},{"line_number":187,"context_line":"                              odl_const.ODL_CREATE, {\u0027foo\u0027: \u0027bar\u0027})"},{"line_number":188,"context_line":"        self._test_full_sync_resources({})"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_b6b43081","line":185,"range":{"start_line":185,"start_character":0,"end_line":185,"end_character":45},"updated":"2017-08-29 16:34:41.000000000","message":"setup isn\u0027t done properly?","commit_id":"bd032be462c3166c381edb84f66fbedf0788f783"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"533a54d55173591331ba8946dba7c2c58af49e1d","unresolved":false,"context_lines":[{"line_number":351,"context_line":"            l2gw_const.L2GW: (mock.Mock(), l2gw_driver.OpenDaylightL2gwDriver)"},{"line_number":352,"context_line":"        }"},{"line_number":353,"context_line":""},{"line_number":354,"context_line":"    def _clean_registered_plugins(self):"},{"line_number":355,"context_line":"        plugins \u003d self._get_all_plugins()"},{"line_number":356,"context_line":"        for plugin in plugins:"},{"line_number":357,"context_line":"            directory.add_plugin(plugin, None)"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"    @staticmethod"},{"line_number":360,"context_line":"    def _get_name(resource_type):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7f287b81_b62790ca","line":357,"range":{"start_line":354,"start_character":0,"end_line":357,"end_character":46},"updated":"2017-08-29 16:34:41.000000000","message":"There is a fixture to clean up diretory in Neutron-lib. PluginDirectoryFixture\n\nso use that fixture in setUp() unconditionally (or via class inheritance.) Please check class hierarchy and if the fixture isn\u0027t used, please add it.","commit_id":"bd032be462c3166c381edb84f66fbedf0788f783"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"8683f6f81d014380938f93ca9ebe3ebcbe48c7b0","unresolved":false,"context_lines":[{"line_number":51,"context_line":"        super(FullSyncTestCase, self).setUp()"},{"line_number":52,"context_line":""},{"line_number":53,"context_line":"        self._CLIENT \u003d full_sync._CLIENT.get_client()"},{"line_number":54,"context_line":"        full_sync.FULL_SYNC_RESOURCES.clear()"},{"line_number":55,"context_line":""},{"line_number":56,"context_line":"    def test_no_full_sync_when_canary_exists(self):"},{"line_number":57,"context_line":"        full_sync.full_sync(self.db_context)"}],"source_content_type":"text/x-python","patch_set":10,"id":"7f287b81_baccf534","line":54,"range":{"start_line":54,"start_character":7,"end_line":54,"end_character":45},"updated":"2017-08-30 16:11:17.000000000","message":"Since FULL_SUNC_RESOURCES is modified by those tests,\nthis should be \naddClenaup(self.clear_registered_resorces)\n\nIf this clear is necessary in setUp() here, it implies some test cases modify FULL_SYNC_RESOURCES and don\u0027t clean it up properly. Please identify such tests and add cleanup.\nhint: stack trace in register() method.\n\nProbably introduce a fixture and sprinkle useFixuture().","commit_id":"50d1d2a1cae02cec355078b95c233b1426e2ec98"}],"networking_odl/trunk/trunk_driver_v2.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"99d2c920393ec99fb990de84e8d67ec881ff42cb","unresolved":false,"context_lines":[{"line_number":133,"context_line":"        trunk \u003d trunks[0]"},{"line_number":134,"context_line":"        return (subport[\u0027port_id\u0027] for subport in trunk[\u0027sub_ports\u0027])"},{"line_number":135,"context_line":""},{"line_number":136,"context_line":"    def get_resources(self, context, resource_type):"},{"line_number":137,"context_line":"        plugin \u003d directory.get_plugin(t_consts.TRUNK)"},{"line_number":138,"context_line":"        obj_getter \u003d getattr(plugin, \u0027get_%s\u0027 % TRUNK_RESOURCES[resource_type])"},{"line_number":139,"context_line":"        return obj_getter(context)"}],"source_content_type":"text/x-python","patch_set":1,"id":"7f287b81_a8d0e051","line":136,"updated":"2017-08-23 14:34:23.000000000","message":"I would make it a staticmethod and pay attention about my comment on repeating code.","commit_id":"4f10f3929837c14774325e9687c61689e83d6611"}]}
