)]}'
{"networking_odl/tests/unit/ml2/test_mechanism_odl_v2.py":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"4872f3b610c06804771df5efce87ae144b53ffcb","unresolved":false,"context_lines":[{"line_number":98,"context_line":"class _OpenDaylightMechanismBase(base_v2.OpenDaylightTestCase):"},{"line_number":99,"context_line":"    _mechanism_drivers \u003d [\u0027logger\u0027, \u0027opendaylight_v2\u0027]"},{"line_number":100,"context_line":"    # TODO(mpeterson): Add a test to make sure extension_drivers are honored."},{"line_number":101,"context_line":"    _extension_drivers \u003d [\u0027port_security\u0027, \u0027qos\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def setUp(self):"},{"line_number":104,"context_line":"        mech_initialize_patcher \u003d mock.patch.object("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_e0c8a155","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":49},"updated":"2017-11-30 08:34:52.000000000","message":"You sure this works?\n\nI see in the py27 log the following example:\n2017-11-29 18:11:33.838724 | ubuntu-xenial | 2017-11-29 18:11:23.192 7428 INFO neutron.plugins.ml2.managers [req-ab883f94-e6a9-44e4-823a-1f05c04e61c0 - tenant_1 - - -] Loaded extension driver names: []\n2017-11-29 18:11:33.838781 | ubuntu-xenial | 2017-11-29 18:11:23.192 7428 INFO neutron.plugins.ml2.managers [req-ab883f94-e6a9-44e4-823a-1f05c04e61c0 - tenant_1 - - -] Registered extension drivers: []","commit_id":"2c9d23184e2245d924bc59c87422a45cc2fdeff2"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"8bafcb3f31d0db70c2b178d13d461feb9bb391a3","unresolved":false,"context_lines":[{"line_number":98,"context_line":"class _OpenDaylightMechanismBase(base_v2.OpenDaylightTestCase):"},{"line_number":99,"context_line":"    _mechanism_drivers \u003d [\u0027logger\u0027, \u0027opendaylight_v2\u0027]"},{"line_number":100,"context_line":"    # TODO(mpeterson): Add a test to make sure extension_drivers are honored."},{"line_number":101,"context_line":"    _extension_drivers \u003d [\u0027port_security\u0027, \u0027qos\u0027]"},{"line_number":102,"context_line":""},{"line_number":103,"context_line":"    def setUp(self):"},{"line_number":104,"context_line":"        mech_initialize_patcher \u003d mock.patch.object("}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_31e57add","line":101,"range":{"start_line":101,"start_character":0,"end_line":101,"end_character":49},"in_reply_to":"ff82abbf_e0c8a155","updated":"2017-11-30 13:44:00.000000000","message":"Good catch! I actually did not test that, since there is no test for it. Any ideas how we could test it so we can remove the TODO and forget about it?","commit_id":"2c9d23184e2245d924bc59c87422a45cc2fdeff2"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"6f7dc2ed2397248e25802803abdaf6d7b6021b5f","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        # NOTE(mpeterson): Because of the autospec the mock lacks"},{"line_number":128,"context_line":"        # the helper assert_called_once"},{"line_number":129,"context_line":"        msg \u003d \"The opendaylight_v2 ML2 Mechanism Driver was not initialized\""},{"line_number":130,"context_line":"        self.assertEqual(self.mech_initialize_mock.call_count, 1, msg)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class OpenDaylightMechanismTestBasicGet(test_plugin.TestMl2BasicGet,"},{"line_number":133,"context_line":"                                        _OpenDaylightMechanismBase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_6acc7234","line":130,"range":{"start_line":130,"start_character":8,"end_line":130,"end_character":70},"updated":"2017-11-30 08:31:04.000000000","message":"self.mech_initialize_mock.assert_called_with()?\n\nor perhaps\n\nself.assertTrue(self.mech_initialize_mock.called, msg)?","commit_id":"2c9d23184e2245d924bc59c87422a45cc2fdeff2"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"8bafcb3f31d0db70c2b178d13d461feb9bb391a3","unresolved":false,"context_lines":[{"line_number":127,"context_line":"        # NOTE(mpeterson): Because of the autospec the mock lacks"},{"line_number":128,"context_line":"        # the helper assert_called_once"},{"line_number":129,"context_line":"        msg \u003d \"The opendaylight_v2 ML2 Mechanism Driver was not initialized\""},{"line_number":130,"context_line":"        self.assertEqual(self.mech_initialize_mock.call_count, 1, msg)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class OpenDaylightMechanismTestBasicGet(test_plugin.TestMl2BasicGet,"},{"line_number":133,"context_line":"                                        _OpenDaylightMechanismBase):"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_b1d8aa1e","line":130,"range":{"start_line":130,"start_character":8,"end_line":130,"end_character":70},"in_reply_to":"ff82abbf_6acc7234","updated":"2017-11-30 13:44:00.000000000","message":"Done","commit_id":"2c9d23184e2245d924bc59c87422a45cc2fdeff2"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"ac78c71525fbce34f9bbe552ebdf7102b765725c","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        # the helper assert_called_once"},{"line_number":129,"context_line":"        msg \u003d \"The opendaylight_v2 ML2 Mechanism Driver was not initialized\""},{"line_number":130,"context_line":"        self.assertEqual(self.mech_initialize_mock.call_count, 1, msg)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class OpenDaylightMechanismTestBasicGet(test_plugin.TestMl2BasicGet,"},{"line_number":133,"context_line":"                                        _OpenDaylightMechanismBase):"},{"line_number":134,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_6e8c8d35","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":0},"updated":"2017-11-29 23:45:15.000000000","message":"pep8. 2 blank lines.","commit_id":"2c9d23184e2245d924bc59c87422a45cc2fdeff2"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"8bafcb3f31d0db70c2b178d13d461feb9bb391a3","unresolved":false,"context_lines":[{"line_number":128,"context_line":"        # the helper assert_called_once"},{"line_number":129,"context_line":"        msg \u003d \"The opendaylight_v2 ML2 Mechanism Driver was not initialized\""},{"line_number":130,"context_line":"        self.assertEqual(self.mech_initialize_mock.call_count, 1, msg)"},{"line_number":131,"context_line":""},{"line_number":132,"context_line":"class OpenDaylightMechanismTestBasicGet(test_plugin.TestMl2BasicGet,"},{"line_number":133,"context_line":"                                        _OpenDaylightMechanismBase):"},{"line_number":134,"context_line":"    pass"}],"source_content_type":"text/x-python","patch_set":2,"id":"ff82abbf_91f32674","line":131,"range":{"start_line":131,"start_character":0,"end_line":131,"end_character":0},"in_reply_to":"ff82abbf_6e8c8d35","updated":"2017-11-30 13:44:00.000000000","message":"Done","commit_id":"2c9d23184e2245d924bc59c87422a45cc2fdeff2"}]}