)]}'
{"networking_odl/cmd/set_ovs_hostconfigs.py":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"b87081c2bfe548c75e60d12450ed063741779ed9","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                \"vhostuser_socket\": os.path.join("},{"line_number":361,"context_line":"                    conf.vhostuser_socket_dir,"},{"line_number":362,"context_line":"                    conf.vhostuser_port_prefix + \u0027$PORT_ID\u0027)}"},{"line_number":363,"context_line":"    return None"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"def setup_conf(args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_5c699ef6","line":363,"range":{"start_line":363,"start_character":4,"end_line":363,"end_character":15},"updated":"2017-12-19 07:09:14.000000000","message":"In this case, vif_type is unexpected. so an exception should be raised instead of silently setting vif_details to None.\nIt requires logic change, so can you please address it with another patch?","commit_id":"9ac332e3f521ad55b8b225b58c0de3e88834e9bb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"60269935563d0cdcd69d01f797fd12fd6ee50ca9","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                \"vhostuser_socket\": os.path.join("},{"line_number":361,"context_line":"                    conf.vhostuser_socket_dir,"},{"line_number":362,"context_line":"                    conf.vhostuser_port_prefix + \u0027$PORT_ID\u0027)}"},{"line_number":363,"context_line":"    return None"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"def setup_conf(args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_4a0a1e20","line":363,"range":{"start_line":363,"start_character":4,"end_line":363,"end_character":15},"in_reply_to":"df87a7cf_2f100c00","updated":"2017-12-19 17:48:25.000000000","message":"Done https://review.openstack.org/#/c/529123","commit_id":"9ac332e3f521ad55b8b225b58c0de3e88834e9bb"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"0d19fcdcfbf26d000ab3efd5bd68f9c06e958b11","unresolved":false,"context_lines":[{"line_number":360,"context_line":"                \"vhostuser_socket\": os.path.join("},{"line_number":361,"context_line":"                    conf.vhostuser_socket_dir,"},{"line_number":362,"context_line":"                    conf.vhostuser_port_prefix + \u0027$PORT_ID\u0027)}"},{"line_number":363,"context_line":"    return None"},{"line_number":364,"context_line":""},{"line_number":365,"context_line":""},{"line_number":366,"context_line":"def setup_conf(args):"}],"source_content_type":"text/x-python","patch_set":2,"id":"df87a7cf_2f100c00","line":363,"range":{"start_line":363,"start_character":4,"end_line":363,"end_character":15},"in_reply_to":"df87a7cf_5c699ef6","updated":"2017-12-19 17:23:11.000000000","message":"sure !!","commit_id":"9ac332e3f521ad55b8b225b58c0de3e88834e9bb"}]}