)]}'
{"networking_odl/common/websocket_client.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"8e14fc2b9632f906be3896e451aaae930b195cdf","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        stream_url \u003d self._subscribe_websocket()"},{"line_number":260,"context_line":"        if stream_url is None:"},{"line_number":261,"context_line":"            return None"},{"line_number":262,"context_line":"        if \u0027https:\u0027 in self.odl_rest_client.url and \u0027wss:\u0027 not in \\"},{"line_number":263,"context_line":"                stream_url:"},{"line_number":264,"context_line":"            LOG.warning(\u0027TLS ODL URL detected, but websocket URL is not.  \u0027"},{"line_number":265,"context_line":"                        \u0027Forcing websocket URL to TLS\u0027)"},{"line_number":266,"context_line":"            stream_url \u003d stream_url.replace(\u0027ws:\u0027, \u0027wss:\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_e0227a01","line":263,"range":{"start_line":262,"start_character":8,"end_line":263,"end_character":27},"updated":"2018-01-23 14:45:34.000000000","message":"For readability I\u0027d recommend writing it like\n\nif (\u0027https:\u0027 in self.odl_rest_client.url and \n    \u0027wss:\u0027 not in stream_url):","commit_id":"4c838b4d4e3ae871aafc87e794fb240ae17a663d"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"1654f5052a27d1dfb34d1c82f61f539bf365a8a4","unresolved":false,"context_lines":[{"line_number":259,"context_line":"        stream_url \u003d self._subscribe_websocket()"},{"line_number":260,"context_line":"        if stream_url is None:"},{"line_number":261,"context_line":"            return None"},{"line_number":262,"context_line":"        if \u0027https:\u0027 in self.odl_rest_client.url and \u0027wss:\u0027 not in \\"},{"line_number":263,"context_line":"                stream_url:"},{"line_number":264,"context_line":"            LOG.warning(\u0027TLS ODL URL detected, but websocket URL is not.  \u0027"},{"line_number":265,"context_line":"                        \u0027Forcing websocket URL to TLS\u0027)"},{"line_number":266,"context_line":"            stream_url \u003d stream_url.replace(\u0027ws:\u0027, \u0027wss:\u0027)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_eff4a589","line":263,"range":{"start_line":262,"start_character":8,"end_line":263,"end_character":27},"in_reply_to":"7f96bb07_e0227a01","updated":"2018-01-23 16:47:21.000000000","message":"Done","commit_id":"4c838b4d4e3ae871aafc87e794fb240ae17a663d"}],"networking_odl/tests/unit/common/test_websocket_client.py":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"8e14fc2b9632f906be3896e451aaae930b195cdf","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def test_create_connection_handles_exception(self, mock_create_connection):"},{"line_number":164,"context_line":"        self.assertIsNone(self.mgr._socket_create_connection(\"localhost\"))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_websocket_connect(self):"},{"line_number":167,"context_line":"        self.mgr._subscribe_websocket \u003d mock.MagicMock("},{"line_number":168,"context_line":"            return_value\u003dTestWebsocketClient.WEBSOCKET_URI)"},{"line_number":169,"context_line":"        self.mgr._socket_create_connection \u003d mock.MagicMock(return_value\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_604f4a92","line":166,"updated":"2018-01-23 14:45:34.000000000","message":"Could you divide this in different tests instead one overarching one?\n\nThanks","commit_id":"4c838b4d4e3ae871aafc87e794fb240ae17a663d"},{"author":{"_account_id":17280,"name":"Tim Rozet","email":"trozet@redhat.com","username":"trozet"},"change_message_id":"1654f5052a27d1dfb34d1c82f61f539bf365a8a4","unresolved":false,"context_lines":[{"line_number":163,"context_line":"    def test_create_connection_handles_exception(self, mock_create_connection):"},{"line_number":164,"context_line":"        self.assertIsNone(self.mgr._socket_create_connection(\"localhost\"))"},{"line_number":165,"context_line":""},{"line_number":166,"context_line":"    def test_websocket_connect(self):"},{"line_number":167,"context_line":"        self.mgr._subscribe_websocket \u003d mock.MagicMock("},{"line_number":168,"context_line":"            return_value\u003dTestWebsocketClient.WEBSOCKET_URI)"},{"line_number":169,"context_line":"        self.mgr._socket_create_connection \u003d mock.MagicMock(return_value\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7f96bb07_cfd0c9fa","line":166,"in_reply_to":"7f96bb07_604f4a92","updated":"2018-01-23 16:47:21.000000000","message":"Done","commit_id":"4c838b4d4e3ae871aafc87e794fb240ae17a663d"}]}