)]}'
{"devstack/entry_points":[{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"4eeda259610fc6a814e6f0f1bd0778d0c1ae5917","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    local ODL_LOGGING_CONFIG\u003d${ODL_DIR}/${ODL_NAME}/etc/org.ops4j.pax.logging.cfg"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # Add netvirt feature in Karaf, if it\u0027s not already there"},{"line_number":30,"context_line":"    if ! (grep featuresBoot \u003d $ODL_DIR/$ODL_NAME/etc/org.apache.karaf.features.cfg | grep $ODL_NETVIRT_KARAF_FEATURE); then"},{"line_number":31,"context_line":"        sed -i \"/^featuresBoot \u003d / s/$/,$ODL_NETVIRT_KARAF_FEATURE/\" \\"},{"line_number":32,"context_line":"            $ODL_DIR/$ODL_NAME/etc/org.apache.karaf.features.cfg"},{"line_number":33,"context_line":"        # NOTE(yamahata): From Nitrogen, the format has been slightly changed"},{"line_number":34,"context_line":"        sed -i \"/^featuresBoot \u003d \\\\\\\\$/ s/\\\\\\\\$/$ODL_NETVIRT_KARAF_FEATURE, \\\\\\\\/\" \\"},{"line_number":35,"context_line":"            $ODL_DIR/$ODL_NAME/etc/org.apache.karaf.features.cfg"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f93b717_682fd387","line":32,"range":{"start_line":30,"start_character":27,"end_line":32,"end_character":64},"updated":"2018-01-31 23:27:38.000000000","message":"This would break nitrogen.\nKeep the old line for nitrogen and add new line for oxygen.\nPlease add comment for it.","commit_id":"16c94eed7a8b91678188c951b0a0f4210f23ec7b"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"4eeda259610fc6a814e6f0f1bd0778d0c1ae5917","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Move Jetty to $ODL_PORT"},{"line_number":39,"context_line":"    if ! grep $ODL_PORT $ODL_DIR/$ODL_NAME/etc/jetty.xml; then"},{"line_number":40,"context_line":"        sed -i \"/\\\u003cProperty name\\\u003d\\\"jetty\\.port/ s/8181/$ODL_PORT/\" \\"},{"line_number":41,"context_line":"            $ODL_DIR/$ODL_NAME/etc/jetty.xml"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Configure conntrack for legacy netvirt"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f93b717_c820679e","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":44},"updated":"2018-01-31 23:27:38.000000000","message":"Please don\u0027t change the behavior with the older ODL version. i.e. carbon and nitrogen.\nSo please check ODL version.","commit_id":"16c94eed7a8b91678188c951b0a0f4210f23ec7b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"959b83a5b8fcd1c8d40a1c6ba3f0c903cb9f4d87","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Move Jetty to $ODL_PORT"},{"line_number":39,"context_line":"    if ! grep $ODL_PORT $ODL_DIR/$ODL_NAME/etc/jetty.xml; then"},{"line_number":40,"context_line":"        sed -i \"/\\\u003cProperty name\\\u003d\\\"jetty\\.port/ s/8181/$ODL_PORT/\" \\"},{"line_number":41,"context_line":"            $ODL_DIR/$ODL_NAME/etc/jetty.xml"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Configure conntrack for legacy netvirt"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f93b717_5cf7265a","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":44},"in_reply_to":"5f93b717_28378b01","updated":"2018-02-01 17:15:13.000000000","message":"8181 is supported anyways, it depends on the config if ODL_PORT is 8181 it will be 8181. is there any harm in replacing port that with whatever port operator defines as ODL_PORT ? tbh I don\u0027t see any issue with replacing jetty.xml with the defined port. The solution of having jettylegacy.xml in networking-odl and patching jetty.xml is also fine.\nI think It would be good to document this port issue to keep devs aware, that could be followup patch. what do you guys think on documenting ?","commit_id":"16c94eed7a8b91678188c951b0a0f4210f23ec7b"},{"author":{"_account_id":11240,"name":"Sam Hague","email":"shague@gmail.com","username":"shague"},"change_message_id":"f1c6aacca857dc2399b8959f7ab8bac9685bcba6","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Move Jetty to $ODL_PORT"},{"line_number":39,"context_line":"    if ! grep $ODL_PORT $ODL_DIR/$ODL_NAME/etc/jetty.xml; then"},{"line_number":40,"context_line":"        sed -i \"/\\\u003cProperty name\\\u003d\\\"jetty\\.port/ s/8181/$ODL_PORT/\" \\"},{"line_number":41,"context_line":"            $ODL_DIR/$ODL_NAME/etc/jetty.xml"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Configure conntrack for legacy netvirt"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f93b717_eb9afd5f","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":44},"in_reply_to":"5f93b717_c820679e","updated":"2018-02-01 01:15:38.000000000","message":"8181 has been supported for quite a while so it would be less confusing to make the change to 8181 for all branches.\n\nThat being said, why is the jetty port even changed? By default ODL is listening on 8181. Does that collide with anything?","commit_id":"16c94eed7a8b91678188c951b0a0f4210f23ec7b"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"34d47f8f8fabde952eb4587d16edf6d1b3d31e18","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"    # Move Jetty to $ODL_PORT"},{"line_number":39,"context_line":"    if ! grep $ODL_PORT $ODL_DIR/$ODL_NAME/etc/jetty.xml; then"},{"line_number":40,"context_line":"        sed -i \"/\\\u003cProperty name\\\u003d\\\"jetty\\.port/ s/8181/$ODL_PORT/\" \\"},{"line_number":41,"context_line":"            $ODL_DIR/$ODL_NAME/etc/jetty.xml"},{"line_number":42,"context_line":"    fi"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    # Configure conntrack for legacy netvirt"}],"source_content_type":"application/x-shellscript","patch_set":4,"id":"5f93b717_28378b01","line":41,"range":{"start_line":40,"start_character":0,"end_line":41,"end_character":44},"in_reply_to":"5f93b717_c820679e","updated":"2018-02-01 17:06:22.000000000","message":"yes need to do that, i was just so eager to test ci, given that oxygen is green, I\u0027ll respin to add compatibility for nitrogen and carbon","commit_id":"16c94eed7a8b91678188c951b0a0f4210f23ec7b"},{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"e84f24a73e2d17719966c508e48bf0ae2baca926","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    local ODL_LOGGING_CONFIG\u003d${ODL_DIR}/${ODL_NAME}/etc/org.ops4j.pax.logging.cfg"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # Add netvirt feature in Karaf, if it\u0027s not already there"},{"line_number":30,"context_line":"    if ! (grep -w \u0027^featuresBoot\u0027 $ODL_DIR/$ODL_NAME/etc/org.apache.karaf.features.cfg | grep $ODL_NETVIRT_KARAF_FEATURE); then"},{"line_number":31,"context_line":"        case \"$ODL_RELEASE\" in"},{"line_number":32,"context_line":"            boron*|carbon*)"},{"line_number":33,"context_line":"                sed -i \"/^featuresBoot\u003d/ s/$/,$ODL_NETVIRT_KARAF_FEATURE/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5f93b717_93c36757","line":30,"range":{"start_line":30,"start_character":34,"end_line":30,"end_character":86},"updated":"2018-02-01 11:46:46.000000000","message":"nit: Can this be extracted to a variable? It repeats 4 times already..","commit_id":"183207f1ceafaaa3ae4f182fadc414730ebf2b6d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"34d47f8f8fabde952eb4587d16edf6d1b3d31e18","unresolved":false,"context_lines":[{"line_number":27,"context_line":"    local ODL_LOGGING_CONFIG\u003d${ODL_DIR}/${ODL_NAME}/etc/org.ops4j.pax.logging.cfg"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    # Add netvirt feature in Karaf, if it\u0027s not already there"},{"line_number":30,"context_line":"    if ! (grep -w \u0027^featuresBoot\u0027 $ODL_DIR/$ODL_NAME/etc/org.apache.karaf.features.cfg | grep $ODL_NETVIRT_KARAF_FEATURE); then"},{"line_number":31,"context_line":"        case \"$ODL_RELEASE\" in"},{"line_number":32,"context_line":"            boron*|carbon*)"},{"line_number":33,"context_line":"                sed -i \"/^featuresBoot\u003d/ s/$/,$ODL_NETVIRT_KARAF_FEATURE/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5f93b717_9ca04e92","line":30,"range":{"start_line":30,"start_character":34,"end_line":30,"end_character":86},"in_reply_to":"5f93b717_93c36757","updated":"2018-02-01 17:06:22.000000000","message":"Done","commit_id":"183207f1ceafaaa3ae4f182fadc414730ebf2b6d"}],"devstack/jetty-legacy.patch":[{"author":{"_account_id":7921,"name":"Mike Kolesnik","email":"mkolesni@redhat.com","username":"mkolesni"},"change_message_id":"e84f24a73e2d17719966c508e48bf0ae2baca926","unresolved":false,"context_lines":[{"line_number":5,"context_line":"@@ -93,6 +93,37 @@ DTD Configure//EN\" \"http://jetty.mortbay.org/configure.dtd\"\u003e"},{"line_number":6,"context_line":"         \u003c/Arg\u003e"},{"line_number":7,"context_line":"     \u003c/Call\u003e"},{"line_number":8,"context_line":" "},{"line_number":9,"context_line":"+    \u003cCall name\u003d\"addConnector\"\u003e"},{"line_number":10,"context_line":"+        \u003cArg\u003e"},{"line_number":11,"context_line":"+            \u003cNew class\u003d\"org.eclipse.jetty.server.ServerConnector\"\u003e"}],"source_content_type":"text/x-diff","patch_set":7,"id":"5f93b717_d3924f57","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"updated":"2018-02-01 11:46:46.000000000","message":"red thingy","commit_id":"183207f1ceafaaa3ae4f182fadc414730ebf2b6d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"74b3b160dd872cf27cfc3655a29eefc1c926c5d0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"@@ -93,6 +93,37 @@ DTD Configure//EN\" \"http://jetty.mortbay.org/configure.dtd\"\u003e"},{"line_number":6,"context_line":"         \u003c/Arg\u003e"},{"line_number":7,"context_line":"     \u003c/Call\u003e"},{"line_number":8,"context_line":" "},{"line_number":9,"context_line":"+    \u003cCall name\u003d\"addConnector\"\u003e"},{"line_number":10,"context_line":"+        \u003cArg\u003e"},{"line_number":11,"context_line":"+            \u003cNew class\u003d\"org.eclipse.jetty.server.ServerConnector\"\u003e"}],"source_content_type":"text/x-diff","patch_set":7,"id":"5f93b717_359d8d65","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"in_reply_to":"5f93b717_150bb1d5","updated":"2018-02-01 18:44:22.000000000","message":"Done","commit_id":"183207f1ceafaaa3ae4f182fadc414730ebf2b6d"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"34d47f8f8fabde952eb4587d16edf6d1b3d31e18","unresolved":false,"context_lines":[{"line_number":5,"context_line":"@@ -93,6 +93,37 @@ DTD Configure//EN\" \"http://jetty.mortbay.org/configure.dtd\"\u003e"},{"line_number":6,"context_line":"         \u003c/Arg\u003e"},{"line_number":7,"context_line":"     \u003c/Call\u003e"},{"line_number":8,"context_line":" "},{"line_number":9,"context_line":"+    \u003cCall name\u003d\"addConnector\"\u003e"},{"line_number":10,"context_line":"+        \u003cArg\u003e"},{"line_number":11,"context_line":"+            \u003cNew class\u003d\"org.eclipse.jetty.server.ServerConnector\"\u003e"}],"source_content_type":"text/x-diff","patch_set":7,"id":"5f93b717_dce816b4","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"in_reply_to":"5f93b717_d3924f57","updated":"2018-02-01 17:06:22.000000000","message":"Done","commit_id":"183207f1ceafaaa3ae4f182fadc414730ebf2b6d"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c3ba532626dec6e40869f4f0c2b0a679fc65d209","unresolved":false,"context_lines":[{"line_number":5,"context_line":"@@ -93,6 +93,37 @@ DTD Configure//EN\" \"http://jetty.mortbay.org/configure.dtd\"\u003e"},{"line_number":6,"context_line":"         \u003c/Arg\u003e"},{"line_number":7,"context_line":"     \u003c/Call\u003e"},{"line_number":8,"context_line":" "},{"line_number":9,"context_line":"+    \u003cCall name\u003d\"addConnector\"\u003e"},{"line_number":10,"context_line":"+        \u003cArg\u003e"},{"line_number":11,"context_line":"+            \u003cNew class\u003d\"org.eclipse.jetty.server.ServerConnector\"\u003e"}],"source_content_type":"text/x-diff","patch_set":7,"id":"5f93b717_150bb1d5","line":8,"range":{"start_line":8,"start_character":0,"end_line":8,"end_character":1},"in_reply_to":"5f93b717_dce816b4","updated":"2018-02-01 18:39:53.000000000","message":"This is necessary because it comes from the original file to be patches.\nIf this white space is deleted, patch fails.","commit_id":"183207f1ceafaaa3ae4f182fadc414730ebf2b6d"}]}