)]}'
{"devstack/entry_points":[{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"0048155647b5ad5f4ee3c9ad798601fa643b6194","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # Change the karaf logfile"},{"line_number":124,"context_line":"    # disable log rotation by setting max fiel size large enough"},{"line_number":125,"context_line":"    if [[ ,${ODL_RELEASE} \u003d~ \"oxygen\" || ,${ODL_RELEASE} \u003d~ \"latest\" ]]; then"},{"line_number":126,"context_line":"        # oxygen or later"},{"line_number":127,"context_line":"        sed -i -e \"/^log4j2\\.appender\\.rolling\\.fileName/ s/.*/log4j2\\.appender\\.rolling\\.fileName\\ \u003d $LF/\" \\"},{"line_number":128,"context_line":"            -e \"/^log4j2\\.appender\\.rolling\\.policies\\.size\\.size/ s/.*/log4j2\\.appender\\.rolling\\.policies\\.size\\.size\\ \u003d 1024GB/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_2b2e938b","line":125,"updated":"2018-02-23 17:56:11.000000000","message":"This will become a maintenance nightmare... I actually think that either we do it by version number and find bigger than X.Y.Z or just execute the both sed... I think they should not create a problem (and add a TODO to remove them in two cycles)","commit_id":"a9717ff3a2cd12ef626fc8e03ee276951341098f"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f8f11df8198dee5a9043f8feb88a3ad6b654299b","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # Change the karaf logfile"},{"line_number":124,"context_line":"    # disable log rotation by setting max fiel size large enough"},{"line_number":125,"context_line":"    if [[ ,${ODL_RELEASE} \u003d~ \"oxygen\" || ,${ODL_RELEASE} \u003d~ \"latest\" ]]; then"},{"line_number":126,"context_line":"        # oxygen or later"},{"line_number":127,"context_line":"        sed -i -e \"/^log4j2\\.appender\\.rolling\\.fileName/ s/.*/log4j2\\.appender\\.rolling\\.fileName\\ \u003d $LF/\" \\"},{"line_number":128,"context_line":"            -e \"/^log4j2\\.appender\\.rolling\\.policies\\.size\\.size/ s/.*/log4j2\\.appender\\.rolling\\.policies\\.size\\.size\\ \u003d 1024GB/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_6bcc9b88","line":125,"in_reply_to":"3fa0c359_2b2e938b","updated":"2018-02-23 18:10:21.000000000","message":"+1.\nwe can do something similar to line 34-50.","commit_id":"a9717ff3a2cd12ef626fc8e03ee276951341098f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2c12d09482c506f2c5f235381cd28566ac075247","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # Change the karaf logfile"},{"line_number":124,"context_line":"    # disable log rotation by setting max fiel size large enough"},{"line_number":125,"context_line":"    if [[ ,${ODL_RELEASE} \u003d~ \"oxygen\" || ,${ODL_RELEASE} \u003d~ \"latest\" ]]; then"},{"line_number":126,"context_line":"        # oxygen or later"},{"line_number":127,"context_line":"        sed -i -e \"/^log4j2\\.appender\\.rolling\\.fileName/ s/.*/log4j2\\.appender\\.rolling\\.fileName\\ \u003d $LF/\" \\"},{"line_number":128,"context_line":"            -e \"/^log4j2\\.appender\\.rolling\\.policies\\.size\\.size/ s/.*/log4j2\\.appender\\.rolling\\.policies\\.size\\.size\\ \u003d 1024GB/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_0b9077ec","line":125,"in_reply_to":"3fa0c359_2b2e938b","updated":"2018-02-23 18:16:08.000000000","message":"waiting for logs to come out, I\u0027ll revise it once the results are posted.","commit_id":"a9717ff3a2cd12ef626fc8e03ee276951341098f"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"f8f11df8198dee5a9043f8feb88a3ad6b654299b","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    # Configure DEBUG logs for network virtualization in odl, if the user wants it"},{"line_number":138,"context_line":"    if [ \"${ODL_NETVIRT_DEBUG_LOGS}\" \u003d\u003d \"True\" ]; then"},{"line_number":139,"context_line":"        if ! grep ^log4j.logger.org.opendaylight.ovsdb $ODL_LOGGING_CONFIG; then"},{"line_number":140,"context_line":"            echo \u0027log4j.logger.org.opendaylight.ovsdb \u003d INFO, out\u0027 \u003e\u003e $ODL_LOGGING_CONFIG"},{"line_number":141,"context_line":"        fi"},{"line_number":142,"context_line":"        if ! grep ^log4j.logger.org.opendaylight.netvirt $ODL_LOGGING_CONFIG; then"},{"line_number":143,"context_line":"            echo \u0027log4j.logger.org.opendaylight.netvirt \u003d DEBUG, out\u0027 \u003e\u003e $ODL_LOGGING_CONFIG"},{"line_number":144,"context_line":"        fi"},{"line_number":145,"context_line":"        if ! grep ^log4j.logger.org.opendaylight.neutron $ODL_LOGGING_CONFIG; then"},{"line_number":146,"context_line":"            echo \u0027log4j.logger.org.opendaylight.neutron \u003d DEBUG, out\u0027 \u003e\u003e $ODL_LOGGING_CONFIG"},{"line_number":147,"context_line":"        fi"},{"line_number":148,"context_line":"    fi"},{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_eb18abd3","line":147,"range":{"start_line":139,"start_character":0,"end_line":147,"end_character":10},"updated":"2018-02-23 18:10:21.000000000","message":"do we need to update this?\nlog4j vs log4j2","commit_id":"a9717ff3a2cd12ef626fc8e03ee276951341098f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"2c12d09482c506f2c5f235381cd28566ac075247","unresolved":false,"context_lines":[{"line_number":136,"context_line":""},{"line_number":137,"context_line":"    # Configure DEBUG logs for network virtualization in odl, if the user wants it"},{"line_number":138,"context_line":"    if [ \"${ODL_NETVIRT_DEBUG_LOGS}\" \u003d\u003d \"True\" ]; then"},{"line_number":139,"context_line":"        if ! grep ^log4j.logger.org.opendaylight.ovsdb $ODL_LOGGING_CONFIG; then"},{"line_number":140,"context_line":"            echo \u0027log4j.logger.org.opendaylight.ovsdb \u003d INFO, out\u0027 \u003e\u003e $ODL_LOGGING_CONFIG"},{"line_number":141,"context_line":"        fi"},{"line_number":142,"context_line":"        if ! grep ^log4j.logger.org.opendaylight.netvirt $ODL_LOGGING_CONFIG; then"},{"line_number":143,"context_line":"            echo \u0027log4j.logger.org.opendaylight.netvirt \u003d DEBUG, out\u0027 \u003e\u003e $ODL_LOGGING_CONFIG"},{"line_number":144,"context_line":"        fi"},{"line_number":145,"context_line":"        if ! grep ^log4j.logger.org.opendaylight.neutron $ODL_LOGGING_CONFIG; then"},{"line_number":146,"context_line":"            echo \u0027log4j.logger.org.opendaylight.neutron \u003d DEBUG, out\u0027 \u003e\u003e $ODL_LOGGING_CONFIG"},{"line_number":147,"context_line":"        fi"},{"line_number":148,"context_line":"    fi"},{"line_number":149,"context_line":"}"},{"line_number":150,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":1,"id":"3fa0c359_6b001b35","line":147,"range":{"start_line":139,"start_character":0,"end_line":147,"end_character":10},"in_reply_to":"3fa0c359_eb18abd3","updated":"2018-02-23 18:16:08.000000000","message":"no they don\u0027t need changes, they\u0027re same in oxygen","commit_id":"a9717ff3a2cd12ef626fc8e03ee276951341098f"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"6dd336aa4e237e3cb4f67d820740329dc1a21d67","unresolved":false,"context_lines":[{"line_number":121,"context_line":"    sudo ln -sf $_LF \"$ODL_LOGDIR/screen-karaf.log\""},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # Change the karaf logfile"},{"line_number":124,"context_line":"    # disable log rotation by setting max fiel size large enough"},{"line_number":125,"context_line":"    case \"$ODL_RELEASE\" in"},{"line_number":126,"context_line":"        boron*|carbon*|nitrogen*)"},{"line_number":127,"context_line":"        sed -i -e \"/^log4j\\.appender\\.out\\.file/ s/.*/log4j\\.appender\\.out\\.file\\\u003d$LF/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_fdd4ee21","line":124,"range":{"start_line":124,"start_character":38,"end_line":124,"end_character":46},"updated":"2018-02-23 18:39:30.000000000","message":"comments need an update too","commit_id":"7e18e741a8248c3deba44f9912bdf545b4e8c704"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"5e3b68535ec0a41a0e02245582889d37e4263554","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # Change the karaf logfile"},{"line_number":124,"context_line":"    # disable log rotation by setting max fiel size large enough"},{"line_number":125,"context_line":"    case \"$ODL_RELEASE\" in"},{"line_number":126,"context_line":"        boron*|carbon*|nitrogen*)"},{"line_number":127,"context_line":"        sed -i -e \"/^log4j\\.appender\\.out\\.file/ s/.*/log4j\\.appender\\.out\\.file\\\u003d$LF/\" \\"},{"line_number":128,"context_line":"            -e \"/^log4j\\.appender\\.out\\.maxFileSize/ s/.*/log4j\\.appender\\.out\\.maxFileSize\\\u003d1024GB/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_7de8dee0","line":125,"updated":"2018-02-23 18:40:03.000000000","message":"This is OK, although I think that we should also avoid things like this... It would be WAAAAY better to use the mechanism that already exists for this, ie: files inside devstack/odl-releases/","commit_id":"7e18e741a8248c3deba44f9912bdf545b4e8c704"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"f23d0990a25f713da3d8bc2e7edbc646524929d2","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # Change the karaf logfile"},{"line_number":124,"context_line":"    # disable log rotation by setting max fiel size large enough"},{"line_number":125,"context_line":"    case \"$ODL_RELEASE\" in"},{"line_number":126,"context_line":"        boron*|carbon*|nitrogen*)"},{"line_number":127,"context_line":"        sed -i -e \"/^log4j\\.appender\\.out\\.file/ s/.*/log4j\\.appender\\.out\\.file\\\u003d$LF/\" \\"},{"line_number":128,"context_line":"            -e \"/^log4j\\.appender\\.out\\.maxFileSize/ s/.*/log4j\\.appender\\.out\\.maxFileSize\\\u003d1024GB/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_9d004a36","line":125,"in_reply_to":"3fa0c359_7de8dee0","updated":"2018-02-23 18:45:45.000000000","message":"that definitely looks simple and clean, I\u0027m down with either, lets wait for Isaku the only issue I see with files in odl-releases is may need to redefine some variables, not1 100% sure if ODL_DIR or ODL_NAME will be visible there.","commit_id":"7e18e741a8248c3deba44f9912bdf545b4e8c704"},{"author":{"_account_id":333,"name":"Isaku Yamahata","email":"isaku.yamahata@gmail.com","username":"yamahata"},"change_message_id":"c9e682a2f9d18e5a4f1d0836bfb5401ec05541d7","unresolved":false,"context_lines":[{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    # Change the karaf logfile"},{"line_number":124,"context_line":"    # disable log rotation by setting max fiel size large enough"},{"line_number":125,"context_line":"    case \"$ODL_RELEASE\" in"},{"line_number":126,"context_line":"        boron*|carbon*|nitrogen*)"},{"line_number":127,"context_line":"        sed -i -e \"/^log4j\\.appender\\.out\\.file/ s/.*/log4j\\.appender\\.out\\.file\\\u003d$LF/\" \\"},{"line_number":128,"context_line":"            -e \"/^log4j\\.appender\\.out\\.maxFileSize/ s/.*/log4j\\.appender\\.out\\.maxFileSize\\\u003d1024GB/\" \\"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"3fa0c359_93ab59d4","line":125,"in_reply_to":"3fa0c359_9d004a36","updated":"2018-02-23 20:22:10.000000000","message":"For now it\u0027s okay because we\u0027d like to unblock oxygen early.\nIn long term, devstack/odl-release/common is the place to contain those ODL version hell.","commit_id":"7e18e741a8248c3deba44f9912bdf545b4e8c704"}]}