)]}'
{"devstack/upgrade/upgrade.sh":[{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"fb8381ea3e4e69012beb9af4a99fb57a29f0b4d8","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"NETWORKING_ODL_DIR\u003d\"$TARGET_RELEASE_DIR/networking-odl\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"source $NETWORKING_ODL_DIR/devstack/entry_points"},{"line_number":18,"context_line":"install_networking_odl"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set +x"},{"line_number":21,"context_line":"set +o xtrace"}],"source_content_type":"text/x-sh","patch_set":6,"id":"bf659307_902fe186","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":22},"updated":"2018-04-02 16:21:28.000000000","message":"can this be done in a separate patch ?\ngrenade job is already broken, so keeping this separate unless its badly needed in this patch","commit_id":"391c1d89ef2b8133d3aafbe7612c7908be106e73"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"1fd45ae809c59baf9f1078a37f5df94ab3875e26","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"NETWORKING_ODL_DIR\u003d\"$TARGET_RELEASE_DIR/networking-odl\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"source $NETWORKING_ODL_DIR/devstack/entry_points"},{"line_number":18,"context_line":"install_networking_odl"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set +x"},{"line_number":21,"context_line":"set +o xtrace"}],"source_content_type":"text/x-sh","patch_set":6,"id":"bf659307_95425a0e","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":22},"in_reply_to":"bf659307_77c9d856","updated":"2018-04-03 15:32:17.000000000","message":"I know, but I mean just have changes related to grenade in separate patch as this is not directly related to this patch","commit_id":"391c1d89ef2b8133d3aafbe7612c7908be106e73"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"dcbc62f4d02ba914abb0c14f5160ff07361ef725","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"NETWORKING_ODL_DIR\u003d\"$TARGET_RELEASE_DIR/networking-odl\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"source $NETWORKING_ODL_DIR/devstack/entry_points"},{"line_number":18,"context_line":"install_networking_odl"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set +x"},{"line_number":21,"context_line":"set +o xtrace"}],"source_content_type":"text/x-sh","patch_set":6,"id":"bf659307_77c9d856","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":22},"in_reply_to":"bf659307_902fe186","updated":"2018-04-03 07:22:04.000000000","message":"It is not broken because of this though. If this is not introduced then once the cause for why it\u0027s broken gets fixed then it will be broken because of this.\n\nAs you can see, grenade is broken because of a missing function that stack.sh calls:\n\nhttp://logs.openstack.org/70/557370/6/check/networking-odl-grenade/31130ac/logs/grenade.sh.txt.gz#_2018-04-02_14_55_01_765","commit_id":"391c1d89ef2b8133d3aafbe7612c7908be106e73"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"c328e361234032e25d5e00ee348bc4f09b974613","unresolved":false,"context_lines":[{"line_number":14,"context_line":""},{"line_number":15,"context_line":"NETWORKING_ODL_DIR\u003d\"$TARGET_RELEASE_DIR/networking-odl\""},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"source $NETWORKING_ODL_DIR/devstack/entry_points"},{"line_number":18,"context_line":"install_networking_odl"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"set +x"},{"line_number":21,"context_line":"set +o xtrace"}],"source_content_type":"text/x-sh","patch_set":6,"id":"bf659307_9bc7d664","line":18,"range":{"start_line":17,"start_character":0,"end_line":18,"end_character":22},"in_reply_to":"bf659307_95425a0e","updated":"2018-04-04 10:20:58.000000000","message":"Except it is. As I\u0027ve done in entry_points, because the way setup_develop installs the package the requirement is not processed correctly, so the solution is to install ceilometer first and then networking-odl. So, yes, this is also related.","commit_id":"391c1d89ef2b8133d3aafbe7612c7908be106e73"}],"requirements.txt":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"6a1d53b47ee843d15b3e10ee3cd406203f7c023e","unresolved":false,"context_lines":[{"line_number":18,"context_line":"networking-bgpvpn\u003e\u003d8.0.0  # Apache-2.0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Not on PyPI yet:"},{"line_number":21,"context_line":"-e git+https://git.openstack.org/openstack/ceilometer@master#egg\u003dceilometer"}],"source_content_type":"text/plain","patch_set":1,"id":"bf659307_a50b097b","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":75},"updated":"2018-03-29 03:08:30.000000000","message":"Can\u0027t you use http://tarballs.openstack.org/ceilometer/ceilometer-master.tar.gz or http://tarballs.openstack.org/ceilometer/ceilometer-master.whl ?","commit_id":"910604ba5819cebb4e0d58228994cab668c3fe58"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"e8d341621438be468d1222d69b88c6fbb18c85b5","unresolved":false,"context_lines":[{"line_number":18,"context_line":"networking-bgpvpn\u003e\u003d8.0.0  # Apache-2.0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Not on PyPI yet:"},{"line_number":21,"context_line":"-e git+https://git.openstack.org/openstack/ceilometer@master#egg\u003dceilometer"}],"source_content_type":"text/plain","patch_set":1,"id":"bf659307_af0c3b41","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":75},"in_reply_to":"bf659307_5afbe345","updated":"2018-03-29 14:50:55.000000000","message":"You should ask the infra folks for the exact reason. I haven\u0027t checked this case since I haven\u0027t hit this case so far. I just show a possible solution which I know works.","commit_id":"910604ba5819cebb4e0d58228994cab668c3fe58"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"b53232f20688f2740cf8c1ce96b8ab082b20c7ee","unresolved":false,"context_lines":[{"line_number":18,"context_line":"networking-bgpvpn\u003e\u003d8.0.0  # Apache-2.0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Not on PyPI yet:"},{"line_number":21,"context_line":"-e git+https://git.openstack.org/openstack/ceilometer@master#egg\u003dceilometer"}],"source_content_type":"text/plain","patch_set":1,"id":"bf659307_5afbe345","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":75},"in_reply_to":"bf659307_a50b097b","updated":"2018-03-29 08:48:37.000000000","message":"I could, but why not use the repo itself?","commit_id":"910604ba5819cebb4e0d58228994cab668c3fe58"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"5e809a58fe6eb8ebc70da11e7ed1450732a3c899","unresolved":false,"context_lines":[{"line_number":18,"context_line":"networking-bgpvpn\u003e\u003d8.0.0  # Apache-2.0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Not on PyPI yet:"},{"line_number":21,"context_line":"-e git+https://git.openstack.org/openstack/ceilometer@master#egg\u003dceilometer"}],"source_content_type":"text/plain","patch_set":5,"id":"bf659307_8a203bae","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":75},"updated":"2018-03-29 22:43:35.000000000","message":"can\u0027t this be added to deps in requirement.txt ? looks odd here","commit_id":"64070826da0f9b8d996e39a20e1d32851dca8348"},{"author":{"_account_id":26507,"name":"Michel Peterson","email":"michel@redhat.com","username":"mpeterson"},"change_message_id":"8930090ff1fd1a9fe7f250cde9ad142b0a8c3337","unresolved":false,"context_lines":[{"line_number":18,"context_line":"networking-bgpvpn\u003e\u003d8.0.0  # Apache-2.0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Not on PyPI yet:"},{"line_number":21,"context_line":"-e git+https://git.openstack.org/openstack/ceilometer@master#egg\u003dceilometer"}],"source_content_type":"text/plain","patch_set":5,"id":"bf659307_87d49721","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":75},"in_reply_to":"bf659307_3f759d64","updated":"2018-04-01 07:57:24.000000000","message":"it could be added to tox.ini but then it would only be for tox environments (as it was before though...)\n\nBy adding it to requirements.txt has two advantages: \n\n1) means that if anyone wants to have an environment with networking-odl they can do `pip install -r requirements.txt` and that\u0027s it.\n2) requirements.txt now actually reflects the requirements of the project.\n\nMoreover, as you can see in this search, it\u0027s also a common practice among the projects in openstack, as it is not incorrect syntax. \n\nhttp://codesearch.openstack.org/?q\u003dgit\u0026i\u003dnope\u0026files\u003drequirements.txt\u0026repos\u003d\n\nFinally, to say that this is only a temporary solution until the telemetry teams starts publishing to PyPI as all the other projects.","commit_id":"64070826da0f9b8d996e39a20e1d32851dca8348"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"6de2d1f8ab0eab332faa28aebfb13ecc3d94c404","unresolved":false,"context_lines":[{"line_number":18,"context_line":"networking-bgpvpn\u003e\u003d8.0.0  # Apache-2.0"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"# Not on PyPI yet:"},{"line_number":21,"context_line":"-e git+https://git.openstack.org/openstack/ceilometer@master#egg\u003dceilometer"}],"source_content_type":"text/plain","patch_set":5,"id":"bf659307_3f759d64","line":21,"range":{"start_line":21,"start_character":0,"end_line":21,"end_character":75},"in_reply_to":"bf659307_8a203bae","updated":"2018-03-30 18:18:13.000000000","message":"deps in tox.ini ***","commit_id":"64070826da0f9b8d996e39a20e1d32851dca8348"}]}