)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"7be1ecc8c2fa6892f26062fe075eaeef117f5190","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Yenuganti Vasudha \u003cyenuganti.vasudha@ericsson.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-02-21 06:07:37 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"To keep the backward comaptability with V1 driver."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"If we are using v2 driver bgpvpn update commands were failing with error"},{"line_number":10,"context_line":"thrown by update_bgpvpn_precommit method."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":21,"id":"9fdfeff1_bb1a606c","line":7,"updated":"2019-02-22 04:45:38.000000000","message":"this is not backward compatibility with V1 driver..\n\nPlease quote this:\n\nThe v2 driver interface from networking-odl for managing a neutron bgpvpn should match the signature imposed by the driver-api of networking-bgpvpn.\n\nHowever, we noticed that the signature of update_bgpvpn_precommit method was incorrect compared to the networking-bgpvpn driver_api.py.\n\nhttps://github.com/openstack/networking-bgpvpn/blob/master/networking_bgpvpn/neutron/services/service_drivers/driver_api.py#L265\n\nThis review fixes the signature in our ODL v2 driver for bgpvpn to enable the update_bgpvpn functionality to work.","commit_id":"d68c41d798def050743e7aee28bb47844bda240c"}],"networking_odl/tests/unit/bgpvpn/test_odl_v2.py":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"4fcab27beb40b135c9e919949a67271a4de5b35e","unresolved":false,"context_lines":[{"line_number":91,"context_line":""},{"line_number":92,"context_line":"    def test_update_bgpvpn(self):"},{"line_number":93,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"},{"line_number":94,"context_line":"        fake_updated_data \u003d self._get_fake_updated_bgpvpn()"},{"line_number":95,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context, fake_data,"},{"line_number":96,"context_line":"                                            fake_updated_data)"},{"line_number":97,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_00f68bfa","line":94,"updated":"2019-02-10 14:32:58.000000000","message":"split this get_fake_updated_bgpvpn() as two calls one with new RD added and another one with the same RD removed.\n\nMake sure to execute the entire set of test lines from 95 to 100 below for both the updates.","commit_id":"b588a948a686ba8c72efaffc0c6c1c7a12183170"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"a64da92a98740d0d747cc5c1bfffc39deced7193","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_update_bgpvpn(self):"},{"line_number":100,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"},{"line_number":101,"context_line":"        fake_data_temp \u003d self._get_fake_bgpvpn()"},{"line_number":102,"context_line":"        fake_updated_data1 \u003d self._add_rd(fake_data_temp, \u0027100:2\u0027)"},{"line_number":103,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context, fake_data,"},{"line_number":104,"context_line":"                                            fake_updated_data1)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9fdfeff1_77e4323d","line":101,"updated":"2019-02-20 16:36:47.000000000","message":"please do a deep_copy of fake_data and pass that deep-copy to add_rd","commit_id":"004b0a93b2aa9a4c232e84e5f73b236bc4e4aa1b"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"7b0df3e27fb447fbbba7203ce0dbd8729dd9bf99","unresolved":false,"context_lines":[{"line_number":98,"context_line":""},{"line_number":99,"context_line":"    def test_update_bgpvpn(self):"},{"line_number":100,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"},{"line_number":101,"context_line":"        fake_data_temp \u003d self._get_fake_bgpvpn()"},{"line_number":102,"context_line":"        fake_updated_data1 \u003d self._add_rd(fake_data_temp, \u0027100:2\u0027)"},{"line_number":103,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context, fake_data,"},{"line_number":104,"context_line":"                                            fake_updated_data1)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9fdfeff1_8de73d47","line":101,"in_reply_to":"9fdfeff1_77e4323d","updated":"2019-02-21 05:12:38.000000000","message":"Done","commit_id":"004b0a93b2aa9a4c232e84e5f73b236bc4e4aa1b"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"a64da92a98740d0d747cc5c1bfffc39deced7193","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.run_journal_processing()"},{"line_number":108,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":109,"context_line":"                        fake_updated_data1, False)"},{"line_number":110,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1, \u0027100:1\u0027)"},{"line_number":111,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":112,"context_line":"                                            fake_updated_data1,"},{"line_number":113,"context_line":"                                            fake_updated_data2)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9fdfeff1_57d56e42","line":110,"updated":"2019-02-20 16:36:47.000000000","message":"take a deep copy of fake_updated_data1 and pass that deepcopy to _delet_rd","commit_id":"004b0a93b2aa9a4c232e84e5f73b236bc4e4aa1b"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"7b0df3e27fb447fbbba7203ce0dbd8729dd9bf99","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        self.run_journal_processing()"},{"line_number":108,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":109,"context_line":"                        fake_updated_data1, False)"},{"line_number":110,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1, \u0027100:1\u0027)"},{"line_number":111,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":112,"context_line":"                                            fake_updated_data1,"},{"line_number":113,"context_line":"                                            fake_updated_data2)"}],"source_content_type":"text/x-python","patch_set":17,"id":"9fdfeff1_adea410b","line":110,"in_reply_to":"9fdfeff1_57d56e42","updated":"2019-02-21 05:12:38.000000000","message":"Done","commit_id":"004b0a93b2aa9a4c232e84e5f73b236bc4e4aa1b"},{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"a64da92a98740d0d747cc5c1bfffc39deced7193","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1, \u0027100:1\u0027)"},{"line_number":111,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":112,"context_line":"                                            fake_updated_data1,"},{"line_number":113,"context_line":"                                            fake_updated_data2)"},{"line_number":114,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":115,"context_line":"                        fake_updated_data2)"},{"line_number":116,"context_line":"        self.run_journal_processing()"}],"source_content_type":"text/x-python","patch_set":17,"id":"9fdfeff1_5779ee90","line":113,"updated":"2019-02-20 16:36:47.000000000","message":"won\u0027t this case have fake_updated_data2 content same as fake_updated_data1?","commit_id":"004b0a93b2aa9a4c232e84e5f73b236bc4e4aa1b"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"7b0df3e27fb447fbbba7203ce0dbd8729dd9bf99","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1, \u0027100:1\u0027)"},{"line_number":111,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":112,"context_line":"                                            fake_updated_data1,"},{"line_number":113,"context_line":"                                            fake_updated_data2)"},{"line_number":114,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":115,"context_line":"                        fake_updated_data2)"},{"line_number":116,"context_line":"        self.run_journal_processing()"}],"source_content_type":"text/x-python","patch_set":17,"id":"9fdfeff1_0ddb4d7d","line":113,"in_reply_to":"9fdfeff1_5779ee90","updated":"2019-02-21 05:12:38.000000000","message":"yes","commit_id":"004b0a93b2aa9a4c232e84e5f73b236bc4e4aa1b"},{"author":{"_account_id":25550,"name":"Achuth","email":"achuth.maniyedath@gmail.com","username":"achuthm"},"change_message_id":"eb0cf2ad91dc01d5a593370e7d5ea2724878bab6","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                          \u0027network_id\u0027: \u0027NET_ID\u0027}"},{"line_number":65,"context_line":"        return fake_net_assoc"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _assert_op_with_id(self, operation, object_type, data,"},{"line_number":68,"context_line":"                           precommit\u003dTrue):"},{"line_number":69,"context_line":"        rows \u003d sorted(db.get_all_db_rows_by_state(self.db_context,"},{"line_number":70,"context_line":"                                                  odl_const.PENDING),"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_d02e8b8a","line":67,"updated":"2019-03-18 17:15:20.000000000","message":"call these assert_delete_op / assert_create_op","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":25550,"name":"Achuth","email":"achuth.maniyedath@gmail.com","username":"achuthm"},"change_message_id":"1f1bb9258b2863a8e14c92e51c09e61f0cf85702","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                          \u0027network_id\u0027: \u0027NET_ID\u0027}"},{"line_number":65,"context_line":"        return fake_net_assoc"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _assert_op_with_id(self, operation, object_type, data,"},{"line_number":68,"context_line":"                           precommit\u003dTrue):"},{"line_number":69,"context_line":"        rows \u003d sorted(db.get_all_db_rows_by_state(self.db_context,"},{"line_number":70,"context_line":"                                                  odl_const.PENDING),"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_e13e4eb8","line":67,"in_reply_to":"5fc1f717_b6ebaeda","updated":"2019-03-19 06:33:18.000000000","message":"I see only delete  operation using the id validaion , so it is clear from method what it is meant for like assert_delete_op","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"f1b6aff08305a77194a4e05ccb7c2a2d66e923d2","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                          \u0027network_id\u0027: \u0027NET_ID\u0027}"},{"line_number":65,"context_line":"        return fake_net_assoc"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _assert_op_with_id(self, operation, object_type, data,"},{"line_number":68,"context_line":"                           precommit\u003dTrue):"},{"line_number":69,"context_line":"        rows \u003d sorted(db.get_all_db_rows_by_state(self.db_context,"},{"line_number":70,"context_line":"                                                  odl_const.PENDING),"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_b6ebaeda","line":67,"in_reply_to":"5fc1f717_d02e8b8a","updated":"2019-03-19 04:37:03.000000000","message":"Both create and delete operations will use this and the only difference between the two operations that is assert_op and assert_op_with_id is asserting id value in assert_op_with_id.\nto reflect that difference i think it is better to have that name assert_op_with_id no?","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"59a4d8a30d0576257443bcc7ffcef94454b8e160","unresolved":false,"context_lines":[{"line_number":64,"context_line":"                          \u0027network_id\u0027: \u0027NET_ID\u0027}"},{"line_number":65,"context_line":"        return fake_net_assoc"},{"line_number":66,"context_line":""},{"line_number":67,"context_line":"    def _assert_op_with_id(self, operation, object_type, data,"},{"line_number":68,"context_line":"                           precommit\u003dTrue):"},{"line_number":69,"context_line":"        rows \u003d sorted(db.get_all_db_rows_by_state(self.db_context,"},{"line_number":70,"context_line":"                                                  odl_const.PENDING),"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_217c5671","line":67,"in_reply_to":"5fc1f717_e13e4eb8","updated":"2019-03-19 06:39:40.000000000","message":"Done","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"91b4a60b15650ff14bd8ac08a33d34e1e9eeb9e7","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            self.db_context.session.flush()"},{"line_number":86,"context_line":"            self.assertEqual(operation, rows[0][\u0027operation\u0027])"},{"line_number":87,"context_line":"            self.assertEqual(object_type, rows[0][\u0027object_type\u0027])"},{"line_number":88,"context_line":"            self.assertEqual(data, rows[0][\u0027data\u0027])"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            self.assertEqual([], rows)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_fd28c586","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":51},"updated":"2019-03-11 16:19:11.000000000","message":"can\u0027t this line be added after L76 because L80-87 looks redundant ?","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ba026fcaa7ee5a3a7eb29e77886c6480f172504e","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            self.db_context.session.flush()"},{"line_number":86,"context_line":"            self.assertEqual(operation, rows[0][\u0027operation\u0027])"},{"line_number":87,"context_line":"            self.assertEqual(object_type, rows[0][\u0027object_type\u0027])"},{"line_number":88,"context_line":"            self.assertEqual(data, rows[0][\u0027data\u0027])"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            self.assertEqual([], rows)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_583e63c1","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":51},"in_reply_to":"5fc1f717_cfdd0215","updated":"2019-03-15 19:36:58.000000000","message":"operation is an argument so can be done based on condition ? but okay with this","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"9d2b382127a3d44bb8b6a16b3ca07ee9610d3e54","unresolved":false,"context_lines":[{"line_number":85,"context_line":"            self.db_context.session.flush()"},{"line_number":86,"context_line":"            self.assertEqual(operation, rows[0][\u0027operation\u0027])"},{"line_number":87,"context_line":"            self.assertEqual(object_type, rows[0][\u0027object_type\u0027])"},{"line_number":88,"context_line":"            self.assertEqual(data, rows[0][\u0027data\u0027])"},{"line_number":89,"context_line":"        else:"},{"line_number":90,"context_line":"            self.assertEqual([], rows)"},{"line_number":91,"context_line":""}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_cfdd0215","line":88,"range":{"start_line":88,"start_character":12,"end_line":88,"end_character":51},"in_reply_to":"5fc1f717_fd28c586","updated":"2019-03-12 04:09:47.000000000","message":"Only update_bgpvpn requires to compare data before and after change in data. Remaining operations wont require that.so we added separate assert operations.","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"91b4a60b15650ff14bd8ac08a33d34e1e9eeb9e7","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":111,"context_line":"                        fake_updated_data1, False)"},{"line_number":112,"context_line":"        fake_updated_data1_copy \u003d copy.deepcopy(fake_updated_data1)"},{"line_number":113,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1_copy, \u0027100:1\u0027)"},{"line_number":114,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":115,"context_line":"                                            fake_updated_data1,"},{"line_number":116,"context_line":"                                            fake_updated_data2)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_9daae1cf","line":113,"range":{"start_line":113,"start_character":70,"end_line":113,"end_character":76},"updated":"2019-03-11 16:19:11.000000000","message":"\u0027100:1\u0027 was never added, do you mean 100:2 here ?","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ba026fcaa7ee5a3a7eb29e77886c6480f172504e","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":111,"context_line":"                        fake_updated_data1, False)"},{"line_number":112,"context_line":"        fake_updated_data1_copy \u003d copy.deepcopy(fake_updated_data1)"},{"line_number":113,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1_copy, \u0027100:1\u0027)"},{"line_number":114,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":115,"context_line":"                                            fake_updated_data1,"},{"line_number":116,"context_line":"                                            fake_updated_data2)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_0f664e2b","line":113,"range":{"start_line":113,"start_character":70,"end_line":113,"end_character":76},"in_reply_to":"5fc1f717_8fe7fae4","updated":"2019-03-15 19:36:58.000000000","message":"got it !","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"9d2b382127a3d44bb8b6a16b3ca07ee9610d3e54","unresolved":false,"context_lines":[{"line_number":110,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":111,"context_line":"                        fake_updated_data1, False)"},{"line_number":112,"context_line":"        fake_updated_data1_copy \u003d copy.deepcopy(fake_updated_data1)"},{"line_number":113,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1_copy, \u0027100:1\u0027)"},{"line_number":114,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":115,"context_line":"                                            fake_updated_data1,"},{"line_number":116,"context_line":"                                            fake_updated_data2)"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_8fe7fae4","line":113,"range":{"start_line":113,"start_character":70,"end_line":113,"end_character":76},"in_reply_to":"5fc1f717_9daae1cf","updated":"2019-03-12 04:09:47.000000000","message":"100:1 was there in Original data and later we added 100:2 (refer L41)","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"91b4a60b15650ff14bd8ac08a33d34e1e9eeb9e7","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.run_journal_processing()"},{"line_number":110,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":111,"context_line":"                        fake_updated_data1, False)"},{"line_number":112,"context_line":"        fake_updated_data1_copy \u003d copy.deepcopy(fake_updated_data1)"},{"line_number":113,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1_copy, \u0027100:1\u0027)"},{"line_number":114,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":115,"context_line":"                                            fake_updated_data1,"},{"line_number":116,"context_line":"                                            fake_updated_data2)"},{"line_number":117,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":118,"context_line":"                        fake_updated_data2)"},{"line_number":119,"context_line":"        self.run_journal_processing()"},{"line_number":120,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":121,"context_line":"                        fake_updated_data2, False)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_delete_bgpvpn(self):"},{"line_number":124,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_7dc6159d","line":121,"range":{"start_line":112,"start_character":8,"end_line":121,"end_character":50},"updated":"2019-03-11 16:19:11.000000000","message":"IMO, this isn\u0027t adding value to test and is already tested in L103-L110.","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":17120,"name":"Manjeet Singh Bhatia","email":"manjeet.s.bhatia@intel.com","username":"manjeets"},"change_message_id":"ba026fcaa7ee5a3a7eb29e77886c6480f172504e","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.run_journal_processing()"},{"line_number":110,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":111,"context_line":"                        fake_updated_data1, False)"},{"line_number":112,"context_line":"        fake_updated_data1_copy \u003d copy.deepcopy(fake_updated_data1)"},{"line_number":113,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1_copy, \u0027100:1\u0027)"},{"line_number":114,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":115,"context_line":"                                            fake_updated_data1,"},{"line_number":116,"context_line":"                                            fake_updated_data2)"},{"line_number":117,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":118,"context_line":"                        fake_updated_data2)"},{"line_number":119,"context_line":"        self.run_journal_processing()"},{"line_number":120,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":121,"context_line":"                        fake_updated_data2, False)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_delete_bgpvpn(self):"},{"line_number":124,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_af229ab7","line":121,"range":{"start_line":112,"start_character":8,"end_line":121,"end_character":50},"in_reply_to":"5fc1f717_0fdb0a1b","updated":"2019-03-15 19:36:58.000000000","message":"why do it twice ? I mean L 110 make sure bgpvpn[\u0027route_distinguishers\u0027] is getting updated.","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"9d2b382127a3d44bb8b6a16b3ca07ee9610d3e54","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.run_journal_processing()"},{"line_number":110,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":111,"context_line":"                        fake_updated_data1, False)"},{"line_number":112,"context_line":"        fake_updated_data1_copy \u003d copy.deepcopy(fake_updated_data1)"},{"line_number":113,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1_copy, \u0027100:1\u0027)"},{"line_number":114,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":115,"context_line":"                                            fake_updated_data1,"},{"line_number":116,"context_line":"                                            fake_updated_data2)"},{"line_number":117,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":118,"context_line":"                        fake_updated_data2)"},{"line_number":119,"context_line":"        self.run_journal_processing()"},{"line_number":120,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":121,"context_line":"                        fake_updated_data2, False)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_delete_bgpvpn(self):"},{"line_number":124,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_0fdb0a1b","line":121,"range":{"start_line":112,"start_character":8,"end_line":121,"end_character":50},"in_reply_to":"5fc1f717_7dc6159d","updated":"2019-03-12 04:09:47.000000000","message":"We are \"adding new rd\" 100:2 and \"removing the old rd\" 100:1.\nSo we are checking two times.","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"1400b41c86476d7a7477dc9c1875f15bc2bfaed2","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        self.run_journal_processing()"},{"line_number":110,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":111,"context_line":"                        fake_updated_data1, False)"},{"line_number":112,"context_line":"        fake_updated_data1_copy \u003d copy.deepcopy(fake_updated_data1)"},{"line_number":113,"context_line":"        fake_updated_data2 \u003d self._delete_rd(fake_updated_data1_copy, \u0027100:1\u0027)"},{"line_number":114,"context_line":"        self.driver.update_bgpvpn_precommit(self.db_context,"},{"line_number":115,"context_line":"                                            fake_updated_data1,"},{"line_number":116,"context_line":"                                            fake_updated_data2)"},{"line_number":117,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":118,"context_line":"                        fake_updated_data2)"},{"line_number":119,"context_line":"        self.run_journal_processing()"},{"line_number":120,"context_line":"        self._assert_op(odl_const.ODL_UPDATE, odl_const.ODL_BGPVPN,"},{"line_number":121,"context_line":"                        fake_updated_data2, False)"},{"line_number":122,"context_line":""},{"line_number":123,"context_line":"    def test_delete_bgpvpn(self):"},{"line_number":124,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"}],"source_content_type":"text/x-python","patch_set":23,"id":"5fc1f717_a2086391","line":121,"range":{"start_line":112,"start_character":8,"end_line":121,"end_character":50},"in_reply_to":"5fc1f717_af229ab7","updated":"2019-03-18 05:21:43.000000000","message":"Yeah just checking in both cases like both in the case of add and removal the update is working fine.","commit_id":"561c8afbc1e6666e5d8cf6b5346437f255ea7a2a"},{"author":{"_account_id":25550,"name":"Achuth","email":"achuth.maniyedath@gmail.com","username":"achuthm"},"change_message_id":"8fea69a2eff3d3a930efe38f238baadba2e152ce","unresolved":false,"context_lines":[{"line_number":123,"context_line":"    def test_delete_bgpvpn(self):"},{"line_number":124,"context_line":"        fake_data \u003d self._get_fake_bgpvpn()"},{"line_number":125,"context_line":"        self.driver.delete_bgpvpn_precommit(self.db_context, fake_data)"},{"line_number":126,"context_line":"        self._assert_op_with_id(odl_const.ODL_DELETE, odl_const.ODL_BGPVPN,"},{"line_number":127,"context_line":"                                fake_data)"},{"line_number":128,"context_line":"        self.run_journal_processing()"},{"line_number":129,"context_line":"        self._assert_op_with_id(odl_const.ODL_DELETE, odl_const.ODL_BGPVPN,"}],"source_content_type":"text/x-python","patch_set":24,"id":"5fc1f717_1c58a1f8","line":126,"updated":"2019-03-19 08:16:49.000000000","message":"assert_delte","commit_id":"ccfdb3d7838cdfdf98fd9afcbbd1d7e763550f8d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"4676cf7412130dea9c51aa8e03fb8445ca3292f2","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        return fake_net_assoc"},{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    def _assert_op(self, operation, object_type, data, precommit\u003dTrue):"},{"line_number":70,"context_line":"        rows \u003d sorted(db.get_all_db_rows_by_state(self.db_context,"},{"line_number":71,"context_line":"                                                  odl_const.PENDING),"},{"line_number":72,"context_line":"                      key\u003dlambda x: x.seqnum)"},{"line_number":73,"context_line":"        if precommit:"},{"line_number":74,"context_line":"            self.db_context.session.flush()"},{"line_number":75,"context_line":"            self.assertEqual(operation, rows[0][\u0027operation\u0027])"},{"line_number":76,"context_line":"            self.assertEqual(object_type, rows[0][\u0027object_type\u0027])"},{"line_number":77,"context_line":"            self.assertEqual(data, rows[0][\u0027data\u0027])"},{"line_number":78,"context_line":"        else:"},{"line_number":79,"context_line":"            self.assertEqual([], rows)"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"    def _assert_delete_op(self, operation, object_type, data, precommit\u003dTrue):"},{"line_number":82,"context_line":"        rows \u003d sorted(db.get_all_db_rows_by_state(self.db_context,"}],"source_content_type":"text/x-python","patch_set":30,"id":"5faad753_c025e4c3","line":79,"range":{"start_line":70,"start_character":0,"end_line":79,"end_character":38},"updated":"2019-09-11 11:27:56.000000000","message":"this part is nearly identical in assert_op and assert_delete_op methods, it should be in a method with extra param or similar.","commit_id":"ada77cd71c3fc35fd31b212ee04bbc3d3ee52fab"}]}