)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"8c15c5ced310207d10a418bdf65f56403d291115","unresolved":false,"context_lines":[{"line_number":15,"context_line":"effect the polling of counters."},{"line_number":16,"context_line":""},{"line_number":17,"context_line":"Signed-off-by: Yenuganti Vasudha \u003cyenuganti.vasudha@ericsson.com\u003e"},{"line_number":18,"context_line":"Fixes Bug #1806571"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I48fd2fd64054d9b9db85b5ae490234efe17be67d"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9fdfeff1_403a5398","line":18,"updated":"2019-02-11 05:00:28.000000000","message":"Closes-Bug: #\u003claunchpad-bug-id\u003e","commit_id":"9d1eb4525bc643ce9eed25a8c51b8addb3fc3767"},{"author":{"_account_id":25550,"name":"Achuth","email":"achuth.maniyedath@gmail.com","username":"achuthm"},"change_message_id":"40432e99d6af08bf64bfbb2f3245ce8e210e9068","unresolved":false,"context_lines":[{"line_number":10,"context_line":"it is giving type error during execution and also switch_port counters were"},{"line_number":11,"context_line":"not getting polled."},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"so in this commit we were type casting the port-id variable and keeping"},{"line_number":14,"context_line":"it as integer so that it wont show any type error and also will not"},{"line_number":15,"context_line":"effect the polling of counters."},{"line_number":16,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":8,"id":"5fc1f717_b0741fff","line":13,"updated":"2019-03-18 17:31:52.000000000","message":"Type casting the port-id to Integer for ceilometer polling to work correctly","commit_id":"73427dc5b92cc39da5ff1c25afe7e26e017b4d45"},{"author":{"_account_id":25550,"name":"Achuth","email":"achuth.maniyedath@gmail.com","username":"achuthm"},"change_message_id":"de6dbf6d2609fd47d03d88c3c033fc63e74d1ddc","unresolved":false,"context_lines":[{"line_number":7,"context_line":"variable type of port-id in ceilometer driver is changed from integer to"},{"line_number":8,"context_line":"string"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"due to some type differences of port_id variable in ceilometer driver "},{"line_number":11,"context_line":"code it is giving type error during execution and also switch_port "},{"line_number":12,"context_line":"counters were not getting polled."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5fc1f717_4125e2aa","line":10,"updated":"2019-03-19 06:26:38.000000000","message":"Remove all trailing whitespaces in commit message.\n\nDue to type mismatch of port_id variable , ceilometer driver is throwing type error and switchport counters are not gettng polled","commit_id":"ea87d0be99a9fc9966ed27da9d798ca0052fd231"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"2f95132a6402af420c77a2d32ec72bf23b920af9","unresolved":false,"context_lines":[{"line_number":7,"context_line":"variable type of port-id in ceilometer driver is changed from integer to"},{"line_number":8,"context_line":"string"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"due to some type differences of port_id variable in ceilometer driver "},{"line_number":11,"context_line":"code it is giving type error during execution and also switch_port "},{"line_number":12,"context_line":"counters were not getting polled."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":9,"id":"5fc1f717_01935aa5","line":10,"in_reply_to":"5fc1f717_4125e2aa","updated":"2019-03-19 06:41:04.000000000","message":"Done","commit_id":"ea87d0be99a9fc9966ed27da9d798ca0052fd231"}],"networking_odl/ceilometer/network/statistics/opendaylight_v2/driver.py":[{"author":{"_account_id":9361,"name":"Vivekanandan Narasimhan","email":"n.vivekanandan@ericsson.com","username":"viveknarasimhan"},"change_message_id":"e438df7fd01806812972cce96eca305ff193ddf2","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                tenant_id \u003d (switch.get(\u0027tenant_id\u0027) or"},{"line_number":226,"context_line":"                             data[\u0027admin_tenant_id\u0027])"},{"line_number":227,"context_line":"                for port_statistic in switch[\u0027switch_port_counters\u0027]:"},{"line_number":228,"context_line":"                    port_id \u003d int(port_statistic[\u0027port_id\u0027])"},{"line_number":229,"context_line":"                    resource_id \u003d \u0027%s:%d\u0027 % (switch_id, port_id)"},{"line_number":230,"context_line":"                    resource_meta \u003d {\u0027switch\u0027: switch_id,"},{"line_number":231,"context_line":"                                     \u0027port_number_on_switch\u0027: port_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_00cf6bb0","line":228,"updated":"2019-02-10 14:35:42.000000000","message":"what is this conversion..\n\nWhat is format of data we expect the result of port_statistic[\u0027port-id\u0027] in the left pane earlier?\n\nif the port_id here in line 228 is a neutron port-id, then they cannot be typecasted to integers..","commit_id":"9d1eb4525bc643ce9eed25a8c51b8addb3fc3767"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"3225ced811a1bba57b630cd63b33e73f86928ade","unresolved":false,"context_lines":[{"line_number":225,"context_line":"                tenant_id \u003d (switch.get(\u0027tenant_id\u0027) or"},{"line_number":226,"context_line":"                             data[\u0027admin_tenant_id\u0027])"},{"line_number":227,"context_line":"                for port_statistic in switch[\u0027switch_port_counters\u0027]:"},{"line_number":228,"context_line":"                    port_id \u003d int(port_statistic[\u0027port_id\u0027])"},{"line_number":229,"context_line":"                    resource_id \u003d \u0027%s:%d\u0027 % (switch_id, port_id)"},{"line_number":230,"context_line":"                    resource_meta \u003d {\u0027switch\u0027: switch_id,"},{"line_number":231,"context_line":"                                     \u0027port_number_on_switch\u0027: port_id}"}],"source_content_type":"text/x-python","patch_set":2,"id":"9fdfeff1_364f5593","line":228,"in_reply_to":"9fdfeff1_00cf6bb0","updated":"2019-02-11 04:35:54.000000000","message":"we expect integer but it is coming as string.\nIt is not neutron_port_id.","commit_id":"9d1eb4525bc643ce9eed25a8c51b8addb3fc3767"},{"author":{"_account_id":9542,"name":"Pavlo Shchelokovskyy","email":"pshchelokovskyy@mirantis.com","username":"pshchelo"},"change_message_id":"4bdc3a166dc860fbd95c0f5988002c7605ac0df3","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                packets_received_drop: 0,"},{"line_number":81,"context_line":"                packets_received_error: 0,"},{"line_number":82,"context_line":"                packets_sent: 100,"},{"line_number":83,"context_line":"                port_id: 4,"},{"line_number":84,"context_line":"                tenant_id: PORT_1_TENANT_ID,"},{"line_number":85,"context_line":"                uuid: PORT_1_ID"},{"line_number":86,"context_line":"            }],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_f771aba9","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":26},"updated":"2019-02-12 12:45:05.000000000","message":"this contradicts to the patch now, shouldn\u0027t that be string?","commit_id":"333a72cf25c3e8764046009387a1a9039f74a3d0"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"63070c37319a80a3ab264f6d88fd7cf6c51750e8","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                packets_received_drop: 0,"},{"line_number":81,"context_line":"                packets_received_error: 0,"},{"line_number":82,"context_line":"                packets_sent: 100,"},{"line_number":83,"context_line":"                port_id: 4,"},{"line_number":84,"context_line":"                tenant_id: PORT_1_TENANT_ID,"},{"line_number":85,"context_line":"                uuid: PORT_1_ID"},{"line_number":86,"context_line":"            }],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_db8ba4bd","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":26},"in_reply_to":"9fdfeff1_106ab01a","updated":"2019-02-22 05:35:07.000000000","message":"From ODL not only port_id but everything is coming as string only but in openstack side we were processing port_id as number. That is why it is giving type error.","commit_id":"333a72cf25c3e8764046009387a1a9039f74a3d0"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"fe425d1153d38eb282ba4fcb7b41a23e5460da02","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                packets_received_drop: 0,"},{"line_number":81,"context_line":"                packets_received_error: 0,"},{"line_number":82,"context_line":"                packets_sent: 100,"},{"line_number":83,"context_line":"                port_id: 4,"},{"line_number":84,"context_line":"                tenant_id: PORT_1_TENANT_ID,"},{"line_number":85,"context_line":"                uuid: PORT_1_ID"},{"line_number":86,"context_line":"            }],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_106ab01a","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":26},"in_reply_to":"9fdfeff1_9b0ab7cf","updated":"2019-02-19 12:33:07.000000000","message":"Why should a port id be a string? If a port_id is a string, then I think it\u0027s a side effect, so I suggest, to leave these as numbers and add a new test with every value as string for example.\n\nBut from the given log snippet in the screenshot attached in the bug, I don\u0027t see that this is enough / this is the right solution. Why does OpenDayLight send unicode (what unicode) as parameter? Could only the port_id be a string as a response from OpenDayLight?","commit_id":"333a72cf25c3e8764046009387a1a9039f74a3d0"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"457cd1e9a5c6f86d49d366c34debede3bf984a8b","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                packets_received_drop: 0,"},{"line_number":81,"context_line":"                packets_received_error: 0,"},{"line_number":82,"context_line":"                packets_sent: 100,"},{"line_number":83,"context_line":"                port_id: 4,"},{"line_number":84,"context_line":"                tenant_id: PORT_1_TENANT_ID,"},{"line_number":85,"context_line":"                uuid: PORT_1_ID"},{"line_number":86,"context_line":"            }],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_f85a2181","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":26},"in_reply_to":"9fdfeff1_db8ba4bd","updated":"2019-02-22 17:23:42.000000000","message":"Ok, fair, as code I understand that and it looks good now.\nBut then my question is: Why did it work previously? What have changed that now it is failing?","commit_id":"333a72cf25c3e8764046009387a1a9039f74a3d0"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"19b3d533a84527d4ea8100481acbf08dce864a5d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                packets_received_drop: 0,"},{"line_number":81,"context_line":"                packets_received_error: 0,"},{"line_number":82,"context_line":"                packets_sent: 100,"},{"line_number":83,"context_line":"                port_id: 4,"},{"line_number":84,"context_line":"                tenant_id: PORT_1_TENANT_ID,"},{"line_number":85,"context_line":"                uuid: PORT_1_ID"},{"line_number":86,"context_line":"            }],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_9b0ab7cf","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":26},"in_reply_to":"9fdfeff1_f771aba9","updated":"2019-02-13 05:10:41.000000000","message":"Done","commit_id":"333a72cf25c3e8764046009387a1a9039f74a3d0"},{"author":{"_account_id":29399,"name":"Yenuganti Vasudha","email":"yenuganti.vasudha@ericsson.com","username":"evasyen"},"change_message_id":"8e9ba7ee43055e6143a3015602b29ab1f718f819","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                packets_received_drop: 0,"},{"line_number":81,"context_line":"                packets_received_error: 0,"},{"line_number":82,"context_line":"                packets_sent: 100,"},{"line_number":83,"context_line":"                port_id: 4,"},{"line_number":84,"context_line":"                tenant_id: PORT_1_TENANT_ID,"},{"line_number":85,"context_line":"                uuid: PORT_1_ID"},{"line_number":86,"context_line":"            }],"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fdfeff1_d29fe762","line":83,"range":{"start_line":83,"start_character":25,"end_line":83,"end_character":26},"in_reply_to":"9fdfeff1_f85a2181","updated":"2019-02-25 05:07:06.000000000","message":"Previously in ODL side it was not string.\nIt seems like These String changes in ODL have happened in recent times only.","commit_id":"333a72cf25c3e8764046009387a1a9039f74a3d0"}],"networking_odl/tests/unit/ceilometer/network/statistics/opendaylight_v2/test_driver.py":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"51852d1720d7753037c209556ef1267e871c2a52","unresolved":false,"context_lines":[{"line_number":23,"context_line":"from networking_odl.ceilometer.network.statistics.opendaylight_v2 import driver"},{"line_number":24,"context_line":"from oslo_utils import uuidutils"},{"line_number":25,"context_line":""},{"line_number":26,"context_line":"ADMIN_ID \u003d str(uuidutils.generate_uuid())"},{"line_number":27,"context_line":"PORT_1_TENANT_ID \u003d str(uuidutils.generate_uuid())"},{"line_number":28,"context_line":"PORT_2_TENANT_ID \u003d str(uuidutils.generate_uuid())"},{"line_number":29,"context_line":"PORT_1_ID \u003d str(uuidutils.generate_uuid())"},{"line_number":30,"context_line":"PORT_2_ID \u003d str(uuidutils.generate_uuid())"},{"line_number":31,"context_line":""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"@six.add_metaclass(abc.ABCMeta)"}],"source_content_type":"text/x-python","patch_set":12,"id":"5faad753_e0682022","line":30,"range":{"start_line":26,"start_character":0,"end_line":30,"end_character":42},"updated":"2019-09-11 11:17:19.000000000","message":"nit: generate_uuid returns str as default","commit_id":"0cecb9630d0c0ee460cadd1535101fd8d0dee772"}]}