)]}'
{".zuul.d/jobs.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"678f99748ce0e840cf873dfb23e3f5faeaa86a9f","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    vars:"},{"line_number":193,"context_line":"      devstack_localrc:"},{"line_number":194,"context_line":"        ODL_RELEASE: *neon"},{"line_number":195,"context_line":"        USE_PYTHON3: True"},{"line_number":196,"context_line":"      devstack_plugins:"},{"line_number":197,"context_line":"        rally-openstack: https://opendev.org/openstack/rally-openstack"},{"line_number":198,"context_line":"        networking-odl: https://opendev.org/openstack/networking-odl"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_bd074117","line":195,"updated":"2019-11-21 23:55:25.000000000","message":"nit: devstack now defaults to python3, so this probably isn\u0027t necessary, but it doesn\u0027t hurt.","commit_id":"0d2df7e6f06812d22893f426e129fecfe959acb8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ae5808fa0bc66d5ea3f5c18e49bb5ca41fac5227","unresolved":false,"context_lines":[{"line_number":192,"context_line":"    vars:"},{"line_number":193,"context_line":"      devstack_localrc:"},{"line_number":194,"context_line":"        ODL_RELEASE: *neon"},{"line_number":195,"context_line":"        USE_PYTHON3: True"},{"line_number":196,"context_line":"      devstack_plugins:"},{"line_number":197,"context_line":"        rally-openstack: https://opendev.org/openstack/rally-openstack"},{"line_number":198,"context_line":"        networking-odl: https://opendev.org/openstack/networking-odl"}],"source_content_type":"text/x-yaml","patch_set":9,"id":"3fa7e38b_557ce1b4","line":195,"in_reply_to":"3fa7e38b_bd074117","updated":"2019-11-22 09:09:51.000000000","message":"thanks Brian, if there will be other comments I can change that.","commit_id":"0d2df7e6f06812d22893f426e129fecfe959acb8"}],".zuul.d/project.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6ba27d7202ee9a787cc1ece620247c39d0c8f48b","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    templates:"},{"line_number":3,"context_line":"      - openstack-python-jobs-neutron"},{"line_number":4,"context_line":"      - openstack-python3-train-jobs-neutron"},{"line_number":5,"context_line":"      - release-notes-jobs-python3"},{"line_number":6,"context_line":"      - periodic-stable-jobs-neutron"},{"line_number":7,"context_line":"      - publish-openstack-docs-pti"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_18003cab","line":4,"range":{"start_line":4,"start_character":26,"end_line":4,"end_character":31},"updated":"2019-11-15 11:17:14.000000000","message":"s/ussuri\n\nI believe that will get the py27 job removed.","commit_id":"e42e4827d84850e4bb54550a5fec202ba1b13442"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2a40227d5989135fccde38526297b45b36316726","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    templates:"},{"line_number":3,"context_line":"      - openstack-python-jobs-neutron"},{"line_number":4,"context_line":"      - openstack-python3-train-jobs-neutron"},{"line_number":5,"context_line":"      - release-notes-jobs-python3"},{"line_number":6,"context_line":"      - periodic-stable-jobs-neutron"},{"line_number":7,"context_line":"      - publish-openstack-docs-pti"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"3fa7e38b_14b32450","line":4,"range":{"start_line":4,"start_character":26,"end_line":4,"end_character":31},"in_reply_to":"3fa7e38b_18003cab","updated":"2019-11-15 14:21:15.000000000","message":"Thanks Brian.","commit_id":"e42e4827d84850e4bb54550a5fec202ba1b13442"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"a3b87f80f45211b7a9d03316f1db2d26e6793bb9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    templates:"},{"line_number":3,"context_line":"      - openstack-python-jobs-neutron"},{"line_number":4,"context_line":"      - openstack-python3-ussuri-jobs-neutron"},{"line_number":5,"context_line":"      - release-notes-jobs-python3"},{"line_number":6,"context_line":"      - periodic-stable-jobs-neutron"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_9c6f205f","line":3,"updated":"2019-11-19 02:14:49.000000000","message":"You can remove this one too, sorry, should have mentioned in previous review, the ussuri one is all you need now.","commit_id":"d173c8b502c89f26f328a794bc7e9da005dbd3bf"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e88bee993bc4f91fad6cf7c3f6ffc6c52ac43a05","unresolved":false,"context_lines":[{"line_number":1,"context_line":"- project:"},{"line_number":2,"context_line":"    templates:"},{"line_number":3,"context_line":"      - openstack-python-jobs-neutron"},{"line_number":4,"context_line":"      - openstack-python3-ussuri-jobs-neutron"},{"line_number":5,"context_line":"      - release-notes-jobs-python3"},{"line_number":6,"context_line":"      - periodic-stable-jobs-neutron"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3fa7e38b_db411b38","line":3,"in_reply_to":"3fa7e38b_9c6f205f","updated":"2019-11-19 09:23:11.000000000","message":"No problem, thanks","commit_id":"d173c8b502c89f26f328a794bc7e9da005dbd3bf"}],"networking_odl/journal/worker.py":[{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"b0b616391135090adb545b85c5f5ff19708ca1af","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # run so atexit is only registered once and not several times."},{"line_number":67,"context_line":"        if self._running is None:"},{"line_number":68,"context_line":"            atexit.unregister(self._delete_pidfile)"},{"line_number":69,"context_line":"            atexit.register(self._delete_pidfile)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.pidfile.write(os.getpid())"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_1d976092","line":69,"updated":"2019-11-24 10:36:05.000000000","message":"is that intentional to call unregister and than register again the same method?","commit_id":"0d2df7e6f06812d22893f426e129fecfe959acb8"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"796ebb61969215f24be30ecefc7105604fe5351f","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # run so atexit is only registered once and not several times."},{"line_number":67,"context_line":"        if self._running is None:"},{"line_number":68,"context_line":"            atexit.unregister(self._delete_pidfile)"},{"line_number":69,"context_line":"            atexit.register(self._delete_pidfile)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.pidfile.write(os.getpid())"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_f2fdca08","line":69,"in_reply_to":"3fa7e38b_1d976092","updated":"2019-11-25 12:55:05.000000000","message":"If I understand well unregister is necessary to \"clean\" the registered list, and start registration from a clean situation. See: https://docs.python.org/3.7/library/atexit.html#atexit.unregister","commit_id":"0d2df7e6f06812d22893f426e129fecfe959acb8"},{"author":{"_account_id":11975,"name":"Slawek Kaplonski","email":"skaplons@redhat.com","username":"slaweq"},"change_message_id":"a29911b9197a74d435913938d6dc61644446ddbe","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        # run so atexit is only registered once and not several times."},{"line_number":67,"context_line":"        if self._running is None:"},{"line_number":68,"context_line":"            atexit.unregister(self._delete_pidfile)"},{"line_number":69,"context_line":"            atexit.register(self._delete_pidfile)"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"        self.pidfile.write(os.getpid())"},{"line_number":72,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"3fa7e38b_24dd5241","line":69,"in_reply_to":"3fa7e38b_f2fdca08","updated":"2019-11-26 08:38:41.000000000","message":"ok, that makes sense. Thx","commit_id":"0d2df7e6f06812d22893f426e129fecfe959acb8"}],"tox.ini":[{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"98f9111ad6234faf42dedde8a6553ec38317fdf9","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d docs,py27,py37,pep8"},{"line_number":3,"context_line":"minversion \u003d 1.6"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_eeda0ce7","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":19},"updated":"2019-10-11 14:22:40.000000000","message":"If I understand correctly, this remains here due to zuul jobs need this until they are removed globally. Am I right?","commit_id":"e9f66fb696109c07ba4b38bd9113ca8404518a68"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cb6ec0b13dc24fe471f54721a0b0c5489b514ec8","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d docs,py27,py37,pep8"},{"line_number":3,"context_line":"minversion \u003d 1.6"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_ad5df779","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":19},"in_reply_to":"3fa7e38b_eeda0ce7","updated":"2019-10-11 17:42:19.000000000","message":"I *think* so, i\u0027m giving it a try in a related change and can respond after it finishes.","commit_id":"e9f66fb696109c07ba4b38bd9113ca8404518a68"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ea4dd010f2523af72a134c7c3385a1f8e0a71faf","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d docs,py27,py37,pep8"},{"line_number":3,"context_line":"minversion \u003d 1.6"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_85a560a1","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":19},"in_reply_to":"3fa7e38b_eeda0ce7","updated":"2019-10-14 10:48:16.000000000","message":"yes, if I understand well.","commit_id":"e9f66fb696109c07ba4b38bd9113ca8404518a68"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cb6ec0b13dc24fe471f54721a0b0c5489b514ec8","unresolved":false,"context_lines":[{"line_number":3,"context_line":"minversion \u003d 1.6"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":8,"context_line":"         PYTHONWARNINGS\u003ddefault::DeprecationWarning"},{"line_number":9,"context_line":"         OS_LOG_CAPTURE\u003d{env:OS_LOG_CAPTURE:1}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_8dcd9b31","line":6,"updated":"2019-10-11 17:42:19.000000000","message":"you\u0027ll want this here:\n\nbasepython \u003d python3","commit_id":"e9f66fb696109c07ba4b38bd9113ca8404518a68"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ea4dd010f2523af72a134c7c3385a1f8e0a71faf","unresolved":false,"context_lines":[{"line_number":3,"context_line":"minversion \u003d 1.6"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"[testenv]"},{"line_number":7,"context_line":"setenv \u003d VIRTUAL_ENV\u003d{envdir}"},{"line_number":8,"context_line":"         PYTHONWARNINGS\u003ddefault::DeprecationWarning"},{"line_number":9,"context_line":"         OS_LOG_CAPTURE\u003d{env:OS_LOG_CAPTURE:1}"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_25ba6cc0","line":6,"in_reply_to":"3fa7e38b_8dcd9b31","updated":"2019-10-14 10:48:16.000000000","message":"thanks, you are right","commit_id":"e9f66fb696109c07ba4b38bd9113ca8404518a68"},{"author":{"_account_id":17685,"name":"Elod Illes","email":"elod.illes@est.tech","username":"elod.illes"},"change_message_id":"98f9111ad6234faf42dedde8a6553ec38317fdf9","unresolved":false,"context_lines":[{"line_number":113,"context_line":"local-check-factory \u003d networking_odl.hacking.checks.factory"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"[testenv:bandit]"},{"line_number":116,"context_line":"basepython \u003d python3"},{"line_number":117,"context_line":"# B101: Use of assert detected"},{"line_number":118,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":119,"context_line":"commands \u003d bandit -r networking_odl -x tests -n5 -s B101"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_0eaf682a","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":20},"updated":"2019-10-11 14:22:40.000000000","message":"why is this only removed some places but not everywhere?","commit_id":"e9f66fb696109c07ba4b38bd9113ca8404518a68"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"ea4dd010f2523af72a134c7c3385a1f8e0a71faf","unresolved":false,"context_lines":[{"line_number":113,"context_line":"local-check-factory \u003d networking_odl.hacking.checks.factory"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"[testenv:bandit]"},{"line_number":116,"context_line":"basepython \u003d python3"},{"line_number":117,"context_line":"# B101: Use of assert detected"},{"line_number":118,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":119,"context_line":"commands \u003d bandit -r networking_odl -x tests -n5 -s B101"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_45bd28b5","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":20},"in_reply_to":"3fa7e38b_0eaf682a","updated":"2019-10-14 10:48:16.000000000","message":"Done\nExcept for debug-py37","commit_id":"e9f66fb696109c07ba4b38bd9113ca8404518a68"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"cb6ec0b13dc24fe471f54721a0b0c5489b514ec8","unresolved":false,"context_lines":[{"line_number":113,"context_line":"local-check-factory \u003d networking_odl.hacking.checks.factory"},{"line_number":114,"context_line":""},{"line_number":115,"context_line":"[testenv:bandit]"},{"line_number":116,"context_line":"basepython \u003d python3"},{"line_number":117,"context_line":"# B101: Use of assert detected"},{"line_number":118,"context_line":"deps \u003d -r{toxinidir}/test-requirements.txt"},{"line_number":119,"context_line":"commands \u003d bandit -r networking_odl -x tests -n5 -s B101"}],"source_content_type":"text/x-properties","patch_set":1,"id":"3fa7e38b_0de1ab9b","line":116,"range":{"start_line":116,"start_character":0,"end_line":116,"end_character":20},"in_reply_to":"3fa7e38b_0eaf682a","updated":"2019-10-11 17:42:19.000000000","message":"It can be removed everywhere but you need one up in testenv block","commit_id":"e9f66fb696109c07ba4b38bd9113ca8404518a68"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"7b380cc8e64ebf3f2c69a9aee3699266391027a7","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d docs,py27,py37,pep8"},{"line_number":3,"context_line":"minversion \u003d 1.6"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"3fa7e38b_28deb83d","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":19},"updated":"2019-10-14 20:42:21.000000000","message":"I do think you can remove this, at least it worked in the neutron change.","commit_id":"293327def8a6a40c3d79274a055ff78fdc258cb2"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"14a070cee780d6e66f2c840209bf37eab66fbd46","unresolved":false,"context_lines":[{"line_number":1,"context_line":"[tox]"},{"line_number":2,"context_line":"envlist \u003d docs,py27,py37,pep8"},{"line_number":3,"context_line":"minversion \u003d 1.6"},{"line_number":4,"context_line":"skipsdist \u003d True"},{"line_number":5,"context_line":""}],"source_content_type":"text/x-properties","patch_set":2,"id":"3fa7e38b_78dd54db","line":2,"range":{"start_line":2,"start_character":15,"end_line":2,"end_character":19},"in_reply_to":"3fa7e38b_28deb83d","updated":"2019-10-15 12:52:04.000000000","message":"Done","commit_id":"293327def8a6a40c3d79274a055ff78fdc258cb2"}]}