)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d749c23dd816c925d3bae76ca8eafe6ed7f92d64","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Make the code compatible with hacking rules:"},{"line_number":10,"context_line":"* line break before/after binary operator (for this added ignore for"},{"line_number":11,"context_line":"W503, line break before binary operator, as if I understand well the"},{"line_number":12,"context_line":"suggested is to have the line break before the operator)"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I5f9e0c417336c8ff9e417a668268784485d8d2fa"},{"line_number":15,"context_line":"Depends-On: https://review.opendev.org/#/c/708965/"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"1f493fa4_1917ba53","line":12,"updated":"2020-05-08 03:08:31.000000000","message":"Your understanding is correct. We need to choose one of W503 and W504.","commit_id":"07cc2de515e6c90dc1fda375572bc436e21c2de5"}],"networking_odl/dhcp/odl_dhcp_driver.py":[{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"322bff119e07eed437d1e37ed077e812ff1beda9","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        dev_owner \u003d port[\u0027device_owner\u0027]"},{"line_number":82,"context_line":"        dev_id \u003d port[\u0027device_id\u0027] or \u0027\u0027"},{"line_number":83,"context_line":"        device_id_type \u003d constants.ODL_DEVICE_ID_START"},{"line_number":84,"context_line":"        if (dev_owner \u003d\u003d n_const.DEVICE_OWNER_DHCP and"},{"line_number":85,"context_line":"                dev_id.startswith(device_id_type)):"},{"line_number":86,"context_line":"            self._delete_port(plugin, context, port[\u0027id\u0027])"},{"line_number":87,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_dde54c0c","line":84,"updated":"2020-05-07 13:05:18.000000000","message":"pep8: W504 line break after binary operator","commit_id":"07cc2de515e6c90dc1fda375572bc436e21c2de5"}],"networking_odl/hacking/checks.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d749c23dd816c925d3bae76ca8eafe6ed7f92d64","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"1f493fa4_5422a9a5","side":"PARENT","updated":"2020-05-08 03:08:31.000000000","message":"Is this drop of the hacking rules intended?\n\nIf not, you can find an example on how to convert the existing rules to hacking3 compatible ones in the neutron and neutron-lib hacking rules.","commit_id":"12661e9d451143ecc4fa64d1c99da623de306bc5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d2e35ffb0664c69fd271b15736f18f9ed43b6736","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"ff570b3c_ec25daac","side":"PARENT","in_reply_to":"1f493fa4_5422a9a5","updated":"2020-05-15 07:11:28.000000000","message":"thanks Akihiro, it\u0027s better really to keep it.","commit_id":"12661e9d451143ecc4fa64d1c99da623de306bc5"}],"test-requirements.txt":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d749c23dd816c925d3bae76ca8eafe6ed7f92d64","unresolved":false,"context_lines":[{"line_number":2,"context_line":"# of appearance. Changing the order has an impact on the overall integration"},{"line_number":3,"context_line":"# process, which may cause wedges in the gate later."},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"hacking\u003e\u003d3.0.0 # Apache-2.0"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"coverage\u003e\u003d4.5.1 # Apache-2.0"},{"line_number":8,"context_line":"doc8\u003e\u003d0.8.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":5,"id":"1f493fa4_b907a61c","line":5,"updated":"2020-05-08 03:08:31.000000000","message":"as we do in neutron and neutron-lib, it is better to cap the version with \u003c3.1 as hacking usually introduces new checks in a minor release.","commit_id":"07cc2de515e6c90dc1fda375572bc436e21c2de5"}],"tox.ini":[{"author":{"_account_id":6547,"name":"Andreas Jaeger","email":"jaegerandi@gmail.com","username":"jaegerandi"},"change_message_id":"c79e22268499d151e0540ac3c7773725cf432609","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[hacking]"},{"line_number":106,"context_line":"import_exceptions \u003d networking_odl._i18n"},{"line_number":107,"context_line":"local-check-factory \u003d networking_odl.hacking.checks.factory"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"[testenv:bandit]"},{"line_number":110,"context_line":"# B101: Use of assert detected"}],"source_content_type":"text/x-properties","patch_set":2,"id":"df33271e_d702246f","line":107,"range":{"start_line":107,"start_character":1,"end_line":107,"end_character":59},"updated":"2020-03-29 14:16:20.000000000","message":"remove this line, this is not used with hacking 2.0 anymore.\n\nAlso, remove files in networking_odl/hacking/","commit_id":"b3be7511b0ea2a2de417ca9db00430f98451321d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"781085c3ce5c1133c125d5b04f1f77642630045f","unresolved":false,"context_lines":[{"line_number":104,"context_line":""},{"line_number":105,"context_line":"[hacking]"},{"line_number":106,"context_line":"import_exceptions \u003d networking_odl._i18n"},{"line_number":107,"context_line":"local-check-factory \u003d networking_odl.hacking.checks.factory"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"[testenv:bandit]"},{"line_number":110,"context_line":"# B101: Use of assert detected"}],"source_content_type":"text/x-properties","patch_set":2,"id":"df33271e_ae461ebf","line":107,"range":{"start_line":107,"start_character":1,"end_line":107,"end_character":59},"in_reply_to":"df33271e_d702246f","updated":"2020-03-30 10:07:32.000000000","message":"thanks, I removed","commit_id":"b3be7511b0ea2a2de417ca9db00430f98451321d"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"d749c23dd816c925d3bae76ca8eafe6ed7f92d64","unresolved":false,"context_lines":[{"line_number":123,"context_line":"[flake8]"},{"line_number":124,"context_line":"# TODO(dougwig) -- uncomment this to test for remaining linkages"},{"line_number":125,"context_line":"# N530 direct neutron imports not allowed"},{"line_number":126,"context_line":"# W503 Line break occurred before a binary operator"},{"line_number":127,"context_line":"show-source \u003d True"},{"line_number":128,"context_line":"# TODO(mkolesni): Fix I202 if you really care about import checks"},{"line_number":129,"context_line":"ignore \u003d N530,I202,W503"}],"source_content_type":"text/x-properties","patch_set":5,"id":"1f493fa4_d41cf96b","line":126,"updated":"2020-05-08 03:08:31.000000000","message":"It is better to mention we can use either of W503 and W504.\n\nthe neutron repo ignore W504. If the number of changes is small, it looks better to enforce W503. Looking at the proposed diff, it looks like that most codes follow W503. Thought?","commit_id":"07cc2de515e6c90dc1fda375572bc436e21c2de5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"d2e35ffb0664c69fd271b15736f18f9ed43b6736","unresolved":false,"context_lines":[{"line_number":123,"context_line":"[flake8]"},{"line_number":124,"context_line":"# TODO(dougwig) -- uncomment this to test for remaining linkages"},{"line_number":125,"context_line":"# N530 direct neutron imports not allowed"},{"line_number":126,"context_line":"# W503 Line break occurred before a binary operator"},{"line_number":127,"context_line":"show-source \u003d True"},{"line_number":128,"context_line":"# TODO(mkolesni): Fix I202 if you really care about import checks"},{"line_number":129,"context_line":"ignore \u003d N530,I202,W503"}],"source_content_type":"text/x-properties","patch_set":5,"id":"ff570b3c_6c46ea51","line":126,"in_reply_to":"1f493fa4_d41cf96b","updated":"2020-05-15 07:11:28.000000000","message":"As neutron disabled w504 than it\u0027s better to do the same here.\nThough as I see the other one is better for code readabilty.","commit_id":"07cc2de515e6c90dc1fda375572bc436e21c2de5"}]}