)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e946e9b3e2a6e34dcfb1150e13fb36a3e58955ff","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[0] https://review.opendev.org/713045"},{"line_number":19,"context_line":"[1] https://bugs.launchpad.net/neutron/+bug/1865891"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"Change-Id: I3aed8031c1b784c16dd7055afd41456ed935b7fc"},{"line_number":22,"context_line":"Closes-Bug: #1876033"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"1f493fa4_ed69f524","line":20,"updated":"2020-05-01 14:01:16.000000000","message":"Perhaps add related-bug: #1865891","commit_id":"fe3dfece10131a1a14752e500fc86e2abff1a08d"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"044c82bf06907a20e4859bb9374bfe82a0e7d61c","unresolved":false,"context_lines":[{"line_number":11,"context_line":"this caused that after subnet deletion dhcp ports was not deleted as"},{"line_number":12,"context_line":"no trigger arrived to call handle_port_update_event."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"TODO: check if PRECOMMIT_DELETE_ASSOCIATIONS can be used instead to"},{"line_number":15,"context_line":"avoid introduction of new methods (first check gave me terrible jurnal"},{"line_number":16,"context_line":"exceptions, but let\u0027s have a better look)"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"[0] https://review.opendev.org/713045"},{"line_number":19,"context_line":"[1] https://bugs.launchpad.net/neutron/+bug/1865891"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"1f493fa4_7c2a507e","line":16,"range":{"start_line":14,"start_character":0,"end_line":16,"end_character":41},"updated":"2020-05-06 14:45:23.000000000","message":"I think this can be removed, and this can be as it is now","commit_id":"b2589705aa0a9e2065865dd988e039f412ae6dc5"}],"networking_odl/dhcp/odl_dhcp_driver.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"316047079b3178c55ab8ee3dd68c05ea9f435c3d","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                                   context\u003dNone, operation\u003dNone, row\u003dNone,"},{"line_number":58,"context_line":"                                   **kwargs):"},{"line_number":59,"context_line":"        subnet \u003d kwargs[\u0027subnet\u0027]"},{"line_number":60,"context_line":"        if event \u003d\u003d \u0027after_delete\u0027:"},{"line_number":61,"context_line":"            try:"},{"line_number":62,"context_line":"                plugin \u003d directory.get_plugin()"},{"line_number":63,"context_line":"                network_id \u003d subnet[\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_8d1cb178","line":60,"range":{"start_line":60,"start_character":20,"end_line":60,"end_character":34},"updated":"2020-04-30 14:03:51.000000000","message":"constants.AFTER_DELETE","commit_id":"69c511af8dac55de216b3585e83af67737ae6c0e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e946e9b3e2a6e34dcfb1150e13fb36a3e58955ff","unresolved":false,"context_lines":[{"line_number":57,"context_line":"                                   context\u003dNone, operation\u003dNone, row\u003dNone,"},{"line_number":58,"context_line":"                                   **kwargs):"},{"line_number":59,"context_line":"        subnet \u003d kwargs[\u0027subnet\u0027]"},{"line_number":60,"context_line":"        if event \u003d\u003d \u0027after_delete\u0027:"},{"line_number":61,"context_line":"            try:"},{"line_number":62,"context_line":"                plugin \u003d directory.get_plugin()"},{"line_number":63,"context_line":"                network_id \u003d subnet[\u0027network_id\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_6eb789f6","line":60,"range":{"start_line":60,"start_character":20,"end_line":60,"end_character":34},"in_reply_to":"1f493fa4_8d1cb178","updated":"2020-05-01 14:01:16.000000000","message":"Done","commit_id":"69c511af8dac55de216b3585e83af67737ae6c0e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"316047079b3178c55ab8ee3dd68c05ea9f435c3d","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            try:"},{"line_number":62,"context_line":"                plugin \u003d directory.get_plugin()"},{"line_number":63,"context_line":"                network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":64,"context_line":"                device_id \u003d \u0027OpenDaylight\u0027 + \u0027-\u0027 + subnet[\u0027id\u0027]"},{"line_number":65,"context_line":"                filters \u003d {"},{"line_number":66,"context_line":"                    \u0027network_id\u0027: [network_id],"},{"line_number":67,"context_line":"                    \u0027device_id\u0027: [device_id],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_7052da14","line":64,"range":{"start_line":64,"start_character":29,"end_line":64,"end_character":41},"updated":"2020-04-30 14:03:51.000000000","message":"OPENDAYLIGHT_DEVICE_ID","commit_id":"69c511af8dac55de216b3585e83af67737ae6c0e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e946e9b3e2a6e34dcfb1150e13fb36a3e58955ff","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            try:"},{"line_number":62,"context_line":"                plugin \u003d directory.get_plugin()"},{"line_number":63,"context_line":"                network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":64,"context_line":"                device_id \u003d \u0027OpenDaylight\u0027 + \u0027-\u0027 + subnet[\u0027id\u0027]"},{"line_number":65,"context_line":"                filters \u003d {"},{"line_number":66,"context_line":"                    \u0027network_id\u0027: [network_id],"},{"line_number":67,"context_line":"                    \u0027device_id\u0027: [device_id],"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_ced17d25","line":64,"range":{"start_line":64,"start_character":29,"end_line":64,"end_character":41},"in_reply_to":"1f493fa4_7052da14","updated":"2020-05-01 14:01:16.000000000","message":"Done","commit_id":"69c511af8dac55de216b3585e83af67737ae6c0e"},{"author":{"_account_id":22348,"name":"Zuul","username":"zuul","tags":["SERVICE_USER"]},"tag":"autogenerated:zuul:check","change_message_id":"7df7aff9157ad4a97c1b43ec51dccdcf7a855534","unresolved":false,"context_lines":[{"line_number":72,"context_line":"                ports \u003d plugin.get_ports(context, filters\u003dfilters)"},{"line_number":73,"context_line":"                if ports:"},{"line_number":74,"context_line":"                    self._delete_port_if_dhcp(plugin, context, ports[0])"},{"line_number":75,"context_line":"            except Exception as e:"},{"line_number":76,"context_line":"                LOG.error(\"Error while deleting %s subnet %s: %s\", operation,"},{"line_number":77,"context_line":"                          subnet[\u0027id\u0027])"},{"line_number":78,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_53524314","line":75,"updated":"2020-04-30 17:00:49.000000000","message":"pep8: F841 local variable \u0027e\u0027 is assigned to but never used","commit_id":"69c511af8dac55de216b3585e83af67737ae6c0e"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"316047079b3178c55ab8ee3dd68c05ea9f435c3d","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        dev_owner \u003d port[\u0027device_owner\u0027]"},{"line_number":81,"context_line":"        dev_id \u003d port[\u0027device_id\u0027]"},{"line_number":82,"context_line":"        device_id_type \u003d driver_base.OPENDAYLIGHT_DEVICE_ID"},{"line_number":83,"context_line":"        if (dev_owner and dev_owner \u003d\u003d n_const.DEVICE_OWNER_DHCP and"},{"line_number":84,"context_line":"                dev_id and dev_id.startswith(device_id_type)):"},{"line_number":85,"context_line":"            self._delete_port(plugin, context, port[\u0027id\u0027])"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @registry.receives(constants.ODL_PORT, [constants.BEFORE_COMPLETE])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_b0f462f2","line":84,"range":{"start_line":83,"start_character":12,"end_line":84,"end_character":59},"updated":"2020-04-30 14:03:51.000000000","message":"This could be just:\n  dev_id \u003d port[\u0027device_id\u0027] or \u0027\u0027  # To ensure this is a \n                                    # string (and not None)\n  ...\n  if (dev_owner \u003d\u003d n_const.DEVICE_OWNER_DHCP and\n        dev_id.startswith(device_id_type):","commit_id":"69c511af8dac55de216b3585e83af67737ae6c0e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"e946e9b3e2a6e34dcfb1150e13fb36a3e58955ff","unresolved":false,"context_lines":[{"line_number":80,"context_line":"        dev_owner \u003d port[\u0027device_owner\u0027]"},{"line_number":81,"context_line":"        dev_id \u003d port[\u0027device_id\u0027]"},{"line_number":82,"context_line":"        device_id_type \u003d driver_base.OPENDAYLIGHT_DEVICE_ID"},{"line_number":83,"context_line":"        if (dev_owner and dev_owner \u003d\u003d n_const.DEVICE_OWNER_DHCP and"},{"line_number":84,"context_line":"                dev_id and dev_id.startswith(device_id_type)):"},{"line_number":85,"context_line":"            self._delete_port(plugin, context, port[\u0027id\u0027])"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"    @registry.receives(constants.ODL_PORT, [constants.BEFORE_COMPLETE])"}],"source_content_type":"text/x-python","patch_set":3,"id":"1f493fa4_eec27952","line":84,"range":{"start_line":83,"start_character":12,"end_line":84,"end_character":59},"in_reply_to":"1f493fa4_b0f462f2","updated":"2020-05-01 14:01:16.000000000","message":"thanks, good tip","commit_id":"69c511af8dac55de216b3585e83af67737ae6c0e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5014c9edb255530c387e2298638fea45f7e21518","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            try:"},{"line_number":62,"context_line":"                plugin \u003d directory.get_plugin()"},{"line_number":63,"context_line":"                network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":64,"context_line":"                device_id \u003d (constants.ODL_DEVICE_ID_START"},{"line_number":65,"context_line":"                             + \u0027-\u0027 + subnet[\u0027id\u0027])"},{"line_number":66,"context_line":"                filters \u003d {"},{"line_number":67,"context_line":"                    \u0027network_id\u0027: [network_id],"},{"line_number":68,"context_line":"                    \u0027device_id\u0027: [device_id],"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_549f4902","line":65,"range":{"start_line":64,"start_character":28,"end_line":65,"end_character":50},"updated":"2020-05-08 05:30:52.000000000","message":"nit: perhaps this fits into one line.","commit_id":"12661e9d451143ecc4fa64d1c99da623de306bc5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"36af78822ba6317e55234f1ba211c90acf15cde9","unresolved":false,"context_lines":[{"line_number":61,"context_line":"            try:"},{"line_number":62,"context_line":"                plugin \u003d directory.get_plugin()"},{"line_number":63,"context_line":"                network_id \u003d subnet[\u0027network_id\u0027]"},{"line_number":64,"context_line":"                device_id \u003d (constants.ODL_DEVICE_ID_START"},{"line_number":65,"context_line":"                             + \u0027-\u0027 + subnet[\u0027id\u0027])"},{"line_number":66,"context_line":"                filters \u003d {"},{"line_number":67,"context_line":"                    \u0027network_id\u0027: [network_id],"},{"line_number":68,"context_line":"                    \u0027device_id\u0027: [device_id],"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_a99ea951","line":65,"range":{"start_line":64,"start_character":28,"end_line":65,"end_character":50},"in_reply_to":"1f493fa4_549f4902","updated":"2020-05-09 04:47:38.000000000","message":"True, thanks","commit_id":"12661e9d451143ecc4fa64d1c99da623de306bc5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5014c9edb255530c387e2298638fea45f7e21518","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    \u0027device_owner\u0027: [n_const.DEVICE_OWNER_DHCP]"},{"line_number":70,"context_line":"                }"},{"line_number":71,"context_line":"                LOG.debug(\"Retrieving ODL DHCP port for deleted \""},{"line_number":72,"context_line":"                          \"subnet %s\", subnet[\u0027id\u0027])"},{"line_number":73,"context_line":"                ports \u003d plugin.get_ports(context, filters\u003dfilters)"},{"line_number":74,"context_line":"                if ports:"},{"line_number":75,"context_line":"                    self._delete_port_if_dhcp(plugin, context, ports[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_74fec538","line":72,"updated":"2020-05-08 05:30:52.000000000","message":"nit: it is better to make the message string into one line.","commit_id":"12661e9d451143ecc4fa64d1c99da623de306bc5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"36af78822ba6317e55234f1ba211c90acf15cde9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"                    \u0027device_owner\u0027: [n_const.DEVICE_OWNER_DHCP]"},{"line_number":70,"context_line":"                }"},{"line_number":71,"context_line":"                LOG.debug(\"Retrieving ODL DHCP port for deleted \""},{"line_number":72,"context_line":"                          \"subnet %s\", subnet[\u0027id\u0027])"},{"line_number":73,"context_line":"                ports \u003d plugin.get_ports(context, filters\u003dfilters)"},{"line_number":74,"context_line":"                if ports:"},{"line_number":75,"context_line":"                    self._delete_port_if_dhcp(plugin, context, ports[0])"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_09acf58a","line":72,"in_reply_to":"1f493fa4_74fec538","updated":"2020-05-09 04:47:38.000000000","message":"Done","commit_id":"12661e9d451143ecc4fa64d1c99da623de306bc5"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"5014c9edb255530c387e2298638fea45f7e21518","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                    self._delete_port_if_dhcp(plugin, context, ports[0])"},{"line_number":76,"context_line":"            except Exception:"},{"line_number":77,"context_line":"                LOG.error(\"Error while deleting %s subnet %s: %s\", operation,"},{"line_number":78,"context_line":"                          subnet[\u0027id\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _delete_port_if_dhcp(self, plugin, context, port):"},{"line_number":81,"context_line":"        dev_owner \u003d port[\u0027device_owner\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"1f493fa4_b4f84d49","line":78,"updated":"2020-05-08 05:30:52.000000000","message":"The number of %s and the number of arguments do not match.","commit_id":"12661e9d451143ecc4fa64d1c99da623de306bc5"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"36af78822ba6317e55234f1ba211c90acf15cde9","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                    self._delete_port_if_dhcp(plugin, context, ports[0])"},{"line_number":76,"context_line":"            except Exception:"},{"line_number":77,"context_line":"                LOG.error(\"Error while deleting %s subnet %s: %s\", operation,"},{"line_number":78,"context_line":"                          subnet[\u0027id\u0027])"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"    def _delete_port_if_dhcp(self, plugin, context, port):"},{"line_number":81,"context_line":"        dev_owner \u003d port[\u0027device_owner\u0027]"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff570b3c_e9a8a178","line":78,"in_reply_to":"1f493fa4_b4f84d49","updated":"2020-05-09 04:47:38.000000000","message":"Thanks Akihiro, I\u0027ve missed those %","commit_id":"12661e9d451143ecc4fa64d1c99da623de306bc5"}]}