)]}'
{"networking_odl/l3/l3_flavor.py":[{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2f0b89af1f67ea9c2921c3c4a574900866a25896","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    def _floatingip_create_precommit(self, resource, event, trigger, payload):"},{"line_number":134,"context_line":"        context \u003d payload.context"},{"line_number":135,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":136,"context_line":"        router_id \u003d payload.desired_state[\u0027floatingip_db\u0027].router_id"},{"line_number":137,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":138,"context_line":"            return"},{"line_number":139,"context_line":"        fip_dict[\u0027id\u0027] \u003d payload.resource_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"1f8cbaeb_30d470bb","line":136,"range":{"start_line":136,"start_character":28,"end_line":136,"end_character":58},"updated":"2021-08-03 15:12:03.000000000","message":"IIUC desired_state is not a dict, it\u0027s an obj already","commit_id":"6dfc8ae0fe61c6c2ce0020625652eafbff43605c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5cf1b26d4dd2b1150e79b6991b09415a3ce3314c","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    def _floatingip_create_precommit(self, resource, event, trigger, payload):"},{"line_number":134,"context_line":"        context \u003d payload.context"},{"line_number":135,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":136,"context_line":"        router_id \u003d payload.desired_state[\u0027floatingip_db\u0027].router_id"},{"line_number":137,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":138,"context_line":"            return"},{"line_number":139,"context_line":"        fip_dict[\u0027id\u0027] \u003d payload.resource_id"}],"source_content_type":"text/x-python","patch_set":1,"id":"8b413ba0_d50b2d74","line":136,"range":{"start_line":136,"start_character":28,"end_line":136,"end_character":58},"in_reply_to":"1f8cbaeb_30d470bb","updated":"2021-08-05 11:09:17.000000000","message":"thanks, you are right","commit_id":"6dfc8ae0fe61c6c2ce0020625652eafbff43605c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2f0b89af1f67ea9c2921c3c4a574900866a25896","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        self._update_floatingip_status(context, fip_dict)"},{"line_number":141,"context_line":"        if fip_dict[\u0027floating_ip_address\u0027] is None:"},{"line_number":142,"context_line":"            fip_dict[\u0027floating_ip_address\u0027] \u003d \\"},{"line_number":143,"context_line":"                payload.desired_state[\u0027floatingip_db\u0027].floating_ip_address"},{"line_number":144,"context_line":"        journal.record(context, odl_const.ODL_FLOATINGIP, fip_dict[\u0027id\u0027],"},{"line_number":145,"context_line":"                       odl_const.ODL_CREATE, fip_dict)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"43bcc2e5_b22f65ce","line":143,"range":{"start_line":143,"start_character":24,"end_line":143,"end_character":54},"updated":"2021-08-03 15:12:03.000000000","message":"ditto","commit_id":"6dfc8ae0fe61c6c2ce0020625652eafbff43605c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5cf1b26d4dd2b1150e79b6991b09415a3ce3314c","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self._update_floatingip_status(context, fip_dict)"},{"line_number":141,"context_line":"        if fip_dict[\u0027floating_ip_address\u0027] is None:"},{"line_number":142,"context_line":"            fip_dict[\u0027floating_ip_address\u0027] \u003d \\"},{"line_number":143,"context_line":"                payload.desired_state[\u0027floatingip_db\u0027].floating_ip_address"},{"line_number":144,"context_line":"        journal.record(context, odl_const.ODL_FLOATINGIP, fip_dict[\u0027id\u0027],"},{"line_number":145,"context_line":"                       odl_const.ODL_CREATE, fip_dict)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"965dc3ee_98ef39cd","line":143,"range":{"start_line":143,"start_character":24,"end_line":143,"end_character":54},"in_reply_to":"43bcc2e5_b22f65ce","updated":"2021-08-05 11:09:17.000000000","message":"Done","commit_id":"6dfc8ae0fe61c6c2ce0020625652eafbff43605c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2f0b89af1f67ea9c2921c3c4a574900866a25896","unresolved":true,"context_lines":[{"line_number":149,"context_line":"    def _floatingip_update_precommit(self, resource, event, trigger, payload):"},{"line_number":150,"context_line":"        context \u003d payload.context"},{"line_number":151,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":152,"context_line":"        router_id \u003d payload.metadata[\u0027floatingip_db\u0027].router_id"},{"line_number":153,"context_line":"        fip_dict[\u0027id\u0027] \u003d payload.metadata[\u0027floatingip_db\u0027].id"},{"line_number":154,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":155,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"fdf2d9af_dedc10d1","line":152,"range":{"start_line":152,"start_character":20,"end_line":152,"end_character":53},"updated":"2021-08-03 15:12:03.000000000","message":"changed to desired_state in neutron patch","commit_id":"6dfc8ae0fe61c6c2ce0020625652eafbff43605c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5cf1b26d4dd2b1150e79b6991b09415a3ce3314c","unresolved":true,"context_lines":[{"line_number":149,"context_line":"    def _floatingip_update_precommit(self, resource, event, trigger, payload):"},{"line_number":150,"context_line":"        context \u003d payload.context"},{"line_number":151,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":152,"context_line":"        router_id \u003d payload.metadata[\u0027floatingip_db\u0027].router_id"},{"line_number":153,"context_line":"        fip_dict[\u0027id\u0027] \u003d payload.metadata[\u0027floatingip_db\u0027].id"},{"line_number":154,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":155,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":1,"id":"46acea3c_a473ba6e","line":152,"range":{"start_line":152,"start_character":20,"end_line":152,"end_character":53},"in_reply_to":"fdf2d9af_dedc10d1","updated":"2021-08-05 11:09:17.000000000","message":"thanks, I moved with it","commit_id":"6dfc8ae0fe61c6c2ce0020625652eafbff43605c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"2f0b89af1f67ea9c2921c3c4a574900866a25896","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        context \u003d payload.context"},{"line_number":164,"context_line":"        fip_data \u003d l3_obj.FloatingIP.get_objects("},{"line_number":165,"context_line":"            context,"},{"line_number":166,"context_line":"            floating_port_id\u003dpayload.states[0][\u0027id\u0027])[0]"},{"line_number":167,"context_line":"        if not self._validate_l3_flavor(context, fip_data.router_id):"},{"line_number":168,"context_line":"            return"},{"line_number":169,"context_line":"        dependency_list \u003d [fip_data.router_id, fip_data.floating_network_id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"73b4222b_7a67df0c","line":166,"range":{"start_line":166,"start_character":46,"end_line":166,"end_character":52},"updated":"2021-08-03 15:12:03.000000000","message":"isn\u0027t it an ID of FIP, while floating_port_id is needed?","commit_id":"6dfc8ae0fe61c6c2ce0020625652eafbff43605c"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"5cf1b26d4dd2b1150e79b6991b09415a3ce3314c","unresolved":true,"context_lines":[{"line_number":163,"context_line":"        context \u003d payload.context"},{"line_number":164,"context_line":"        fip_data \u003d l3_obj.FloatingIP.get_objects("},{"line_number":165,"context_line":"            context,"},{"line_number":166,"context_line":"            floating_port_id\u003dpayload.states[0][\u0027id\u0027])[0]"},{"line_number":167,"context_line":"        if not self._validate_l3_flavor(context, fip_data.router_id):"},{"line_number":168,"context_line":"            return"},{"line_number":169,"context_line":"        dependency_list \u003d [fip_data.router_id, fip_data.floating_network_id]"}],"source_content_type":"text/x-python","patch_set":1,"id":"9d9a945d_cdad284d","line":166,"range":{"start_line":166,"start_character":46,"end_line":166,"end_character":52},"in_reply_to":"73b4222b_7a67df0c","updated":"2021-08-05 11:09:17.000000000","message":"thanks, went back to the original publish (https://opendev.org/openstack/neutron/src/branch/master/neutron/db/l3_db.py#L1530-L1536 )","commit_id":"6dfc8ae0fe61c6c2ce0020625652eafbff43605c"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8635fc64805bb74e4dddc342a9e6cd28bdd2fe09","unresolved":true,"context_lines":[{"line_number":132,"context_line":"    @log_helpers.log_method_call"},{"line_number":133,"context_line":"    def _floatingip_create_precommit(self, resource, event, trigger, payload):"},{"line_number":134,"context_line":"        context \u003d payload.context"},{"line_number":135,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":136,"context_line":"        router_id \u003d payload.desired_state.floatingip_db.router_id"},{"line_number":137,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":138,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"eec6639a_bb17a63a","line":135,"range":{"start_line":135,"start_character":19,"end_line":135,"end_character":36},"updated":"2021-08-05 12:21:43.000000000","message":"why removing deepcopy?","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0378dadcb4838e778c9322459644e8fdab083f1a","unresolved":true,"context_lines":[{"line_number":132,"context_line":"    @log_helpers.log_method_call"},{"line_number":133,"context_line":"    def _floatingip_create_precommit(self, resource, event, trigger, payload):"},{"line_number":134,"context_line":"        context \u003d payload.context"},{"line_number":135,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":136,"context_line":"        router_id \u003d payload.desired_state.floatingip_db.router_id"},{"line_number":137,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":138,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"f401a50f_63180404","line":135,"range":{"start_line":135,"start_character":19,"end_line":135,"end_character":36},"in_reply_to":"eec6639a_bb17a63a","updated":"2021-08-06 08:16:35.000000000","message":"my bad I forgot it, thanks","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8635fc64805bb74e4dddc342a9e6cd28bdd2fe09","unresolved":true,"context_lines":[{"line_number":133,"context_line":"    def _floatingip_create_precommit(self, resource, event, trigger, payload):"},{"line_number":134,"context_line":"        context \u003d payload.context"},{"line_number":135,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":136,"context_line":"        router_id \u003d payload.desired_state.floatingip_db.router_id"},{"line_number":137,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":138,"context_line":"            return"},{"line_number":139,"context_line":"        fip_dict[\u0027id\u0027] \u003d payload.resource_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"f1a69cb5_57cb836f","line":136,"range":{"start_line":136,"start_character":28,"end_line":136,"end_character":41},"updated":"2021-08-05 12:21:43.000000000","message":"desired_state is itself floatingip_db obj","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0378dadcb4838e778c9322459644e8fdab083f1a","unresolved":false,"context_lines":[{"line_number":133,"context_line":"    def _floatingip_create_precommit(self, resource, event, trigger, payload):"},{"line_number":134,"context_line":"        context \u003d payload.context"},{"line_number":135,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":136,"context_line":"        router_id \u003d payload.desired_state.floatingip_db.router_id"},{"line_number":137,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":138,"context_line":"            return"},{"line_number":139,"context_line":"        fip_dict[\u0027id\u0027] \u003d payload.resource_id"}],"source_content_type":"text/x-python","patch_set":2,"id":"367097d4_28e60873","line":136,"range":{"start_line":136,"start_character":28,"end_line":136,"end_character":41},"in_reply_to":"f1a69cb5_57cb836f","updated":"2021-08-06 08:16:35.000000000","message":"Done","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8635fc64805bb74e4dddc342a9e6cd28bdd2fe09","unresolved":true,"context_lines":[{"line_number":140,"context_line":"        self._update_floatingip_status(context, fip_dict)"},{"line_number":141,"context_line":"        if fip_dict[\u0027floating_ip_address\u0027] is None:"},{"line_number":142,"context_line":"            fip_dict[\u0027floating_ip_address\u0027] \u003d \\"},{"line_number":143,"context_line":"                payload.desired_state.floatingip_db.floating_ip_address"},{"line_number":144,"context_line":"        journal.record(context, odl_const.ODL_FLOATINGIP, fip_dict[\u0027id\u0027],"},{"line_number":145,"context_line":"                       odl_const.ODL_CREATE, fip_dict)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"8d775e34_1e7a26d1","line":143,"range":{"start_line":143,"start_character":24,"end_line":143,"end_character":37},"updated":"2021-08-05 12:21:43.000000000","message":"ditto","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0378dadcb4838e778c9322459644e8fdab083f1a","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        self._update_floatingip_status(context, fip_dict)"},{"line_number":141,"context_line":"        if fip_dict[\u0027floating_ip_address\u0027] is None:"},{"line_number":142,"context_line":"            fip_dict[\u0027floating_ip_address\u0027] \u003d \\"},{"line_number":143,"context_line":"                payload.desired_state.floatingip_db.floating_ip_address"},{"line_number":144,"context_line":"        journal.record(context, odl_const.ODL_FLOATINGIP, fip_dict[\u0027id\u0027],"},{"line_number":145,"context_line":"                       odl_const.ODL_CREATE, fip_dict)"},{"line_number":146,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"7d63b217_98b08271","line":143,"range":{"start_line":143,"start_character":24,"end_line":143,"end_character":37},"in_reply_to":"8d775e34_1e7a26d1","updated":"2021-08-06 08:16:35.000000000","message":"Done","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8635fc64805bb74e4dddc342a9e6cd28bdd2fe09","unresolved":true,"context_lines":[{"line_number":149,"context_line":"    def _floatingip_update_precommit(self, resource, event, trigger, payload):"},{"line_number":150,"context_line":"        context \u003d payload.context"},{"line_number":151,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":152,"context_line":"        router_id \u003d payload.desired_state.router_id"},{"line_number":153,"context_line":"        fip_dict[\u0027id\u0027] \u003d payload.desired_state.id"},{"line_number":154,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":155,"context_line":"            return"}],"source_content_type":"text/x-python","patch_set":2,"id":"0a6c2e4c_9d398c8c","line":152,"range":{"start_line":152,"start_character":20,"end_line":152,"end_character":51},"updated":"2021-08-05 12:21:43.000000000","message":"this one is correct","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8635fc64805bb74e4dddc342a9e6cd28bdd2fe09","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        context \u003d payload.context"},{"line_number":151,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":152,"context_line":"        router_id \u003d payload.desired_state.router_id"},{"line_number":153,"context_line":"        fip_dict[\u0027id\u0027] \u003d payload.desired_state.id"},{"line_number":154,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":155,"context_line":"            return"},{"line_number":156,"context_line":"        self._update_floatingip_status(context, fip_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"2a1cd526_504a7b4f","line":153,"range":{"start_line":153,"start_character":33,"end_line":153,"end_character":49},"updated":"2021-08-05 12:21:43.000000000","message":"could be just resource_id","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0378dadcb4838e778c9322459644e8fdab083f1a","unresolved":true,"context_lines":[{"line_number":150,"context_line":"        context \u003d payload.context"},{"line_number":151,"context_line":"        fip_dict \u003d payload.states[0]"},{"line_number":152,"context_line":"        router_id \u003d payload.desired_state.router_id"},{"line_number":153,"context_line":"        fip_dict[\u0027id\u0027] \u003d payload.desired_state.id"},{"line_number":154,"context_line":"        if not self._validate_l3_flavor(context, router_id):"},{"line_number":155,"context_line":"            return"},{"line_number":156,"context_line":"        self._update_floatingip_status(context, fip_dict)"}],"source_content_type":"text/x-python","patch_set":2,"id":"8deb9cb1_aec71e8c","line":153,"range":{"start_line":153,"start_character":33,"end_line":153,"end_character":49},"in_reply_to":"2a1cd526_504a7b4f","updated":"2021-08-06 08:16:35.000000000","message":"It\u0027s not in the original neutron patch:\nhttps://review.opendev.org/c/openstack/neutron/+/801874/7/neutron/db/l3_db.py#1487\nbut perhaps it sould be","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"},{"author":{"_account_id":5948,"name":"Oleg Bondarev","email":"obondarev@mirantis.com","username":"obondarev"},"change_message_id":"8635fc64805bb74e4dddc342a9e6cd28bdd2fe09","unresolved":true,"context_lines":[{"line_number":162,"context_line":"    def _floatingip_delete_precommit(self, resource, event, trigger, payload):"},{"line_number":163,"context_line":"        context \u003d payload.context"},{"line_number":164,"context_line":"        port \u003d payload.states[-1]"},{"line_number":165,"context_line":"        floating_port_id \u003d port[\u0027id\u0027]"},{"line_number":166,"context_line":"        fip_data \u003d l3_obj.FloatingIP.get_objects("},{"line_number":167,"context_line":"            context,"},{"line_number":168,"context_line":"            floating_port_id\u003dfloating_port_id)[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"ef60ba6c_d3156081","line":165,"range":{"start_line":165,"start_character":27,"end_line":165,"end_character":37},"updated":"2021-08-05 12:21:43.000000000","message":"can get in one step as payload.resource_id","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"0378dadcb4838e778c9322459644e8fdab083f1a","unresolved":true,"context_lines":[{"line_number":162,"context_line":"    def _floatingip_delete_precommit(self, resource, event, trigger, payload):"},{"line_number":163,"context_line":"        context \u003d payload.context"},{"line_number":164,"context_line":"        port \u003d payload.states[-1]"},{"line_number":165,"context_line":"        floating_port_id \u003d port[\u0027id\u0027]"},{"line_number":166,"context_line":"        fip_data \u003d l3_obj.FloatingIP.get_objects("},{"line_number":167,"context_line":"            context,"},{"line_number":168,"context_line":"            floating_port_id\u003dfloating_port_id)[0]"}],"source_content_type":"text/x-python","patch_set":2,"id":"721e7633_5e2a67c7","line":165,"range":{"start_line":165,"start_character":27,"end_line":165,"end_character":37},"in_reply_to":"ef60ba6c_d3156081","updated":"2021-08-06 08:16:35.000000000","message":"thanks","commit_id":"0dfe70216535901a38beb3bd1024d5cfac7fd924"}]}