)]}'
{".zuul.d/project.yaml":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a6b6a4a47b6ed297a17a651491c1158cbe663ddd","unresolved":true,"context_lines":[{"line_number":75,"context_line":"              - ^releasenotes/.*$"},{"line_number":76,"context_line":"        - networking-odl-functional-neon:"},{"line_number":77,"context_line":"            required-projects:"},{"line_number":78,"context_line":"              - openstack/neutron"},{"line_number":79,"context_line":"              - openstack/ceilometer"},{"line_number":80,"context_line":"              - x/networking-l2gw"},{"line_number":81,"context_line":"              - openstack/networking-sfc"},{"line_number":82,"context_line":"              - openstack/networking-bgpvpn"},{"line_number":83,"context_line":"        - networking-odl-functional-sodium:"},{"line_number":84,"context_line":"            required-projects:"},{"line_number":85,"context_line":"              - openstack/neutron"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"bfb587cb_7e2113b2","line":82,"range":{"start_line":78,"start_character":12,"end_line":82,"end_character":43},"updated":"2022-09-16 11:54:47.000000000","message":"nit: if plan to update the patch can also use anchors/aliases to copying these multiple times.","commit_id":"6d03bcd2892d2e16e23f3af0ac51969ae2ca7376"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"764046a8c0d3073286ca3026f9e7bdca6a914528","unresolved":true,"context_lines":[{"line_number":75,"context_line":"              - ^releasenotes/.*$"},{"line_number":76,"context_line":"        - networking-odl-functional-neon:"},{"line_number":77,"context_line":"            required-projects:"},{"line_number":78,"context_line":"              - openstack/neutron"},{"line_number":79,"context_line":"              - openstack/ceilometer"},{"line_number":80,"context_line":"              - x/networking-l2gw"},{"line_number":81,"context_line":"              - openstack/networking-sfc"},{"line_number":82,"context_line":"              - openstack/networking-bgpvpn"},{"line_number":83,"context_line":"        - networking-odl-functional-sodium:"},{"line_number":84,"context_line":"            required-projects:"},{"line_number":85,"context_line":"              - openstack/neutron"}],"source_content_type":"text/x-yaml","patch_set":11,"id":"984081c4_940bac6c","line":82,"range":{"start_line":78,"start_character":12,"end_line":82,"end_character":43},"in_reply_to":"bfb587cb_7e2113b2","updated":"2022-09-16 13:01:17.000000000","message":"Thanks, good idea ( I remember you suggested the same for bagpipe)","commit_id":"6d03bcd2892d2e16e23f3af0ac51969ae2ca7376"}],"/COMMIT_MSG":[{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"02b0eb62e955f10e228bf73acaa0812bf0d03e77","unresolved":true,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"For now 4 functional tests are still unstable, so mark these unstable"},{"line_number":10,"context_line":"for now:"},{"line_number":11,"context_line":"- networking_odl.tests.functional.test_l2gateway.TestL2gatewayV2Driver."},{"line_number":12,"context_line":"  test_l2gateway_connection_create_delete"},{"line_number":13,"context_line":"- networking_odl.tests.functional.test_l2gateway.TestL2gatewayV2Driver."},{"line_number":14,"context_line":"  test_l2gateway_delete"},{"line_number":15,"context_line":"- networking_odl.tests.functional.test_l2gateway.TestL2gatewayV2Driver."},{"line_number":16,"context_line":"  test_l2gateway_create"},{"line_number":17,"context_line":"- networking_odl.tests.functional.test_l2gateway.TestL2gatewayV2Driver."},{"line_number":18,"context_line":"  test_l2gateway_update"},{"line_number":19,"context_line":"And 1 unit test also seems ustable:"},{"line_number":20,"context_line":"- networking_odl.tests.unit.l2gateway.test_driver_v2."},{"line_number":21,"context_line":"  OpenDaylightL2GWDriverTestCase.test_create_l2_gateway_connection"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"Related-Bug: #1989718"},{"line_number":24,"context_line":"Change-Id: I3adb5a8769ed7aed073bdbf55f03c863e9963196"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"107d45b1_5016ccf3","line":21,"range":{"start_line":11,"start_character":0,"end_line":21,"end_character":66},"updated":"2022-09-19 12:48:39.000000000","message":"No idea why l2gw driver is more vulnerable for this slqalchemy 2.0 change, I compared it to other drivers, and can\u0027t see the difference at the moment.... :-(","commit_id":"c70c3dc6cad40f006df076bd96affd24b3485497"}],"/PATCHSET_LEVEL":[{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"846671c607a259d3eb1598d651528540be3197f9","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":14,"id":"2b154cf5_e06124d9","updated":"2022-09-19 13:21:18.000000000","message":"Looks good to make gates green at least for now and we have https://bugs.launchpad.net/networking-odl/+bug/1989718 for tracking proper fix","commit_id":"c70c3dc6cad40f006df076bd96affd24b3485497"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"2132d8cbd016877dd4ab7da9a19f5704db05ffa2","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":15,"id":"37759d0e_611ee4b6","updated":"2022-09-20 13:12:23.000000000","message":"recheck","commit_id":"9f2c7ba117ab82e772e0319baa9fa66adffc1ff0"},{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"41345632ef472532e857565348a916ed55c60f53","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"1cbb3882_6301f4c5","updated":"2022-09-22 13:48:46.000000000","message":"recheck\n\n(just for testing again)","commit_id":"a9da81d08265597c79476992e76492b48d275d14"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"6e0cc8efc65956c653e785888328c30de9aa6c24","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":18,"id":"33219aaa_fd22b6f2","updated":"2022-09-21 18:18:44.000000000","message":"recheck\nThe functional failure seems familiar, perhaps not related to https://bugs.launchpad.net/networking-odl/+bug/1989718","commit_id":"a9da81d08265597c79476992e76492b48d275d14"}],"networking_odl/db/db.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"be5edb6fc0710f1b65b783795b20f42fa80657da","unresolved":true,"context_lines":[{"line_number":140,"context_line":"            context.session.flush()"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":""},{"line_number":143,"context_line":"def create_pending_row(context, object_type, object_uuid,"},{"line_number":144,"context_line":"                       operation, data, depending_on\u003dNone):"},{"line_number":145,"context_line":"    if depending_on is None:"},{"line_number":146,"context_line":"        depending_on \u003d []"}],"source_content_type":"text/x-python","patch_set":17,"id":"d32c5645_0e4acaa7","line":143,"updated":"2022-09-21 13:31:01.000000000","message":"This method is called outside a DB context. It is called from journal.record.\n\nBecause none of the other methods (update, delete, etc) are decorated, maybe you can just add this context in [1]\n\n[1]https://opendev.org/openstack/networking-odl/src/branch/master/networking_odl/journal/journal.py#L119-L121","commit_id":"ac824683868cc760f1c2a5b0197f48c433953c33"}],"networking_odl/journal/journal.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"cb7862f0854363ec58990b8505ea44035fe29385","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    # would make the dependency irrelevant. In that case we request a retry."},{"line_number":117,"context_line":"    # For more details, read the commit message that introduced this comment."},{"line_number":118,"context_line":"    try:"},{"line_number":119,"context_line":"        entry \u003d db.create_pending_row("},{"line_number":120,"context_line":"            plugin_context, object_type, object_uuid, operation, data,"},{"line_number":121,"context_line":"            depending_on\u003ddepending_on)"},{"line_number":122,"context_line":"    except exception.DBReferenceError as e:"},{"line_number":123,"context_line":"        raise exception.RetryRequest(e)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"58dafc9c_16042090","line":121,"range":{"start_line":119,"start_character":8,"end_line":121,"end_character":38},"updated":"2022-09-21 13:32:27.000000000","message":"This section should be inside a writer context.","commit_id":"ac824683868cc760f1c2a5b0197f48c433953c33"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"308c92a303222f7b17afff8bd8ca0a33b18b0b91","unresolved":true,"context_lines":[{"line_number":116,"context_line":"    # would make the dependency irrelevant. In that case we request a retry."},{"line_number":117,"context_line":"    # For more details, read the commit message that introduced this comment."},{"line_number":118,"context_line":"    try:"},{"line_number":119,"context_line":"        entry \u003d db.create_pending_row("},{"line_number":120,"context_line":"            plugin_context, object_type, object_uuid, operation, data,"},{"line_number":121,"context_line":"            depending_on\u003ddepending_on)"},{"line_number":122,"context_line":"    except exception.DBReferenceError as e:"},{"line_number":123,"context_line":"        raise exception.RetryRequest(e)"},{"line_number":124,"context_line":""}],"source_content_type":"text/x-python","patch_set":17,"id":"6671a38c_490757f2","line":121,"range":{"start_line":119,"start_character":8,"end_line":121,"end_character":38},"in_reply_to":"58dafc9c_16042090","updated":"2022-09-21 13:53:28.000000000","message":"I tried that previously and there is another session open","commit_id":"ac824683868cc760f1c2a5b0197f48c433953c33"}],"networking_odl/tests/unit/db/test_db.py":[{"author":{"_account_id":13861,"name":"yatin","email":"ykarel@redhat.com","username":"yatinkarel"},"change_message_id":"a6b6a4a47b6ed297a17a651491c1158cbe663ddd","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        self.assertIsNotNone(row)"},{"line_number":177,"context_line":"        self.assertEqual(odl_const.PROCESSING, row.state)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @in_session"},{"line_number":180,"context_line":"    def test_get_oldest_pending_row_order(self):"},{"line_number":181,"context_line":"        with db_api.CONTEXT_WRITER.using(self.db_context):"},{"line_number":182,"context_line":"            db.create_pending_row(self.db_context, *self.UPDATE_ROW)"}],"source_content_type":"text/x-python","patch_set":11,"id":"95d55953_9946233a","line":179,"range":{"start_line":179,"start_character":5,"end_line":179,"end_character":15},"updated":"2022-09-16 11:54:47.000000000","message":"seems with the decorator applied, below db_api.CONTEXT_WRITER shouldn\u0027t be needed, it\u0027s kind of duplicating it?","commit_id":"6d03bcd2892d2e16e23f3af0ac51969ae2ca7376"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"764046a8c0d3073286ca3026f9e7bdca6a914528","unresolved":true,"context_lines":[{"line_number":176,"context_line":"        self.assertIsNotNone(row)"},{"line_number":177,"context_line":"        self.assertEqual(odl_const.PROCESSING, row.state)"},{"line_number":178,"context_line":""},{"line_number":179,"context_line":"    @in_session"},{"line_number":180,"context_line":"    def test_get_oldest_pending_row_order(self):"},{"line_number":181,"context_line":"        with db_api.CONTEXT_WRITER.using(self.db_context):"},{"line_number":182,"context_line":"            db.create_pending_row(self.db_context, *self.UPDATE_ROW)"}],"source_content_type":"text/x-python","patch_set":11,"id":"6600a432_08849eef","line":179,"range":{"start_line":179,"start_character":5,"end_line":179,"end_character":15},"in_reply_to":"95d55953_9946233a","updated":"2022-09-16 13:01:17.000000000","message":"thanks, good catch, I looked so long these lines....","commit_id":"6d03bcd2892d2e16e23f3af0ac51969ae2ca7376"}],"networking_odl/tests/unit/journal/test_recovery.py":[{"author":{"_account_id":16688,"name":"Rodolfo Alonso","email":"ralonsoh@redhat.com","username":"rodolfo-alonso-hernandez"},"change_message_id":"33a5ddb4d72ceeaae8251c205c6b6d11e717003b","unresolved":true,"context_lines":[{"line_number":172,"context_line":"        original_row \u003d self._test_recovery("},{"line_number":173,"context_line":"            operation, odl_resource, odl_const.COMPLETED)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        pending_row \u003d db.get_all_db_rows_by_state("},{"line_number":176,"context_line":"            self.db_context, odl_const.PENDING)[0]"},{"line_number":177,"context_line":"        self.assertEqual(expected_operation, pending_row[\u0027operation\u0027])"},{"line_number":178,"context_line":"        self.assertEqual(original_row[\u0027object_type\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"e709973c_933ee9a6","line":175,"range":{"start_line":175,"start_character":25,"end_line":175,"end_character":49},"updated":"2022-09-19 08:35:13.000000000","message":"This method is called outside a context","commit_id":"8cdf26b5752fea237167dca2f51622b23b37621e"},{"author":{"_account_id":8313,"name":"Lajos Katona","display_name":"lajoskatona","email":"katonalala@gmail.com","username":"elajkat","status":"Ericsson Software Technology"},"change_message_id":"2bae6e583a8cf41d27a6d00c2e3a407298dee1e9","unresolved":true,"context_lines":[{"line_number":172,"context_line":"        original_row \u003d self._test_recovery("},{"line_number":173,"context_line":"            operation, odl_resource, odl_const.COMPLETED)"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"        pending_row \u003d db.get_all_db_rows_by_state("},{"line_number":176,"context_line":"            self.db_context, odl_const.PENDING)[0]"},{"line_number":177,"context_line":"        self.assertEqual(expected_operation, pending_row[\u0027operation\u0027])"},{"line_number":178,"context_line":"        self.assertEqual(original_row[\u0027object_type\u0027],"}],"source_content_type":"text/x-python","patch_set":12,"id":"1e79e54b_2bcefa64","line":175,"range":{"start_line":175,"start_character":25,"end_line":175,"end_character":49},"in_reply_to":"e709973c_933ee9a6","updated":"2022-09-19 11:16:36.000000000","message":"Thanks, actually there\u0027s still unstable tests it seems even with this context, strangely for l2gw.\nI try to follow those, and we can backport if I find anything for those.","commit_id":"8cdf26b5752fea237167dca2f51622b23b37621e"}]}