)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"546d2a5d650485bdae233c2491977d4e360337ff","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Handle OVN NB and SB databases with separate ovsdb-server procs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To help with scale issues, default devstack to spawn a separate"},{"line_number":10,"context_line":"ovsdb-server process for the OVN NB database, listening on port 6641,"},{"line_number":11,"context_line":"using a different db socket, and a different PID file for ovs-appctl."},{"line_number":12,"context_line":"Included are corresponding changes needed to start ovn-northd properly,"},{"line_number":13,"context_line":"to ensure that the Neutron plugin connects correctly, and to configure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_e54ae4ab","line":10,"updated":"2016-02-04 19:04:22.000000000","message":"It looks to me that this change doesn\u0027t start a separate ovsdb-server process just one listening on two ports 6640/6641.\n\nI don\u0027t see how this change would improve scale, am i missing something here?","commit_id":"a0407784d468b1646c2cfdccbc90a00bd454247b"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"f593eab32a4a9fa77b9af6a5099786a16ff6e9b0","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Handle OVN NB and SB databases with separate ovsdb-server procs"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"To help with scale issues, default devstack to spawn a separate"},{"line_number":10,"context_line":"ovsdb-server process for the OVN NB database, listening on port 6641,"},{"line_number":11,"context_line":"using a different db socket, and a different PID file for ovs-appctl."},{"line_number":12,"context_line":"Included are corresponding changes needed to start ovn-northd properly,"},{"line_number":13,"context_line":"to ensure that the Neutron plugin connects correctly, and to configure"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"5a5ae5dd_33584632","line":10,"in_reply_to":"5a5ae5dd_e54ae4ab","updated":"2016-02-04 19:27:11.000000000","message":"It starts two separate processes are there are two separate ovsdb-server launches in plugin.sh.  Having two separate processes avoids having the same ovsdb process handle both the NB and SB databases, which appears to lead to the OVN plugin seeing OVS timeouts when communicating to the NB database.","commit_id":"a0407784d468b1646c2cfdccbc90a00bd454247b"}],"devstack/computenode-local.conf.sample":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"8515a50925ee6dce9a416346c610215f0e76018b","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Q_HOST\u003d$SERVICE_HOST"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# How to connect to ovsdb-server hosting the OVN SB database"},{"line_number":48,"context_line":"OVN_SB_REMOTE\u003dtcp:$SERVICE_HOST:6640"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# A UUID to uniquely identify this system.  If one is not specified, a random"},{"line_number":51,"context_line":"# one will be generated and saved in the file \u0027ovn-uuid\u0027 for re-use in future"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"fa0719c6_e519ab89","line":48,"updated":"2016-03-24 00:23:42.000000000","message":"This defaults to 6642 in ovn-ctl","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"78b9a2b54df74749e305d46e9ed8d1a1b546c940","unresolved":false,"context_lines":[{"line_number":45,"context_line":"Q_HOST\u003d$SERVICE_HOST"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":"# How to connect to ovsdb-server hosting the OVN SB database"},{"line_number":48,"context_line":"OVN_SB_REMOTE\u003dtcp:$SERVICE_HOST:6640"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"# A UUID to uniquely identify this system.  If one is not specified, a random"},{"line_number":51,"context_line":"# one will be generated and saved in the file \u0027ovn-uuid\u0027 for re-use in future"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"fa0719c6_3b6c639b","line":48,"in_reply_to":"fa0719c6_e519ab89","updated":"2016-03-24 03:12:05.000000000","message":"I prefer 6640 and 6641 for migration reasons, but I don\u0027t think it matters, so done...","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"}],"devstack/local.conf.sample":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"8515a50925ee6dce9a416346c610215f0e76018b","unresolved":false,"context_lines":[{"line_number":46,"context_line":"#OVN_NB_REMOTE\u003dtcp:$SERVICE_HOST:6641"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# How to connect to ovsdb-server hosting the OVN SB database."},{"line_number":49,"context_line":"#OVN_SB_REMOTE\u003dtcp:$SERVICE_HOST:6640"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# A UUID to uniquely identify this system.  If one is not specified, a random"},{"line_number":52,"context_line":"# one will be generated and saved in the file \u0027ovn-uuid\u0027 for re-use in future"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"fa0719c6_c51e276f","line":49,"updated":"2016-03-24 00:23:42.000000000","message":"This defaults to 6642 in ovn-ctl","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"78b9a2b54df74749e305d46e9ed8d1a1b546c940","unresolved":false,"context_lines":[{"line_number":46,"context_line":"#OVN_NB_REMOTE\u003dtcp:$SERVICE_HOST:6641"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"# How to connect to ovsdb-server hosting the OVN SB database."},{"line_number":49,"context_line":"#OVN_SB_REMOTE\u003dtcp:$SERVICE_HOST:6640"},{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# A UUID to uniquely identify this system.  If one is not specified, a random"},{"line_number":52,"context_line":"# one will be generated and saved in the file \u0027ovn-uuid\u0027 for re-use in future"}],"source_content_type":"application/octet-stream","patch_set":16,"id":"fa0719c6_3b03c3b9","line":49,"in_reply_to":"fa0719c6_c51e276f","updated":"2016-03-24 03:12:05.000000000","message":"same comment as the previous file...","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"}],"devstack/plugin.sh":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"ed0b7960d5c5e3e61018713958f127b8064ab1f7","unresolved":false,"context_lines":[{"line_number":53,"context_line":"OVN_REMOTE\u003d${OVN_REMOTE:-tcp:$HOST_IP:6640}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# How to connect to ovsdb-server hosting the OVN NB database"},{"line_number":56,"context_line":"OVN_NB_REMOTE\u003d${OVN_NB_REMOTE:-tcp:$HOST_IP:6641}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# A UUID to uniquely identify this system.  If one is not specified, a random"},{"line_number":59,"context_line":"# one will be generated.  A randomly generated UUID will be saved in a file"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a5ae5dd_c47d6fe8","line":56,"updated":"2016-02-04 17:30:52.000000000","message":"I think we need to update the Vagrant config for this, specifically the ovn-db box, so we set this variable there. See vagrant/provisioning/setup-db.sh","commit_id":"e24fcb7e656a0e8de7d7f8054ed56dec8ce37c79"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"ed0b7960d5c5e3e61018713958f127b8064ab1f7","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        OVNNB_DB\u003d\"unix:/usr/local/var/run/openvswitch/nb_db.sock\""},{"line_number":340,"context_line":"        OVNSB_DB\u003d\"unix:/usr/local/var/run/openvswitch/db.sock\""},{"line_number":341,"context_line":"        "},{"line_number":342,"context_line":"        run_process ovn-northd \"ovn-northd --ovnnb-db\u003d$OVNNB_DB \\"},{"line_number":343,"context_line":"                                           --ovnsb-db\u003d$OVNSB_DB \\"},{"line_number":344,"context_line":"                                           --pidfile \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a5ae5dd_e478abf4","line":341,"updated":"2016-02-04 17:30:52.000000000","message":"Whitespace.","commit_id":"e24fcb7e656a0e8de7d7f8054ed56dec8ce37c79"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"8417b62bdb73315a3ea1594f842692546f70341d","unresolved":false,"context_lines":[{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        OVNNB_DB\u003d\"unix:/usr/local/var/run/openvswitch/nb_db.sock\""},{"line_number":340,"context_line":"        OVNSB_DB\u003d\"unix:/usr/local/var/run/openvswitch/db.sock\""},{"line_number":341,"context_line":"        "},{"line_number":342,"context_line":"        run_process ovn-northd \"ovn-northd --ovnnb-db\u003d$OVNNB_DB \\"},{"line_number":343,"context_line":"                                           --ovnsb-db\u003d$OVNSB_DB \\"},{"line_number":344,"context_line":"                                           --pidfile \\"}],"source_content_type":"text/x-sh","patch_set":1,"id":"5a5ae5dd_c416cfa6","line":341,"updated":"2016-02-04 17:30:00.000000000","message":"darn, I have a red thingy","commit_id":"e24fcb7e656a0e8de7d7f8054ed56dec8ce37c79"},{"author":{"_account_id":9515,"name":"Matthew Kassawara","email":"mkassawara@gmail.com","username":"ionosphere80"},"change_message_id":"5e00c41030b741ada9d966a6f1c831ad0d090530","unresolved":false,"context_lines":[{"line_number":50,"context_line":"OVN_BRANCH\u003d${OVN_BRANCH:-origin/master}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# How to connect to ovsdb-server hosting the OVN SB database."},{"line_number":53,"context_line":"OVN_REMOTE\u003d${OVN_REMOTE:-tcp:$HOST_IP:6640}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# How to connect to ovsdb-server hosting the OVN NB database"},{"line_number":56,"context_line":"OVN_NB_REMOTE\u003d${OVN_NB_REMOTE:-tcp:$HOST_IP:6641}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a5ae5dd_1f98b2bf","line":53,"updated":"2016-02-04 17:39:59.000000000","message":"Can you change this to OVN_SB_REMOTE for consistency?","commit_id":"a666bce27ace5728ff8164209e45e22b87b9d666"},{"author":{"_account_id":11255,"name":"Dustin Lundquist","username":"dustin.lundquist","inactive":true},"change_message_id":"5b504096ed0b971dc92efa782960533ccbe5f19b","unresolved":false,"context_lines":[{"line_number":50,"context_line":"OVN_BRANCH\u003d${OVN_BRANCH:-origin/master}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# How to connect to ovsdb-server hosting the OVN SB database."},{"line_number":53,"context_line":"OVN_REMOTE\u003d${OVN_REMOTE:-tcp:$HOST_IP:6640}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# How to connect to ovsdb-server hosting the OVN NB database"},{"line_number":56,"context_line":"OVN_NB_REMOTE\u003d${OVN_NB_REMOTE:-tcp:$HOST_IP:6641}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a5ae5dd_5f270a64","line":53,"in_reply_to":"5a5ae5dd_1f98b2bf","updated":"2016-02-04 17:43:37.000000000","message":"+1, but do we need to continue to honor OVN_REMOTE for backwards compatibility?","commit_id":"a666bce27ace5728ff8164209e45e22b87b9d666"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"d7d833f25678d374346205c84b85707b4e30cdcb","unresolved":false,"context_lines":[{"line_number":50,"context_line":"OVN_BRANCH\u003d${OVN_BRANCH:-origin/master}"},{"line_number":51,"context_line":""},{"line_number":52,"context_line":"# How to connect to ovsdb-server hosting the OVN SB database."},{"line_number":53,"context_line":"OVN_REMOTE\u003d${OVN_REMOTE:-tcp:$HOST_IP:6640}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# How to connect to ovsdb-server hosting the OVN NB database"},{"line_number":56,"context_line":"OVN_NB_REMOTE\u003d${OVN_NB_REMOTE:-tcp:$HOST_IP:6641}"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a5ae5dd_1fe992e6","line":53,"in_reply_to":"5a5ae5dd_1f98b2bf","updated":"2016-02-04 17:42:48.000000000","message":"Done","commit_id":"a666bce27ace5728ff8164209e45e22b87b9d666"},{"author":{"_account_id":11255,"name":"Dustin Lundquist","username":"dustin.lundquist","inactive":true},"change_message_id":"5b504096ed0b971dc92efa782960533ccbe5f19b","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        OVNNB_DB\u003d\"unix:/usr/local/var/run/openvswitch/nb_db.sock\""},{"line_number":340,"context_line":"        OVNSB_DB\u003d\"unix:/usr/local/var/run/openvswitch/db.sock\""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        run_process ovn-northd \"ovn-northd --ovnnb-db\u003d$OVNNB_DB \\"},{"line_number":343,"context_line":"                                           --ovnsb-db\u003d$OVNSB_DB \\"}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a5ae5dd_bfbe3ed2","line":340,"updated":"2016-02-04 17:43:37.000000000","message":"sb_db.sock for consistency too?","commit_id":"a666bce27ace5728ff8164209e45e22b87b9d666"},{"author":{"_account_id":11255,"name":"Dustin Lundquist","username":"dustin.lundquist","inactive":true},"change_message_id":"eea9dd7d7d6334d25b5a6bddab66ccbd9ae52840","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    cd $DATA_DIR/ovs"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    EXTRA_DBS\u003d\"\""},{"line_number":257,"context_line":"    OVSDB_REMOTE\u003d\"\""},{"line_number":258,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":259,"context_line":"        EXTRA_DBS\u003d\"ovnsb.db\""},{"line_number":260,"context_line":"        OVSDB_REMOTE\u003d\"--remote\u003dptcp:6640:$HOST_IP\""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5a5ae5dd_1f6f522c","line":257,"updated":"2016-02-04 17:53:06.000000000","message":"OVSDB_SB_REMOTE for consistency?","commit_id":"a0407784d468b1646c2cfdccbc90a00bd454247b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"546d2a5d650485bdae233c2491977d4e360337ff","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    OVSDB_REMOTE\u003d\"\""},{"line_number":258,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":259,"context_line":"        EXTRA_DBS\u003d\"ovnsb.db\""},{"line_number":260,"context_line":"        OVSDB_REMOTE\u003d\"--remote\u003dptcp:6640:$HOST_IP\""},{"line_number":261,"context_line":"        OVSDB_NB_REMOTE\u003d\"--remote\u003dptcp:6641:$HOST_IP\""},{"line_number":262,"context_line":"        PID_FILE\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-nb.pid\""},{"line_number":263,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5a5ae5dd_052700cb","line":260,"updated":"2016-02-04 19:04:22.000000000","message":"This just tells osdb-server to just bind on an additional port a host could connect to either one and they are the same though i believe.","commit_id":"a0407784d468b1646c2cfdccbc90a00bd454247b"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"f593eab32a4a9fa77b9af6a5099786a16ff6e9b0","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    OVSDB_REMOTE\u003d\"\""},{"line_number":258,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":259,"context_line":"        EXTRA_DBS\u003d\"ovnsb.db\""},{"line_number":260,"context_line":"        OVSDB_REMOTE\u003d\"--remote\u003dptcp:6640:$HOST_IP\""},{"line_number":261,"context_line":"        OVSDB_NB_REMOTE\u003d\"--remote\u003dptcp:6641:$HOST_IP\""},{"line_number":262,"context_line":"        PID_FILE\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-nb.pid\""},{"line_number":263,"context_line":""}],"source_content_type":"text/x-sh","patch_set":4,"id":"5a5ae5dd_c8ab3d1c","line":260,"in_reply_to":"5a5ae5dd_052700cb","updated":"2016-02-04 19:27:11.000000000","message":"This has always been used by what is now the *second* ovsdb-server, launched at L284 below.  The difference between the two ovsdb-servers are the databases they handle (see Ls 268 and 288)","commit_id":"a0407784d468b1646c2cfdccbc90a00bd454247b"},{"author":{"_account_id":11255,"name":"Dustin Lundquist","username":"dustin.lundquist","inactive":true},"change_message_id":"eea9dd7d7d6334d25b5a6bddab66ccbd9ae52840","unresolved":false,"context_lines":[{"line_number":337,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"        OVNNB_DB\u003d\"unix:/usr/local/var/run/openvswitch/nb_db.sock\""},{"line_number":340,"context_line":"        OVNSB_DB\u003d\"unix:/usr/local/var/run/openvswitch/db.sock\""},{"line_number":341,"context_line":""},{"line_number":342,"context_line":"        run_process ovn-northd \"ovn-northd --ovnnb-db\u003d$OVNNB_DB \\"},{"line_number":343,"context_line":"                                           --ovnsb-db\u003d$OVNSB_DB \\"}],"source_content_type":"text/x-sh","patch_set":4,"id":"5a5ae5dd_9f61023c","line":340,"updated":"2016-02-04 17:53:06.000000000","message":"sb_db.sock?","commit_id":"a0407784d468b1646c2cfdccbc90a00bd454247b"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"5c62970506c1d7afa1100db65f25d2411e4b1883","unresolved":false,"context_lines":[{"line_number":248,"context_line":"    local ovsdb_logfile\u003d\"ovsdb-server.log.${CURRENT_LOG_TIME}\""},{"line_number":249,"context_line":"    bash -c \"cd \u0027$LOGDIR\u0027 \u0026\u0026 touch \u0027$ovsdb_logfile\u0027 \u0026\u0026 ln -sf \u0027$ovsdb_logfile\u0027 ovsdb-server.log\""},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"    local ovsdb_nb_logfile\u003d\"ovsdb-server-nb.log.${CURRENT_LOG_TIME}\""},{"line_number":252,"context_line":"    bash -c \"cd \u0027$LOGDIR\u0027 \u0026\u0026 touch \u0027$ovsdb_nb_logfile\u0027 \u0026\u0026 ln -sf \u0027$ovsdb_nb_logfile\u0027 ovsdb-server-nb.log\""},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"    cd $DATA_DIR/ovs"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_14c17080","line":251,"updated":"2016-02-04 20:53:26.000000000","message":"This should even be moved to that helper function i mentioned.","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ef4362bf15029d8d09a72f9b06f655f6529abb20","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    cd $DATA_DIR/ovs"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    EXTRA_DBS\u003d\"\""},{"line_number":257,"context_line":"    OVSDB_REMOTE\u003d\"\""},{"line_number":258,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":259,"context_line":"        EXTRA_DBS\u003d\"ovnsb.db\""},{"line_number":260,"context_line":"        OVSDB_REMOTE\u003d\"--remote\u003dptcp:6640:$HOST_IP\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_0ea07d8f","line":257,"updated":"2016-02-04 20:06:42.000000000","message":"What port does it listen on when it\u0027s defined like this?","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fa91ab770c75603c0768d6862ab499baab517fbe","unresolved":false,"context_lines":[{"line_number":254,"context_line":"    cd $DATA_DIR/ovs"},{"line_number":255,"context_line":""},{"line_number":256,"context_line":"    EXTRA_DBS\u003d\"\""},{"line_number":257,"context_line":"    OVSDB_REMOTE\u003d\"\""},{"line_number":258,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":259,"context_line":"        EXTRA_DBS\u003d\"ovnsb.db\""},{"line_number":260,"context_line":"        OVSDB_REMOTE\u003d\"--remote\u003dptcp:6640:$HOST_IP\""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_ae94c9e1","line":257,"in_reply_to":"5a5ae5dd_0ea07d8f","updated":"2016-02-04 20:14:15.000000000","message":"It only listens on the unix socket in L285","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ef4362bf15029d8d09a72f9b06f655f6529abb20","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    OVSDB_REMOTE\u003d\"\""},{"line_number":258,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":259,"context_line":"        EXTRA_DBS\u003d\"ovnsb.db\""},{"line_number":260,"context_line":"        OVSDB_REMOTE\u003d\"--remote\u003dptcp:6640:$HOST_IP\""},{"line_number":261,"context_line":"        OVSDB_NB_REMOTE\u003d\"--remote\u003dptcp:6641:$HOST_IP\""},{"line_number":262,"context_line":"        PID_FILE\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-nb.pid\""},{"line_number":263,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_eecba151","line":260,"updated":"2016-02-04 20:06:42.000000000","message":"Why do we need to do this assignment in here? Can\u0027t we just set this value to be constant above?","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"0376b7d4c5c44eab57e566e1ad3be45b605695b2","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    OVSDB_REMOTE\u003d\"\""},{"line_number":258,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":259,"context_line":"        EXTRA_DBS\u003d\"ovnsb.db\""},{"line_number":260,"context_line":"        OVSDB_REMOTE\u003d\"--remote\u003dptcp:6640:$HOST_IP\""},{"line_number":261,"context_line":"        OVSDB_NB_REMOTE\u003d\"--remote\u003dptcp:6641:$HOST_IP\""},{"line_number":262,"context_line":"        PID_FILE\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-nb.pid\""},{"line_number":263,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_8e9f8db3","line":260,"updated":"2016-02-04 20:00:23.000000000","message":"maybe rename to OVSDB_SB_REMOTE","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"5c62970506c1d7afa1100db65f25d2411e4b1883","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    OVSDB_REMOTE\u003d\"\""},{"line_number":258,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":259,"context_line":"        EXTRA_DBS\u003d\"ovnsb.db\""},{"line_number":260,"context_line":"        OVSDB_REMOTE\u003d\"--remote\u003dptcp:6640:$HOST_IP\""},{"line_number":261,"context_line":"        OVSDB_NB_REMOTE\u003d\"--remote\u003dptcp:6641:$HOST_IP\""},{"line_number":262,"context_line":"        PID_FILE\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-nb.pid\""},{"line_number":263,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_7490e443","line":260,"in_reply_to":"5a5ae5dd_8e678d24","updated":"2016-02-04 20:53:26.000000000","message":"Why not call it OVSDB_SB_REMOTE it seems like it is more clear what it\u0027s used for then? \n\n\nI see, In that case we could even create a 3rd ovsdb-sever process here which would be used by the local ovn controller. Right now it looks like we would share that one.","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fa91ab770c75603c0768d6862ab499baab517fbe","unresolved":false,"context_lines":[{"line_number":257,"context_line":"    OVSDB_REMOTE\u003d\"\""},{"line_number":258,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":259,"context_line":"        EXTRA_DBS\u003d\"ovnsb.db\""},{"line_number":260,"context_line":"        OVSDB_REMOTE\u003d\"--remote\u003dptcp:6640:$HOST_IP\""},{"line_number":261,"context_line":"        OVSDB_NB_REMOTE\u003d\"--remote\u003dptcp:6641:$HOST_IP\""},{"line_number":262,"context_line":"        PID_FILE\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-nb.pid\""},{"line_number":263,"context_line":""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_8e678d24","line":260,"in_reply_to":"5a5ae5dd_eecba151","updated":"2016-02-04 20:14:15.000000000","message":"Gal, you are the second to ask for this, so while I\u0027m not a big fan, I\u0027ll do it\n\nAaron, this is necessary for the ovsdb-server process that hosts the OVN SB db be available to ovn-controller processes on other nodes.","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":11343,"name":"Gal Sagie","email":"gal.sagie@gmail.com","username":"GalSagie"},"change_message_id":"0376b7d4c5c44eab57e566e1ad3be45b605695b2","unresolved":false,"context_lines":[{"line_number":258,"context_line":"    if is_ovn_service_enabled ovn-northd ; then"},{"line_number":259,"context_line":"        EXTRA_DBS\u003d\"ovnsb.db\""},{"line_number":260,"context_line":"        OVSDB_REMOTE\u003d\"--remote\u003dptcp:6640:$HOST_IP\""},{"line_number":261,"context_line":"        OVSDB_NB_REMOTE\u003d\"--remote\u003dptcp:6641:$HOST_IP\""},{"line_number":262,"context_line":"        PID_FILE\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-nb.pid\""},{"line_number":263,"context_line":""},{"line_number":264,"context_line":"        ovsdb-server --remote\u003dpunix:/usr/local/var/run/openvswitch/nb_db.sock \\"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_ae6369db","line":261,"updated":"2016-02-04 20:00:23.000000000","message":"We could use here OVN_NB_REMOTE and OVN_SB_REMOTE i believe","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"ef4362bf15029d8d09a72f9b06f655f6529abb20","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    # rather broken.  So, stay with this for now and somebody more tenacious"},{"line_number":282,"context_line":"    # than I can figure out how to make it work..."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    ovsdb-server --remote\u003dpunix:/usr/local/var/run/openvswitch/db.sock \\"},{"line_number":285,"context_line":"                 --remote\u003ddb:Open_vSwitch,Open_vSwitch,manager_options \\"},{"line_number":286,"context_line":"                 --pidfile --detach -vconsole:off \\"},{"line_number":287,"context_line":"                 --log-file\u003d$LOGDIR/ovsdb-server.log $OVSDB_REMOTE \\"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_eef96181","line":284,"updated":"2016-02-04 20:06:42.000000000","message":"we should pull 284 -293 to it\u0027s own function start_ovsdb()","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"5c62970506c1d7afa1100db65f25d2411e4b1883","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    # rather broken.  So, stay with this for now and somebody more tenacious"},{"line_number":282,"context_line":"    # than I can figure out how to make it work..."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    ovsdb-server --remote\u003dpunix:/usr/local/var/run/openvswitch/db.sock \\"},{"line_number":285,"context_line":"                 --remote\u003ddb:Open_vSwitch,Open_vSwitch,manager_options \\"},{"line_number":286,"context_line":"                 --pidfile --detach -vconsole:off \\"},{"line_number":287,"context_line":"                 --log-file\u003d$LOGDIR/ovsdb-server.log $OVSDB_REMOTE \\"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_34b10ce2","line":284,"in_reply_to":"5a5ae5dd_0e74fdcc","updated":"2016-02-04 20:53:26.000000000","message":"If you insist though I think it would be easy to do and would make it easier to understand how this works. Ideally this refactoring could be done before and this patch could be rebased on it.","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"fa91ab770c75603c0768d6862ab499baab517fbe","unresolved":false,"context_lines":[{"line_number":281,"context_line":"    # rather broken.  So, stay with this for now and somebody more tenacious"},{"line_number":282,"context_line":"    # than I can figure out how to make it work..."},{"line_number":283,"context_line":""},{"line_number":284,"context_line":"    ovsdb-server --remote\u003dpunix:/usr/local/var/run/openvswitch/db.sock \\"},{"line_number":285,"context_line":"                 --remote\u003ddb:Open_vSwitch,Open_vSwitch,manager_options \\"},{"line_number":286,"context_line":"                 --pidfile --detach -vconsole:off \\"},{"line_number":287,"context_line":"                 --log-file\u003d$LOGDIR/ovsdb-server.log $OVSDB_REMOTE \\"}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_0e74fdcc","line":284,"in_reply_to":"5a5ae5dd_eef96181","updated":"2016-02-04 20:14:15.000000000","message":"I\u0027d much rather do that in a follow on patch set.","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":11762,"name":"Han Zhou","email":"zhouhan@gmail.com","username":"hanzhou"},"change_message_id":"8bff6320b5ca342c5ec9e0b41484b2089907ed04","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    ovsdb-server --remote\u003dpunix:/usr/local/var/run/openvswitch/db.sock \\"},{"line_number":285,"context_line":"                 --remote\u003ddb:Open_vSwitch,Open_vSwitch,manager_options \\"},{"line_number":286,"context_line":"                 --pidfile --detach -vconsole:off \\"},{"line_number":287,"context_line":"                 --log-file\u003d$LOGDIR/ovsdb-server.log $OVSDB_REMOTE \\"},{"line_number":288,"context_line":"                 conf.db ${EXTRA_DBS}"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    echo -n \"Waiting for ovsdb-server to start ... \""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_8e4ead94","line":287,"updated":"2016-02-04 20:14:41.000000000","message":"So OVSDB_REMOTE means both ovnsb.db and conf.db. In real production they should never be hosted by same ovsdb server. Since this patch is regarding performance, I would suggest to separate these 2, too, to make this devstack environment closer to a real setup.","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"18c8e2221b1b23e7ca8821208d341f17b4fbadbb","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    ovsdb-server --remote\u003dpunix:/usr/local/var/run/openvswitch/db.sock \\"},{"line_number":285,"context_line":"                 --remote\u003ddb:Open_vSwitch,Open_vSwitch,manager_options \\"},{"line_number":286,"context_line":"                 --pidfile --detach -vconsole:off \\"},{"line_number":287,"context_line":"                 --log-file\u003d$LOGDIR/ovsdb-server.log $OVSDB_REMOTE \\"},{"line_number":288,"context_line":"                 conf.db ${EXTRA_DBS}"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    echo -n \"Waiting for ovsdb-server to start ... \""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_ae07e91a","line":287,"in_reply_to":"5a5ae5dd_8e4ead94","updated":"2016-02-04 20:16:20.000000000","message":"I could see that in a follow-on patch set, but I don\u0027t believe we should put that change here","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":11762,"name":"Han Zhou","email":"zhouhan@gmail.com","username":"hanzhou"},"change_message_id":"8f883326f9b7b8aab2a26524909aee33e48e575b","unresolved":false,"context_lines":[{"line_number":284,"context_line":"    ovsdb-server --remote\u003dpunix:/usr/local/var/run/openvswitch/db.sock \\"},{"line_number":285,"context_line":"                 --remote\u003ddb:Open_vSwitch,Open_vSwitch,manager_options \\"},{"line_number":286,"context_line":"                 --pidfile --detach -vconsole:off \\"},{"line_number":287,"context_line":"                 --log-file\u003d$LOGDIR/ovsdb-server.log $OVSDB_REMOTE \\"},{"line_number":288,"context_line":"                 conf.db ${EXTRA_DBS}"},{"line_number":289,"context_line":""},{"line_number":290,"context_line":"    echo -n \"Waiting for ovsdb-server to start ... \""}],"source_content_type":"text/x-sh","patch_set":5,"id":"5a5ae5dd_592401ae","line":287,"in_reply_to":"5a5ae5dd_ae07e91a","updated":"2016-02-04 20:18:33.000000000","message":"Agree","commit_id":"4198bf2607213ff6b82aaefb57e74d5d0c39b91f"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"4c2b52e691b62d3cf7db562c84011e38003e9a50","unresolved":false,"context_lines":[{"line_number":56,"context_line":"OVN_SB_REMOTE\u003d${OVN_SB_REMOTE:-tcp:$HOST_IP:6640}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# How to connect to ovsdb-server hosting the OVN NB database"},{"line_number":59,"context_line":"OVN_NB_REMOTE\u003d${OVN_NB_REMOTE:-tcp:$HOST_IP:6641}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# A UUID to uniquely identify this system.  If one is not specified, a random"},{"line_number":62,"context_line":"# one will be generated.  A randomly generated UUID will be saved in a file"}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa0719c6_c53747fd","line":59,"updated":"2016-03-24 00:14:32.000000000","message":"Don\u0027t these need to be 6641 and 6642?","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"78b9a2b54df74749e305d46e9ed8d1a1b546c940","unresolved":false,"context_lines":[{"line_number":56,"context_line":"OVN_SB_REMOTE\u003d${OVN_SB_REMOTE:-tcp:$HOST_IP:6640}"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"# How to connect to ovsdb-server hosting the OVN NB database"},{"line_number":59,"context_line":"OVN_NB_REMOTE\u003d${OVN_NB_REMOTE:-tcp:$HOST_IP:6641}"},{"line_number":60,"context_line":""},{"line_number":61,"context_line":"# A UUID to uniquely identify this system.  If one is not specified, a random"},{"line_number":62,"context_line":"# one will be generated.  A randomly generated UUID will be saved in a file"}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa0719c6_1bfebfad","line":59,"in_reply_to":"fa0719c6_c53747fd","updated":"2016-03-24 03:12:05.000000000","message":"same comment as previously ...","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"8515a50925ee6dce9a416346c610215f0e76018b","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        DB_NB_FILE\u003d\"$DATA_DIR/ovs/ovnnb.db\""},{"line_number":251,"context_line":"        OVN_NB_LOGFILE\u003d\"$LOGDIR/ovsdb-server-nb.log\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        DB_SB_PORT\u003d\"6640:$HOST_IP\""},{"line_number":254,"context_line":"        DB_SB_SOCK\u003d\"/usr/local/var/run/openvswitch/sb_db.sock\""},{"line_number":255,"context_line":"        DB_SB_PID\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-sb.pid\""},{"line_number":256,"context_line":"        DB_SB_FILE\u003d\"$DATA_DIR/ovs/ovnsb.db\""}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa0719c6_c0057511","line":253,"updated":"2016-03-24 00:23:42.000000000","message":"This defaults to 6642 in ovn-ctl, so how about we just use that?\n\nIt\u0027s also really weird to be passing a port and IP address to an argument called \"db-sb-port\".","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"78b9a2b54df74749e305d46e9ed8d1a1b546c940","unresolved":false,"context_lines":[{"line_number":250,"context_line":"        DB_NB_FILE\u003d\"$DATA_DIR/ovs/ovnnb.db\""},{"line_number":251,"context_line":"        OVN_NB_LOGFILE\u003d\"$LOGDIR/ovsdb-server-nb.log\""},{"line_number":252,"context_line":""},{"line_number":253,"context_line":"        DB_SB_PORT\u003d\"6640:$HOST_IP\""},{"line_number":254,"context_line":"        DB_SB_SOCK\u003d\"/usr/local/var/run/openvswitch/sb_db.sock\""},{"line_number":255,"context_line":"        DB_SB_PID\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-sb.pid\""},{"line_number":256,"context_line":"        DB_SB_FILE\u003d\"$DATA_DIR/ovs/ovnsb.db\""}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa0719c6_5bc03750","line":253,"in_reply_to":"fa0719c6_c0057511","updated":"2016-03-24 03:12:05.000000000","message":"I agree, so I\u0027m going to mark it as a todo here so we don\u0027t forget to have a followup patch","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"8515a50925ee6dce9a416346c610215f0e76018b","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                     --remote\u003ddb:Open_vSwitch,Open_vSwitch,manager_options \\"},{"line_number":283,"context_line":"                     --pidfile --detach -vconsole:off \\"},{"line_number":284,"context_line":"                     --log-file\u003d$LOGDIR/ovsdb-server.log \\"},{"line_number":285,"context_line":"                     --remote\u003dtcp:$DB_SB_PORT \\"},{"line_number":286,"context_line":"                     conf.db"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        echo -n \"Waiting for ovsdb-server to start ... \""}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa0719c6_e027d9b3","line":285,"updated":"2016-03-24 00:23:42.000000000","message":"This shouldn\u0027t be using the same port as the southbound database.  This is the local Open_vSwitch database, not an OVN database.  I actually don\u0027t think it needs a TCP remote at all, so I tihnk --remote can be removed.","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"78b9a2b54df74749e305d46e9ed8d1a1b546c940","unresolved":false,"context_lines":[{"line_number":282,"context_line":"                     --remote\u003ddb:Open_vSwitch,Open_vSwitch,manager_options \\"},{"line_number":283,"context_line":"                     --pidfile --detach -vconsole:off \\"},{"line_number":284,"context_line":"                     --log-file\u003d$LOGDIR/ovsdb-server.log \\"},{"line_number":285,"context_line":"                     --remote\u003dtcp:$DB_SB_PORT \\"},{"line_number":286,"context_line":"                     conf.db"},{"line_number":287,"context_line":""},{"line_number":288,"context_line":"        echo -n \"Waiting for ovsdb-server to start ... \""}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa0719c6_3bc8e373","line":285,"in_reply_to":"fa0719c6_e027d9b3","updated":"2016-03-24 03:12:05.000000000","message":"Done","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"8515a50925ee6dce9a416346c610215f0e76018b","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        DB_NB_SOCK\u003d\"/usr/local/var/run/openvswitch/nb_db.sock\""},{"line_number":339,"context_line":"        DB_SB_PID\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-sb.pid\""},{"line_number":340,"context_line":"        DB_SB_SOCK\u003d\"/usr/local/var/run/openvswitch/sb_db.sock\""},{"line_number":341,"context_line":"        OVN_NORTHD_LOG\u003d\"--log-file\u003d$LOGDIR/ovn-northd.log\""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        NORTHD_CMD\u003d /usr/local/share/openvswitch/scripts/ovn-ctl start_northd \\"},{"line_number":344,"context_line":"            --db-nb-sock\u003d$DB_NB_SOCK --db-sb-sock\u003d$DB_SB_SOCK \\"}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa0719c6_005acd29","line":341,"updated":"2016-03-24 00:23:42.000000000","message":"This is weird.  I\u0027d like to clean this up.  Instead of:\n\n   --ovn-northd-log\u003d--log-file\u003d$LOGDIR/ovn-northd.log\n\nI\u0027d rather have:\n\n   --ovn-northd-log\u003d$LOGDIR/ovn-northd.log","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"78b9a2b54df74749e305d46e9ed8d1a1b546c940","unresolved":false,"context_lines":[{"line_number":338,"context_line":"        DB_NB_SOCK\u003d\"/usr/local/var/run/openvswitch/nb_db.sock\""},{"line_number":339,"context_line":"        DB_SB_PID\u003d\"/usr/local/var/run/openvswitch/ovsdb-server-sb.pid\""},{"line_number":340,"context_line":"        DB_SB_SOCK\u003d\"/usr/local/var/run/openvswitch/sb_db.sock\""},{"line_number":341,"context_line":"        OVN_NORTHD_LOG\u003d\"--log-file\u003d$LOGDIR/ovn-northd.log\""},{"line_number":342,"context_line":""},{"line_number":343,"context_line":"        NORTHD_CMD\u003d /usr/local/share/openvswitch/scripts/ovn-ctl start_northd \\"},{"line_number":344,"context_line":"            --db-nb-sock\u003d$DB_NB_SOCK --db-sb-sock\u003d$DB_SB_SOCK \\"}],"source_content_type":"text/x-sh","patch_set":16,"id":"fa0719c6_9badaf9d","line":341,"in_reply_to":"fa0719c6_005acd29","updated":"2016-03-24 03:12:05.000000000","message":"I\u0027m going to mark this as a todo so that we remember to have a follow on patch","commit_id":"349e45f695e7fead12bdf0ffe67afa932d5714c2"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"24baf7247ba4e02358191683ee927a47682a66cb","unresolved":false,"context_lines":[{"line_number":50,"context_line":""},{"line_number":51,"context_line":"# The branch to use from $OVN_REPO"},{"line_number":52,"context_line":"#OVN_BRANCH\u003d${OVN_BRANCH:-origin/master}"},{"line_number":53,"context_line":"OVN_BRANCH\u003d${OVN_BRANCH:-origin/separation}"},{"line_number":54,"context_line":""},{"line_number":55,"context_line":"# How to connect to ovsdb-server hosting the OVN SB database."},{"line_number":56,"context_line":"OVN_SB_REMOTE\u003d${OVN_SB_REMOTE:-tcp:$HOST_IP:6642}"}],"source_content_type":"text/x-sh","patch_set":17,"id":"fa0719c6_27db8f1c","line":53,"updated":"2016-03-24 12:38:37.000000000","message":"It looks like you still need to change the repo/branch back to upstream master","commit_id":"391772c3fa5f8c783f7fe5633487948bb73a87f3"}],"vagrant/provisioning/setup-compute.sh":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"81c29fc90e5017d5bc3ae849ad25b56533c15135","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Q_HOST\u003d$1"},{"line_number":23,"context_line":"HOSTNAME\u003d$(hostname)"},{"line_number":24,"context_line":"OVN_REMOTE\u003dtcp:$ovnip:6640"},{"line_number":25,"context_line":"OVN_NB_REMOTE\u003dtcp:$ovnip:6641"},{"line_number":26,"context_line":"enable_service q-dhcp q-meta"},{"line_number":27,"context_line":"DEVSTACKEOF"},{"line_number":28,"context_line":""}],"source_content_type":"text/x-sh","patch_set":3,"id":"5a5ae5dd_5f7dca6c","line":25,"updated":"2016-02-04 17:39:11.000000000","message":"This is fine because:\n\n#1: The freshly split-out SB and NB DBs run on the same Vagrant box.\n#2: This is used for executing \"ovn-nbctl\" from compute nodes.","commit_id":"a666bce27ace5728ff8164209e45e22b87b9d666"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"d86fbb3f0c8b3c8061721adfbf9be1447c056a63","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# OpenStack services."},{"line_number":22,"context_line":"Q_HOST\u003d$1"},{"line_number":23,"context_line":"HOSTNAME\u003d$(hostname)"},{"line_number":24,"context_line":"OVN_REMOTE\u003dtcp:$ovnip:6640"},{"line_number":25,"context_line":"enable_service q-dhcp q-meta"},{"line_number":26,"context_line":"DEVSTACKEOF"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5a5ae5dd_5902c170","side":"PARENT","line":24,"updated":"2016-02-04 20:31:49.000000000","message":"OVN_SB_REMOTE and not OVN_REMOTE.","commit_id":"13b2ad811dec63e57474cf65e81258eb77fd4002"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"e4c0e98ef00fb3a568073a7462ba529e81f39247","unresolved":false,"context_lines":[{"line_number":21,"context_line":"# OpenStack services."},{"line_number":22,"context_line":"Q_HOST\u003d$1"},{"line_number":23,"context_line":"HOSTNAME\u003d$(hostname)"},{"line_number":24,"context_line":"OVN_REMOTE\u003dtcp:$ovnip:6640"},{"line_number":25,"context_line":"enable_service q-dhcp q-meta"},{"line_number":26,"context_line":"DEVSTACKEOF"},{"line_number":27,"context_line":""}],"source_content_type":"text/x-sh","patch_set":6,"id":"5a5ae5dd_19d8c9ee","side":"PARENT","line":24,"in_reply_to":"5a5ae5dd_5902c170","updated":"2016-02-04 20:37:04.000000000","message":"/me smacks forehead\n\nDone","commit_id":"13b2ad811dec63e57474cf65e81258eb77fd4002"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"d86fbb3f0c8b3c8061721adfbf9be1447c056a63","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Set the OVN_*_DB variables to enable OVN commands using a remote database."},{"line_number":46,"context_line":"echo -e \"\\n# Enable OVN commands using a remote database."},{"line_number":47,"context_line":"export OVN_NB_DB\u003d$OVN_REMOTE"},{"line_number":48,"context_line":"export OVN_SB_DB\u003d$OVN_REMOTE\" \u003e\u003e ~/.bash_profile"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5a5ae5dd_3936e552","side":"PARENT","line":48,"updated":"2016-02-04 20:31:49.000000000","message":"OVN_SB_REMOTE and not OVN_REMOTE.","commit_id":"13b2ad811dec63e57474cf65e81258eb77fd4002"},{"author":{"_account_id":11682,"name":"Ryan Moats","email":"rmoats@us.ibm.com","username":"regXboi"},"change_message_id":"e4c0e98ef00fb3a568073a7462ba529e81f39247","unresolved":false,"context_lines":[{"line_number":45,"context_line":"# Set the OVN_*_DB variables to enable OVN commands using a remote database."},{"line_number":46,"context_line":"echo -e \"\\n# Enable OVN commands using a remote database."},{"line_number":47,"context_line":"export OVN_NB_DB\u003d$OVN_REMOTE"},{"line_number":48,"context_line":"export OVN_SB_DB\u003d$OVN_REMOTE\" \u003e\u003e ~/.bash_profile"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5a5ae5dd_d9e1d19b","side":"PARENT","line":48,"in_reply_to":"5a5ae5dd_3936e552","updated":"2016-02-04 20:37:04.000000000","message":"Ditto","commit_id":"13b2ad811dec63e57474cf65e81258eb77fd4002"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f8a0119787da3965810a429c8f3f58bac499d1eb","unresolved":false,"context_lines":[{"line_number":24,"context_line":"# OpenStack services."},{"line_number":25,"context_line":"Q_HOST\u003d$1"},{"line_number":26,"context_line":"HOSTNAME\u003d$(hostname)"},{"line_number":27,"context_line":"OVN_SB_REMOTE\u003dtcp:$ovnip:6640"},{"line_number":28,"context_line":"OVN_NB_REMOTE\u003dtcp:$ovnip:6641"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"# Enable logging to files."}],"source_content_type":"text/x-sh","patch_set":19,"id":"fa0719c6_5d77769f","line":27,"updated":"2016-03-24 13:05:39.000000000","message":"Should this be port 6642 to match the non-vagrant deployment?","commit_id":"4ceea5ac7747bb83cceac3a6d5bb165eb2bbfff1"}],"vagrant/provisioning/setup-controller.sh":[{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"d86fbb3f0c8b3c8061721adfbf9be1447c056a63","unresolved":false,"context_lines":[{"line_number":22,"context_line":"HOSTNAME\u003d$(hostname)"},{"line_number":23,"context_line":"SERVICE_HOST_NAME\u003d${HOST_NAME}"},{"line_number":24,"context_line":"SERVICE_HOST\u003d$ipaddress"},{"line_number":25,"context_line":"OVN_REMOTE\u003dtcp:$ovnip:6640"},{"line_number":26,"context_line":"disable_service ovn-northd"},{"line_number":27,"context_line":"disable_service c-api c-sch c-vol n-cpu q-dhcp q-meta tempest"},{"line_number":28,"context_line":"DEVSTACKEOF"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5a5ae5dd_f9f92d81","side":"PARENT","line":25,"updated":"2016-02-04 20:31:49.000000000","message":"OVN_SB_REMOTE and not OVN_REMOTE.","commit_id":"13b2ad811dec63e57474cf65e81258eb77fd4002"},{"author":{"_account_id":105,"name":"Kyle Mestery","email":"mestery@mestery.com","username":"mestery"},"change_message_id":"d86fbb3f0c8b3c8061721adfbf9be1447c056a63","unresolved":false,"context_lines":[{"line_number":77,"context_line":"# Set the OVN_*_DB variables to enable OVN commands using a remote database."},{"line_number":78,"context_line":"echo -e \"\\n# Enable OVN commands using a remote database."},{"line_number":79,"context_line":"export OVN_NB_DB\u003d$OVN_REMOTE"},{"line_number":80,"context_line":"export OVN_SB_DB\u003d$OVN_REMOTE\" \u003e\u003e ~/.bash_profile"}],"source_content_type":"text/x-sh","patch_set":6,"id":"5a5ae5dd_992fd9f5","side":"PARENT","line":80,"updated":"2016-02-04 20:31:49.000000000","message":"OVN_SB_REMOTE and not OVN_REMOTE.","commit_id":"13b2ad811dec63e57474cf65e81258eb77fd4002"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f8a0119787da3965810a429c8f3f58bac499d1eb","unresolved":false,"context_lines":[{"line_number":27,"context_line":"HOSTNAME\u003d$(hostname)"},{"line_number":28,"context_line":"SERVICE_HOST_NAME\u003d${HOST_NAME}"},{"line_number":29,"context_line":"SERVICE_HOST\u003d$ipaddress"},{"line_number":30,"context_line":"OVN_SB_REMOTE\u003dtcp:$ovnip:6640"},{"line_number":31,"context_line":"OVN_NB_REMOTE\u003dtcp:$ovnip:6641"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"# Enable logging to files."}],"source_content_type":"text/x-sh","patch_set":19,"id":"fa0719c6_7d707aa4","line":30,"updated":"2016-03-24 13:05:39.000000000","message":"Should this be port 6642 to match the non-vagrant deployment?","commit_id":"4ceea5ac7747bb83cceac3a6d5bb165eb2bbfff1"}]}