)]}'
{"networking_ovn/plugin.py":[{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a3a2218cfd77b444acb2ca2a960f1b097d7b604e","unresolved":false,"context_lines":[{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def check_and_set_lswitch_dhcp_options(self, subnet):"},{"line_number":534,"context_line":"        if subnet[\u0027ip_version\u0027] !\u003d 4 or not subnet[\u0027enable_dhcp\u0027] or not ("},{"line_number":535,"context_line":"                subnet[\u0027gateway_ip\u0027]):"},{"line_number":536,"context_line":"            return"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        netmask \u003d str(netaddr.IPNetwork(subnet[\u0027cidr\u0027]).netmask)"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_a547afba","line":535,"updated":"2016-04-14 22:22:37.000000000","message":"I guess the reason why you check and not subnet[\u0027gateway_ip\u0027] is because the dhcp built into ovn works through the gateway interface?","commit_id":"b193d844b03b719db43f1a413c8ea091c90511ba"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"6eae9b1c62f2b511b4be14516a16714511ca9283","unresolved":false,"context_lines":[{"line_number":532,"context_line":""},{"line_number":533,"context_line":"    def check_and_set_lswitch_dhcp_options(self, subnet):"},{"line_number":534,"context_line":"        if subnet[\u0027ip_version\u0027] !\u003d 4 or not subnet[\u0027enable_dhcp\u0027] or not ("},{"line_number":535,"context_line":"                subnet[\u0027gateway_ip\u0027]):"},{"line_number":536,"context_line":"            return"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        netmask \u003d str(netaddr.IPNetwork(subnet[\u0027cidr\u0027]).netmask)"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_3f3ec2b8","line":535,"in_reply_to":"5a18252c_a547afba","updated":"2016-04-15 12:49:41.000000000","message":"I am not sure if I understood your comment correctly. In order for ovn to respond to the dhcp request from vm, it needs atleast dhcp option 3 (default gateway) and option 1 (subnet mask).\n\nHence returning if default gateway is not set for the subnet.","commit_id":"b193d844b03b719db43f1a413c8ea091c90511ba"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"a3a2218cfd77b444acb2ca2a960f1b097d7b604e","unresolved":false,"context_lines":[{"line_number":536,"context_line":"            return"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        netmask \u003d str(netaddr.IPNetwork(subnet[\u0027cidr\u0027]).netmask)"},{"line_number":539,"context_line":"        default_lease_time \u003d \"43200\"  # in seconds - 12 hours"},{"line_number":540,"context_line":"        mtu \u003d cfg.CONF.global_physnet_mtu - 58"},{"line_number":541,"context_line":"        subnet_dhcp_options \u003d {\"server_id\": subnet[\u0027gateway_ip\u0027],"},{"line_number":542,"context_line":"                               \"server_mac\": self._generate_mac(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5a18252c_05a2e34a","line":539,"updated":"2016-04-14 22:22:37.000000000","message":"I think people might want to configure this. We could maybe even re-use this existing neutron config option for this here: \n\nhttps://github.com/openstack/neutron/blob/master/neutron/agent/dhcp/config.py#L97","commit_id":"b193d844b03b719db43f1a413c8ea091c90511ba"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"6eae9b1c62f2b511b4be14516a16714511ca9283","unresolved":false,"context_lines":[{"line_number":536,"context_line":"            return"},{"line_number":537,"context_line":""},{"line_number":538,"context_line":"        netmask \u003d str(netaddr.IPNetwork(subnet[\u0027cidr\u0027]).netmask)"},{"line_number":539,"context_line":"        default_lease_time \u003d \"43200\"  # in seconds - 12 hours"},{"line_number":540,"context_line":"        mtu \u003d cfg.CONF.global_physnet_mtu - 58"},{"line_number":541,"context_line":"        subnet_dhcp_options \u003d {\"server_id\": subnet[\u0027gateway_ip\u0027],"},{"line_number":542,"context_line":"                               \"server_mac\": self._generate_mac(),"}],"source_content_type":"text/x-python","patch_set":2,"id":"1a122d0e_5f68deba","line":539,"in_reply_to":"5a18252c_05a2e34a","updated":"2016-04-15 12:49:41.000000000","message":"thanks for pointing this. Sure","commit_id":"b193d844b03b719db43f1a413c8ea091c90511ba"}]}