)]}'
{"networking_ovn/ml2/mech_driver.py":[{"author":{"_account_id":9970,"name":"John Kasperski","email":"jckasper@linux.vnet.ibm.com","username":"jckasper"},"change_message_id":"e478e4b183a92e3658596b23fd22eeaa0700e8a6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _admin_context(self):"},{"line_number":91,"context_line":"        if self._admin_context_property is None:"},{"line_number":92,"context_line":"            self._admin_context_property \u003d n_context.get_admin_context()"},{"line_number":93,"context_line":"        return self._admin_context_property"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @property"},{"line_number":96,"context_line":"    def _plugin(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_4e3bc89c","side":"PARENT","line":93,"updated":"2016-05-19 15:19:31.000000000","message":"Alternatively you could have kept this method and just removed the caching.","commit_id":"11707bdac8f9bec4b0ab6d977d23bf841079dc80"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6ef24ffab0e531c35a0e3c77f338ca1fb4b56481","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _admin_context(self):"},{"line_number":91,"context_line":"        if self._admin_context_property is None:"},{"line_number":92,"context_line":"            self._admin_context_property \u003d n_context.get_admin_context()"},{"line_number":93,"context_line":"        return self._admin_context_property"},{"line_number":94,"context_line":""},{"line_number":95,"context_line":"    @property"},{"line_number":96,"context_line":"    def _plugin(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_a59fe64e","side":"PARENT","line":93,"in_reply_to":"bab6814e_4e3bc89c","updated":"2016-05-19 18:57:10.000000000","message":"I thought about doing that but wanted to avoid getting the context too often.","commit_id":"11707bdac8f9bec4b0ab6d977d23bf841079dc80"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b8e9c6a6ec088ce54622b5903c8817010362c73c","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                              need_compare\u003dneed_compare,"},{"line_number":670,"context_line":"                              is_add_acl\u003dis_add_acl).execute(check_error\u003dTrue)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def create_port_in_ovn(self, port, ovn_port_info):"},{"line_number":673,"context_line":"        external_ids \u003d {ovn_const.OVN_PORT_NAME_EXT_ID_KEY: port[\u0027name\u0027]}"},{"line_number":674,"context_line":"        lswitch_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":675,"context_line":"        admin_context \u003d n_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_e0727948","line":672,"updated":"2016-05-19 20:11:35.000000000","message":"We should also restructure this code so that all the actual calculation which requires querying the neutron database is done outside of this method within the transaction that creates the neutron port. This would allow us to now have to use the database or deal with transactions once we get into the create_port_in_ovn. I know this would be a lot of work and restructuring to achieve though thou.","commit_id":"2f2141559519e956331b897ee8ffa88757a4eafe"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b3eeaa887935e0010057f26404e1ec1ce5ff28b4","unresolved":false,"context_lines":[{"line_number":669,"context_line":"                              need_compare\u003dneed_compare,"},{"line_number":670,"context_line":"                              is_add_acl\u003dis_add_acl).execute(check_error\u003dTrue)"},{"line_number":671,"context_line":""},{"line_number":672,"context_line":"    def create_port_in_ovn(self, port, ovn_port_info):"},{"line_number":673,"context_line":"        external_ids \u003d {ovn_const.OVN_PORT_NAME_EXT_ID_KEY: port[\u0027name\u0027]}"},{"line_number":674,"context_line":"        lswitch_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":675,"context_line":"        admin_context \u003d n_context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_76d2cfd3","line":672,"in_reply_to":"bab6814e_e0727948","updated":"2016-05-19 20:55:48.000000000","message":"Hi Aaron, I\u0027m not sure I understand how to restructure.  Can you please provide more detail or an example?  Also, would you like this done in this patch set or a follow-on?","commit_id":"2f2141559519e956331b897ee8ffa88757a4eafe"},{"author":{"_account_id":4395,"name":"Aaron Rosen","email":"aaronorosen@gmail.com","username":"arosen"},"change_message_id":"b8e9c6a6ec088ce54622b5903c8817010362c73c","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    def create_port_in_ovn(self, port, ovn_port_info):"},{"line_number":673,"context_line":"        external_ids \u003d {ovn_const.OVN_PORT_NAME_EXT_ID_KEY: port[\u0027name\u0027]}"},{"line_number":674,"context_line":"        lswitch_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":675,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":676,"context_line":"        sg_cache \u003d {}"},{"line_number":677,"context_line":"        sg_ports_cache \u003d {}"},{"line_number":678,"context_line":"        subnet_cache \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_c021354f","line":675,"updated":"2016-05-19 20:11:35.000000000","message":"Rather than doing this here and then passing it around I think it would be better to do this in _add_acls directly so we don\u0027t need to pass this around as a param into _add_acls.","commit_id":"2f2141559519e956331b897ee8ffa88757a4eafe"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"0068f81bda9c8d632fdf7d9d3f49dbca9e67f624","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    def create_port_in_ovn(self, port, ovn_port_info):"},{"line_number":673,"context_line":"        external_ids \u003d {ovn_const.OVN_PORT_NAME_EXT_ID_KEY: port[\u0027name\u0027]}"},{"line_number":674,"context_line":"        lswitch_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":675,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":676,"context_line":"        sg_cache \u003d {}"},{"line_number":677,"context_line":"        sg_ports_cache \u003d {}"},{"line_number":678,"context_line":"        subnet_cache \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_72e0e996","line":675,"in_reply_to":"bab6814e_c021354f","updated":"2016-05-20 17:20:54.000000000","message":"Hi Aaron, when I went to implement the change, I realized that the context is also used by _refresh_remote_security_group() both here and in update_port_in_ovn().  Also, context is a parameter on _add_acls() for the core plugin too.  Would you still like me to change this for both _add_acls() and _refresh_remote_security_group()?","commit_id":"2f2141559519e956331b897ee8ffa88757a4eafe"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"b3eeaa887935e0010057f26404e1ec1ce5ff28b4","unresolved":false,"context_lines":[{"line_number":672,"context_line":"    def create_port_in_ovn(self, port, ovn_port_info):"},{"line_number":673,"context_line":"        external_ids \u003d {ovn_const.OVN_PORT_NAME_EXT_ID_KEY: port[\u0027name\u0027]}"},{"line_number":674,"context_line":"        lswitch_name \u003d utils.ovn_name(port[\u0027network_id\u0027])"},{"line_number":675,"context_line":"        admin_context \u003d n_context.get_admin_context()"},{"line_number":676,"context_line":"        sg_cache \u003d {}"},{"line_number":677,"context_line":"        sg_ports_cache \u003d {}"},{"line_number":678,"context_line":"        subnet_cache \u003d {}"}],"source_content_type":"text/x-python","patch_set":1,"id":"bab6814e_d6e1fb9b","line":675,"in_reply_to":"bab6814e_c021354f","updated":"2016-05-19 20:55:48.000000000","message":"Will do","commit_id":"2f2141559519e956331b897ee8ffa88757a4eafe"}]}