)]}'
{"networking_ovn/tests/functional/base.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5edbe2ed554570c8a215d1aec244564cac8f3280","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    Must be used with TestOVNFunctionalBase."},{"line_number":200,"context_line":"    \"\"\""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def add_fake_chassis(self, host, physical_nets\u003dNone):"},{"line_number":203,"context_line":"        physical_nets \u003d physical_nets or []"},{"line_number":204,"context_line":"        fake_api \u003d mock.MagicMock()"},{"line_number":205,"context_line":"        fake_api.idl \u003d self.monitor_sb_db_idl"},{"line_number":206,"context_line":"        fake_api._tables \u003d self.monitor_sb_db_idl.tables"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        bridge_mapping \u003d \",\".join([\"%s:br-provider%s\" % (phys_net, i)"},{"line_number":209,"context_line":"                                  for i, phys_net in enumerate(physical_nets)])"},{"line_number":210,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":211,"context_line":"        with self.sb_idl_transaction(fake_api, check_error\u003dTrue) as txn:"},{"line_number":212,"context_line":"            external_ids \u003d {\u0027ovn-bridge-mappings\u0027: bridge_mapping}"},{"line_number":213,"context_line":"            txn.add(AddFakeChassisCommand(fake_api, name, \"172.24.4.10\","},{"line_number":214,"context_line":"                                          external_ids\u003dexternal_ids,"},{"line_number":215,"context_line":"                                          hostname\u003dhost))"},{"line_number":216,"context_line":"        return name"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_25cfc5b4","line":216,"range":{"start_line":202,"start_character":0,"end_line":216,"end_character":19},"updated":"2016-08-19 10:07:12.000000000","message":"I would prefer this method to be added to the functional test base class.","commit_id":"e1896b2b8e59432051e48814df20143213f4b8ea"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"7017d696419bd3c198269dbe5131bb648cf9a4ed","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    Must be used with TestOVNFunctionalBase."},{"line_number":200,"context_line":"    \"\"\""},{"line_number":201,"context_line":""},{"line_number":202,"context_line":"    def add_fake_chassis(self, host, physical_nets\u003dNone):"},{"line_number":203,"context_line":"        physical_nets \u003d physical_nets or []"},{"line_number":204,"context_line":"        fake_api \u003d mock.MagicMock()"},{"line_number":205,"context_line":"        fake_api.idl \u003d self.monitor_sb_db_idl"},{"line_number":206,"context_line":"        fake_api._tables \u003d self.monitor_sb_db_idl.tables"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"        bridge_mapping \u003d \",\".join([\"%s:br-provider%s\" % (phys_net, i)"},{"line_number":209,"context_line":"                                  for i, phys_net in enumerate(physical_nets)])"},{"line_number":210,"context_line":"        name \u003d uuid.uuid4().hex"},{"line_number":211,"context_line":"        with self.sb_idl_transaction(fake_api, check_error\u003dTrue) as txn:"},{"line_number":212,"context_line":"            external_ids \u003d {\u0027ovn-bridge-mappings\u0027: bridge_mapping}"},{"line_number":213,"context_line":"            txn.add(AddFakeChassisCommand(fake_api, name, \"172.24.4.10\","},{"line_number":214,"context_line":"                                          external_ids\u003dexternal_ids,"},{"line_number":215,"context_line":"                                          hostname\u003dhost))"},{"line_number":216,"context_line":"        return name"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_2ed95922","line":216,"range":{"start_line":202,"start_character":0,"end_line":216,"end_character":19},"in_reply_to":"3ac371cc_25cfc5b4","updated":"2016-08-20 11:47:47.000000000","message":"Done","commit_id":"e1896b2b8e59432051e48814df20143213f4b8ea"}],"networking_ovn/tests/functional/test_ovn_db_sync.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"92cc53789327325774148dd257aef386d9545770","unresolved":false,"context_lines":[{"line_number":436,"context_line":"class TestOvnSbSync(base.TestOVNSbFunctionalMixin, base.TestOVNFunctionalBase):"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def setUp(self):"},{"line_number":439,"context_line":"        super(TestOvnSbSync, self).setUp(ovn_worker\u003dTrue)"},{"line_number":440,"context_line":"        # Explicitly unwatch the Chassis event, so that the synchronizer will"},{"line_number":441,"context_line":"        # be the only path to update SegmentHostMapping"},{"line_number":442,"context_line":"        self.mech_driver._sb_ovn.idl.notify_handler.unwatch_event("}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_8e956d88","line":439,"updated":"2016-08-11 05:15:34.000000000","message":"It\u0027s better you pass ovn_worker\u003dFalse so that you don\u0027t have to unwatch the chassis event below.\n\nIf you pass ovn_worker\u003dTrue, the post_fork_initialize in OVN driver will also call sync.","commit_id":"46a03b6a29ba4085a06bc5573df9560747a7b3b4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"b582dd712bd9356df4d340e0781f21b055684a0c","unresolved":false,"context_lines":[{"line_number":436,"context_line":"class TestOvnSbSync(base.TestOVNSbFunctionalMixin, base.TestOVNFunctionalBase):"},{"line_number":437,"context_line":""},{"line_number":438,"context_line":"    def setUp(self):"},{"line_number":439,"context_line":"        super(TestOvnSbSync, self).setUp(ovn_worker\u003dTrue)"},{"line_number":440,"context_line":"        # Explicitly unwatch the Chassis event, so that the synchronizer will"},{"line_number":441,"context_line":"        # be the only path to update SegmentHostMapping"},{"line_number":442,"context_line":"        self.mech_driver._sb_ovn.idl.notify_handler.unwatch_event("}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_55f536c9","line":439,"in_reply_to":"9ad45d7e_8e956d88","updated":"2016-08-16 00:07:49.000000000","message":"Thanks and done.","commit_id":"46a03b6a29ba4085a06bc5573df9560747a7b3b4"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"92cc53789327325774148dd257aef386d9545770","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        return self.segments_plugin.create_segment("},{"line_number":458,"context_line":"            self.ctx, segment\u003d{\u0027segment\u0027: segment_data})"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def test_ovn_sb_sync_add_new_host(self):"},{"line_number":461,"context_line":"        with self.network() as network:"},{"line_number":462,"context_line":"            network_id \u003d network[\u0027network\u0027][\u0027id\u0027]"},{"line_number":463,"context_line":"        self.create_segment(network_id, \u0027physnet1\u0027, 50)"}],"source_content_type":"text/x-python","patch_set":4,"id":"9ad45d7e_8ef8cdc4","line":460,"updated":"2016-08-11 05:15:34.000000000","message":"These test cases are testing the individual paths of the function \"sb_synchronizer.sync_hostname_and_physical_networks\", I think it will be good to also have one test case which tests  all the three scenarios i.e stale host, new host and host found in both sb db and neutron.","commit_id":"46a03b6a29ba4085a06bc5573df9560747a7b3b4"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"b582dd712bd9356df4d340e0781f21b055684a0c","unresolved":false,"context_lines":[{"line_number":457,"context_line":"        return self.segments_plugin.create_segment("},{"line_number":458,"context_line":"            self.ctx, segment\u003d{\u0027segment\u0027: segment_data})"},{"line_number":459,"context_line":""},{"line_number":460,"context_line":"    def test_ovn_sb_sync_add_new_host(self):"},{"line_number":461,"context_line":"        with self.network() as network:"},{"line_number":462,"context_line":"            network_id \u003d network[\u0027network\u0027][\u0027id\u0027]"},{"line_number":463,"context_line":"        self.create_segment(network_id, \u0027physnet1\u0027, 50)"}],"source_content_type":"text/x-python","patch_set":4,"id":"3ac371cc_d52f663c","line":460,"in_reply_to":"9ad45d7e_8ef8cdc4","updated":"2016-08-16 00:07:49.000000000","message":"I will add one in next PS","commit_id":"46a03b6a29ba4085a06bc5573df9560747a7b3b4"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5edbe2ed554570c8a215d1aec244564cac8f3280","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    def setUp(self):"},{"line_number":491,"context_line":"        super(TestOvnSbSync, self).setUp(ovn_worker\u003dFalse)"},{"line_number":492,"context_line":"        self.segments_plugin \u003d segments_plugin.Plugin()"},{"line_number":493,"context_line":"        self.sb_synchronizer \u003d ovn_db_sync.OvnSbSynchronizer("},{"line_number":494,"context_line":"            self.plugin, self.mech_driver._sb_ovn, self.mech_driver)"},{"line_number":495,"context_line":"        self.ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":6,"id":"3ac371cc_a553b56b","line":492,"range":{"start_line":492,"start_character":9,"end_line":492,"end_character":55},"updated":"2016-08-19 10:07:12.000000000","message":"Should the test configure and get the segments extension rather than creating it here?","commit_id":"e1896b2b8e59432051e48814df20143213f4b8ea"},{"author":{"_account_id":11159,"name":"Hong Hui Xiao","email":"honghui_xiao@yeah.net","username":"HongHuiXiao"},"change_message_id":"7017d696419bd3c198269dbe5131bb648cf9a4ed","unresolved":false,"context_lines":[{"line_number":489,"context_line":""},{"line_number":490,"context_line":"    def setUp(self):"},{"line_number":491,"context_line":"        super(TestOvnSbSync, self).setUp(ovn_worker\u003dFalse)"},{"line_number":492,"context_line":"        self.segments_plugin \u003d segments_plugin.Plugin()"},{"line_number":493,"context_line":"        self.sb_synchronizer \u003d ovn_db_sync.OvnSbSynchronizer("},{"line_number":494,"context_line":"            self.plugin, self.mech_driver._sb_ovn, self.mech_driver)"},{"line_number":495,"context_line":"        self.ctx \u003d context.get_admin_context()"}],"source_content_type":"text/x-python","patch_set":6,"id":"1ac06dbe_0e5f3d42","line":492,"range":{"start_line":492,"start_character":9,"end_line":492,"end_character":55},"in_reply_to":"3ac371cc_a553b56b","updated":"2016-08-20 11:47:47.000000000","message":"Done","commit_id":"e1896b2b8e59432051e48814df20143213f4b8ea"}]}
