)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5052dc8c678cc4009f5d8ef8736552d1af9a00d9","unresolved":false,"context_lines":[{"line_number":17,"context_line":"https://patchwork.ozlabs.org/patch/649529/"},{"line_number":18,"context_line":"https://patchwork.ozlabs.org/patch/646184/"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"TODO:"},{"line_number":21,"context_line":"Add functional test cases"},{"line_number":22,"context_line":"Fix errors in current test cases"},{"line_number":23,"context_line":"Revert transcation in case of failures"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_7e056778","line":20,"updated":"2016-08-04 18:33:12.000000000","message":"devstackgatenativel3rc needs to be updated to re-enable the floating IP tests.","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5052dc8c678cc4009f5d8ef8736552d1af9a00d9","unresolved":false,"context_lines":[{"line_number":23,"context_line":"Revert transcation in case of failures"},{"line_number":24,"context_line":"Prevent user from creating admin transit network"},{"line_number":25,"context_line":"Create static routes in gateway router if nexthop is not in private networks"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I9b78ceb6b42e96c1ba58ed269e369b46113edd7e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_9e0e5b8a","line":26,"updated":"2016-08-04 18:33:12.000000000","message":"There will also be a TODO for OVN NB DB sync support and for documentation and release note updates.","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5052dc8c678cc4009f5d8ef8736552d1af9a00d9","unresolved":false,"context_lines":[{"line_number":24,"context_line":"Prevent user from creating admin transit network"},{"line_number":25,"context_line":"Create static routes in gateway router if nexthop is not in private networks"},{"line_number":26,"context_line":""},{"line_number":27,"context_line":"Change-Id: I9b78ceb6b42e96c1ba58ed269e369b46113edd7e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"bacf61ea_de3d732c","line":27,"updated":"2016-08-04 18:33:12.000000000","message":"Please update the commit message to reference bug 1514995","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"ff6df333f4b192826837721472872354a38c3d14","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TODO:"},{"line_number":13,"context_line":"1. Add functional test cases (To be followed up in a different patch)"},{"line_number":14,"context_line":"2. Add sync code (To be dollowed up in a different patch)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://etherpad.openstack.org/p/Integration_with_OVN_L3_Gateway"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":10,"id":"fa7ab95a_3e2d7e46","line":14,"updated":"2016-09-01 21:35:36.000000000","message":"If both of these are going to be in follow-up patches, what\u0027s keeping this as WIP?  Are there patches still needed in OVN?","commit_id":"8e31421ad563ac2cd1b2862ef6086867da9f7681"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fa34425d36ccce492fc9ee9e28d8d3a8100da432","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TODO:"},{"line_number":13,"context_line":"1. Add functional test cases (To be followed up in a different patch)"},{"line_number":14,"context_line":"2. Add sync code (To be followed up in a different patch)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://etherpad.openstack.org/p/Integration_with_OVN_L3_Gateway"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9a89bdaa_111b4fcb","line":14,"updated":"2016-09-12 17:09:16.000000000","message":"I don\u0027t think we can leave everything as a TODO.  I ran sync with a couple floating IP ports and got the following output:\n\n\n016-09-12 12:01:18.442 WARNING networking_ovn.ovn_db_sync [req-7a649e62-eff1-47de-8462-85f6eaf709a8 None None] Port found in Neutron but not in OVN DB, port_id\u003d510b440a-512e-44bc-81d4-7b98d10dafa4\n2016-09-12 12:01:18.443 WARNING networking_ovn.ovn_db_sync [req-7a649e62-eff1-47de-8462-85f6eaf709a8 None None] Port found in Neutron but not in OVN DB, port_id\u003d2b2479fd-233c-49be-bbfb-a4282f7f72ab","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"98ef4a0ef8e91e0727d4658b62d9f2aa02dd7e4f","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TODO:"},{"line_number":13,"context_line":"1. Add functional test cases (To be followed up in a different patch)"},{"line_number":14,"context_line":"2. Add sync code (To be followed up in a different patch)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://etherpad.openstack.org/p/Integration_with_OVN_L3_Gateway"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":14,"id":"9a89bdaa_11f7cf59","line":14,"in_reply_to":"9a89bdaa_111b4fcb","updated":"2016-09-12 17:12:01.000000000","message":"I also see the following:\n\n\n2016-09-12 12:11:13.728 WARNING networking_ovn.ovn_db_sync [req-48696ee2-201c-4abe-8307-63863d310b80 None None] Router found in OVN but not in Neutron, router id\u003dogr-a1c58d15-c9a5-4a07-a2e2-38ffc59fae15\n2016-09-12 12:11:13.729 WARNING networking_ovn.ovn_db_sync [req-48696ee2-201c-4abe-8307-63863d310b80 None None] Router Port found in OVN but not in Neutron, port_id\u003ddtsp-a1c58d15-c9a5-4a07-a2e2-38ffc59fae15\n2016-09-12 12:11:13.729 WARNING networking_ovn.ovn_db_sync [req-48696ee2-201c-4abe-8307-63863d310b80 None None] Router a1c58d15-c9a5-4a07-a2e2-38ffc59fae15 static routes [{u\u0027nexthop\u0027: u\u0027169.254.128.1\u0027, u\u0027destination\u0027: u\u00270.0.0.0/0\u0027}] found in OVN but not in Neutron","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":10,"context_line":"NAT support can be found @ [1]"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TODO:"},{"line_number":13,"context_line":"1. Add functional test cases (To be followed up in a different patch)"},{"line_number":14,"context_line":"2. Add sync code (To be followed up in a different patch)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://etherpad.openstack.org/p/Integration_with_OVN_L3_Gateway"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3a98d1f4_3df02067","line":13,"updated":"2016-09-30 14:03:00.000000000","message":"There are also missing unit tests.  Please open a bug and reference here which will close the testing gaps.","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":11,"context_line":""},{"line_number":12,"context_line":"TODO:"},{"line_number":13,"context_line":"1. Add functional test cases (To be followed up in a different patch)"},{"line_number":14,"context_line":"2. Add sync code (To be followed up in a different patch)"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"[1] https://etherpad.openstack.org/p/Integration_with_OVN_L3_Gateway"},{"line_number":17,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"3a98d1f4_9d5db47b","line":14,"updated":"2016-09-30 14:03:00.000000000","message":"Have you fixed the problems with sync that I noted earlier?  I\u0027m okay with deferring the actual sync code, but we need to keep sync working.\n\nAlso, you can reference the bug that you opened for this.","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dc3b5a888cdc1cf60365b850150f8fad6307d954","unresolved":false,"context_lines":[{"line_number":16,"context_line":"[1] https://etherpad.openstack.org/p/Integration_with_OVN_L3_Gateway"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"Change-Id: I9b78ceb6b42e96c1ba58ed269e369b46113edd7e"},{"line_number":19,"context_line":"Closes-Bug: 1514995"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"ba5da102_69f50a82","line":19,"updated":"2016-10-26 14:27:38.000000000","message":"I believe this closes bug 1551717 as well.","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"93c42f4259188ecb96a4579c43c9edcb12d8780e","unresolved":false,"context_lines":[{"line_number":17,"context_line":"[1] https://etherpad.openstack.org/p/Integration_with_OVN_L3_Gateway"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I9b78ceb6b42e96c1ba58ed269e369b46113edd7e"},{"line_number":20,"context_line":"Closes-Bug: 1514995"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"ba5da102_cc61fa06","line":20,"updated":"2016-11-03 12:30:47.000000000","message":"Please note that this closes bug 1551717 too.","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"ab85b527e20c011602305652184e966ca721236f","unresolved":false,"context_lines":[{"line_number":17,"context_line":"[1] https://etherpad.openstack.org/p/Integration_with_OVN_L3_Gateway"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: I9b78ceb6b42e96c1ba58ed269e369b46113edd7e"},{"line_number":20,"context_line":"Closes-Bug: 1514995"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":19,"id":"ba5da102_ca337660","line":20,"in_reply_to":"ba5da102_cc61fa06","updated":"2016-11-04 04:26:29.000000000","message":"Done","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"}],"devstack/devstackgatenativeservicesrc":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"476d8fc3530befd6a49d18b391b3b8ad497e49ae","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# exclude things that aren\u0027t fully implemented yet in the OVN native L3 agent"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE: Re-enable floating ip tests once floating IPs are implemented"},{"line_number":41,"context_line":"# in OVN (bug 1514995)."},{"line_number":42,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_minimum_basic.*)\""},{"line_number":43,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_network_advanced_server_ops.*)\""}],"source_content_type":"application/octet-stream","patch_set":14,"id":"9a89bdaa_45211eb4","line":40,"updated":"2016-09-08 21:15:35.000000000","message":"Why aren\u0027t we re-enabling all of these tests?  They either need to be re-enabled or an exclusion should be documented.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"79b4dcd31d571a2b3267348c0e68bece589b46a3","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# exclude things that aren\u0027t fully implemented yet in the OVN native L3 agent"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE: Re-enable floating ip tests once floating IPs are implemented"},{"line_number":41,"context_line":"# in OVN (bug 1514995)."},{"line_number":42,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_minimum_basic.*)\""},{"line_number":43,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_network_advanced_server_ops.*)\""}],"source_content_type":"application/octet-stream","patch_set":14,"id":"7a8ec9b2_38951940","line":40,"in_reply_to":"7a8ec9b2_21c40891","updated":"2016-09-13 19:54:08.000000000","message":"This entire block was intended to be addressed in bug 1514995. However, Brad and I weren\u0027t sure which ones that we should expect to work.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2da32f0ec880d43cad7a6843cd02f52802980722","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# exclude things that aren\u0027t fully implemented yet in the OVN native L3 agent"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE: Re-enable floating ip tests once floating IPs are implemented"},{"line_number":41,"context_line":"# in OVN (bug 1514995)."},{"line_number":42,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_minimum_basic.*)\""},{"line_number":43,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_network_advanced_server_ops.*)\""}],"source_content_type":"application/octet-stream","patch_set":14,"id":"7a8ec9b2_560d1136","line":40,"in_reply_to":"7a8ec9b2_38951940","updated":"2016-09-14 18:30:43.000000000","message":"I pushed a test patch that runs all of these tests (see https://review.openstack.org/#/c/370298/).  All tests appear to be failing on floating IP connectivity.  You may have run into unrelated issues which have since been fixed or got past the floating IP connectivity to hit another missing feature. Anyway, we\u0027ll have to look in more detail before opening new bugs.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# exclude things that aren\u0027t fully implemented yet in the OVN native L3 agent"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE: Re-enable floating ip tests once floating IPs are implemented"},{"line_number":41,"context_line":"# in OVN (bug 1514995)."},{"line_number":42,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_minimum_basic.*)\""},{"line_number":43,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_network_advanced_server_ops.*)\""}],"source_content_type":"application/octet-stream","patch_set":14,"id":"7a8ec9b2_6d544fc9","line":40,"in_reply_to":"7a8ec9b2_560d1136","updated":"2016-09-19 10:18:51.000000000","message":"I enabled all the tests but test_network_v6, which is failing. I would prefer to open a bug for this and investigate later","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# exclude things that aren\u0027t fully implemented yet in the OVN native L3 agent"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"# NOTE: Re-enable floating ip tests once floating IPs are implemented"},{"line_number":41,"context_line":"# in OVN (bug 1514995)."},{"line_number":42,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_minimum_basic.*)\""},{"line_number":43,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_network_advanced_server_ops.*)\""}],"source_content_type":"application/octet-stream","patch_set":14,"id":"7a8ec9b2_21c40891","line":40,"in_reply_to":"9a89bdaa_45211eb4","updated":"2016-09-13 17:53:18.000000000","message":"I wasn\u0027t sure, all these tests are related to floating ip, besides some of them are failing and i havent had the time to dig into the failues. I\u0027ll enable the following in the next patch.\n\ntest_network_advanced_server_ops\ntest_security_groups_basic_ops\ntest_stamp_pattern\n\nFor the rest i\u0027ll document, and open a bug","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# exclude the slow tag (part of the default for \u0027full\u0027)"},{"line_number":36,"context_line":"r\u003d\"$r(?:.*\\[.*\\bslow\\b.*\\])\""},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"# TODO(chandrav): File a bug for the following test"},{"line_number":39,"context_line":"r\u003d\"$r|(?:tempest\\.scenario\\.test_network_v6.*)\""},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# exclude things that just aren\u0027t enabled with OVN"}],"source_content_type":"application/octet-stream","patch_set":18,"id":"3a98d1f4_42018b04","line":38,"updated":"2016-09-30 14:03:00.000000000","message":"Please reference the bug here.","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"}],"devstack/lib/networking-ovn":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"476d8fc3530befd6a49d18b391b3b8ad497e49ae","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    ext_gw_ifc\u003d$(get_ext_gw_interface)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    sudo ovs-vsctl --may-exist add-br $ext_gw_ifc -- set bridge $ext_gw_ifc protocols\u003dOpenFlow13"},{"line_number":496,"context_line":"    sudo ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003dpublic:$ext_gw_ifc"},{"line_number":497,"context_line":"    if [ -n \"$FLOATING_RANGE\" ]; then"},{"line_number":498,"context_line":"        local cidr_len\u003d${FLOATING_RANGE#*/}"},{"line_number":499,"context_line":"        sudo ip addr add $PUBLIC_NETWORK_GATEWAY/$cidr_len dev $ext_gw_ifc"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"9a89bdaa_85688689","line":496,"range":{"start_line":496,"start_character":63,"end_line":496,"end_character":69},"updated":"2016-09-08 21:15:35.000000000","message":"This should be $PHYSICAL_NETWORK to avoid hard coding.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":493,"context_line":"    ext_gw_ifc\u003d$(get_ext_gw_interface)"},{"line_number":494,"context_line":""},{"line_number":495,"context_line":"    sudo ovs-vsctl --may-exist add-br $ext_gw_ifc -- set bridge $ext_gw_ifc protocols\u003dOpenFlow13"},{"line_number":496,"context_line":"    sudo ovs-vsctl set open . external-ids:ovn-bridge-mappings\u003dpublic:$ext_gw_ifc"},{"line_number":497,"context_line":"    if [ -n \"$FLOATING_RANGE\" ]; then"},{"line_number":498,"context_line":"        local cidr_len\u003d${FLOATING_RANGE#*/}"},{"line_number":499,"context_line":"        sudo ip addr add $PUBLIC_NETWORK_GATEWAY/$cidr_len dev $ext_gw_ifc"}],"source_content_type":"application/x-shellscript","patch_set":14,"id":"7a8ec9b2_c13b649b","line":496,"range":{"start_line":496,"start_character":63,"end_line":496,"end_character":69},"in_reply_to":"9a89bdaa_85688689","updated":"2016-09-13 17:53:18.000000000","message":"yup, wil fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"}],"doc/source/features.rst":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"476d8fc3530befd6a49d18b391b3b8ad497e49ae","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  Native implementation or conventional layer-3 agent. The native"},{"line_number":17,"context_line":"  implementation supports distributed routing. However, it currently lacks"},{"line_number":18,"context_line":"  support for floating IP addresses, NAT, and the metadata proxy."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* DHCP"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"9a89bdaa_02162c55","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":41},"updated":"2016-09-08 21:15:35.000000000","message":"You can remove these restrictions.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  Native implementation or conventional layer-3 agent. The native"},{"line_number":17,"context_line":"  implementation supports distributed routing. However, it currently lacks"},{"line_number":18,"context_line":"  support for floating IP addresses, NAT, and the metadata proxy."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"* DHCP"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-rst","patch_set":14,"id":"7a8ec9b2_a15d78ee","line":18,"range":{"start_line":18,"start_character":14,"end_line":18,"end_character":41},"in_reply_to":"9a89bdaa_02162c55","updated":"2016-09-13 17:53:18.000000000","message":"wil remove it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"}],"networking_ovn/common/config.py":[{"author":{"_account_id":17224,"name":"MingShuang Xian","email":"xianms@cn.ibm.com","username":"MingShuangXian"},"change_message_id":"2e7dd3c347116d4064426b3063f6858f4cfe7aa8","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               help\u003d_(\u0027Default least time (in seconds ) to use when \u0027"},{"line_number":82,"context_line":"                      \u0027ovn_native_dhcp is enabled.\u0027)),"},{"line_number":83,"context_line":"    cfg.StrOpt(\"ovn_l3_admin_net_cidr\","},{"line_number":84,"context_line":"               default\u003d\u0027169.254.128.0/30\u0027,"},{"line_number":85,"context_line":"               help\u003d_(\u0027Admin network used for connecting distributed \u0027"},{"line_number":86,"context_line":"                      \u0027routers to gateway routers. Do not change the value \u0027"},{"line_number":87,"context_line":"                      \u0027for existing deployments that contain routers.\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_63aa481b","line":84,"updated":"2016-09-11 14:42:52.000000000","message":"needs a bigger subnet for VPNaaS, 169.254.128.0/28 is better","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":81,"context_line":"               help\u003d_(\u0027Default least time (in seconds ) to use when \u0027"},{"line_number":82,"context_line":"                      \u0027ovn_native_dhcp is enabled.\u0027)),"},{"line_number":83,"context_line":"    cfg.StrOpt(\"ovn_l3_admin_net_cidr\","},{"line_number":84,"context_line":"               default\u003d\u0027169.254.128.0/30\u0027,"},{"line_number":85,"context_line":"               help\u003d_(\u0027Admin network used for connecting distributed \u0027"},{"line_number":86,"context_line":"                      \u0027routers to gateway routers. Do not change the value \u0027"},{"line_number":87,"context_line":"                      \u0027for existing deployments that contain routers.\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_616c509d","line":84,"in_reply_to":"9a89bdaa_63aa481b","updated":"2016-09-13 17:53:18.000000000","message":"You should make that change as part of your VPN patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"476d8fc3530befd6a49d18b391b3b8ad497e49ae","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                      \u0027ovn_native_dhcp is enabled.\u0027)),"},{"line_number":83,"context_line":"    cfg.StrOpt(\"ovn_l3_admin_net_cidr\","},{"line_number":84,"context_line":"               default\u003d\u0027169.254.128.0/30\u0027,"},{"line_number":85,"context_line":"               help\u003d_(\u0027Admin network used for connecting distributed \u0027"},{"line_number":86,"context_line":"                      \u0027routers to gateway routers. Do not change the value \u0027"},{"line_number":87,"context_line":"                      \u0027for existing deployments that contain routers.\u0027))"},{"line_number":88,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_453d9eba","line":85,"updated":"2016-09-08 21:15:35.000000000","message":"When would an administrator want or need to change this? This may be good information to add in the help and documentation.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":82,"context_line":"                      \u0027ovn_native_dhcp is enabled.\u0027)),"},{"line_number":83,"context_line":"    cfg.StrOpt(\"ovn_l3_admin_net_cidr\","},{"line_number":84,"context_line":"               default\u003d\u0027169.254.128.0/30\u0027,"},{"line_number":85,"context_line":"               help\u003d_(\u0027Admin network used for connecting distributed \u0027"},{"line_number":86,"context_line":"                      \u0027routers to gateway routers. Do not change the value \u0027"},{"line_number":87,"context_line":"                      \u0027for existing deployments that contain routers.\u0027))"},{"line_number":88,"context_line":"]"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_a12bb832","line":85,"in_reply_to":"9a89bdaa_453d9eba","updated":"2016-09-13 17:53:18.000000000","message":"will do in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"}],"networking_ovn/common/exceptions.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"476d8fc3530befd6a49d18b391b3b8ad497e49ae","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from networking_ovn._i18n import _"},{"line_number":16,"context_line":"from neutron.common import exceptions"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class L3AdinNetError(exceptions.NeutronException):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_c829c38b","line":16,"updated":"2016-09-08 21:15:35.000000000","message":"Please use neutron_lib","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"#"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"from networking_ovn._i18n import _"},{"line_number":16,"context_line":"from neutron.common import exceptions"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class L3AdinNetError(exceptions.NeutronException):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_a1d2d832","line":16,"in_reply_to":"9a89bdaa_c829c38b","updated":"2016-09-13 17:53:18.000000000","message":"wil fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b1d14d330e40ad02e9281d4be3245c23655c707d","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class L3AdinNetError(exceptions.NeutronException):"},{"line_number":20,"context_line":"    message \u003d _(\u0027%(msg)s\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class L3AdminNetSubnetError(exceptions.NeutronException):"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_4e3dda8d","line":20,"updated":"2016-11-03 12:43:59.000000000","message":"this is not the correct usage of the translations - the actual text should be here - that is what is translated.","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"ab85b527e20c011602305652184e966ca721236f","unresolved":false,"context_lines":[{"line_number":17,"context_line":""},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class L3AdinNetError(exceptions.NeutronException):"},{"line_number":20,"context_line":"    message \u003d _(\u0027%(msg)s\u0027)"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"class L3AdminNetSubnetError(exceptions.NeutronException):"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_eae83ab5","line":20,"in_reply_to":"ba5da102_4e3dda8d","updated":"2016-11-04 04:26:29.000000000","message":"Done","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"}],"networking_ovn/common/extensions.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"5052dc8c678cc4009f5d8ef8736552d1af9a00d9","unresolved":false,"context_lines":[{"line_number":30,"context_line":"ML2_SUPPORTED_API_EXTENSIONS_OVN_L3 \u003d ["},{"line_number":31,"context_line":"    \u0027router\u0027,"},{"line_number":32,"context_line":"    \u0027extraroute\u0027,"},{"line_number":33,"context_line":"    \u0027ext-gw-mode\u0027"},{"line_number":34,"context_line":"]"},{"line_number":35,"context_line":"ML2_SUPPORTED_API_EXTENSIONS \u003d ["},{"line_number":36,"context_line":"    \u0027address-scope\u0027,"}],"source_content_type":"text/x-python","patch_set":2,"id":"bacf61ea_fe55d74f","line":33,"updated":"2016-08-04 18:33:12.000000000","message":"Please update the features doc and release note for this.","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"}],"networking_ovn/l3/l3_ovn.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":81,"context_line":"        return (\"L3 Router Service Plugin for basic L3 forwarding\""},{"line_number":82,"context_line":"                \" using OVN\")"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"    def get_admin_transit_network(self, context, create\u003dFalse):"},{"line_number":85,"context_line":"        filters \u003d {\u0027name\u0027: [ovn_const.OVN_TRANSIT_NW_NAME],"},{"line_number":86,"context_line":"                   \u0027tenant_id\u0027: [\u0027 \u0027]}"},{"line_number":87,"context_line":"        networks \u003d self._plugin.get_networks(context, filters\u003dfilters)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_fc04dac0","line":84,"updated":"2016-08-10 08:01:21.000000000","message":"this applies to any other method you\u0027r adding/have already: I\u0027d set any method that is not expected to provide the interface of the L3 Router Plugin to be a private method, that way it\u0027s very clear which methods are part of such interface, and which methods are internal implementation.","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":133,"context_line":"            return"},{"line_number":134,"context_line":""},{"line_number":135,"context_line":"    def get_admin_transit_network_ports(self, create\u003dFalse):"},{"line_number":136,"context_line":"        if len(self.transit_network_ports) is 2:"},{"line_number":137,"context_line":"            return self.transit_network_ports"},{"line_number":138,"context_line":"        \"Check if transit network ports exist in neutron\""},{"line_number":139,"context_line":"        context \u003d self.admin_context"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_a92186b6","line":136,"updated":"2016-08-10 08:01:21.000000000","message":"You may need add in-process locking to this function to avoid race conditions.\n\n1) one call enters this, len is 0, starts creating...\n2) it get\u0027s blocked at some point (socket access, etc..)\n3) another call enters, len is 0, starts creating...\n3) 1st call is unblocked, ... sets the ports\n4) 2nd call is unblocked, ... sets other pair of ports.","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":143,"context_line":"             \u0027tenant_id\u0027: [\u0027 \u0027]}"},{"line_number":144,"context_line":"        ports \u003d self._plugin.get_ports(context, filters\u003dfilters)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if len(ports) \u003e 2 or len(ports) \u003d\u003d 1:"},{"line_number":147,"context_line":"            LOG.exception(_LE(\u0027Unexpected no of admin transit network ports\u0027"},{"line_number":148,"context_line":"                              \u0027 found: %r\u0027), ports)"},{"line_number":149,"context_line":"            raise n_exc.ServiceUnavailable()"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_bc142244","line":146,"updated":"2016-08-10 08:01:21.000000000","message":"suggestion (error condition is the one where no valid option is detected).\n\nif len(ports)\u003d\u003d0 and create: \n   \u0027.... creates\u0027\nelif len(ports)\u003d\u003d2:\n   \u0027 .....\u0027\nelse:\n   LOG.error","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":144,"context_line":"        ports \u003d self._plugin.get_ports(context, filters\u003dfilters)"},{"line_number":145,"context_line":""},{"line_number":146,"context_line":"        if len(ports) \u003e 2 or len(ports) \u003d\u003d 1:"},{"line_number":147,"context_line":"            LOG.exception(_LE(\u0027Unexpected no of admin transit network ports\u0027"},{"line_number":148,"context_line":"                              \u0027 found: %r\u0027), ports)"},{"line_number":149,"context_line":"            raise n_exc.ServiceUnavailable()"},{"line_number":150,"context_line":"        elif len(ports) \u003d\u003d 2:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_bc3b82d0","line":147,"updated":"2016-08-10 08:01:21.000000000","message":"LOG.exception (as far as I know, I can be wrong) it\u0027s used to log an exception which already happened and you caught, in this case the exception is still not raised.\n\nMay be LOG.error is more correct.","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                \u0027fixed_ips\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":165,"context_line":"                \u0027port_security_enabled\u0027: False}}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            \"Create gateway transit switch port (GTSP)\""},{"line_number":168,"context_line":"            port_params[\u0027port\u0027][\u0027name\u0027] \u003d \u0027GTSP\u0027"},{"line_number":169,"context_line":"            port_params[\u0027port\u0027][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":170,"context_line":"            gtsp \u003d self._plugin.create_port(context, port_params)"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_6645fd15","line":167,"updated":"2016-08-10 08:01:21.000000000","message":"This may be a comment, not a string","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":165,"context_line":"                \u0027port_security_enabled\u0027: False}}"},{"line_number":166,"context_line":""},{"line_number":167,"context_line":"            \"Create gateway transit switch port (GTSP)\""},{"line_number":168,"context_line":"            port_params[\u0027port\u0027][\u0027name\u0027] \u003d \u0027GTSP\u0027"},{"line_number":169,"context_line":"            port_params[\u0027port\u0027][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":170,"context_line":"            gtsp \u003d self._plugin.create_port(context, port_params)"},{"line_number":171,"context_line":"            self.transit_network_ports[\u0027gtsp\u0027] \u003d gtsp"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_46bb99e5","line":168,"updated":"2016-08-10 08:01:21.000000000","message":"This block could be a separate private method function.","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":174,"context_line":"            self.transit_network_ports[\u0027gtsp\u0027][\u0027ip\u0027] \u003d \\"},{"line_number":175,"context_line":"                gtsp[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            \"Create distributed transit switch port (DTSP)\""},{"line_number":178,"context_line":"            port_params[\u0027port\u0027][\u0027name\u0027] \u003d \u0027DTSP\u0027"},{"line_number":179,"context_line":"            port_params[\u0027port\u0027][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":180,"context_line":"            port_params[\u0027port\u0027][\u0027mac_address\u0027] \u003d n_const.ATTR_NOT_SPECIFIED"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_86275163","line":177,"updated":"2016-08-10 08:01:21.000000000","message":"This should be a comment, not a string.","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":175,"context_line":"                gtsp[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"            \"Create distributed transit switch port (DTSP)\""},{"line_number":178,"context_line":"            port_params[\u0027port\u0027][\u0027name\u0027] \u003d \u0027DTSP\u0027"},{"line_number":179,"context_line":"            port_params[\u0027port\u0027][\u0027network_id\u0027] \u003d network[\u0027id\u0027]"},{"line_number":180,"context_line":"            port_params[\u0027port\u0027][\u0027mac_address\u0027] \u003d n_const.ATTR_NOT_SPECIFIED"},{"line_number":181,"context_line":"            port_params[\u0027port\u0027][\u0027fixed_ips\u0027] \u003d n_const.ATTR_NOT_SPECIFIED"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_a6ca556c","line":178,"updated":"2016-08-10 08:01:21.000000000","message":"same for this block","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":184,"context_line":"            self.transit_network_ports[\u0027dtsp\u0027][\u0027addresses\u0027] \u003d \\"},{"line_number":185,"context_line":"                dtsp[\u0027mac_address\u0027] + \u0027 \u0027 + dtsp[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":186,"context_line":"            self.transit_network_ports[\u0027dtsp\u0027][\u0027ip\u0027] \u003d \\"},{"line_number":187,"context_line":"                dtsp[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":188,"context_line":""},{"line_number":189,"context_line":"        return self.transit_network_ports"},{"line_number":190,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_1c9f2eb5","line":187,"updated":"2016-08-10 08:01:21.000000000","message":"You could still make this a bit more beautiful if you used objects which returned dictionaries\n\nTransitSwitchPort(object): \n....\n   def __init__(self, network_id, \n\n      self._port_params \u003d {\u0027.....\n\n   def to_dict(self):\n      ...\n\n    DistributedTSPPort(TransitSwitchPort):\n        ...\n\n    GatewayTSPPort(TransitSwitchPort):\n        ....\n\nso you could do\n\n    self.transit_network_ports \u003d {\u0027dtsp\u0027: DistributedTSPort(....).to_dict(),\n                                  \u0027gtsp\u0027: GatewayTSPort(...).to_dict()}","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":196,"context_line":"                addresses \u003d \\"},{"line_number":197,"context_line":"                    port[\u0027mac_address\u0027] + \u0027 \u0027 + \\"},{"line_number":198,"context_line":"                    port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":199,"context_line":"                ports_dict[\u0027dtsp\u0027][\u0027addresses\u0027] \u003d addresses"},{"line_number":200,"context_line":"                ports_dict[\u0027dtsp\u0027][\u0027ip\u0027] \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":201,"context_line":"            elif port[\u0027name\u0027] \u003d\u003d \u0027GTSP\u0027:"},{"line_number":202,"context_line":"                ports_dict[\u0027gtsp\u0027] \u003d port"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_86b75185","line":199,"updated":"2016-08-10 08:01:21.000000000","message":"please note that here you\u0027re mutating the original port in ports list.","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"45001d0dd23178f24c3cc3cf98f5442d9a2d0839","unresolved":false,"context_lines":[{"line_number":203,"context_line":"                addresses \u003d \\"},{"line_number":204,"context_line":"                    port[\u0027mac_address\u0027] + \u0027 \u0027 + \\"},{"line_number":205,"context_line":"                    port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":206,"context_line":"                ports_dict[\u0027gtsp\u0027][\u0027addresses\u0027] \u003d addresses"},{"line_number":207,"context_line":"                ports_dict[\u0027gtsp\u0027][\u0027ip\u0027] \u003d port[\u0027fixed_ips\u0027][0][\u0027ip_address\u0027]"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"        return ports_dict"}],"source_content_type":"text/x-python","patch_set":2,"id":"9ad45d7e_66ba1d70","line":206,"range":{"start_line":206,"start_character":43,"end_line":206,"end_character":44},"updated":"2016-08-10 08:01:21.000000000","message":"same here.","commit_id":"c28fc0bd21b9e107d685a033cec17a2c720e7dde"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"48ce19df6a6aeb0030d72333cb5cd8791adff4b1","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _admin_net(self):"},{"line_number":91,"context_line":"        if self._admin_net_mgr is None:"},{"line_number":92,"context_line":"            self._admin_net_mgr \u003d l3_ovn_admin_net.OVNL3AdminNetwork("},{"line_number":93,"context_line":"                self._ovn, self._plugin, config.get_ovn_l3_admin_net_cidr())"},{"line_number":94,"context_line":"        return self._admin_net_mgr"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def get_plugin_type(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_242c9801","line":93,"range":{"start_line":93,"start_character":41,"end_line":93,"end_character":75},"updated":"2016-09-12 16:26:35.000000000","message":"You can use self.l3_admin_net_cidr here.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    def _admin_net(self):"},{"line_number":91,"context_line":"        if self._admin_net_mgr is None:"},{"line_number":92,"context_line":"            self._admin_net_mgr \u003d l3_ovn_admin_net.OVNL3AdminNetwork("},{"line_number":93,"context_line":"                self._ovn, self._plugin, config.get_ovn_l3_admin_net_cidr())"},{"line_number":94,"context_line":"        return self._admin_net_mgr"},{"line_number":95,"context_line":""},{"line_number":96,"context_line":"    def get_plugin_type(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_21e7a813","line":93,"range":{"start_line":93,"start_character":41,"end_line":93,"end_character":75},"in_reply_to":"9a89bdaa_242c9801","updated":"2016-09-13 17:53:18.000000000","message":"wil fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"48ce19df6a6aeb0030d72333cb5cd8791adff4b1","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            ovn_const.OVN_L3_ADMIN_NET_PORT_DEVICE_OWNER, create)"},{"line_number":110,"context_line":"        for port in ports:"},{"line_number":111,"context_line":"            ip \u003d port.get(\u0027fixed_ips\u0027)[0].get(\u0027ip_address\u0027)"},{"line_number":112,"context_line":"            port.update({\u0027ip\u0027: ip,"},{"line_number":113,"context_line":"                         \u0027addresses\u0027: port.get(\u0027mac_address\u0027) + \u0027 \u0027 + ip})"},{"line_number":114,"context_line":"            if port.get(\u0027name\u0027) \u003d\u003d \u0027DTSP\u0027:"},{"line_number":115,"context_line":"                transit_net_ports[\u0027dtsp\u0027] \u003d port"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_44c27cea","line":112,"updated":"2016-09-12 16:26:35.000000000","message":"Instead of changing the port dict from the database, it is probably better to just build a transit_net_ports dict with the data that you want.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":109,"context_line":"            ovn_const.OVN_L3_ADMIN_NET_PORT_DEVICE_OWNER, create)"},{"line_number":110,"context_line":"        for port in ports:"},{"line_number":111,"context_line":"            ip \u003d port.get(\u0027fixed_ips\u0027)[0].get(\u0027ip_address\u0027)"},{"line_number":112,"context_line":"            port.update({\u0027ip\u0027: ip,"},{"line_number":113,"context_line":"                         \u0027addresses\u0027: port.get(\u0027mac_address\u0027) + \u0027 \u0027 + ip})"},{"line_number":114,"context_line":"            if port.get(\u0027name\u0027) \u003d\u003d \u0027DTSP\u0027:"},{"line_number":115,"context_line":"                transit_net_ports[\u0027dtsp\u0027] \u003d port"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_a1b9f8ee","line":112,"in_reply_to":"9a89bdaa_44c27cea","updated":"2016-09-13 17:53:18.000000000","message":"wil fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        filters \u003d {\u0027device_owner\u0027: [n_const.DEVICE_OWNER_ROUTER_GW]}"},{"line_number":124,"context_line":"        gateway_ports \u003d self._plugin.get_ports(context.elevated(),"},{"line_number":125,"context_line":"                                               filters\u003dfilters)"},{"line_number":126,"context_line":"        if gateway_ports:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # No gateway ports, delete the l3 admin net"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_21793c30","line":126,"updated":"2016-09-09 15:51:45.000000000","message":"This isn\u0027t done within a transaction so race conditions are possible here.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"79b4dcd31d571a2b3267348c0e68bece589b46a3","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        filters \u003d {\u0027device_owner\u0027: [n_const.DEVICE_OWNER_ROUTER_GW]}"},{"line_number":124,"context_line":"        gateway_ports \u003d self._plugin.get_ports(context.elevated(),"},{"line_number":125,"context_line":"                                               filters\u003dfilters)"},{"line_number":126,"context_line":"        if gateway_ports:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # No gateway ports, delete the l3 admin net"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_d82fd5f4","line":126,"in_reply_to":"7a8ec9b2_a111f8b1","updated":"2016-09-13 19:54:08.000000000","message":"Does it harm anything to keep it around? You can avoid potential race conditions by not deleting it.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        filters \u003d {\u0027device_owner\u0027: [n_const.DEVICE_OWNER_ROUTER_GW]}"},{"line_number":124,"context_line":"        gateway_ports \u003d self._plugin.get_ports(context.elevated(),"},{"line_number":125,"context_line":"                                               filters\u003dfilters)"},{"line_number":126,"context_line":"        if gateway_ports:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # No gateway ports, delete the l3 admin net"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_e8ed9c26","line":126,"in_reply_to":"7a8ec9b2_d82fd5f4","updated":"2016-09-19 10:18:51.000000000","message":"There is no harm in keeping it around, except that a user who cleaned up all the resources will still see admin net, subnet and ports, which is not a big deal, i guess","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        filters \u003d {\u0027device_owner\u0027: [n_const.DEVICE_OWNER_ROUTER_GW]}"},{"line_number":124,"context_line":"        gateway_ports \u003d self._plugin.get_ports(context.elevated(),"},{"line_number":125,"context_line":"                                               filters\u003dfilters)"},{"line_number":126,"context_line":"        if gateway_ports:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # No gateway ports, delete the l3 admin net"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_6cd92257","line":126,"in_reply_to":"9a89bdaa_21793c30","updated":"2016-09-12 18:28:00.000000000","message":"Why does the L3 admin network need to be deleted? I\u0027m unclear on the delete use case?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":17224,"name":"MingShuang Xian","email":"xianms@cn.ibm.com","username":"MingShuangXian"},"change_message_id":"2e7dd3c347116d4064426b3063f6858f4cfe7aa8","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        filters \u003d {\u0027device_owner\u0027: [n_const.DEVICE_OWNER_ROUTER_GW]}"},{"line_number":124,"context_line":"        gateway_ports \u003d self._plugin.get_ports(context.elevated(),"},{"line_number":125,"context_line":"                                               filters\u003dfilters)"},{"line_number":126,"context_line":"        if gateway_ports:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # No gateway ports, delete the l3 admin net"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_a3cff0b1","line":126,"in_reply_to":"9a89bdaa_21793c30","updated":"2016-09-11 14:42:52.000000000","message":"should check if vpn is using the transit network also vpn shares transit network with NAT?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        filters \u003d {\u0027device_owner\u0027: [n_const.DEVICE_OWNER_ROUTER_GW]}"},{"line_number":124,"context_line":"        gateway_ports \u003d self._plugin.get_ports(context.elevated(),"},{"line_number":125,"context_line":"                                               filters\u003dfilters)"},{"line_number":126,"context_line":"        if gateway_ports:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # No gateway ports, delete the l3 admin net"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_a111f8b1","line":126,"in_reply_to":"9a89bdaa_6cd92257","updated":"2016-09-13 17:53:18.000000000","message":"There is no use of l3_adin_net when there is no router with external gateway.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":123,"context_line":"        filters \u003d {\u0027device_owner\u0027: [n_const.DEVICE_OWNER_ROUTER_GW]}"},{"line_number":124,"context_line":"        gateway_ports \u003d self._plugin.get_ports(context.elevated(),"},{"line_number":125,"context_line":"                                               filters\u003dfilters)"},{"line_number":126,"context_line":"        if gateway_ports:"},{"line_number":127,"context_line":"            return"},{"line_number":128,"context_line":""},{"line_number":129,"context_line":"        # No gateway ports, delete the l3 admin net"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_61f2909c","line":126,"in_reply_to":"9a89bdaa_a3cff0b1","updated":"2016-09-13 17:53:18.000000000","message":"For now, there is no sharing of ports between NAT and VPN. If such a need exists we can enhance this later.\n\nI do see a scenario where a tenant can be configured to reach the customer datacenter through VPN and external network through gateway router. But i am not convinced yet, that this will require port sharing between NAT and VPN.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            if found_nexthop:"},{"line_number":221,"context_line":"                break"},{"line_number":222,"context_line":"        if not lrouter_name:"},{"line_number":223,"context_line":"            LOG.error((\u0027Unable to find router connected to nexthop %s to add \u0027"},{"line_number":224,"context_line":"                       \u0027static route in router %s\u0027) % (nexthop, router_id))"},{"line_number":225,"context_line":"            raise RuntimeError"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_8cad8686","line":223,"updated":"2016-09-12 18:28:00.000000000","message":"Please use _LE for error messages. This comment applies throughout.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":220,"context_line":"            if found_nexthop:"},{"line_number":221,"context_line":"                break"},{"line_number":222,"context_line":"        if not lrouter_name:"},{"line_number":223,"context_line":"            LOG.error((\u0027Unable to find router connected to nexthop %s to add \u0027"},{"line_number":224,"context_line":"                       \u0027static route in router %s\u0027) % (nexthop, router_id))"},{"line_number":225,"context_line":"            raise RuntimeError"},{"line_number":226,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_811ddcbf","line":223,"in_reply_to":"9a89bdaa_8cad8686","updated":"2016-09-13 17:53:18.000000000","message":"wil fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                    lrouter_name\u003dgw_lrouter_name)"},{"line_number":311,"context_line":"        except Exception:"},{"line_number":312,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":313,"context_line":"                self._disjoin_lrouter_and_gw_lrouter(router, transit_net_ports)"},{"line_number":314,"context_line":"                self._ovn.delete_static_route("},{"line_number":315,"context_line":"                    gw_lrouter_name, ip_prefix\u003d\u00270.0.0.0/0\u0027,"},{"line_number":316,"context_line":"                    nexthop\u003dext_gw_ip).execute(check_error\u003dTrue)"},{"line_number":317,"context_line":"                self._ovn.delete_lrouter_port("},{"line_number":318,"context_line":"                    utils.ovn_lrouter_port_name(gw_port_id),"},{"line_number":319,"context_line":"                    gw_lrouter_name).execute(check_error\u003dTrue)"},{"line_number":320,"context_line":"                self._delete_lrouter_in_ovn(router_id, is_gateway_router\u003dTrue)"},{"line_number":321,"context_line":"                LOG.error((\u0027Error in updating SNAT for router %s\u0027, router_id))"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _delete_router_ext_gw(self, context, router_id, router):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_2c72ba11","line":320,"range":{"start_line":313,"start_character":0,"end_line":320,"end_character":78},"updated":"2016-09-12 18:28:00.000000000","message":"There\u0027s a lot of duplicate code in the exception handling steps.  Can we simplify this by tracking the pieces that need to be cleaned up?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                    lrouter_name\u003dgw_lrouter_name)"},{"line_number":311,"context_line":"        except Exception:"},{"line_number":312,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":313,"context_line":"                self._disjoin_lrouter_and_gw_lrouter(router, transit_net_ports)"},{"line_number":314,"context_line":"                self._ovn.delete_static_route("},{"line_number":315,"context_line":"                    gw_lrouter_name, ip_prefix\u003d\u00270.0.0.0/0\u0027,"},{"line_number":316,"context_line":"                    nexthop\u003dext_gw_ip).execute(check_error\u003dTrue)"},{"line_number":317,"context_line":"                self._ovn.delete_lrouter_port("},{"line_number":318,"context_line":"                    utils.ovn_lrouter_port_name(gw_port_id),"},{"line_number":319,"context_line":"                    gw_lrouter_name).execute(check_error\u003dTrue)"},{"line_number":320,"context_line":"                self._delete_lrouter_in_ovn(router_id, is_gateway_router\u003dTrue)"},{"line_number":321,"context_line":"                LOG.error((\u0027Error in updating SNAT for router %s\u0027, router_id))"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _delete_router_ext_gw(self, context, router_id, router):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_0ddf4b3a","line":320,"range":{"start_line":313,"start_character":0,"end_line":320,"end_character":78},"in_reply_to":"7a8ec9b2_a1ed7890","updated":"2016-09-19 10:18:51.000000000","message":"Done","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":310,"context_line":"                    lrouter_name\u003dgw_lrouter_name)"},{"line_number":311,"context_line":"        except Exception:"},{"line_number":312,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":313,"context_line":"                self._disjoin_lrouter_and_gw_lrouter(router, transit_net_ports)"},{"line_number":314,"context_line":"                self._ovn.delete_static_route("},{"line_number":315,"context_line":"                    gw_lrouter_name, ip_prefix\u003d\u00270.0.0.0/0\u0027,"},{"line_number":316,"context_line":"                    nexthop\u003dext_gw_ip).execute(check_error\u003dTrue)"},{"line_number":317,"context_line":"                self._ovn.delete_lrouter_port("},{"line_number":318,"context_line":"                    utils.ovn_lrouter_port_name(gw_port_id),"},{"line_number":319,"context_line":"                    gw_lrouter_name).execute(check_error\u003dTrue)"},{"line_number":320,"context_line":"                self._delete_lrouter_in_ovn(router_id, is_gateway_router\u003dTrue)"},{"line_number":321,"context_line":"                LOG.error((\u0027Error in updating SNAT for router %s\u0027, router_id))"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _delete_router_ext_gw(self, context, router_id, router):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_a1ed7890","line":320,"range":{"start_line":313,"start_character":0,"end_line":320,"end_character":78},"in_reply_to":"9a89bdaa_2c72ba11","updated":"2016-09-13 17:53:18.000000000","message":"Yup, will try to see what can be done to simplify this","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                self._delete_lrouter_in_ovn(router_id, is_gateway_router\u003dTrue)"},{"line_number":321,"context_line":"                LOG.error((\u0027Error in updating SNAT for router %s\u0027, router_id))"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _delete_router_ext_gw(self, context, router_id, router):"},{"line_number":324,"context_line":"        transit_net_ports \u003d self._get_transit_network_ports()"},{"line_number":325,"context_line":"        gw_port_id \u003d router[\u0027gw_port_id\u0027]"},{"line_number":326,"context_line":"        gw_lrouter_name \u003d utils.ovn_gateway_router_name(router_id)"},{"line_number":327,"context_line":"        ext_gw_ip \u003d self._get_external_gateway_ip(context, router)"},{"line_number":328,"context_line":"        route \u003d [{\u0027destination\u0027: \u00270.0.0.0/0\u0027, \u0027nexthop\u0027: ext_gw_ip}]"},{"line_number":329,"context_line":"        self._update_lrouter_routes(context, router_id, [], route,"},{"line_number":330,"context_line":"                                    gw_lrouter_name)"},{"line_number":331,"context_line":"        self._ovn.delete_lrouter_port(utils.ovn_lrouter_port_name(gw_port_id),"},{"line_number":332,"context_line":"                                      gw_lrouter_name"},{"line_number":333,"context_line":"                                      ).execute(check_error\u003dTrue)"},{"line_number":334,"context_line":"        self._disjoin_lrouter_and_gw_lrouter(router, transit_net_ports)"},{"line_number":335,"context_line":"        self._delete_lrouter_in_ovn(router_id, is_gateway_router\u003dTrue)"},{"line_number":336,"context_line":"        self._check_and_delete_l3_admin_net(context)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def _join_lrouter_and_gw_lrouter(self, router, transit_net_ports):"},{"line_number":339,"context_line":"        router_id \u003d router[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_c7b04946","line":336,"range":{"start_line":323,"start_character":0,"end_line":336,"end_character":52},"updated":"2016-09-12 18:28:00.000000000","message":"Can this method be used to cleanup _add_router_ext_gw()?  Although the cleanup steps are slightly different and in a different order which seems odd.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":320,"context_line":"                self._delete_lrouter_in_ovn(router_id, is_gateway_router\u003dTrue)"},{"line_number":321,"context_line":"                LOG.error((\u0027Error in updating SNAT for router %s\u0027, router_id))"},{"line_number":322,"context_line":""},{"line_number":323,"context_line":"    def _delete_router_ext_gw(self, context, router_id, router):"},{"line_number":324,"context_line":"        transit_net_ports \u003d self._get_transit_network_ports()"},{"line_number":325,"context_line":"        gw_port_id \u003d router[\u0027gw_port_id\u0027]"},{"line_number":326,"context_line":"        gw_lrouter_name \u003d utils.ovn_gateway_router_name(router_id)"},{"line_number":327,"context_line":"        ext_gw_ip \u003d self._get_external_gateway_ip(context, router)"},{"line_number":328,"context_line":"        route \u003d [{\u0027destination\u0027: \u00270.0.0.0/0\u0027, \u0027nexthop\u0027: ext_gw_ip}]"},{"line_number":329,"context_line":"        self._update_lrouter_routes(context, router_id, [], route,"},{"line_number":330,"context_line":"                                    gw_lrouter_name)"},{"line_number":331,"context_line":"        self._ovn.delete_lrouter_port(utils.ovn_lrouter_port_name(gw_port_id),"},{"line_number":332,"context_line":"                                      gw_lrouter_name"},{"line_number":333,"context_line":"                                      ).execute(check_error\u003dTrue)"},{"line_number":334,"context_line":"        self._disjoin_lrouter_and_gw_lrouter(router, transit_net_ports)"},{"line_number":335,"context_line":"        self._delete_lrouter_in_ovn(router_id, is_gateway_router\u003dTrue)"},{"line_number":336,"context_line":"        self._check_and_delete_l3_admin_net(context)"},{"line_number":337,"context_line":""},{"line_number":338,"context_line":"    def _join_lrouter_and_gw_lrouter(self, router, transit_net_ports):"},{"line_number":339,"context_line":"        router_id \u003d router[\u0027id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_cdbf23ce","line":336,"range":{"start_line":323,"start_character":0,"end_line":336,"end_character":52},"in_reply_to":"9a89bdaa_c7b04946","updated":"2016-09-19 10:18:51.000000000","message":"Done","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":17224,"name":"MingShuang Xian","email":"xianms@cn.ibm.com","username":"MingShuangXian"},"change_message_id":"2e7dd3c347116d4064426b3063f6858f4cfe7aa8","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                                  lswitch_name\u003dlswitch_name,"},{"line_number":373,"context_line":"                                                  addresses\u003dgtsp_addresses,"},{"line_number":374,"context_line":"                                                  enabled\u003d\u0027True\u0027))"},{"line_number":375,"context_line":"            # 4. Add dtrp port in logical router"},{"line_number":376,"context_line":"            txn.add(self._ovn.add_lrouter_port(name\u003dgtrp_name,"},{"line_number":377,"context_line":"                                               lrouter\u003dgw_lrouter_name,"},{"line_number":378,"context_line":"                                               mac\u003dgtrp_mac,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_987897fa","line":375,"updated":"2016-09-11 14:42:52.000000000","message":"the comment should be # 4. Add gtrp port in gateway router","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                                  lswitch_name\u003dlswitch_name,"},{"line_number":373,"context_line":"                                                  addresses\u003dgtsp_addresses,"},{"line_number":374,"context_line":"                                                  enabled\u003d\u0027True\u0027))"},{"line_number":375,"context_line":"            # 4. Add dtrp port in logical router"},{"line_number":376,"context_line":"            txn.add(self._ovn.add_lrouter_port(name\u003dgtrp_name,"},{"line_number":377,"context_line":"                                               lrouter\u003dgw_lrouter_name,"},{"line_number":378,"context_line":"                                               mac\u003dgtrp_mac,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_2dd16723","line":375,"in_reply_to":"7a8ec9b2_01ed4c8b","updated":"2016-09-19 10:18:51.000000000","message":"Done","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":372,"context_line":"                                                  lswitch_name\u003dlswitch_name,"},{"line_number":373,"context_line":"                                                  addresses\u003dgtsp_addresses,"},{"line_number":374,"context_line":"                                                  enabled\u003d\u0027True\u0027))"},{"line_number":375,"context_line":"            # 4. Add dtrp port in logical router"},{"line_number":376,"context_line":"            txn.add(self._ovn.add_lrouter_port(name\u003dgtrp_name,"},{"line_number":377,"context_line":"                                               lrouter\u003dgw_lrouter_name,"},{"line_number":378,"context_line":"                                               mac\u003dgtrp_mac,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_01ed4c8b","line":375,"in_reply_to":"9a89bdaa_987897fa","updated":"2016-09-13 17:53:18.000000000","message":"wil fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":17224,"name":"MingShuang Xian","email":"xianms@cn.ibm.com","username":"MingShuangXian"},"change_message_id":"2e7dd3c347116d4064426b3063f6858f4cfe7aa8","unresolved":false,"context_lines":[{"line_number":417,"context_line":"            txn.add(self._ovn.delete_lswitch_port(gtsp_name, lswitch_name))"},{"line_number":418,"context_line":"            # 5. Delete dtsp port"},{"line_number":419,"context_line":"            txn.add(self._ovn.delete_lswitch_port(dtsp_name, lswitch_name))"},{"line_number":420,"context_line":"            # 6. Delete transit logical switch"},{"line_number":421,"context_line":"            txn.add(self._ovn.delete_lswitch(lswitch_name))"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"    def create_router(self, context, router):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_030c1c3a","line":420,"updated":"2016-09-11 14:42:52.000000000","message":"should check if there is vpn transit port before deleting the logical switch?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":498,"context_line":"                msg \u003d \u0027Unable to update lrouter for %s\u0027, id"},{"line_number":499,"context_line":"                LOG.error(msg)"},{"line_number":500,"context_line":"                router[\u0027router\u0027] \u003d original_router"},{"line_number":501,"context_line":"                super(OVNL3RouterPlugin, self).update_router(context, id,"},{"line_number":502,"context_line":"                                                             router)"},{"line_number":503,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_47bb59e5","line":500,"updated":"2016-09-12 18:28:00.000000000","message":"I don\u0027t think this should change the input parameter.  This is a general comment for this method.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":498,"context_line":"                msg \u003d \u0027Unable to update lrouter for %s\u0027, id"},{"line_number":499,"context_line":"                LOG.error(msg)"},{"line_number":500,"context_line":"                router[\u0027router\u0027] \u003d original_router"},{"line_number":501,"context_line":"                super(OVNL3RouterPlugin, self).update_router(context, id,"},{"line_number":502,"context_line":"                                                             router)"},{"line_number":503,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_4dccf388","line":500,"in_reply_to":"7a8ec9b2_01a46c55","updated":"2016-09-19 10:18:51.000000000","message":"Done","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":497,"context_line":"            with excutils.save_and_reraise_exception():"},{"line_number":498,"context_line":"                msg \u003d \u0027Unable to update lrouter for %s\u0027, id"},{"line_number":499,"context_line":"                LOG.error(msg)"},{"line_number":500,"context_line":"                router[\u0027router\u0027] \u003d original_router"},{"line_number":501,"context_line":"                super(OVNL3RouterPlugin, self).update_router(context, id,"},{"line_number":502,"context_line":"                                                             router)"},{"line_number":503,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_01a46c55","line":500,"in_reply_to":"9a89bdaa_47bb59e5","updated":"2016-09-13 17:53:18.000000000","message":"wil fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fa34425d36ccce492fc9ee9e28d8d3a8100da432","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        with self._ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":621,"context_line":"            txn.add(self._ovn.delete_lrouter(lrouter_name))"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def _get_networks_for_lrouter_port(self, context, port_fixed_ips):"},{"line_number":624,"context_line":"        networks \u003d set()"},{"line_number":625,"context_line":"        for fixed_ip in port_fixed_ips:"},{"line_number":626,"context_line":"            subnet_id \u003d fixed_ip[\u0027subnet_id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_f1734b4c","line":623,"updated":"2016-09-12 17:09:16.000000000","message":"This method is used by sync and shouldn\u0027t be renamed.  Renaming it caused the following error when I restarted neutron-server:\n\n\nTraceback (most recent call last):\n  File \"/usr/local/lib/python2.7/dist-packages/eventlet/hubs/hub.py\", line 457, in fire_timers\n    timer()\n  File \"/usr/local/lib/python2.7/dist-packages/eventlet/hubs/timer.py\", line 58, in __call__\n    cb(*args, **kw)\n  File \"/opt/stack/networking-ovn/networking_ovn/ovn_db_sync.py\", line 81, in _sync\n    self.sync_routers_and_rports(ctx)\n  File \"/opt/stack/networking-ovn/networking_ovn/ovn_db_sync.py\", line 317, in sync_routers_and_rports\n    self.l3_plugin.get_networks_for_lrouter_port(\nAttributeError: \u0027OVNL3RouterPlugin\u0027 object has no attribute \u0027get_networks_for_lrouter_port\u0027","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        with self._ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":621,"context_line":"            txn.add(self._ovn.delete_lrouter(lrouter_name))"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def _get_networks_for_lrouter_port(self, context, port_fixed_ips):"},{"line_number":624,"context_line":"        networks \u003d set()"},{"line_number":625,"context_line":"        for fixed_ip in port_fixed_ips:"},{"line_number":626,"context_line":"            subnet_id \u003d fixed_ip[\u0027subnet_id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_cda643c0","line":623,"in_reply_to":"7a8ec9b2_045c7a24","updated":"2016-09-19 10:18:51.000000000","message":"Done","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":620,"context_line":"        with self._ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":621,"context_line":"            txn.add(self._ovn.delete_lrouter(lrouter_name))"},{"line_number":622,"context_line":""},{"line_number":623,"context_line":"    def _get_networks_for_lrouter_port(self, context, port_fixed_ips):"},{"line_number":624,"context_line":"        networks \u003d set()"},{"line_number":625,"context_line":"        for fixed_ip in port_fixed_ips:"},{"line_number":626,"context_line":"            subnet_id \u003d fixed_ip[\u0027subnet_id\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_045c7a24","line":623,"in_reply_to":"9a89bdaa_f1734b4c","updated":"2016-09-13 17:53:18.000000000","message":"wil fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":809,"context_line":"            # OVNL3ExtrarouteTests.test_floatingip_association_on_unowned_"},{"line_number":810,"context_line":"            # router"},{"line_number":811,"context_line":"            router \u003d self.get_router(context.elevated(), router_id)"},{"line_number":812,"context_line":"            update_fip[\u0027fip_port_id\u0027] \u003d fip_db[\u0027floating_port_id\u0027]"},{"line_number":813,"context_line":"            update_fip[\u0027fip_net_id\u0027] \u003d fip[\u0027floating_network_id\u0027]"},{"line_number":814,"context_line":"            update_fip[\u0027logical_ip\u0027] \u003d fip[\u0027fixed_ip_address\u0027]"},{"line_number":815,"context_line":"            update_fip[\u0027external_ip\u0027] \u003d fip[\u0027floating_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_2249e3b7","line":812,"updated":"2016-09-12 18:28:00.000000000","message":"It would be nice to update neutron to return to avoid another DB read.  Consider adding a TODO.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":823,"context_line":"        return fip"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def delete_floatingip(self, context, id):"},{"line_number":826,"context_line":"        original_fip \u003d self.get_floatingip(context, id)"},{"line_number":827,"context_line":"        router_id \u003d original_fip.get(\u0027router_id\u0027)"},{"line_number":828,"context_line":"        super(OVNL3RouterPlugin, self).delete_floatingip(context, id)"},{"line_number":829,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_02913ff1","line":826,"updated":"2016-09-12 18:28:00.000000000","message":"Can\u0027t you used the floating IP dict returned by delete_floatingip?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":823,"context_line":"        return fip"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def delete_floatingip(self, context, id):"},{"line_number":826,"context_line":"        original_fip \u003d self.get_floatingip(context, id)"},{"line_number":827,"context_line":"        router_id \u003d original_fip.get(\u0027router_id\u0027)"},{"line_number":828,"context_line":"        super(OVNL3RouterPlugin, self).delete_floatingip(context, id)"},{"line_number":829,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_b4a4f14a","line":826,"in_reply_to":"7a8ec9b2_24afb6e4","updated":"2016-09-19 10:18:51.000000000","message":"delete_floatingip does not return anything, so had to call get_floatingip before deleting","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":823,"context_line":"        return fip"},{"line_number":824,"context_line":""},{"line_number":825,"context_line":"    def delete_floatingip(self, context, id):"},{"line_number":826,"context_line":"        original_fip \u003d self.get_floatingip(context, id)"},{"line_number":827,"context_line":"        router_id \u003d original_fip.get(\u0027router_id\u0027)"},{"line_number":828,"context_line":"        super(OVNL3RouterPlugin, self).delete_floatingip(context, id)"},{"line_number":829,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_24afb6e4","line":826,"in_reply_to":"9a89bdaa_02913ff1","updated":"2016-09-13 17:53:18.000000000","message":"I think that should work, will check and fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":858,"context_line":"            try:"},{"line_number":859,"context_line":"                self._update_floating_ip_in_ovn(context, previous_router_id,"},{"line_number":860,"context_line":"                                                update_fip, associate\u003dFalse)"},{"line_number":861,"context_line":"                fip_db[\u0027status\u0027] \u003d n_const.FLOATINGIP_STATUS_DOWN"},{"line_number":862,"context_line":"            except RuntimeError:"},{"line_number":863,"context_line":"                LOG.error(_LE(\u0027Unable to update floating ip in \u0027"},{"line_number":864,"context_line":"                              \u0027gateway router\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_9d220ea2","line":861,"updated":"2016-09-12 18:28:00.000000000","message":"What is the purpose of setting the original fip status here?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"79b4dcd31d571a2b3267348c0e68bece589b46a3","unresolved":false,"context_lines":[{"line_number":858,"context_line":"            try:"},{"line_number":859,"context_line":"                self._update_floating_ip_in_ovn(context, previous_router_id,"},{"line_number":860,"context_line":"                                                update_fip, associate\u003dFalse)"},{"line_number":861,"context_line":"                fip_db[\u0027status\u0027] \u003d n_const.FLOATINGIP_STATUS_DOWN"},{"line_number":862,"context_line":"            except RuntimeError:"},{"line_number":863,"context_line":"                LOG.error(_LE(\u0027Unable to update floating ip in \u0027"},{"line_number":864,"context_line":"                              \u0027gateway router\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_784ec1c2","line":861,"in_reply_to":"7a8ec9b2_04255aaa","updated":"2016-09-13 19:54:08.000000000","message":"But how does this update the database? I don\u0027t see fip_db used in a DB update.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":858,"context_line":"            try:"},{"line_number":859,"context_line":"                self._update_floating_ip_in_ovn(context, previous_router_id,"},{"line_number":860,"context_line":"                                                update_fip, associate\u003dFalse)"},{"line_number":861,"context_line":"                fip_db[\u0027status\u0027] \u003d n_const.FLOATINGIP_STATUS_DOWN"},{"line_number":862,"context_line":"            except RuntimeError:"},{"line_number":863,"context_line":"                LOG.error(_LE(\u0027Unable to update floating ip in \u0027"},{"line_number":864,"context_line":"                              \u0027gateway router\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_547acdbd","line":861,"in_reply_to":"7a8ec9b2_784ec1c2","updated":"2016-09-19 10:18:51.000000000","message":"\u0027fip_db[\u0027status\u0027] \u003d n_const.FLOATINGIP_STATUS_DOWN\u0027 is the code that updates the database. I\u0027ll revise this in my next patch by calling update_floatingip_status","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":858,"context_line":"            try:"},{"line_number":859,"context_line":"                self._update_floating_ip_in_ovn(context, previous_router_id,"},{"line_number":860,"context_line":"                                                update_fip, associate\u003dFalse)"},{"line_number":861,"context_line":"                fip_db[\u0027status\u0027] \u003d n_const.FLOATINGIP_STATUS_DOWN"},{"line_number":862,"context_line":"            except RuntimeError:"},{"line_number":863,"context_line":"                LOG.error(_LE(\u0027Unable to update floating ip in \u0027"},{"line_number":864,"context_line":"                              \u0027gateway router\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_04255aaa","line":861,"in_reply_to":"9a89bdaa_9d220ea2","updated":"2016-09-13 17:53:18.000000000","message":"There are some tests in tempest, which check for the state of the FIP.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":867,"context_line":"        if new_router_id:"},{"line_number":868,"context_line":"            router \u003d self.get_router(context.elevated(), new_router_id)"},{"line_number":869,"context_line":"            update_fip \u003d {}"},{"line_number":870,"context_line":"            update_fip[\u0027fip_port_id\u0027] \u003d fip_db[\u0027floating_port_id\u0027]"},{"line_number":871,"context_line":"            update_fip[\u0027fip_net_id\u0027] \u003d fip[\u0027floating_network_id\u0027]"},{"line_number":872,"context_line":"            update_fip[\u0027logical_ip\u0027] \u003d fip[\u0027fixed_ip_address\u0027]"},{"line_number":873,"context_line":"            update_fip[\u0027external_ip\u0027] \u003d fip[\u0027floating_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_9d704ea6","line":870,"range":{"start_line":870,"start_character":40,"end_line":870,"end_character":46},"updated":"2016-09-12 18:28:00.000000000","message":"Shouldn\u0027t this be the new fip?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":867,"context_line":"        if new_router_id:"},{"line_number":868,"context_line":"            router \u003d self.get_router(context.elevated(), new_router_id)"},{"line_number":869,"context_line":"            update_fip \u003d {}"},{"line_number":870,"context_line":"            update_fip[\u0027fip_port_id\u0027] \u003d fip_db[\u0027floating_port_id\u0027]"},{"line_number":871,"context_line":"            update_fip[\u0027fip_net_id\u0027] \u003d fip[\u0027floating_network_id\u0027]"},{"line_number":872,"context_line":"            update_fip[\u0027logical_ip\u0027] \u003d fip[\u0027fixed_ip_address\u0027]"},{"line_number":873,"context_line":"            update_fip[\u0027external_ip\u0027] \u003d fip[\u0027floating_ip_address\u0027]"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_14b5a57c","line":870,"range":{"start_line":870,"start_character":40,"end_line":870,"end_character":46},"in_reply_to":"9a89bdaa_9d704ea6","updated":"2016-09-19 10:18:51.000000000","message":"to get the floating_port_id from the new fip we have to read the DB again, besides since this is a case of updating the floatingip which was already created, \u0027floating_port_id\u0027 will be the same before and after update_floatingip","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":875,"context_line":"            try:"},{"line_number":876,"context_line":"                self._update_floating_ip_in_ovn(context, new_router_id,"},{"line_number":877,"context_line":"                                                update_fip)"},{"line_number":878,"context_line":"                fip_db[\u0027status\u0027] \u003d n_const.FLOATINGIP_STATUS_ACTIVE"},{"line_number":879,"context_line":"            except RuntimeError:"},{"line_number":880,"context_line":"                LOG.error(_LE(\u0027Unable to update floating ip in \u0027"},{"line_number":881,"context_line":"                              \u0027gateway router\u0027))"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_3d4e626f","line":878,"updated":"2016-09-12 18:28:00.000000000","message":"What is the purpose of setting the original fip status here?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":900,"context_line":"                    # ip port. Proper fix for this would be to redirect packets"},{"line_number":901,"context_line":"                    # destined to floating ip to the router port. This would"},{"line_number":902,"context_line":"                    # require changes in ovn-northd."},{"line_number":903,"context_line":"                    txn.add(self._ovn.delete_lswitch_port("},{"line_number":904,"context_line":"                        update[\u0027fip_port_id\u0027],"},{"line_number":905,"context_line":"                        utils.ovn_name(update[\u0027fip_net_id\u0027])))"},{"line_number":906,"context_line":"                txn.add(fip_apis[\u0027nat\u0027](gw_lrouter_name, type\u003d\u0027dnat_and_snat\u0027,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_8709e186","line":903,"updated":"2016-09-12 18:28:00.000000000","message":"This will cause problems on sync, because sync will recreate the lswitch port. Should we simply avoid creating the lswitch port to begin with?  Either way, sync needs to be updated to handle floating IP ports.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"fb333b15b89a6437bfc88779a24762f1f35bf61e","unresolved":false,"context_lines":[{"line_number":910,"context_line":"                                         nat_ip\u003dupdate[\u0027external_ip\u0027]))"},{"line_number":911,"context_line":"        except RuntimeError:"},{"line_number":912,"context_line":"            LOG.error(_LE(\u0027Unable to update NAT rule in gateway router\u0027))"},{"line_number":913,"context_line":"            raise RuntimeError"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"    def schedule_unhosted_routers(self):"},{"line_number":916,"context_line":"        valid_chassis_list \u003d self._sb_ovn.get_all_chassis()"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_677f7de0","line":913,"updated":"2016-09-12 18:28:00.000000000","message":"This should re-raise the original exception.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":910,"context_line":"                                         nat_ip\u003dupdate[\u0027external_ip\u0027]))"},{"line_number":911,"context_line":"        except RuntimeError:"},{"line_number":912,"context_line":"            LOG.error(_LE(\u0027Unable to update NAT rule in gateway router\u0027))"},{"line_number":913,"context_line":"            raise RuntimeError"},{"line_number":914,"context_line":""},{"line_number":915,"context_line":"    def schedule_unhosted_routers(self):"},{"line_number":916,"context_line":"        valid_chassis_list \u003d self._sb_ovn.get_all_chassis()"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_41ad9430","line":913,"in_reply_to":"9a89bdaa_677f7de0","updated":"2016-09-13 17:53:18.000000000","message":"wil fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"12472e3de3272fd4c4c92f5b0541cb312fa17253","unresolved":false,"context_lines":[{"line_number":861,"context_line":"        #     except Exception:"},{"line_number":862,"context_line":"        #         with excutils.save_and_reraise_exception():"},{"line_number":863,"context_line":"        #             LOG.error(_LE(\u0027Error in disassociating floatingip: %s\u0027),"},{"line_number":864,"context_line":"        #                       id)"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"    def update_floatingip(self, context, id, floatingip):"},{"line_number":867,"context_line":"        fip_db \u003d self._get_floatingip(context, id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a8ec9b2_48f7ccd2","line":864,"updated":"2016-09-21 21:32:22.000000000","message":"Should this be removed?  If not, can you add a comment clarifying while it\u0027s here and commented out?","commit_id":"6bcd59354d3431c31551b7b57037c759eb381565"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"de4d767a15a83bf38279f53b8483cad508a4b00a","unresolved":false,"context_lines":[{"line_number":861,"context_line":"        #     except Exception:"},{"line_number":862,"context_line":"        #         with excutils.save_and_reraise_exception():"},{"line_number":863,"context_line":"        #             LOG.error(_LE(\u0027Error in disassociating floatingip: %s\u0027),"},{"line_number":864,"context_line":"        #                       id)"},{"line_number":865,"context_line":""},{"line_number":866,"context_line":"    def update_floatingip(self, context, id, floatingip):"},{"line_number":867,"context_line":"        fip_db \u003d self._get_floatingip(context, id)"}],"source_content_type":"text/x-python","patch_set":16,"id":"7a8ec9b2_20537418","line":864,"in_reply_to":"7a8ec9b2_48f7ccd2","updated":"2016-09-21 22:43:02.000000000","message":"I\u0027ll remove this.","commit_id":"6bcd59354d3431c31551b7b57037c759eb381565"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b1d14d330e40ad02e9281d4be3245c23655c707d","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self._plugin_property \u003d None"},{"line_number":66,"context_line":"        self.scheduler \u003d l3_ovn_scheduler.get_scheduler()"},{"line_number":67,"context_line":"        self._admin_net_mgr \u003d None"},{"line_number":68,"context_line":"        self.l3_admin_net_cidr \u003d config.get_ovn_l3_admin_net_cidr()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @property"},{"line_number":71,"context_line":"    def _ovn(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_4e64fab7","line":68,"updated":"2016-11-03 12:43:59.000000000","message":"nit - why not use an _ here too?","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"ab85b527e20c011602305652184e966ca721236f","unresolved":false,"context_lines":[{"line_number":65,"context_line":"        self._plugin_property \u003d None"},{"line_number":66,"context_line":"        self.scheduler \u003d l3_ovn_scheduler.get_scheduler()"},{"line_number":67,"context_line":"        self._admin_net_mgr \u003d None"},{"line_number":68,"context_line":"        self.l3_admin_net_cidr \u003d config.get_ovn_l3_admin_net_cidr()"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    @property"},{"line_number":71,"context_line":"    def _ovn(self):"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_0ad48ee9","line":68,"in_reply_to":"ba5da102_4e64fab7","updated":"2016-11-04 04:26:29.000000000","message":"Done","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b1d14d330e40ad02e9281d4be3245c23655c707d","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            if subnet[\u0027ip_version\u0027] \u003d\u003d 4:"},{"line_number":160,"context_line":"                return ext_fixed_ip[\u0027ip_address\u0027]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        return None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _get_external_gateway_ip(self, context, router):"},{"line_number":165,"context_line":"        ext_gw_info \u003d router.get(\u0027external_gateway_info\u0027, {})"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_cef72ad1","line":162,"updated":"2016-11-03 12:43:59.000000000","message":"you do not need this line - None is returned by default","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"ab85b527e20c011602305652184e966ca721236f","unresolved":false,"context_lines":[{"line_number":159,"context_line":"            if subnet[\u0027ip_version\u0027] \u003d\u003d 4:"},{"line_number":160,"context_line":"                return ext_fixed_ip[\u0027ip_address\u0027]"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"        return None"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"    def _get_external_gateway_ip(self, context, router):"},{"line_number":165,"context_line":"        ext_gw_info \u003d router.get(\u0027external_gateway_info\u0027, {})"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_4ada0618","line":162,"in_reply_to":"ba5da102_cef72ad1","updated":"2016-11-04 04:26:29.000000000","message":"Done","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b1d14d330e40ad02e9281d4be3245c23655c707d","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            if subnet[\u0027ip_version\u0027] \u003d\u003d 4:"},{"line_number":171,"context_line":"                return subnet.get(\u0027gateway_ip\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        return None"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _is_snat_enabled(self, router):"},{"line_number":176,"context_line":"        enable_snat \u003d router.get(l3.EXTERNAL_GW_INFO, {}).get("}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_4e323aa8","line":173,"updated":"2016-11-03 12:43:59.000000000","message":"ditto","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"ab85b527e20c011602305652184e966ca721236f","unresolved":false,"context_lines":[{"line_number":170,"context_line":"            if subnet[\u0027ip_version\u0027] \u003d\u003d 4:"},{"line_number":171,"context_line":"                return subnet.get(\u0027gateway_ip\u0027)"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"        return None"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    def _is_snat_enabled(self, router):"},{"line_number":176,"context_line":"        enable_snat \u003d router.get(l3.EXTERNAL_GW_INFO, {}).get("}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_6ad50ae3","line":173,"in_reply_to":"ba5da102_4e323aa8","updated":"2016-11-04 04:26:29.000000000","message":"Done","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b1d14d330e40ad02e9281d4be3245c23655c707d","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            if found_nexthop:"},{"line_number":220,"context_line":"                break"},{"line_number":221,"context_line":"        if not lrouter_name:"},{"line_number":222,"context_line":"            msg \u003d (\u0027Unable to find router connected to nexthop %s to add \u0027"},{"line_number":223,"context_line":"                   \u0027static route in router %s\u0027) % (nexthop, router_id)"},{"line_number":224,"context_line":"            LOG.exception(msg)"},{"line_number":225,"context_line":"            raise exc.L3RouterPluginError(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_0e9a026e","line":222,"updated":"2016-11-03 12:43:59.000000000","message":"exceptions should be translated","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"ab85b527e20c011602305652184e966ca721236f","unresolved":false,"context_lines":[{"line_number":219,"context_line":"            if found_nexthop:"},{"line_number":220,"context_line":"                break"},{"line_number":221,"context_line":"        if not lrouter_name:"},{"line_number":222,"context_line":"            msg \u003d (\u0027Unable to find router connected to nexthop %s to add \u0027"},{"line_number":223,"context_line":"                   \u0027static route in router %s\u0027) % (nexthop, router_id)"},{"line_number":224,"context_line":"            LOG.exception(msg)"},{"line_number":225,"context_line":"            raise exc.L3RouterPluginError(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_aa09e296","line":222,"in_reply_to":"ba5da102_0e9a026e","updated":"2016-11-04 04:26:29.000000000","message":"Done","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b1d14d330e40ad02e9281d4be3245c23655c707d","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        if not lrouter_name:"},{"line_number":222,"context_line":"            msg \u003d (\u0027Unable to find router connected to nexthop %s to add \u0027"},{"line_number":223,"context_line":"                   \u0027static route in router %s\u0027) % (nexthop, router_id)"},{"line_number":224,"context_line":"            LOG.exception(msg)"},{"line_number":225,"context_line":"            raise exc.L3RouterPluginError(msg\u003dmsg)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        return lrouter_name"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_eef06ecb","line":224,"updated":"2016-11-03 12:43:59.000000000","message":"this is not an exception - you should use LOG.debug","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"ab85b527e20c011602305652184e966ca721236f","unresolved":false,"context_lines":[{"line_number":221,"context_line":"        if not lrouter_name:"},{"line_number":222,"context_line":"            msg \u003d (\u0027Unable to find router connected to nexthop %s to add \u0027"},{"line_number":223,"context_line":"                   \u0027static route in router %s\u0027) % (nexthop, router_id)"},{"line_number":224,"context_line":"            LOG.exception(msg)"},{"line_number":225,"context_line":"            raise exc.L3RouterPluginError(msg\u003dmsg)"},{"line_number":226,"context_line":""},{"line_number":227,"context_line":"        return lrouter_name"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_cafc5674","line":224,"in_reply_to":"ba5da102_eef06ecb","updated":"2016-11-04 04:26:29.000000000","message":"Done","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":1653,"name":"garyk","email":"gkotton@vmware.com","username":"garyk"},"change_message_id":"b1d14d330e40ad02e9281d4be3245c23655c707d","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                self._delete_router_ext_gw(context, router_id, router,"},{"line_number":256,"context_line":"                                           transit_net_ports, cleanup)"},{"line_number":257,"context_line":"                LOG.error(_LE(\u0027Unable to add external router port %(id)s to\u0027"},{"line_number":258,"context_line":"                              \u0027gateway_router %(name)s\u0027) %"},{"line_number":259,"context_line":"                          {\u0027id\u0027: port[\u0027id\u0027], \u0027name\u0027: gw_lrouter_name})"},{"line_number":260,"context_line":"        cleanup.append(\u0027ext_gw_port\u0027)"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_8e9b7265","line":258,"updated":"2016-11-03 12:43:59.000000000","message":"nit - please use a , instead of %","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"ab85b527e20c011602305652184e966ca721236f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"                self._delete_router_ext_gw(context, router_id, router,"},{"line_number":256,"context_line":"                                           transit_net_ports, cleanup)"},{"line_number":257,"context_line":"                LOG.error(_LE(\u0027Unable to add external router port %(id)s to\u0027"},{"line_number":258,"context_line":"                              \u0027gateway_router %(name)s\u0027) %"},{"line_number":259,"context_line":"                          {\u0027id\u0027: port[\u0027id\u0027], \u0027name\u0027: gw_lrouter_name})"},{"line_number":260,"context_line":"        cleanup.append(\u0027ext_gw_port\u0027)"},{"line_number":261,"context_line":""}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_eaff5a63","line":258,"in_reply_to":"ba5da102_8e9b7265","updated":"2016-11-04 04:26:29.000000000","message":"Done","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"}],"networking_ovn/l3/l3_ovn_admin_net.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class OVNL3AdminNetwork(object):"},{"line_number":31,"context_line":"    def __init__(self, nb_ovn_idl, plugin, cidr,):"},{"line_number":32,"context_line":"        self._admin_context \u003d n_context.get_admin_context()"},{"line_number":33,"context_line":"        self._nb_ovn_idl \u003d nb_ovn_idl"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_d65774c8","line":30,"updated":"2016-09-09 15:51:45.000000000","message":"Unit tests would be nice.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"79b4dcd31d571a2b3267348c0e68bece589b46a3","unresolved":false,"context_lines":[{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class OVNL3AdminNetwork(object):"},{"line_number":31,"context_line":"    def __init__(self, nb_ovn_idl, plugin, cidr,):"},{"line_number":32,"context_line":"        self._admin_context \u003d n_context.get_admin_context()"},{"line_number":33,"context_line":"        self._nb_ovn_idl \u003d nb_ovn_idl"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_d8cb551d","line":30,"in_reply_to":"9a89bdaa_d56eeffe","updated":"2016-09-13 19:54:08.000000000","message":"That\u0027s fine","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":27,"context_line":"LOG \u003d log.getLogger(__name__)"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class OVNL3AdminNetwork(object):"},{"line_number":31,"context_line":"    def __init__(self, nb_ovn_idl, plugin, cidr,):"},{"line_number":32,"context_line":"        self._admin_context \u003d n_context.get_admin_context()"},{"line_number":33,"context_line":"        self._nb_ovn_idl \u003d nb_ovn_idl"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_d56eeffe","line":30,"in_reply_to":"9a89bdaa_d65774c8","updated":"2016-09-13 17:53:18.000000000","message":"If its ok, i\u0027ll add the unit tests in a follow up patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class OVNL3AdminNetwork(object):"},{"line_number":31,"context_line":"    def __init__(self, nb_ovn_idl, plugin, cidr,):"},{"line_number":32,"context_line":"        self._admin_context \u003d n_context.get_admin_context()"},{"line_number":33,"context_line":"        self._nb_ovn_idl \u003d nb_ovn_idl"},{"line_number":34,"context_line":"        self._plugin \u003d plugin"},{"line_number":35,"context_line":"        self._cidr \u003d cidr"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_33ac32ed","line":32,"updated":"2016-09-09 15:51:45.000000000","message":"Saving the admin context can prove to be problematic.  Generally it should be obtained when needed.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class OVNL3AdminNetwork(object):"},{"line_number":31,"context_line":"    def __init__(self, nb_ovn_idl, plugin, cidr,):"},{"line_number":32,"context_line":"        self._admin_context \u003d n_context.get_admin_context()"},{"line_number":33,"context_line":"        self._nb_ovn_idl \u003d nb_ovn_idl"},{"line_number":34,"context_line":"        self._plugin \u003d plugin"},{"line_number":35,"context_line":"        self._cidr \u003d cidr"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_f5605303","line":32,"in_reply_to":"9a89bdaa_33ac32ed","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":29,"context_line":""},{"line_number":30,"context_line":"class OVNL3AdminNetwork(object):"},{"line_number":31,"context_line":"    def __init__(self, nb_ovn_idl, plugin, cidr,):"},{"line_number":32,"context_line":"        self._admin_context \u003d n_context.get_admin_context()"},{"line_number":33,"context_line":"        self._nb_ovn_idl \u003d nb_ovn_idl"},{"line_number":34,"context_line":"        self._plugin \u003d plugin"},{"line_number":35,"context_line":"        self._cidr \u003d cidr"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_4d5cf34a","line":32,"in_reply_to":"9a89bdaa_f5605303","updated":"2016-09-19 10:18:51.000000000","message":"Done","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _get_l3_admin_net_query_filter(self):"},{"line_number":38,"context_line":"        return {\u0027name\u0027: [ovn_const.OVN_L3_ADMIN_NET_NAME],"},{"line_number":39,"context_line":"                \u0027tenant_id\u0027: [\u0027 \u0027]}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_l3_admin_net_ports_query_filter(self, device_id, device_owner):"},{"line_number":42,"context_line":"        return {\u0027device_id\u0027: [device_id],"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_53be1600","line":39,"updated":"2016-09-09 15:51:45.000000000","message":"Why use a blank tenant id instead of admin?  This could be configurable. I\u0027m concerned that tools to purge orphaned resources will remove the L3 admin resources.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _get_l3_admin_net_query_filter(self):"},{"line_number":38,"context_line":"        return {\u0027name\u0027: [ovn_const.OVN_L3_ADMIN_NET_NAME],"},{"line_number":39,"context_line":"                \u0027tenant_id\u0027: [\u0027 \u0027]}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_l3_admin_net_ports_query_filter(self, device_id, device_owner):"},{"line_number":42,"context_line":"        return {\u0027device_id\u0027: [device_id],"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_c83620b4","line":39,"in_reply_to":"7a8ec9b2_93528edc","updated":"2016-09-19 10:18:51.000000000","message":"i have to check on this, i think i had a problem when querying neutron with None. I\u0027ll recheck and fix","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"79b4dcd31d571a2b3267348c0e68bece589b46a3","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _get_l3_admin_net_query_filter(self):"},{"line_number":38,"context_line":"        return {\u0027name\u0027: [ovn_const.OVN_L3_ADMIN_NET_NAME],"},{"line_number":39,"context_line":"                \u0027tenant_id\u0027: [\u0027 \u0027]}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_l3_admin_net_ports_query_filter(self, device_id, device_owner):"},{"line_number":42,"context_line":"        return {\u0027device_id\u0027: [device_id],"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_93528edc","line":39,"in_reply_to":"7a8ec9b2_de57c5c8","updated":"2016-09-13 19:54:08.000000000","message":"Okay, that\u0027s fine.  But why is blank used here but empty used on create?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    def _get_l3_admin_net_query_filter(self):"},{"line_number":38,"context_line":"        return {\u0027name\u0027: [ovn_const.OVN_L3_ADMIN_NET_NAME],"},{"line_number":39,"context_line":"                \u0027tenant_id\u0027: [\u0027 \u0027]}"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    def _get_l3_admin_net_ports_query_filter(self, device_id, device_owner):"},{"line_number":42,"context_line":"        return {\u0027device_id\u0027: [device_id],"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_de57c5c8","line":39,"in_reply_to":"9a89bdaa_53be1600","updated":"2016-09-13 17:53:18.000000000","message":"Neutron(l3_hamode) and other vendor implementation use a blank tenant id when creating networks/subnets programmatically which are hidden from user. A user with admin privileges will only be allowed to use blank tenant id. Your concern about tools purging orphaned resources will also apply if the tenant id is \"admin\", isn\u0027t it ?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f092bf38da05e1528aba856257bc770ff4057db0","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \u0027tenant_id\u0027: [\u0027 \u0027]}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _create_l3_admin_net(self, context):"},{"line_number":47,"context_line":"        net_params \u003d {\u0027network\u0027: {\u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":48,"context_line":"                                  \u0027name\u0027: ovn_const.OVN_L3_ADMIN_NET_NAME,"},{"line_number":49,"context_line":"                                  \u0027admin_state_up\u0027: False,"},{"line_number":50,"context_line":"                                  \u0027shared\u0027: False,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_be2355bc","line":47,"updated":"2016-09-12 15:40:56.000000000","message":"I think it would be good to include a description for the network to avoid confusing the cloud admin when this network is created.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \u0027tenant_id\u0027: [\u0027 \u0027]}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _create_l3_admin_net(self, context):"},{"line_number":47,"context_line":"        net_params \u003d {\u0027network\u0027: {\u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":48,"context_line":"                                  \u0027name\u0027: ovn_const.OVN_L3_ADMIN_NET_NAME,"},{"line_number":49,"context_line":"                                  \u0027admin_state_up\u0027: False,"},{"line_number":50,"context_line":"                                  \u0027shared\u0027: False,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_0d3d8bdc","line":47,"in_reply_to":"7a8ec9b2_de0ee5e4","updated":"2016-09-19 10:18:51.000000000","message":"Done","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                \u0027tenant_id\u0027: [\u0027 \u0027]}"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"    def _create_l3_admin_net(self, context):"},{"line_number":47,"context_line":"        net_params \u003d {\u0027network\u0027: {\u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":48,"context_line":"                                  \u0027name\u0027: ovn_const.OVN_L3_ADMIN_NET_NAME,"},{"line_number":49,"context_line":"                                  \u0027admin_state_up\u0027: False,"},{"line_number":50,"context_line":"                                  \u0027shared\u0027: False,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_de0ee5e4","line":47,"in_reply_to":"9a89bdaa_be2355bc","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6c2316e557c38bf1482b653fbc392b9e1bcaae63","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def _create_l3_admin_net(self, context):"},{"line_number":47,"context_line":"        net_params \u003d {\u0027network\u0027: {\u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":48,"context_line":"                                  \u0027name\u0027: ovn_const.OVN_L3_ADMIN_NET_NAME,"},{"line_number":49,"context_line":"                                  \u0027admin_state_up\u0027: False,"},{"line_number":50,"context_line":"                                  \u0027shared\u0027: False,"},{"line_number":51,"context_line":"                                  \u0027status\u0027: \u0027ACTIVE\u0027}}"},{"line_number":52,"context_line":"        return self._plugin.create_network(context, net_params)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_44535c17","line":49,"updated":"2016-09-12 15:50:41.000000000","message":"When does the admin state move to up?  It seems odd to keep the state down when the network is working fine.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":46,"context_line":"    def _create_l3_admin_net(self, context):"},{"line_number":47,"context_line":"        net_params \u003d {\u0027network\u0027: {\u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":48,"context_line":"                                  \u0027name\u0027: ovn_const.OVN_L3_ADMIN_NET_NAME,"},{"line_number":49,"context_line":"                                  \u0027admin_state_up\u0027: False,"},{"line_number":50,"context_line":"                                  \u0027shared\u0027: False,"},{"line_number":51,"context_line":"                                  \u0027status\u0027: \u0027ACTIVE\u0027}}"},{"line_number":52,"context_line":"        return self._plugin.create_network(context, net_params)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_1e95ad3f","line":49,"in_reply_to":"9a89bdaa_44535c17","updated":"2016-09-13 17:53:18.000000000","message":"This network we are creating is just a place holder which provides us ports with IP and MAC. There is no real use of this network and there is no traffic expected in this network. \n\nFor every router that has an external gateway, we create a transit logical switch in ovn and reuse the ports created in l3_admin_net to connect the gateway router and the distributed router","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f092bf38da05e1528aba856257bc770ff4057db0","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _create_l3_admin_subnet(self, context, net_id):"},{"line_number":55,"context_line":"        subnet_params \u003d {"},{"line_number":56,"context_line":"            \u0027subnet\u0027: {"},{"line_number":57,"context_line":"                \u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":58,"context_line":"                \u0027network_id\u0027: net_id,"},{"line_number":59,"context_line":"                \u0027admin_state_up\u0027: True,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_7e146d4c","line":56,"updated":"2016-09-12 15:40:56.000000000","message":"Similar comment about description.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _create_l3_admin_subnet(self, context, net_id):"},{"line_number":55,"context_line":"        subnet_params \u003d {"},{"line_number":56,"context_line":"            \u0027subnet\u0027: {"},{"line_number":57,"context_line":"                \u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":58,"context_line":"                \u0027network_id\u0027: net_id,"},{"line_number":59,"context_line":"                \u0027admin_state_up\u0027: True,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_8d299b9d","line":56,"in_reply_to":"7a8ec9b2_3e926958","updated":"2016-09-19 10:18:51.000000000","message":"Done","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":53,"context_line":""},{"line_number":54,"context_line":"    def _create_l3_admin_subnet(self, context, net_id):"},{"line_number":55,"context_line":"        subnet_params \u003d {"},{"line_number":56,"context_line":"            \u0027subnet\u0027: {"},{"line_number":57,"context_line":"                \u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":58,"context_line":"                \u0027network_id\u0027: net_id,"},{"line_number":59,"context_line":"                \u0027admin_state_up\u0027: True,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_3e926958","line":56,"in_reply_to":"9a89bdaa_7e146d4c","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                \u0027cidr\u0027: self._cidr,"},{"line_number":62,"context_line":"                \u0027enable_dhcp\u0027: False,"},{"line_number":63,"context_line":"                \u0027no-gateway\u0027: True,"},{"line_number":64,"context_line":"                \u0027allocation_pools\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":65,"context_line":"                \u0027ip_version\u0027: 4,"},{"line_number":66,"context_line":"                \u0027dns_nameservers\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":67,"context_line":"                \u0027host_routes\u0027: n_const.ATTR_NOT_SPECIFIED}}"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_2174dccd","line":64,"updated":"2016-09-09 15:51:45.000000000","message":"n_const.ATTR_NOT_SPECIFIED is the default","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                \u0027cidr\u0027: self._cidr,"},{"line_number":62,"context_line":"                \u0027enable_dhcp\u0027: False,"},{"line_number":63,"context_line":"                \u0027no-gateway\u0027: True,"},{"line_number":64,"context_line":"                \u0027allocation_pools\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":65,"context_line":"                \u0027ip_version\u0027: 4,"},{"line_number":66,"context_line":"                \u0027dns_nameservers\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":67,"context_line":"                \u0027host_routes\u0027: n_const.ATTR_NOT_SPECIFIED}}"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_6738f9d3","line":64,"in_reply_to":"7a8ec9b2_de8185fd","updated":"2016-09-19 10:18:51.000000000","message":"n_const.ATTR_NOT_SPECIFIED\u0027 is not the default for all the params. Without this there is a key error in allocate_subnet","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":61,"context_line":"                \u0027cidr\u0027: self._cidr,"},{"line_number":62,"context_line":"                \u0027enable_dhcp\u0027: False,"},{"line_number":63,"context_line":"                \u0027no-gateway\u0027: True,"},{"line_number":64,"context_line":"                \u0027allocation_pools\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":65,"context_line":"                \u0027ip_version\u0027: 4,"},{"line_number":66,"context_line":"                \u0027dns_nameservers\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":67,"context_line":"                \u0027host_routes\u0027: n_const.ATTR_NOT_SPECIFIED}}"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_de8185fd","line":64,"in_reply_to":"9a89bdaa_2174dccd","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                \u0027no-gateway\u0027: True,"},{"line_number":64,"context_line":"                \u0027allocation_pools\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":65,"context_line":"                \u0027ip_version\u0027: 4,"},{"line_number":66,"context_line":"                \u0027dns_nameservers\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":67,"context_line":"                \u0027host_routes\u0027: n_const.ATTR_NOT_SPECIFIED}}"},{"line_number":68,"context_line":"        return self._plugin.create_subnet(context, subnet_params)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _create_l3_admin_net_ports(self, context, net_id, names, device_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_4181e08e","line":67,"range":{"start_line":66,"start_character":0,"end_line":67,"end_character":59},"updated":"2016-09-09 15:51:45.000000000","message":"n_const.ATTR_NOT_SPECIFIED is the default","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"                \u0027no-gateway\u0027: True,"},{"line_number":64,"context_line":"                \u0027allocation_pools\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":65,"context_line":"                \u0027ip_version\u0027: 4,"},{"line_number":66,"context_line":"                \u0027dns_nameservers\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":67,"context_line":"                \u0027host_routes\u0027: n_const.ATTR_NOT_SPECIFIED}}"},{"line_number":68,"context_line":"        return self._plugin.create_subnet(context, subnet_params)"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"    def _create_l3_admin_net_ports(self, context, net_id, names, device_id,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_7e73114e","line":67,"range":{"start_line":66,"start_character":0,"end_line":67,"end_character":59},"in_reply_to":"9a89bdaa_4181e08e","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"f092bf38da05e1528aba856257bc770ff4057db0","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                   device_owner):"},{"line_number":72,"context_line":"        port_list \u003d []"},{"line_number":73,"context_line":"        for name in names:"},{"line_number":74,"context_line":"            port \u003d {\u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":75,"context_line":"                    \u0027network_id\u0027: net_id,"},{"line_number":76,"context_line":"                    \u0027name\u0027: name,"},{"line_number":77,"context_line":"                    \u0027admin_state_up\u0027: False,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_fe007d04","line":74,"updated":"2016-09-12 15:40:56.000000000","message":"Similar comment about description.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                   device_owner):"},{"line_number":72,"context_line":"        port_list \u003d []"},{"line_number":73,"context_line":"        for name in names:"},{"line_number":74,"context_line":"            port \u003d {\u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":75,"context_line":"                    \u0027network_id\u0027: net_id,"},{"line_number":76,"context_line":"                    \u0027name\u0027: name,"},{"line_number":77,"context_line":"                    \u0027admin_state_up\u0027: False,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_0d14ab4a","line":74,"in_reply_to":"7a8ec9b2_be93d94e","updated":"2016-09-19 10:18:51.000000000","message":"Done","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":71,"context_line":"                                   device_owner):"},{"line_number":72,"context_line":"        port_list \u003d []"},{"line_number":73,"context_line":"        for name in names:"},{"line_number":74,"context_line":"            port \u003d {\u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":75,"context_line":"                    \u0027network_id\u0027: net_id,"},{"line_number":76,"context_line":"                    \u0027name\u0027: name,"},{"line_number":77,"context_line":"                    \u0027admin_state_up\u0027: False,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_be93d94e","line":74,"in_reply_to":"9a89bdaa_fe007d04","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"6c2316e557c38bf1482b653fbc392b9e1bcaae63","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            port \u003d {\u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":75,"context_line":"                    \u0027network_id\u0027: net_id,"},{"line_number":76,"context_line":"                    \u0027name\u0027: name,"},{"line_number":77,"context_line":"                    \u0027admin_state_up\u0027: False,"},{"line_number":78,"context_line":"                    \u0027device_id\u0027: device_id,"},{"line_number":79,"context_line":"                    \u0027device_owner\u0027: device_owner,"},{"line_number":80,"context_line":"                    \u0027mac_address\u0027: n_const.ATTR_NOT_SPECIFIED,"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_0446b44e","line":77,"updated":"2016-09-12 15:50:41.000000000","message":"When does the admin state move to up?  It seems odd to keep the state down when the port is working fine.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":74,"context_line":"            port \u003d {\u0027tenant_id\u0027: \u0027\u0027,"},{"line_number":75,"context_line":"                    \u0027network_id\u0027: net_id,"},{"line_number":76,"context_line":"                    \u0027name\u0027: name,"},{"line_number":77,"context_line":"                    \u0027admin_state_up\u0027: False,"},{"line_number":78,"context_line":"                    \u0027device_id\u0027: device_id,"},{"line_number":79,"context_line":"                    \u0027device_owner\u0027: device_owner,"},{"line_number":80,"context_line":"                    \u0027mac_address\u0027: n_const.ATTR_NOT_SPECIFIED,"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_fe39e142","line":77,"in_reply_to":"9a89bdaa_0446b44e","updated":"2016-09-13 17:53:18.000000000","message":"The admin state never moves to UP. There is no traffic that is expected on these ports, so there is no need to enable the admin state.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \u0027admin_state_up\u0027: False,"},{"line_number":78,"context_line":"                    \u0027device_id\u0027: device_id,"},{"line_number":79,"context_line":"                    \u0027device_owner\u0027: device_owner,"},{"line_number":80,"context_line":"                    \u0027mac_address\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":81,"context_line":"                    \u0027fixed_ips\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":82,"context_line":"                    \u0027port_security_enabled\u0027: False}"},{"line_number":83,"context_line":"            port_list.append({\u0027port\u0027: port})"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_015ef844","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":60},"updated":"2016-09-09 15:51:45.000000000","message":"n_const.ATTR_NOT_SPECIFIED is the default","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":77,"context_line":"                    \u0027admin_state_up\u0027: False,"},{"line_number":78,"context_line":"                    \u0027device_id\u0027: device_id,"},{"line_number":79,"context_line":"                    \u0027device_owner\u0027: device_owner,"},{"line_number":80,"context_line":"                    \u0027mac_address\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":81,"context_line":"                    \u0027fixed_ips\u0027: n_const.ATTR_NOT_SPECIFIED,"},{"line_number":82,"context_line":"                    \u0027port_security_enabled\u0027: False}"},{"line_number":83,"context_line":"            port_list.append({\u0027port\u0027: port})"},{"line_number":84,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_5e49f5cf","line":81,"range":{"start_line":80,"start_character":0,"end_line":81,"end_character":60},"in_reply_to":"9a89bdaa_015ef844","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                try:"},{"line_number":124,"context_line":"                    self._create_l3_admin_subnet(context, net_id)"},{"line_number":125,"context_line":"                except Exception:"},{"line_number":126,"context_line":"                    LOG.error(_LE(\u0027Error in creating l3 admin subnet\u0027))"},{"line_number":127,"context_line":"                    network \u003d None"},{"line_number":128,"context_line":"            elif len(subnet_ids) \u003d\u003d 1:"},{"line_number":129,"context_line":"                if not self._validate_l3_admin_subnet(context, subnet_ids[0]):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_33cef25a","line":126,"updated":"2016-09-09 15:51:45.000000000","message":"It would be nice to know the error in the message. It may be better to LOG.exception here.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":123,"context_line":"                try:"},{"line_number":124,"context_line":"                    self._create_l3_admin_subnet(context, net_id)"},{"line_number":125,"context_line":"                except Exception:"},{"line_number":126,"context_line":"                    LOG.error(_LE(\u0027Error in creating l3 admin subnet\u0027))"},{"line_number":127,"context_line":"                    network \u003d None"},{"line_number":128,"context_line":"            elif len(subnet_ids) \u003d\u003d 1:"},{"line_number":129,"context_line":"                if not self._validate_l3_admin_subnet(context, subnet_ids[0]):"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_de0b457c","line":126,"in_reply_to":"9a89bdaa_33cef25a","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    network \u003d None"},{"line_number":128,"context_line":"            elif len(subnet_ids) \u003d\u003d 1:"},{"line_number":129,"context_line":"                if not self._validate_l3_admin_subnet(context, subnet_ids[0]):"},{"line_number":130,"context_line":"                    msg \u003d (\u0027Validation failed for l3 admin subnet %s\u0027,"},{"line_number":131,"context_line":"                           subnet_ids[0])"},{"line_number":132,"context_line":"                    LOG.error(msg)"},{"line_number":133,"context_line":"                    raise exc.L3AdminNetSubnetError(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_f3872ad5","line":130,"updated":"2016-09-09 15:51:45.000000000","message":"It would be nice to know what isn\u0027t valid.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":127,"context_line":"                    network \u003d None"},{"line_number":128,"context_line":"            elif len(subnet_ids) \u003d\u003d 1:"},{"line_number":129,"context_line":"                if not self._validate_l3_admin_subnet(context, subnet_ids[0]):"},{"line_number":130,"context_line":"                    msg \u003d (\u0027Validation failed for l3 admin subnet %s\u0027,"},{"line_number":131,"context_line":"                           subnet_ids[0])"},{"line_number":132,"context_line":"                    LOG.error(msg)"},{"line_number":133,"context_line":"                    raise exc.L3AdminNetSubnetError(msg\u003dmsg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_3e234907","line":130,"in_reply_to":"9a89bdaa_f3872ad5","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":17224,"name":"MingShuang Xian","email":"xianms@cn.ibm.com","username":"MingShuangXian"},"change_message_id":"2e7dd3c347116d4064426b3063f6858f4cfe7aa8","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":159,"context_line":"                    LOG.error(_LE(\u0027Error in creating l3 admin net ports %r\u0027),"},{"line_number":160,"context_line":"                              names)"},{"line_number":161,"context_line":"        elif len(ports) \u003d\u003d len(names):"},{"line_number":162,"context_line":"            if not self._validate_l3_admin_net_ports(ports, names):"},{"line_number":163,"context_line":"                msg \u003d (\u0027Validation failed for l3 admin net ports %r\u0027, names)"},{"line_number":164,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_a35d30ee","line":161,"updated":"2016-09-11 14:42:52.000000000","message":"VPN needs only 2 transit ports when HA disabled, but it needs more than two ports if HA is enabled. So one corner case is user creates some routers with VPNaaS without HA, then he enables the HA and creates new router with VPNaaS. In this case VPNaaS needs only 2 ports for some routers but needs more than 2 ports for other HA routers.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":158,"context_line":"                with excutils.save_and_reraise_exception():"},{"line_number":159,"context_line":"                    LOG.error(_LE(\u0027Error in creating l3 admin net ports %r\u0027),"},{"line_number":160,"context_line":"                              names)"},{"line_number":161,"context_line":"        elif len(ports) \u003d\u003d len(names):"},{"line_number":162,"context_line":"            if not self._validate_l3_admin_net_ports(ports, names):"},{"line_number":163,"context_line":"                msg \u003d (\u0027Validation failed for l3 admin net ports %r\u0027, names)"},{"line_number":164,"context_line":"                LOG.error(msg)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_9ec61d15","line":161,"in_reply_to":"9a89bdaa_a35d30ee","updated":"2016-09-13 17:53:18.000000000","message":"This should be handled in the VPN plugin.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                              names)"},{"line_number":161,"context_line":"        elif len(ports) \u003d\u003d len(names):"},{"line_number":162,"context_line":"            if not self._validate_l3_admin_net_ports(ports, names):"},{"line_number":163,"context_line":"                msg \u003d (\u0027Validation failed for l3 admin net ports %r\u0027, names)"},{"line_number":164,"context_line":"                LOG.error(msg)"},{"line_number":165,"context_line":"                raise exc.L3AdminNetPortsError(msg\u003dmsg)"},{"line_number":166,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_13548e52","line":163,"updated":"2016-09-09 15:51:45.000000000","message":"It would be nice to know what isn\u0027t valid.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":160,"context_line":"                              names)"},{"line_number":161,"context_line":"        elif len(ports) \u003d\u003d len(names):"},{"line_number":162,"context_line":"            if not self._validate_l3_admin_net_ports(ports, names):"},{"line_number":163,"context_line":"                msg \u003d (\u0027Validation failed for l3 admin net ports %r\u0027, names)"},{"line_number":164,"context_line":"                LOG.error(msg)"},{"line_number":165,"context_line":"                raise exc.L3AdminNetPortsError(msg\u003dmsg)"},{"line_number":166,"context_line":"        else:"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_9e78ddfa","line":163,"in_reply_to":"9a89bdaa_13548e52","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                LOG.error(msg)"},{"line_number":165,"context_line":"                raise exc.L3AdminNetPortsError(msg\u003dmsg)"},{"line_number":166,"context_line":"        else:"},{"line_number":167,"context_line":"            msg \u003d (\u0027Unexpected no of l3 admin net ports %d\u0027, len(ports))"},{"line_number":168,"context_line":"            LOG.error(msg)"},{"line_number":169,"context_line":"            raise exc.L3AdminNetPortsError(msg\u003dmsg)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_93dc1e1a","line":167,"range":{"start_line":167,"start_character":31,"end_line":167,"end_character":33},"updated":"2016-09-09 15:51:45.000000000","message":"number","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":164,"context_line":"                LOG.error(msg)"},{"line_number":165,"context_line":"                raise exc.L3AdminNetPortsError(msg\u003dmsg)"},{"line_number":166,"context_line":"        else:"},{"line_number":167,"context_line":"            msg \u003d (\u0027Unexpected no of l3 admin net ports %d\u0027, len(ports))"},{"line_number":168,"context_line":"            LOG.error(msg)"},{"line_number":169,"context_line":"            raise exc.L3AdminNetPortsError(msg\u003dmsg)"},{"line_number":170,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_fe8721d5","line":167,"range":{"start_line":167,"start_character":31,"end_line":167,"end_character":33},"in_reply_to":"9a89bdaa_93dc1e1a","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":17224,"name":"MingShuang Xian","email":"xianms@cn.ibm.com","username":"MingShuangXian"},"change_message_id":"2e7dd3c347116d4064426b3063f6858f4cfe7aa8","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        else:"},{"line_number":167,"context_line":"            msg \u003d (\u0027Unexpected no of l3 admin net ports %d\u0027, len(ports))"},{"line_number":168,"context_line":"            LOG.error(msg)"},{"line_number":169,"context_line":"            raise exc.L3AdminNetPortsError(msg\u003dmsg)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        return ports"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_d25d9bed","line":169,"updated":"2016-09-11 14:42:52.000000000","message":"should it be an exception if len(ports) \u003d\u003d AND create \u003d\u003d False?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":166,"context_line":"        else:"},{"line_number":167,"context_line":"            msg \u003d (\u0027Unexpected no of l3 admin net ports %d\u0027, len(ports))"},{"line_number":168,"context_line":"            LOG.error(msg)"},{"line_number":169,"context_line":"            raise exc.L3AdminNetPortsError(msg\u003dmsg)"},{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        return ports"},{"line_number":172,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_3e7429ce","line":169,"in_reply_to":"9a89bdaa_d25d9bed","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        return ports"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def delete_l3_admin_net_ports(self, context, names, device_id,"},{"line_number":174,"context_line":"                                  device_owner):"},{"line_number":175,"context_line":"        admin_context \u003d self._admin_context"},{"line_number":176,"context_line":"        net_id \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_36ac20ed","line":173,"updated":"2016-09-09 15:51:45.000000000","message":"The caller documents that the L3 admin network should be deleted.  If so, this function should ensure this is done.  Although, I wonder why it needs to be delete.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"1b2cfed7ac4e98d88412aa48302251f1d0a2c32f","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        return ports"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def delete_l3_admin_net_ports(self, context, names, device_id,"},{"line_number":174,"context_line":"                                  device_owner):"},{"line_number":175,"context_line":"        admin_context \u003d self._admin_context"},{"line_number":176,"context_line":"        net_id \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_a89c746a","line":173,"in_reply_to":"7a8ec9b2_73c8a275","updated":"2016-09-19 10:18:51.000000000","message":"The reason why we need a place holder is because we need ports with IP and MAC to connect the distributed router and the gateway router via the transit network. \n\nIf we create ports outside neutron then we need to store them in DB and i am not sure where","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"79b4dcd31d571a2b3267348c0e68bece589b46a3","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        return ports"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def delete_l3_admin_net_ports(self, context, names, device_id,"},{"line_number":174,"context_line":"                                  device_owner):"},{"line_number":175,"context_line":"        admin_context \u003d self._admin_context"},{"line_number":176,"context_line":"        net_id \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_73c8a275","line":173,"in_reply_to":"7a8ec9b2_bec039e2","updated":"2016-09-13 19:54:08.000000000","message":"I\u0027m still unclear why this place holder is needed in the neutron DB. A comment explaining this somewhere would be helpful. I was hoping this could be done only in OVN.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"58365dff9796e9dc3bf842669788a58238c8eaa8","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        return ports"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def delete_l3_admin_net_ports(self, context, names, device_id,"},{"line_number":174,"context_line":"                                  device_owner):"},{"line_number":175,"context_line":"        admin_context \u003d self._admin_context"},{"line_number":176,"context_line":"        net_id \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_c4ada29c","line":173,"in_reply_to":"9a89bdaa_36ac20ed","updated":"2016-09-12 19:23:08.000000000","message":"Operationally, the cloud admin will have trouble if he/she updates or deletes this L3 admin network, subnet or ports (e.g. I was unable to delete a router after deleting the network).  But as far as I can tell, this network is used as a placeholder.  Does it really even need to be stored in the neutron DB?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":170,"context_line":""},{"line_number":171,"context_line":"        return ports"},{"line_number":172,"context_line":""},{"line_number":173,"context_line":"    def delete_l3_admin_net_ports(self, context, names, device_id,"},{"line_number":174,"context_line":"                                  device_owner):"},{"line_number":175,"context_line":"        admin_context \u003d self._admin_context"},{"line_number":176,"context_line":"        net_id \u003d None"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_bec039e2","line":173,"in_reply_to":"9a89bdaa_36ac20ed","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch.\n\nThe l3_admin_net is only created when there is a router with external gateway. If there is no router with external gateway the l3_admin_net serves no purpose. Also, i thought that when user is cleaning up the resources, this would bring back to a clean state.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":32,"context_line":"                          \u0027router with the gateway router\u0027"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"class OVNL3AdminNetwork(object):"},{"line_number":36,"context_line":"    def __init__(self, nb_ovn_idl, plugin, cidr,):"},{"line_number":37,"context_line":"        self._nb_ovn_idl \u003d nb_ovn_idl"},{"line_number":38,"context_line":"        self._plugin \u003d plugin"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_7db46881","line":35,"updated":"2016-09-30 14:03:00.000000000","message":"Please add a TODO which references the IPAM bug that you opened.\n\nAlso, please add a TODO for unit tests?","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"}],"networking_ovn/ml2/mech_driver.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":376,"context_line":"        subnet \u003d context.current"},{"line_number":377,"context_line":"        if subnet[\u0027enable_dhcp\u0027] and config.is_ovn_dhcp():"},{"line_number":378,"context_line":"            with self._nb_ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":379,"context_line":"                subnet_dhcp_options \u003d self._nb_ovn.get_subnet_dhcp_options("},{"line_number":380,"context_line":"                    subnet[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_50db6c1b","line":377,"updated":"2016-09-09 15:51:45.000000000","message":"Why wouldn\u0027t we want to delete the subnet DHCP options if they exist? I suspect you were trying to work around the following problem which is now fixed: https://github.com/openstack/networking-ovn/commit/1f68a9cf838a47ec3b83216c36c560f79d80efae","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":374,"context_line":""},{"line_number":375,"context_line":"    def delete_subnet_postcommit(self, context):"},{"line_number":376,"context_line":"        subnet \u003d context.current"},{"line_number":377,"context_line":"        if subnet[\u0027enable_dhcp\u0027] and config.is_ovn_dhcp():"},{"line_number":378,"context_line":"            with self._nb_ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":379,"context_line":"                subnet_dhcp_options \u003d self._nb_ovn.get_subnet_dhcp_options("},{"line_number":380,"context_line":"                    subnet[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_3e5b4956","line":377,"in_reply_to":"9a89bdaa_50db6c1b","updated":"2016-09-13 17:53:18.000000000","message":"I\u0027ll remove this change. I was trying to work around the problem you mentioned","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                addresses +\u003d \u0027 \u0027 + ip[\u0027ip_address\u0027]"},{"line_number":590,"context_line":"            port_security \u003d self._get_allowed_addresses_from_port(port)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        if port.get(\u0027device_owner\u0027) in [const.DEVICE_OWNER_ROUTER_INTF,"},{"line_number":593,"context_line":"                                        const.DEVICE_OWNER_ROUTER_GW]:"},{"line_number":594,"context_line":"            options.update(self._nb_ovn.get_router_port_options(port[\u0027id\u0027]))"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        port_dhcpv4_options_info \u003d self._get_port_dhcpv4_options("},{"line_number":597,"context_line":"            port, original_port\u003doriginal_port)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_90c6d414","line":594,"range":{"start_line":592,"start_character":0,"end_line":594,"end_character":76},"updated":"2016-09-09 15:51:45.000000000","message":"To avoid race conditions on port update, this logic should be moved within the update transaction.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"79b4dcd31d571a2b3267348c0e68bece589b46a3","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                addresses +\u003d \u0027 \u0027 + ip[\u0027ip_address\u0027]"},{"line_number":590,"context_line":"            port_security \u003d self._get_allowed_addresses_from_port(port)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        if port.get(\u0027device_owner\u0027) in [const.DEVICE_OWNER_ROUTER_INTF,"},{"line_number":593,"context_line":"                                        const.DEVICE_OWNER_ROUTER_GW]:"},{"line_number":594,"context_line":"            options.update(self._nb_ovn.get_router_port_options(port[\u0027id\u0027]))"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        port_dhcpv4_options_info \u003d self._get_port_dhcpv4_options("},{"line_number":597,"context_line":"            port, original_port\u003doriginal_port)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_939c4e6b","line":594,"range":{"start_line":592,"start_character":0,"end_line":594,"end_character":76},"in_reply_to":"7a8ec9b2_5e2f35a1","updated":"2016-09-13 19:54:08.000000000","message":"I was thinking within the lswitch port update.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":589,"context_line":"                addresses +\u003d \u0027 \u0027 + ip[\u0027ip_address\u0027]"},{"line_number":590,"context_line":"            port_security \u003d self._get_allowed_addresses_from_port(port)"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"        if port.get(\u0027device_owner\u0027) in [const.DEVICE_OWNER_ROUTER_INTF,"},{"line_number":593,"context_line":"                                        const.DEVICE_OWNER_ROUTER_GW]:"},{"line_number":594,"context_line":"            options.update(self._nb_ovn.get_router_port_options(port[\u0027id\u0027]))"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"        port_dhcpv4_options_info \u003d self._get_port_dhcpv4_options("},{"line_number":597,"context_line":"            port, original_port\u003doriginal_port)"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_5e2f35a1","line":594,"range":{"start_line":592,"start_character":0,"end_line":594,"end_character":76},"in_reply_to":"9a89bdaa_90c6d414","updated":"2016-09-13 17:53:18.000000000","message":"Can you pls be more specific about moving the code to update transaction ? Which update transaction","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"}],"networking_ovn/ovsdb/commands.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"171a6a726d39abe8a0c8189b7665189de3c2dcb7","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        self.api._tables[\u0027DHCP_Options\u0027].rows[self.row_uuid].delete()"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"class AddNATRuleInLRouterCommand(BaseCommand):"},{"line_number":762,"context_line":"    def __init__(self, api, lrouter, **columns):"},{"line_number":763,"context_line":"        super(AddNATRuleInLRouterCommand, self).__init__(api)"},{"line_number":764,"context_line":"        self.lrouter \u003d lrouter"}],"source_content_type":"text/x-python","patch_set":12,"id":"fa7ab95a_554be7b0","line":761,"updated":"2016-09-02 10:29:28.000000000","message":"This is a unit test infrastructure available now to test commands.","commit_id":"056dfc82171482e1a0dc6a756289ad71515a1c7f"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"8a29287bbef4e0fa7f7ce89d73259d4274fbe100","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        self.api._tables[\u0027DHCP_Options\u0027].rows[self.row_uuid].delete()"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"class AddNATRuleInLRouterCommand(BaseCommand):"},{"line_number":762,"context_line":"    def __init__(self, api, lrouter, **columns):"},{"line_number":763,"context_line":"        super(AddNATRuleInLRouterCommand, self).__init__(api)"},{"line_number":764,"context_line":"        self.lrouter \u003d lrouter"}],"source_content_type":"text/x-python","patch_set":12,"id":"9a89bdaa_63453f41","line":761,"in_reply_to":"fa7ab95a_554be7b0","updated":"2016-09-08 19:47:06.000000000","message":"I\u0027ll update the next patch with the unit tests","commit_id":"056dfc82171482e1a0dc6a756289ad71515a1c7f"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        self.api._tables[\u0027DHCP_Options\u0027].rows[self.row_uuid].delete()"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"class AddNATRuleInLRouterCommand(BaseCommand):"},{"line_number":762,"context_line":"    def __init__(self, api, lrouter, **columns):"},{"line_number":763,"context_line":"        super(AddNATRuleInLRouterCommand, self).__init__(api)"},{"line_number":764,"context_line":"        self.lrouter \u003d lrouter"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_76c5c859","line":761,"updated":"2016-09-09 15:51:45.000000000","message":"Unit tests for these commands would be nice.  But I\u0027m okay with a follow-on patch set.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":758,"context_line":"        self.api._tables[\u0027DHCP_Options\u0027].rows[self.row_uuid].delete()"},{"line_number":759,"context_line":""},{"line_number":760,"context_line":""},{"line_number":761,"context_line":"class AddNATRuleInLRouterCommand(BaseCommand):"},{"line_number":762,"context_line":"    def __init__(self, api, lrouter, **columns):"},{"line_number":763,"context_line":"        super(AddNATRuleInLRouterCommand, self).__init__(api)"},{"line_number":764,"context_line":"        self.lrouter \u003d lrouter"}],"source_content_type":"text/x-python","patch_set":14,"id":"7a8ec9b2_3e098932","line":761,"in_reply_to":"9a89bdaa_76c5c859","updated":"2016-09-13 17:53:18.000000000","message":"Will add in the follow up patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":778,"context_line":"        lrouter.verify(\u0027nat\u0027)"},{"line_number":779,"context_line":"        nat \u003d getattr(lrouter, \u0027nat\u0027, [])"},{"line_number":780,"context_line":"        nat.append(row.uuid)"},{"line_number":781,"context_line":"        setattr(lrouter, \u0027nat\u0027, nat)"},{"line_number":782,"context_line":""},{"line_number":783,"context_line":""},{"line_number":784,"context_line":"class DeleteNATRuleInLRouterCommand(BaseCommand):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_f6d558b9","line":781,"range":{"start_line":781,"start_character":0,"end_line":781,"end_character":36},"updated":"2016-09-09 15:51:45.000000000","message":"Would this benefit from using OVS transaction mutate support? Depending on the order of merges, either this patch or https://review.openstack.org/#/c/351861 should be updated.  Similar comments for other commands.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"2f67544f7402c61757a668e5f3cdf2bc94698e4b","unresolved":false,"context_lines":[{"line_number":859,"context_line":"                                          \u0027name\u0027, self.lport)"},{"line_number":860,"context_line":""},{"line_number":861,"context_line":"        except idlutils.RowNotFound:"},{"line_number":862,"context_line":"            msg \u003d _(\"Logical Switch Port %s does not exist\") % self.port"},{"line_number":863,"context_line":"            raise RuntimeError(msg)"},{"line_number":864,"context_line":""},{"line_number":865,"context_line":"        lport.verify(\u0027options\u0027)"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_7673084e","line":862,"updated":"2016-09-09 15:51:45.000000000","message":"Should this error be ignore by using if_exists parameter?","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":786,"context_line":"        self.api._tables[\u0027DHCP_Options\u0027].rows[self.row_uuid].delete()"},{"line_number":787,"context_line":""},{"line_number":788,"context_line":""},{"line_number":789,"context_line":"class AddNATRuleInLRouterCommand(commands.BaseCommand):"},{"line_number":790,"context_line":"    def __init__(self, api, lrouter, **columns):"},{"line_number":791,"context_line":"        super(AddNATRuleInLRouterCommand, self).__init__(api)"},{"line_number":792,"context_line":"        self.lrouter \u003d lrouter"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_22d71fee","line":789,"updated":"2016-09-30 14:03:00.000000000","message":"Can you please add a TODO for unit tests?","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":803,"context_line":"        row \u003d txn.insert(self.api._tables[\u0027NAT\u0027])"},{"line_number":804,"context_line":"        for col, val in self.columns.items():"},{"line_number":805,"context_line":"            setattr(row, col, val)"},{"line_number":806,"context_line":"        lrouter.verify(\u0027nat\u0027)"},{"line_number":807,"context_line":"        nat \u003d getattr(lrouter, \u0027nat\u0027, [])"},{"line_number":808,"context_line":"        nat.append(row.uuid)"},{"line_number":809,"context_line":"        setattr(lrouter, \u0027nat\u0027, nat)"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"class DeleteNATRuleInLRouterCommand(commands.BaseCommand):"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_22739f16","line":809,"range":{"start_line":806,"start_character":0,"end_line":809,"end_character":36},"updated":"2016-09-30 14:03:00.000000000","message":"You can use ovs transaction mutate here (i.e. _addvalue_to_list()) here.  However given bug 1629099, maybe just add a TODO to use mutate.","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":809,"context_line":"        setattr(lrouter, \u0027nat\u0027, nat)"},{"line_number":810,"context_line":""},{"line_number":811,"context_line":""},{"line_number":812,"context_line":"class DeleteNATRuleInLRouterCommand(commands.BaseCommand):"},{"line_number":813,"context_line":"    def __init__(self, api, lrouter, type, logical_ip, external_ip,"},{"line_number":814,"context_line":"                 if_exists):"},{"line_number":815,"context_line":"        super(DeleteNATRuleInLRouterCommand, self).__init__(api)"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_c2567b5b","line":812,"updated":"2016-09-30 14:03:00.000000000","message":"Same comments as above.","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":844,"context_line":"        setattr(lrouter, \u0027nat\u0027, nats)"},{"line_number":845,"context_line":""},{"line_number":846,"context_line":""},{"line_number":847,"context_line":"class AddNatIpToLRPortPeerOptionsCommand(commands.BaseCommand):"},{"line_number":848,"context_line":"    def __init__(self, api, lport, nat_ip):"},{"line_number":849,"context_line":"        super(AddNatIpToLRPortPeerOptionsCommand, self).__init__(api)"},{"line_number":850,"context_line":"        self.lport \u003d lport"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_42c98b25","line":847,"updated":"2016-09-30 14:03:00.000000000","message":"Same comments as above.","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":875,"context_line":"        lport.options \u003d options"},{"line_number":876,"context_line":""},{"line_number":877,"context_line":""},{"line_number":878,"context_line":"class DeleteNatIpFromLRPortPeerOptionsCommand(commands.BaseCommand):"},{"line_number":879,"context_line":"    def __init__(self, api, lport, nat_ip):"},{"line_number":880,"context_line":"        super(DeleteNatIpFromLRPortPeerOptionsCommand, self).__init__(api)"},{"line_number":881,"context_line":"        self.lport \u003d lport"}],"source_content_type":"text/x-python","patch_set":18,"id":"3a98d1f4_c28bdbc1","line":878,"updated":"2016-09-30 14:03:00.000000000","message":"Same comments as above.","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"93c42f4259188ecb96a4579c43c9edcb12d8780e","unresolved":false,"context_lines":[{"line_number":883,"context_line":"            msg \u003d _(\"Logical Router %s does not exist\") % self.lrouter"},{"line_number":884,"context_line":"            raise RuntimeError(msg)"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"        lrouter.verify(\u0027nat\u0027)"},{"line_number":887,"context_line":"        nats \u003d getattr(lrouter, \u0027nat\u0027, [])"},{"line_number":888,"context_line":"        for nat in nats:"},{"line_number":889,"context_line":"            type \u003d getattr(nat, \u0027type\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_aca12648","line":886,"updated":"2016-11-03 12:30:47.000000000","message":"You could add a TODO here for transaction mutate support.","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"ab85b527e20c011602305652184e966ca721236f","unresolved":false,"context_lines":[{"line_number":883,"context_line":"            msg \u003d _(\"Logical Router %s does not exist\") % self.lrouter"},{"line_number":884,"context_line":"            raise RuntimeError(msg)"},{"line_number":885,"context_line":""},{"line_number":886,"context_line":"        lrouter.verify(\u0027nat\u0027)"},{"line_number":887,"context_line":"        nats \u003d getattr(lrouter, \u0027nat\u0027, [])"},{"line_number":888,"context_line":"        for nat in nats:"},{"line_number":889,"context_line":"            type \u003d getattr(nat, \u0027type\u0027, \u0027\u0027)"}],"source_content_type":"text/x-python","patch_set":19,"id":"ba5da102_0a42cead","line":886,"in_reply_to":"ba5da102_aca12648","updated":"2016-11-04 04:26:29.000000000","message":"Done","commit_id":"e00a55cdc36f173cc1253b45801fa4804d8520b6"}],"networking_ovn/tests/unit/l3/test_l3_ovn.py":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"48ce19df6a6aeb0030d72333cb5cd8791adff4b1","unresolved":false,"context_lines":[{"line_number":729,"context_line":"            assert_called_once_with(\u0027gw-port-id\u0027, nat_ip\u003d\u0027192.168.0.10\u0027)"},{"line_number":730,"context_line":""},{"line_number":731,"context_line":""},{"line_number":732,"context_line":"class OVNL3ExtrarouteTests(test_l3.L3NatDBIntTestCase,"},{"line_number":733,"context_line":"                           test_extraroute.ExtraRouteDBTestCaseBase):"},{"line_number":734,"context_line":""},{"line_number":735,"context_line":"    def setUp(self):"}],"source_content_type":"text/x-python","patch_set":14,"id":"9a89bdaa_f87410ff","line":732,"updated":"2016-09-12 16:26:35.000000000","message":"We should also consider running neutron\u0027s ExtGwModeIntTestCase unit tests.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"}],"releasenotes/notes/networking-ovn-0df373f5a7b22d19.yaml":[{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"476d8fc3530befd6a49d18b391b3b8ad497e49ae","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * Layer-2 (native OVN implementation)"},{"line_number":11,"context_line":"    * Layer-3 (native OVN implementation or conventional layer-3 agent)"},{"line_number":12,"context_line":"      The native OVN implementation supports distributed routing. However,"},{"line_number":13,"context_line":"      it currently lacks support for floating IP addresses, NAT, and the"},{"line_number":14,"context_line":"      metadata proxy."},{"line_number":15,"context_line":"    * DHCP (native OVN implementation or conventional DHCP agent)"},{"line_number":16,"context_line":"      The native implementation supports distributed DHCP. However,"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"9a89bdaa_82023c0a","line":13,"range":{"start_line":13,"start_character":37,"end_line":13,"end_character":63},"updated":"2016-09-08 21:15:35.000000000","message":"You can remove these restrictions.","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"bf5d7e45f44d7ca4f22dce954f90ccec071529a6","unresolved":false,"context_lines":[{"line_number":10,"context_line":"    * Layer-2 (native OVN implementation)"},{"line_number":11,"context_line":"    * Layer-3 (native OVN implementation or conventional layer-3 agent)"},{"line_number":12,"context_line":"      The native OVN implementation supports distributed routing. However,"},{"line_number":13,"context_line":"      it currently lacks support for floating IP addresses, NAT, and the"},{"line_number":14,"context_line":"      metadata proxy."},{"line_number":15,"context_line":"    * DHCP (native OVN implementation or conventional DHCP agent)"},{"line_number":16,"context_line":"      The native implementation supports distributed DHCP. However,"}],"source_content_type":"text/x-yaml","patch_set":14,"id":"7a8ec9b2_213a48ce","line":13,"range":{"start_line":13,"start_character":37,"end_line":13,"end_character":63},"in_reply_to":"9a89bdaa_82023c0a","updated":"2016-09-13 17:53:18.000000000","message":"Will fix it in the next patch","commit_id":"1cf8c46431853d932a23589f99a0a57acee414e1"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    conventional agents:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    * Layer-2 (native OVN implementation)"},{"line_number":11,"context_line":"    * Layer-3 (native OVN implementation or conventional layer-3 agent)"},{"line_number":12,"context_line":"      The native OVN implementation supports distributed routing. However,"},{"line_number":13,"context_line":"      it currently lacks support for floating IP addresses, NAT, and the"},{"line_number":14,"context_line":"      metadata proxy."},{"line_number":15,"context_line":"    * DHCP (native OVN implementation or conventional DHCP agent)"},{"line_number":16,"context_line":"      The native implementation supports distributed DHCP. However,"},{"line_number":17,"context_line":"      it currently lacks support for IPv6, internal DNS, and metadata"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a98d1f4_02b86329","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":21},"updated":"2016-09-30 14:03:00.000000000","message":"This needs to be updated.  However, you need a new release note since these features have already been released.","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":18589,"name":"Chandra Sekhar Vejendla","email":"csvejend@us.ibm.com","username":"chandrav"},"change_message_id":"daa79d1bf0479f776b51bbc8f3670018e6771413","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    conventional agents:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    * Layer-2 (native OVN implementation)"},{"line_number":11,"context_line":"    * Layer-3 (native OVN implementation or conventional layer-3 agent)"},{"line_number":12,"context_line":"      The native OVN implementation supports distributed routing. However,"},{"line_number":13,"context_line":"      it currently lacks support for floating IP addresses, NAT, and the"},{"line_number":14,"context_line":"      metadata proxy."},{"line_number":15,"context_line":"    * DHCP (native OVN implementation or conventional DHCP agent)"},{"line_number":16,"context_line":"      The native implementation supports distributed DHCP. However,"},{"line_number":17,"context_line":"      it currently lacks support for IPv6, internal DNS, and metadata"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ba5da102_b4f5ab84","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":21},"in_reply_to":"3a98d1f4_02b86329","updated":"2016-10-27 03:59:22.000000000","message":"What should the name of the new release note be ?? I see ovn_dhcpv6-xxxx.yaml, ovsdb_connection-yyyy.yaml, something on these lines ? Also i am not sure if xxxx and yyyy have any meaning and is there a way to generate them ?","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"628077f3489f88c2d92ff213860bccf008c517c6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    conventional agents:"},{"line_number":9,"context_line":""},{"line_number":10,"context_line":"    * Layer-2 (native OVN implementation)"},{"line_number":11,"context_line":"    * Layer-3 (native OVN implementation or conventional layer-3 agent)"},{"line_number":12,"context_line":"      The native OVN implementation supports distributed routing. However,"},{"line_number":13,"context_line":"      it currently lacks support for floating IP addresses, NAT, and the"},{"line_number":14,"context_line":"      metadata proxy."},{"line_number":15,"context_line":"    * DHCP (native OVN implementation or conventional DHCP agent)"},{"line_number":16,"context_line":"      The native implementation supports distributed DHCP. However,"},{"line_number":17,"context_line":"      it currently lacks support for IPv6, internal DNS, and metadata"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"ba5da102_45dd7b41","line":14,"range":{"start_line":11,"start_character":0,"end_line":14,"end_character":21},"in_reply_to":"ba5da102_b4f5ab84","updated":"2016-10-27 08:01:03.000000000","message":"The prefix is your choice.  You could use the \"ovn-native-snat-floatingip-\" prefix.  The xxxx and yyyy comes from generating the release note.  Please see http://docs.openstack.org/project-team-guide/release-management.html#managing-release-notes for how to do this.","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"},{"author":{"_account_id":8410,"name":"Richard Theis","email":"rtheis@us.ibm.com","username":"rtheis"},"change_message_id":"dddae25ca604755abca696e3baeb354823e70842","unresolved":false,"context_lines":[{"line_number":41,"context_line":"    * ``Neutron external network``"},{"line_number":42,"context_line":"    * ``Neutron Extra DHCP opts``"},{"line_number":43,"context_line":"    * ``Neutron Extra Route``"},{"line_number":44,"context_line":"    * ``Neutron L3 Configurable external gateway mode``"},{"line_number":45,"context_line":"    * ``Neutron L3 Router``"},{"line_number":46,"context_line":"    * ``Network MTU``"},{"line_number":47,"context_line":"    * ``Port Binding``"}],"source_content_type":"text/x-yaml","patch_set":18,"id":"3a98d1f4_028f8375","line":44,"updated":"2016-09-30 14:03:00.000000000","message":"See above","commit_id":"84fc8a83af3dfcb0351a450d74e997538fcc3be6"}]}
