)]}'
{"networking_ovn/ml2/qos_driver.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"270826d858d6449f9adbbee2584ac9cbd5fff072","unresolved":false,"context_lines":[{"line_number":161,"context_line":"                # There is nothing we need to do"},{"line_number":162,"context_line":"                return"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"            with self._driver._nb_ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":165,"context_line":"                if action \u003d\u003d \"mark\":"},{"line_number":166,"context_line":"                    cmd \u003d self._driver._nb_ovn.mark_dscp("},{"line_number":167,"context_line":"                        utils.ovn_name(network), port, policy_id,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_dc049919","line":164,"updated":"2016-11-10 09:45:46.000000000","message":"Instead of having a txn for each item in details, we can have one transaction and run the for loop inside it.","commit_id":"7803a5d54308938bd0eeedc55e2d3891eec8ec80"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"270826d858d6449f9adbbee2584ac9cbd5fff072","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        network_bindings \u003d policy.get_bound_networks()"},{"line_number":232,"context_line":"        for network_id in network_bindings:"},{"line_number":233,"context_line":"            self._update_network_ports(context, network_id, options)"},{"line_number":234,"context_line":"            with self._driver._nb_ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":235,"context_line":"                txn.add(self._driver._nb_ovn.sync_dscp_policy_change("},{"line_number":236,"context_line":"                    utils.ovn_name(network_id), None, policy.id,"},{"line_number":237,"context_line":"                    dscp_rule.id if dscp_rule else None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_d0c39d87","line":234,"updated":"2016-11-10 09:45:46.000000000","message":"Same comment as L164","commit_id":"7803a5d54308938bd0eeedc55e2d3891eec8ec80"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"86b649fb2c139e16b21baeaf566c03787a5b253b","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        network_bindings \u003d policy.get_bound_networks()"},{"line_number":232,"context_line":"        for network_id in network_bindings:"},{"line_number":233,"context_line":"            self._update_network_ports(context, network_id, options)"},{"line_number":234,"context_line":"            with self._driver._nb_ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":235,"context_line":"                txn.add(self._driver._nb_ovn.sync_dscp_policy_change("},{"line_number":236,"context_line":"                    utils.ovn_name(network_id), None, policy.id,"},{"line_number":237,"context_line":"                    dscp_rule.id if dscp_rule else None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"1a6eadb0_ccb445f4","line":234,"in_reply_to":"3a71b18c_db292039","updated":"2016-12-13 12:50:48.000000000","message":"That\u0027s right. I am fine with this","commit_id":"7803a5d54308938bd0eeedc55e2d3891eec8ec80"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"458aa59311438b6c8058803a9d557d753d017e5b","unresolved":false,"context_lines":[{"line_number":231,"context_line":"        network_bindings \u003d policy.get_bound_networks()"},{"line_number":232,"context_line":"        for network_id in network_bindings:"},{"line_number":233,"context_line":"            self._update_network_ports(context, network_id, options)"},{"line_number":234,"context_line":"            with self._driver._nb_ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":235,"context_line":"                txn.add(self._driver._nb_ovn.sync_dscp_policy_change("},{"line_number":236,"context_line":"                    utils.ovn_name(network_id), None, policy.id,"},{"line_number":237,"context_line":"                    dscp_rule.id if dscp_rule else None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_db292039","line":234,"in_reply_to":"9a629dbe_d0c39d87","updated":"2016-12-09 12:07:24.000000000","message":"I noticed that there is one transaction __enter__ happening in update_network_ports() method. Won\u0027t it become a proble if I move this statement upwards.","commit_id":"7803a5d54308938bd0eeedc55e2d3891eec8ec80"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"270826d858d6449f9adbbee2584ac9cbd5fff072","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        for port_id in port_bindings:"},{"line_number":243,"context_line":"            port \u003d self._plugin.get_port(context, port_id)"},{"line_number":244,"context_line":"            self._driver.update_port(port, port, options)"},{"line_number":245,"context_line":"            with self._driver._nb_ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":246,"context_line":"                txn.add(self._driver._nb_ovn.sync_dscp_policy_change("},{"line_number":247,"context_line":"                    utils.ovn_name(port[\u0027network_id\u0027]), port_id, policy.id,"},{"line_number":248,"context_line":"                    dscp_rule.id if dscp_rule else None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"9a629dbe_10ba750a","line":245,"updated":"2016-11-10 09:45:46.000000000","message":"Same comment as L164","commit_id":"7803a5d54308938bd0eeedc55e2d3891eec8ec80"},{"author":{"_account_id":8298,"name":"Babu Shanmugam","email":"bschanmu@redhat.com","username":"anbu"},"change_message_id":"458aa59311438b6c8058803a9d557d753d017e5b","unresolved":false,"context_lines":[{"line_number":242,"context_line":"        for port_id in port_bindings:"},{"line_number":243,"context_line":"            port \u003d self._plugin.get_port(context, port_id)"},{"line_number":244,"context_line":"            self._driver.update_port(port, port, options)"},{"line_number":245,"context_line":"            with self._driver._nb_ovn.transaction(check_error\u003dTrue) as txn:"},{"line_number":246,"context_line":"                txn.add(self._driver._nb_ovn.sync_dscp_policy_change("},{"line_number":247,"context_line":"                    utils.ovn_name(port[\u0027network_id\u0027]), port_id, policy.id,"},{"line_number":248,"context_line":"                    dscp_rule.id if dscp_rule else None,"}],"source_content_type":"text/x-python","patch_set":6,"id":"3a71b18c_9bd6c825","line":245,"in_reply_to":"9a629dbe_10ba750a","updated":"2016-12-09 12:07:24.000000000","message":"Same as line 234.","commit_id":"7803a5d54308938bd0eeedc55e2d3891eec8ec80"}]}