)]}'
{"networking_ovn/common/acl.py":[{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"b212bad7ff47c78e385e12118453704396b9dd05","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # If the protocol doesn\u0027t match with anything just return an empty"},{"line_number":86,"context_line":"    # match string"},{"line_number":87,"context_line":"    if protocol is None:"},{"line_number":88,"context_line":"        return match"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    # Get the protocol by its number, it\u0027s easier for comparison"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_c38733b5","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":24},"updated":"2017-04-20 09:12:41.000000000","message":"If the protocol is digit but not in supported names, like \u00275\u0027, it returns here. Actually we can support it.","commit_id":"689d3023877380b08ea4c780fee64d4b714ac21c"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"f0ff94ecc3777aece0ef388d5707b8bc6d944101","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # If the protocol doesn\u0027t match with anything just return an empty"},{"line_number":86,"context_line":"    # match string"},{"line_number":87,"context_line":"    if protocol is None:"},{"line_number":88,"context_line":"        return match"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    # Get the protocol by its number, it\u0027s easier for comparison"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_3253bf41","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":24},"in_reply_to":"7ffa3b31_bc3d682c","updated":"2017-04-20 10:13:42.000000000","message":"I am fine with this checking.\nAnd None is valid value for r[\u0027protocol\u0027], indicating all protocols.","commit_id":"689d3023877380b08ea4c780fee64d4b714ac21c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f5891b17d026ab2c8864f93f37c289ed493b613f","unresolved":false,"context_lines":[{"line_number":84,"context_line":""},{"line_number":85,"context_line":"    # If the protocol doesn\u0027t match with anything just return an empty"},{"line_number":86,"context_line":"    # match string"},{"line_number":87,"context_line":"    if protocol is None:"},{"line_number":88,"context_line":"        return match"},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"    # Get the protocol by its number, it\u0027s easier for comparison"}],"source_content_type":"text/x-python","patch_set":2,"id":"7ffa3b31_bc3d682c","line":87,"range":{"start_line":87,"start_character":4,"end_line":87,"end_character":24},"in_reply_to":"7ffa3b31_c38733b5","updated":"2017-04-20 09:20:35.000000000","message":"Oh right, I was assuming that we only supported the protocols that are part of the IP_PROTOCOL_MAP() from neutron-lib.\n\nSo, we can look for a range here, 0-255 ?\n\nThanks for the tips!","commit_id":"689d3023877380b08ea4c780fee64d4b714ac21c"}],"networking_ovn/tests/unit/common/test_acl.py":[{"author":{"_account_id":14885,"name":"Daniel Mellado","email":"dmellado@redhat.com","username":"daniel-mellado"},"change_message_id":"d45141a4c05148300ddcc0e75719e584e0c55d62","unresolved":false,"context_lines":[{"line_number":414,"context_line":"        sg_rule \u003d {\u0027port_range_min\u0027: None,"},{"line_number":415,"context_line":"                   \u0027port_range_max\u0027: None}"},{"line_number":416,"context_line":""},{"line_number":417,"context_line":"        # There are covered in other tests in this file, they also use"},{"line_number":418,"context_line":"        # names instead of numbers for readability/debbugability."},{"line_number":419,"context_line":"        skip_protos \u003d (const.PROTO_NUM_TCP, const.PROTO_NUM_UDP,"},{"line_number":420,"context_line":"                       const.PROTO_NUM_SCTP, const.PROTO_NUM_ICMP,"},{"line_number":421,"context_line":"                       const.PROTO_NUM_IPV6_ICMP)"}],"source_content_type":"text/x-python","patch_set":3,"id":"7ffa3b31_2d2472ae","line":418,"range":{"start_line":417,"start_character":8,"end_line":418,"end_character":65},"updated":"2017-04-20 16:16:12.000000000","message":"Could you pls improve this comment? For me is not really clear what do you mean with this. /me assumes maybe protocol and ports range, but could be deff improved.","commit_id":"65156a94fb9f058576110d5f79000737d9ed86ce"}]}