)]}'
{"devstack/local.conf.sample":[{"author":{"_account_id":1561,"name":"Russell Bryant","email":"rbryant@redhat.com","username":"russellb"},"change_message_id":"edd25592aad2b463584f53329aea4fc3f2eaff8e","unresolved":false,"context_lines":[{"line_number":36,"context_line":"disable_service q-dhcp"},{"line_number":37,"context_line":"disable_service q-meta"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Disable Horizon and Cinder, not needed for the tests"},{"line_number":40,"context_line":"disable_service horizon"},{"line_number":41,"context_line":"disable_service cinder c-sch c-api c-vol"},{"line_number":42,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5ff73747_60cc4361","line":39,"updated":"2017-05-03 13:24:29.000000000","message":"I think of comments here as being written to someone trying out OVN with DevStack.  I would separate the two as something like:\n\n    # Horizon (the web UI) is disabled by default to speed up DevStack a bit.\n    # You may enable it here if you would like to use it.\n    disable_service horizon\n    #enable_service horizon\n\nand then another section for Cinder ...","commit_id":"5e03d936e192ce3f11c72689067a3c3f43cf45b1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"208ef259c9512b30348c5da1f2c110537bbefdd2","unresolved":false,"context_lines":[{"line_number":36,"context_line":"disable_service q-dhcp"},{"line_number":37,"context_line":"disable_service q-meta"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Disable Horizon and Cinder, not needed for the tests"},{"line_number":40,"context_line":"disable_service horizon"},{"line_number":41,"context_line":"disable_service cinder c-sch c-api c-vol"},{"line_number":42,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5ff73747_435391e3","line":39,"in_reply_to":"5ff73747_60cc4361","updated":"2017-05-03 13:38:21.000000000","message":"Very good point, I will make it more user-friendly! Thanks","commit_id":"5e03d936e192ce3f11c72689067a3c3f43cf45b1"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"f2b781f21b5120e12f913ebbc25ccdaf4058bca8","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# Horizon (the web UI) is disabled by default to speed up DevStack a"},{"line_number":40,"context_line":"# bit. You may enable it here if you would like to use it."},{"line_number":41,"context_line":"disable_service horizon"},{"line_number":42,"context_line":"#enable_service horizon"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Cinder (OpenStack Block Storage) is disabled by default to speed up"},{"line_number":45,"context_line":"# DevStack a bit. You may enable it here if you would like to use it."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f044301_76db8d7b","line":42,"updated":"2017-05-10 11:34:32.000000000","message":"-1 from me simply because, a developer who wants to setup ovn with devstack can edit the local.conf and disable horizon if needed.\n\nAn operator or someone who wants to try out ovn with devstack probably would expect horizon service.\n\nI would suggest enable horizon and have the \"disable_service horizon\" commented so that a developer can toggle easily.","commit_id":"0e86a89b25827b6faac6bfd66a759efadd07bab6"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"469b83d1e08286da68f7bab7bc08dd57032b2d26","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# Horizon (the web UI) is disabled by default to speed up DevStack a"},{"line_number":40,"context_line":"# bit. You may enable it here if you would like to use it."},{"line_number":41,"context_line":"disable_service horizon"},{"line_number":42,"context_line":"#enable_service horizon"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Cinder (OpenStack Block Storage) is disabled by default to speed up"},{"line_number":45,"context_line":"# DevStack a bit. You may enable it here if you would like to use it."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f044301_d63ee189","line":42,"in_reply_to":"3f044301_76db8d7b","updated":"2017-05-10 11:36:12.000000000","message":"Is local.conf.sample used by the CI scripts to setup devstack ?","commit_id":"0e86a89b25827b6faac6bfd66a759efadd07bab6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e5348dec4eb301c4c97f6323888311dc914aaf39","unresolved":false,"context_lines":[{"line_number":39,"context_line":"# Horizon (the web UI) is disabled by default to speed up DevStack a"},{"line_number":40,"context_line":"# bit. You may enable it here if you would like to use it."},{"line_number":41,"context_line":"disable_service horizon"},{"line_number":42,"context_line":"#enable_service horizon"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Cinder (OpenStack Block Storage) is disabled by default to speed up"},{"line_number":45,"context_line":"# DevStack a bit. You may enable it here if you would like to use it."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f044301_ca23c255","line":42,"in_reply_to":"3f044301_d63ee189","updated":"2017-05-11 10:06:27.000000000","message":"Fair enough, yeah let\u0027s leave horizon enabled by default then.\n\nRe: local.conf.sample in the gate, I don\u0027t think it\u0027s used there at least I couldn\u0027t find any reference of it in project-config or devstack-gate.\n\nThis config is used in our testing docs: https://docs.openstack.org/developer/networking-ovn/testing.html","commit_id":"0e86a89b25827b6faac6bfd66a759efadd07bab6"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"f2b781f21b5120e12f913ebbc25ccdaf4058bca8","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"# Cinder (OpenStack Block Storage) is disabled by default to speed up"},{"line_number":45,"context_line":"# DevStack a bit. You may enable it here if you would like to use it."},{"line_number":46,"context_line":"disable_service cinder c-sch c-api c-vol"},{"line_number":47,"context_line":"#enable_service cinder c-sch c-api c-vol"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"# How to connect to ovsdb-server hosting the OVN NB database."}],"source_content_type":"application/octet-stream","patch_set":2,"id":"3f044301_f6d8bd7b","line":46,"updated":"2017-05-10 11:34:32.000000000","message":"+1 for this","commit_id":"0e86a89b25827b6faac6bfd66a759efadd07bab6"}]}