)]}'
{"networking_ovn/tests/functional/test_trunk_driver.py":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"4ae39b90a28831c7f861a5e8cb9648e595c043e9","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_subport_add(self):"},{"line_number":89,"context_line":"        with self.trunk() as trunk:"},{"line_number":90,"context_line":"            with self.subport() as subport:"},{"line_number":91,"context_line":"                self.trunk_plugin.add_subports(self.context, trunk[\u0027id\u0027],"},{"line_number":92,"context_line":"                                               {\u0027sub_ports\u0027: [subport]})"},{"line_number":93,"context_line":"                new_trunk \u003d self.trunk_plugin.get_trunk(self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_c022a5a4","line":90,"updated":"2017-05-09 18:36:52.000000000","message":"I am little confused about the usage of the functions, self.trunk() and self.subport() and the way they are used as\n\n - call trunk() and then subport()\n - call subport() and then trunk().\n\nAfter carefully looking into it, it makes sense. Just wondering if this can be simplified.\n\nI am fine with the code otherwise :)","commit_id":"1b69edc83759e4d12df420852dbf987199a1a735"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"5af194be084b1765e30d7c2bfc860f90553f4e89","unresolved":false,"context_lines":[{"line_number":87,"context_line":""},{"line_number":88,"context_line":"    def test_subport_add(self):"},{"line_number":89,"context_line":"        with self.trunk() as trunk:"},{"line_number":90,"context_line":"            with self.subport() as subport:"},{"line_number":91,"context_line":"                self.trunk_plugin.add_subports(self.context, trunk[\u0027id\u0027],"},{"line_number":92,"context_line":"                                               {\u0027sub_ports\u0027: [subport]})"},{"line_number":93,"context_line":"                new_trunk \u003d self.trunk_plugin.get_trunk(self.context,"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f044301_723de0c2","line":90,"in_reply_to":"3f044301_c022a5a4","updated":"2017-05-10 04:10:30.000000000","message":"Sorry this confused you, I will make the call sequence same as others, subport() and then trunk().","commit_id":"1b69edc83759e4d12df420852dbf987199a1a735"}]}