)]}'
{"networking_ovn/common/acl.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"b175d84d256976986de0ff042219ec1f39d0d1b0","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    return add_sg_rule_acl_for_port(port, r, match)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"def _acl_columns_name_severity_supported(ovn):"},{"line_number":278,"context_line":"    return (ovn._tables[\u0027ACL\u0027].columns.get(\u0027name\u0027)"},{"line_number":279,"context_line":"            and ovn._tables[\u0027ACL\u0027].columns.get(\u0027severity\u0027))"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"def update_acls_for_security_group(plugin,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_0e178c53","line":279,"range":{"start_line":277,"start_character":0,"end_line":279,"end_character":59},"updated":"2017-08-14 08:12:28.000000000","message":"I know we\u0027ve discussed this but maybe we can try to think of a way to handle this kind of schema changes at a more general level? Instead of having a function which checks for \u0027name\u0027 and \u0027severity\u0027, how do you feel about some generic function which pops out the columns that are not supported in the schema and call that function from where we want to have backwards compat?\n\nNot sure if my suggestion fits the general compatibility model we want to support in networking-ovn. Anyways, I\u0027m fine with this :)","commit_id":"158c9a54478692df0f9a89e9790eb7cbf726250e"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"f6ec546b53aa36ae730611e5b7e39220c1fb96ff","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    return add_sg_rule_acl_for_port(port, r, match)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"def _acl_columns_name_severity_supported(ovn):"},{"line_number":278,"context_line":"    return (ovn._tables[\u0027ACL\u0027].columns.get(\u0027name\u0027)"},{"line_number":279,"context_line":"            and ovn._tables[\u0027ACL\u0027].columns.get(\u0027severity\u0027))"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"def update_acls_for_security_group(plugin,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_c4ce0581","line":279,"range":{"start_line":277,"start_character":0,"end_line":279,"end_character":59},"in_reply_to":"9f436f4f_0e178c53","updated":"2017-08-14 09:08:56.000000000","message":"You mean, like some generic function that\u0027s going to pop out any unknown columns and throw a warning?\n\nThat would be cool, but, I don\u0027t know that could lead to unexpected issues later in time which are hard to figure out.\n\nAnd in some cases you may want to translate columns into other stuff, which is compatible (thinking of gw chassis case)...\n\nI\u0027d look back into the idea when we have a few cases, may be we could document it as a note next to this function?","commit_id":"158c9a54478692df0f9a89e9790eb7cbf726250e"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"9b388a6fd3390926a93b63c7181d2d1760207f05","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    return add_sg_rule_acl_for_port(port, r, match)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"def _acl_columns_name_severity_supported(ovn):"},{"line_number":278,"context_line":"    return (ovn._tables[\u0027ACL\u0027].columns.get(\u0027name\u0027)"},{"line_number":279,"context_line":"            and ovn._tables[\u0027ACL\u0027].columns.get(\u0027severity\u0027))"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""},{"line_number":282,"context_line":"def update_acls_for_security_group(plugin,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f436f4f_779da864","line":279,"range":{"start_line":277,"start_character":0,"end_line":279,"end_character":59},"in_reply_to":"9f436f4f_c4ce0581","updated":"2017-08-15 11:11:51.000000000","message":"This method just tries to check if \"name\" and \"severity\" fields exist, so it looks better to use \"in\" operator.\n\n  return (\"name\" in ovs._tables[\"ACL].columns and\n          \"severity\" in ovs._tables[\"ACL].columns)\n\nGeneric approach itself would be nice, but I think we need some way to know the schema version of the table(s) to achieve this in a reliable way.","commit_id":"158c9a54478692df0f9a89e9790eb7cbf726250e"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"8163cd4f66c3ffc82e0985b970637158842d7b95","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    return add_sg_rule_acl_for_port(port, r, match)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"def _acl_columns_name_severity_supported(ovn):"},{"line_number":278,"context_line":"    return (ovn._tables[\u0027ACL\u0027].columns.get(\u0027name\u0027)"},{"line_number":279,"context_line":"            and ovn._tables[\u0027ACL\u0027].columns.get(\u0027severity\u0027))"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_7d62ecaf","line":277,"range":{"start_line":277,"start_character":41,"end_line":277,"end_character":44},"updated":"2017-08-17 10:09:26.000000000","message":"The parameter name \u0027ovn\u0027 is confusing.\nThis is IDL right ?\nMay be \u0027nb_idl\u0027 ? or something more appropriate.","commit_id":"cf235cbffa6345d9ae5fadc8922d8dff7b91063c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"15c416ab22b824f6786f79f3486026cad2e19d01","unresolved":false,"context_lines":[{"line_number":274,"context_line":"    return add_sg_rule_acl_for_port(port, r, match)"},{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"def _acl_columns_name_severity_supported(ovn):"},{"line_number":278,"context_line":"    return (ovn._tables[\u0027ACL\u0027].columns.get(\u0027name\u0027)"},{"line_number":279,"context_line":"            and ovn._tables[\u0027ACL\u0027].columns.get(\u0027severity\u0027))"},{"line_number":280,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_98147eea","line":277,"range":{"start_line":277,"start_character":41,"end_line":277,"end_character":44},"in_reply_to":"9f436f4f_7d62ecaf","updated":"2017-08-17 11:01:22.000000000","message":"Yes, but I was following existing code https://github.com/openstack/networking-ovn/blob/master/networking_ovn/common/acl.py#L312","commit_id":"cf235cbffa6345d9ae5fadc8922d8dff7b91063c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"870b48f689f049ee285226ef7a706ea6a2d6650b","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"def _acl_columns_name_severity_supported(ovn):"},{"line_number":278,"context_line":"    return (ovn._tables[\u0027ACL\u0027].columns.get(\u0027name\u0027)"},{"line_number":279,"context_line":"            and ovn._tables[\u0027ACL\u0027].columns.get(\u0027severity\u0027))"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_9ddfd064","line":278,"range":{"start_line":278,"start_character":12,"end_line":278,"end_character":50},"updated":"2017-08-17 10:10:01.000000000","message":"Do you want to check the existence of \u0027name\u0027 field or want to check a name field is empty or not? I think what you want to do is the former.\nIf my understanding is correct, I would suggest the following instead:\n\n  \u0027name\u0027 in ovs._tables[\u0027ACL\u0027].columns\n\nIn the current code, if \u0027name\u0027 exists but it has an empty value, \u0027name\u0027 field will be pop-ed below. I think there is no case where name is empty but it is better to use a code which describe what we want to do actually.","commit_id":"cf235cbffa6345d9ae5fadc8922d8dff7b91063c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"15c416ab22b824f6786f79f3486026cad2e19d01","unresolved":false,"context_lines":[{"line_number":275,"context_line":""},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"def _acl_columns_name_severity_supported(ovn):"},{"line_number":278,"context_line":"    return (ovn._tables[\u0027ACL\u0027].columns.get(\u0027name\u0027)"},{"line_number":279,"context_line":"            and ovn._tables[\u0027ACL\u0027].columns.get(\u0027severity\u0027))"},{"line_number":280,"context_line":""},{"line_number":281,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_78d55a1b","line":278,"range":{"start_line":278,"start_character":12,"end_line":278,"end_character":50},"in_reply_to":"9f436f4f_9ddfd064","updated":"2017-08-17 11:01:22.000000000","message":"sure","commit_id":"cf235cbffa6345d9ae5fadc8922d8dff7b91063c"}],"networking_ovn/tests/functional/test_ovn_db_sync.py":[{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"870b48f689f049ee285226ef7a706ea6a2d6650b","unresolved":false,"context_lines":[{"line_number":540,"context_line":"        dhcp_acls \u003d acl_utils.add_acl_dhcp(fake_port, n3_s1[\u0027subnet\u0027])"},{"line_number":541,"context_line":"        for dhcp_acl in dhcp_acls:"},{"line_number":542,"context_line":"            self.create_acls.append(dhcp_acl)"},{"line_number":543,"context_line":"        if not (self.monitor_nb_db_idl.tables[\u0027ACL\u0027].columns.get(\u0027name\u0027) or"},{"line_number":544,"context_line":"                self.monitor_nb_db_idl.tables[\u0027ACL\u0027].columns.get(\u0027severity\u0027)):"},{"line_number":545,"context_line":"            for acl in self.create_acls:"},{"line_number":546,"context_line":"                acl.pop(\u0027name\u0027)"}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_9d8a3061","line":543,"range":{"start_line":543,"start_character":16,"end_line":543,"end_character":72},"updated":"2017-08-17 10:10:01.000000000","message":"Same comment as for networking_ovn/common/acl.py\n\nConsider using:\n\n  \u0027name\u0027 in self.monitor_nb_db_idl.tables[\u0027ACL\u0027].columns\n\nIn the current code, if \u0027name\u0027 exists but it has an empty value, \u0027name\u0027 field will be pop-ed below.","commit_id":"cf235cbffa6345d9ae5fadc8922d8dff7b91063c"}],"networking_ovn/tests/unit/ml2/test_mech_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b40bd690e0dde326b15c5acb8233de3d5a01dd1d","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        mock.patch("},{"line_number":87,"context_line":"            \"networking_ovn.common.acl._acl_columns_name_severity_supported\","},{"line_number":88,"context_line":"            return_value\u003dTrue"},{"line_number":89,"context_line":"        ).start()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test__process_sg_notification_create(self):"},{"line_number":92,"context_line":"        self.mech_driver._process_sg_notification("}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_67c37fee","line":89,"updated":"2017-08-17 09:02:56.000000000","message":"We need to stop this mock at clean up or it can interfere on other tests, here\u0027s one example: https://review.openstack.org/#/c/459757/\n\n p \u003d mock.patch(..., return_value\u003dTrue)\n p.start()\n p.addCleanup(p.stop)","commit_id":"cf235cbffa6345d9ae5fadc8922d8dff7b91063c"},{"author":{"_account_id":841,"name":"Akihiro Motoki","email":"amotoki@gmail.com","username":"amotoki"},"change_message_id":"870b48f689f049ee285226ef7a706ea6a2d6650b","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        mock.patch("},{"line_number":87,"context_line":"            \"networking_ovn.common.acl._acl_columns_name_severity_supported\","},{"line_number":88,"context_line":"            return_value\u003dTrue"},{"line_number":89,"context_line":"        ).start()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test__process_sg_notification_create(self):"},{"line_number":92,"context_line":"        self.mech_driver._process_sg_notification("}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_9d4d903c","line":89,"in_reply_to":"9f436f4f_220fa588","updated":"2017-08-17 10:10:01.000000000","message":"Yeah, mock.patch.stopall should work.","commit_id":"cf235cbffa6345d9ae5fadc8922d8dff7b91063c"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"c76ba4bb7121a31f210725b297ae590d26c5f8e5","unresolved":false,"context_lines":[{"line_number":86,"context_line":"        mock.patch("},{"line_number":87,"context_line":"            \"networking_ovn.common.acl._acl_columns_name_severity_supported\","},{"line_number":88,"context_line":"            return_value\u003dTrue"},{"line_number":89,"context_line":"        ).start()"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"    def test__process_sg_notification_create(self):"},{"line_number":92,"context_line":"        self.mech_driver._process_sg_notification("}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_220fa588","line":89,"in_reply_to":"9f436f4f_67c37fee","updated":"2017-08-17 09:38:10.000000000","message":"As the base class is already doing the same[1], no need to explicitly add \"mock.stop\" here. \n\n[1] https://github.com/openstack/neutron/blob/master/neutron/tests/base.py#L171","commit_id":"cf235cbffa6345d9ae5fadc8922d8dff7b91063c"}],"networking_ovn/tests/unit/test_ovn_db_sync.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b40bd690e0dde326b15c5acb8233de3d5a01dd1d","unresolved":false,"context_lines":[{"line_number":483,"context_line":""},{"line_number":484,"context_line":"        core_plugin \u003d ovn_nb_synchronizer.core_plugin"},{"line_number":485,"context_line":"        ovn_api \u003d ovn_nb_synchronizer.ovn_api"},{"line_number":486,"context_line":"        mock.patch(\"networking_ovn.ovsdb.impl_idl_ovn.get_connection\").start()"},{"line_number":487,"context_line":"        "},{"line_number":488,"context_line":"        ovn_nb_synchronizer.do_sync()"},{"line_number":489,"context_line":""}],"source_content_type":"text/x-python","patch_set":6,"id":"9f436f4f_27b9f777","line":486,"updated":"2017-08-17 09:02:56.000000000","message":"ditto","commit_id":"cf235cbffa6345d9ae5fadc8922d8dff7b91063c"}]}
