)]}'
{"networking_ovn/ml2/mech_driver.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"36712eac0ead60f4e04d66d1a31f868894a9879c","unresolved":false,"context_lines":[{"line_number":109,"context_line":"        return res"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _setup_vif_port_bindings(self):"},{"line_number":112,"context_line":"        # (pranabjb) Extending the list of supported_vnic_types to"},{"line_number":113,"context_line":"        # include VNIC_DIRECT inorder to bind direct (SR-IOV) ports."},{"line_number":114,"context_line":"        self.supported_vnic_types \u003d [portbindings.VNIC_NORMAL,"},{"line_number":115,"context_line":"                                     portbindings.VNIC_DIRECT]"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_a6a3b4b1","line":112,"range":{"start_line":112,"start_character":11,"end_line":112,"end_character":19},"updated":"2017-10-27 07:17:00.000000000","message":"Usually name in comments are used with a NOTE(name) or TODO(name) to call the attention of another developers. In this case, I agree with Lucas that this comment should go in a release note instead.","commit_id":"93f99656098ade5b1178321945702e92e531834b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"36712eac0ead60f4e04d66d1a31f868894a9879c","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _setup_vif_port_bindings(self):"},{"line_number":112,"context_line":"        # (pranabjb) Extending the list of supported_vnic_types to"},{"line_number":113,"context_line":"        # include VNIC_DIRECT inorder to bind direct (SR-IOV) ports."},{"line_number":114,"context_line":"        self.supported_vnic_types \u003d [portbindings.VNIC_NORMAL,"},{"line_number":115,"context_line":"                                     portbindings.VNIC_DIRECT]"},{"line_number":116,"context_line":"        self.vif_details \u003d {"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_06928857","line":113,"range":{"start_line":113,"start_character":30,"end_line":113,"end_character":37},"updated":"2017-10-27 07:17:00.000000000","message":"nit: s/inorder/in order","commit_id":"93f99656098ade5b1178321945702e92e531834b"},{"author":{"_account_id":12171,"name":"Moshe Levi","email":"moshele@nvidia.com","username":"moshele"},"change_message_id":"e6d0a56068319ff2867ef5c58d6874e4689cfd6f","unresolved":false,"context_lines":[{"line_number":110,"context_line":""},{"line_number":111,"context_line":"    def _setup_vif_port_bindings(self):"},{"line_number":112,"context_line":"        self.supported_vnic_types \u003d [portbindings.VNIC_NORMAL,"},{"line_number":113,"context_line":"                                     portbindings.VNIC_DIRECT]"},{"line_number":114,"context_line":"        self.vif_details \u003d {"},{"line_number":115,"context_line":"            portbindings.VIF_TYPE_OVS: {"},{"line_number":116,"context_line":"                portbindings.CAP_PORT_FILTER: self.sg_enabled"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f4b6375_720d288f","line":113,"range":{"start_line":113,"start_character":34,"end_line":113,"end_character":62},"updated":"2017-10-31 07:22:59.000000000","message":"you need to add code like the following\nhttps://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/openvswitch/mech_driver/mech_openvswitch.py#L81-L89\nso that use will request direct port with swithcdev. This is need so we can still work with SR-IOV and OVN mechanism driver at the same setup. \n\nso just direct port is SR-IOV legacy.\ndirect port with binding profile switchdev is OVS HW offload. \nThan we can have also SR-IVO legacy and SR-IOV switchdev to work in the same setup when this spec will be implemented https://review.openstack.org/#/c/504895/","commit_id":"d9cbd53e05e9237d493811c90a12683083b769d0"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"2bf09a6a9d708ec3d3808a40c2a3dacc0552386b","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        \"\"\""},{"line_number":514,"context_line":"        port \u003d context.current"},{"line_number":515,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE, portbindings.VNIC_NORMAL)"},{"line_number":516,"context_line":"        profile \u003d port.get(portbindings.PROFILE)"},{"line_number":517,"context_line":"        capabilities \u003d []"},{"line_number":518,"context_line":"        if vnic_type not in self.supported_vnic_types:"},{"line_number":519,"context_line":"            LOG.debug(\u0027Refusing to bind port %(port_id)s due to unsupported \u0027"},{"line_number":520,"context_line":"                      \u0027vnic_type: %(vnic_type)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_094951b5","line":517,"range":{"start_line":516,"start_character":0,"end_line":517,"end_character":25},"updated":"2017-11-29 09:39:01.000000000","message":"Can move to L522, it\u0027s better in same section","commit_id":"6b827dedfc458cc8f14ccdf091da62decf19d331"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"95af639bee3460f491022bd1dba04af6e0f60860","unresolved":false,"context_lines":[{"line_number":513,"context_line":"        \"\"\""},{"line_number":514,"context_line":"        port \u003d context.current"},{"line_number":515,"context_line":"        vnic_type \u003d port.get(portbindings.VNIC_TYPE, portbindings.VNIC_NORMAL)"},{"line_number":516,"context_line":"        profile \u003d port.get(portbindings.PROFILE)"},{"line_number":517,"context_line":"        capabilities \u003d []"},{"line_number":518,"context_line":"        if vnic_type not in self.supported_vnic_types:"},{"line_number":519,"context_line":"            LOG.debug(\u0027Refusing to bind port %(port_id)s due to unsupported \u0027"},{"line_number":520,"context_line":"                      \u0027vnic_type: %(vnic_type)s\u0027 %"}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_80e52ede","line":517,"range":{"start_line":516,"start_character":0,"end_line":517,"end_character":25},"in_reply_to":"ff82abbf_094951b5","updated":"2017-11-29 12:49:50.000000000","message":"Done","commit_id":"6b827dedfc458cc8f14ccdf091da62decf19d331"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"2bf09a6a9d708ec3d3808a40c2a3dacc0552386b","unresolved":false,"context_lines":[{"line_number":520,"context_line":"                      \u0027vnic_type: %(vnic_type)s\u0027 %"},{"line_number":521,"context_line":"                      {\u0027port_id\u0027: port[\u0027id\u0027], \u0027vnic_type\u0027: vnic_type})"},{"line_number":522,"context_line":"            return"},{"line_number":523,"context_line":"        if profile:"},{"line_number":524,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":525,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"},{"line_number":526,"context_line":"           \u0027switchdev\u0027 not in capabilities):"},{"line_number":527,"context_line":"            LOG.debug(\"Refusing to bind port due to unsupported vnic_type: %s\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_4c39a7d4","line":524,"range":{"start_line":523,"start_character":0,"end_line":524,"end_character":58},"updated":"2017-11-29 09:39:01.000000000","message":"You gave a default value to Capabilities but did not to profile, I suggest simplify it as:\ncapabilities \u003d port.get(portbindings.PROFILE, {}).get(\u0027capabilities\u0027, [])","commit_id":"6b827dedfc458cc8f14ccdf091da62decf19d331"},{"author":{"_account_id":23458,"name":"Dong Jun","email":"dongjun.01@bytedance.com","username":"Dongj"},"change_message_id":"276e48948c2a6b8c911f3891e942f072307e155b","unresolved":false,"context_lines":[{"line_number":520,"context_line":"                      \u0027vnic_type: %(vnic_type)s\u0027 %"},{"line_number":521,"context_line":"                      {\u0027port_id\u0027: port[\u0027id\u0027], \u0027vnic_type\u0027: vnic_type})"},{"line_number":522,"context_line":"            return"},{"line_number":523,"context_line":"        if profile:"},{"line_number":524,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":525,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"},{"line_number":526,"context_line":"           \u0027switchdev\u0027 not in capabilities):"},{"line_number":527,"context_line":"            LOG.debug(\"Refusing to bind port due to unsupported vnic_type: %s\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_7bf1bf00","line":524,"range":{"start_line":523,"start_character":0,"end_line":524,"end_character":58},"in_reply_to":"ff82abbf_00f27e9a","updated":"2017-11-29 13:19:12.000000000","message":"Oh you right, I agree^","commit_id":"6b827dedfc458cc8f14ccdf091da62decf19d331"},{"author":{"_account_id":24654,"name":"Pranab","email":"pranabjyotiboruah@gmail.com","username":"pranabjb"},"change_message_id":"95af639bee3460f491022bd1dba04af6e0f60860","unresolved":false,"context_lines":[{"line_number":520,"context_line":"                      \u0027vnic_type: %(vnic_type)s\u0027 %"},{"line_number":521,"context_line":"                      {\u0027port_id\u0027: port[\u0027id\u0027], \u0027vnic_type\u0027: vnic_type})"},{"line_number":522,"context_line":"            return"},{"line_number":523,"context_line":"        if profile:"},{"line_number":524,"context_line":"            capabilities \u003d profile.get(\u0027capabilities\u0027, [])"},{"line_number":525,"context_line":"        if (vnic_type \u003d\u003d portbindings.VNIC_DIRECT and"},{"line_number":526,"context_line":"           \u0027switchdev\u0027 not in capabilities):"},{"line_number":527,"context_line":"            LOG.debug(\"Refusing to bind port due to unsupported vnic_type: %s\""}],"source_content_type":"text/x-python","patch_set":5,"id":"ff82abbf_00f27e9a","line":524,"range":{"start_line":523,"start_character":0,"end_line":524,"end_character":58},"in_reply_to":"ff82abbf_4c39a7d4","updated":"2017-11-29 12:49:50.000000000","message":"why do we need a default value in Profile. By the time, it reaches here, binding:profile would be populated by Nova. Right?","commit_id":"6b827dedfc458cc8f14ccdf091da62decf19d331"}],"networking_ovn/tests/unit/ml2/test_mech_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"91a1a0af07b369f625f3b170422fa11554869775","unresolved":false,"context_lines":[{"line_number":688,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":689,"context_line":"            self.mech_driver.vif_details[portbindings.VIF_TYPE_OVS])"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"    # (pranabjb) OVN now supports binding SRIOV port."},{"line_number":692,"context_line":"    def _test_bind_port_sriov(self, fake_segments):"},{"line_number":693,"context_line":"        fake_port \u003d fakes.FakePort.create_one_port("},{"line_number":694,"context_line":"            attrs\u003d{\u0027binding:vnic_type\u0027: \u0027direct\u0027}).info()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_3ad48ce8","line":691,"range":{"start_line":691,"start_character":3,"end_line":691,"end_character":53},"updated":"2017-10-26 14:10:33.000000000","message":"This comment can be removed, probably should be added as release note.","commit_id":"93f99656098ade5b1178321945702e92e531834b"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"36712eac0ead60f4e04d66d1a31f868894a9879c","unresolved":false,"context_lines":[{"line_number":688,"context_line":"            portbindings.VIF_TYPE_OVS,"},{"line_number":689,"context_line":"            self.mech_driver.vif_details[portbindings.VIF_TYPE_OVS])"},{"line_number":690,"context_line":""},{"line_number":691,"context_line":"    # (pranabjb) OVN now supports binding SRIOV port."},{"line_number":692,"context_line":"    def _test_bind_port_sriov(self, fake_segments):"},{"line_number":693,"context_line":"        fake_port \u003d fakes.FakePort.create_one_port("},{"line_number":694,"context_line":"            attrs\u003d{\u0027binding:vnic_type\u0027: \u0027direct\u0027}).info()"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_2680e4f4","line":691,"range":{"start_line":691,"start_character":3,"end_line":691,"end_character":53},"in_reply_to":"3f4b6375_3ad48ce8","updated":"2017-10-27 07:17:00.000000000","message":"+1","commit_id":"93f99656098ade5b1178321945702e92e531834b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"91a1a0af07b369f625f3b170422fa11554869775","unresolved":false,"context_lines":[{"line_number":711,"context_line":"            [fakes.FakeSegment.create_one_segment(attrs\u003dsegment_attrs).info()]"},{"line_number":712,"context_line":"        self._test_bind_port(fake_segments)"},{"line_number":713,"context_line":""},{"line_number":714,"context_line":"    # (pranabjb) Binding a SRIOV port to a geneve segment"},{"line_number":715,"context_line":"    def test_bind_sriov_port_geneve(self):"},{"line_number":716,"context_line":"        segment_attrs \u003d {\u0027network_type\u0027: \u0027geneve\u0027,"},{"line_number":717,"context_line":"                         \u0027physical_network\u0027: None,"}],"source_content_type":"text/x-python","patch_set":1,"id":"3f4b6375_fa0b948a","line":714,"range":{"start_line":714,"start_character":4,"end_line":714,"end_character":57},"updated":"2017-10-26 14:10:33.000000000","message":"This information should go in a docstring to the test method. E.g:\n\n def test_bind_sriov_port_geneve(self):\n     \"\"\"Test binding a SRIOV port to a geneve segment.\"\"\"\n     ...","commit_id":"93f99656098ade5b1178321945702e92e531834b"}]}