)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7160c2b2a72d8d2c419805df71affa0d33c8b41d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     venkata anil \u003canilvenkata@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-20 17:43:29 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use genve mtu for vlan"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In OVN driver, traffic from vlan (or any other) tenant network"},{"line_number":10,"context_line":"to external network uses a geneve tunnel between the compute"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_241b7bd0","line":7,"updated":"2018-04-20 12:27:11.000000000","message":"geneve","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"18677d29e106eafd820eefca83c3afbd7600306f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     venkata anil \u003canilvenkata@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2018-04-20 17:43:29 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Use genve mtu for vlan"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"In OVN driver, traffic from vlan (or any other) tenant network"},{"line_number":10,"context_line":"to external network uses a geneve tunnel between the compute"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_1ff0fefd","line":7,"in_reply_to":"9f6a8fd7_241b7bd0","updated":"2018-04-20 12:40:03.000000000","message":"++","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7160c2b2a72d8d2c419805df71affa0d33c8b41d","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to external network uses a geneve tunnel between the compute"},{"line_number":11,"context_line":"node and the gateway node."},{"line_number":12,"context_line":"So MTU for the VLAN networks needs to account for geneve tunnel"},{"line_number":13,"context_line":"overhead. Till OVN driver is fixed not to use geneve tunnel,"},{"line_number":14,"context_line":"we need to adjust the MTU of the tenant networks."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug: #1765691"},{"line_number":17,"context_line":"Change-Id: Ia7bf790f92042beea8dc58cb5bb803303c130ba0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_842927e7","line":14,"range":{"start_line":13,"start_character":10,"end_line":14,"end_character":49},"updated":"2018-04-20 12:27:11.000000000","message":"I\u0027m not sure if that will ever happen, I\u0027d remove that paragraph.","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"2c26ec1ce8b7dd701f6246132ed4d4bfab3491a9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"to external network uses a geneve tunnel between the compute"},{"line_number":11,"context_line":"node and the gateway node."},{"line_number":12,"context_line":"So MTU for the VLAN networks needs to account for geneve tunnel"},{"line_number":13,"context_line":"overhead. Till OVN driver is fixed not to use geneve tunnel,"},{"line_number":14,"context_line":"we need to adjust the MTU of the tenant networks."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Closes-bug: #1765691"},{"line_number":17,"context_line":"Change-Id: Ia7bf790f92042beea8dc58cb5bb803303c130ba0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"9f6a8fd7_a4754bcd","line":14,"range":{"start_line":13,"start_character":10,"end_line":14,"end_character":49},"in_reply_to":"9f6a8fd7_842927e7","updated":"2018-04-20 12:32:10.000000000","message":"I am working on core ovn fix.","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"}],"networking_ovn/ml2/mech_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d8c943b7f29216e314f7aed71d60748b50154796","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        of the current transaction."},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # NOTE: OVN driver uses genve tunneling for SNAT traffic."},{"line_number":282,"context_line":"        # So use geneve network mtu for all network types."},{"line_number":283,"context_line":"        if context.current[\u0027mtu\u0027] \u003e 1450:"},{"line_number":284,"context_line":"            context.current[\u0027mtu\u0027] \u003d 1450"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_b3cef32a","line":281,"range":{"start_line":281,"start_character":32,"end_line":281,"end_character":37},"updated":"2018-04-20 10:21:08.000000000","message":"nit: geneve","commit_id":"c780976f7f2d71192c9b4bfcd10d7d7acbe5338a"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"7e8085d0550c66ab4f117b68c95d3cf5a227773b","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        of the current transaction."},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # NOTE: OVN driver uses genve tunneling for SNAT traffic."},{"line_number":282,"context_line":"        # So use geneve network mtu for all network types."},{"line_number":283,"context_line":"        if context.current[\u0027mtu\u0027] \u003e 1450:"},{"line_number":284,"context_line":"            context.current[\u0027mtu\u0027] \u003d 1450"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_93540f55","line":281,"updated":"2018-04-20 10:21:28.000000000","message":"nit:geneve. Do we want to raise a bug in LP to track it and add a TODO to remove this referencing the bug when it\u0027s fixed in Core OVN.","commit_id":"c780976f7f2d71192c9b4bfcd10d7d7acbe5338a"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"1432e824ba8180d33f037e62adedb14f35222377","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        of the current transaction."},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # NOTE: OVN driver uses genve tunneling for SNAT traffic."},{"line_number":282,"context_line":"        # So use geneve network mtu for all network types."},{"line_number":283,"context_line":"        if context.current[\u0027mtu\u0027] \u003e 1450:"},{"line_number":284,"context_line":"            context.current[\u0027mtu\u0027] \u003d 1450"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_66789bc3","line":281,"in_reply_to":"9f6a8fd7_93540f55","updated":"2018-04-20 12:09:07.000000000","message":"sure","commit_id":"c780976f7f2d71192c9b4bfcd10d7d7acbe5338a"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"7e8085d0550c66ab4f117b68c95d3cf5a227773b","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # NOTE: OVN driver uses genve tunneling for SNAT traffic."},{"line_number":282,"context_line":"        # So use geneve network mtu for all network types."},{"line_number":283,"context_line":"        if context.current[\u0027mtu\u0027] \u003e 1450:"},{"line_number":284,"context_line":"            context.current[\u0027mtu\u0027] \u003d 1450"},{"line_number":285,"context_line":"        db_rev.create_initial_revision("},{"line_number":286,"context_line":"            context.current[\u0027id\u0027], ovn_const.TYPE_NETWORKS,"},{"line_number":287,"context_line":"            context._plugin_context.session)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_33e2e3a1","line":284,"range":{"start_line":283,"start_character":0,"end_line":284,"end_character":41},"updated":"2018-04-20 10:21:28.000000000","message":"I may be wrong but shouldn\u0027t we just substract the geneve overhead fromt he current MTU?\n\ncontext.current[\u0027mtu\u0027] \u003d 1450 - GENEVE_OVERHEAD","commit_id":"c780976f7f2d71192c9b4bfcd10d7d7acbe5338a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d8c943b7f29216e314f7aed71d60748b50154796","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # NOTE: OVN driver uses genve tunneling for SNAT traffic."},{"line_number":282,"context_line":"        # So use geneve network mtu for all network types."},{"line_number":283,"context_line":"        if context.current[\u0027mtu\u0027] \u003e 1450:"},{"line_number":284,"context_line":"            context.current[\u0027mtu\u0027] \u003d 1450"},{"line_number":285,"context_line":"        db_rev.create_initial_revision("},{"line_number":286,"context_line":"            context.current[\u0027id\u0027], ovn_const.TYPE_NETWORKS,"},{"line_number":287,"context_line":"            context._plugin_context.session)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_13cebf2d","line":284,"range":{"start_line":283,"start_character":0,"end_line":284,"end_character":41},"updated":"2018-04-20 10:21:08.000000000","message":"Let\u0027s add a LOG explaining what is happening here. Otherwise this could be very confusing for an user setting the mtu to something \u003e 1450 and that changes just not being applied without no logs/complains at all.\n\nLOG.warning(\u0027Setting the MTU to 150 for networking %s because the OVN driver uses geneve tunneling ...\u0027)","commit_id":"c780976f7f2d71192c9b4bfcd10d7d7acbe5338a"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"1432e824ba8180d33f037e62adedb14f35222377","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # NOTE: OVN driver uses genve tunneling for SNAT traffic."},{"line_number":282,"context_line":"        # So use geneve network mtu for all network types."},{"line_number":283,"context_line":"        if context.current[\u0027mtu\u0027] \u003e 1450:"},{"line_number":284,"context_line":"            context.current[\u0027mtu\u0027] \u003d 1450"},{"line_number":285,"context_line":"        db_rev.create_initial_revision("},{"line_number":286,"context_line":"            context.current[\u0027id\u0027], ovn_const.TYPE_NETWORKS,"},{"line_number":287,"context_line":"            context._plugin_context.session)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_44e46f3c","line":284,"range":{"start_line":283,"start_character":0,"end_line":284,"end_character":41},"in_reply_to":"9f6a8fd7_1338ffec","updated":"2018-04-20 12:09:07.000000000","message":"1450 is after removing GENEVE_OVERHEAD[1]. Let me directly get mtu from geneve type driver.\n\n[1] https://github.com/openstack/neutron/blob/master/neutron/plugins/ml2/drivers/type_tunnel.py#L199","commit_id":"c780976f7f2d71192c9b4bfcd10d7d7acbe5338a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"daddae4f72f8667aa48c49e78d7b3c0a7c1eb417","unresolved":false,"context_lines":[{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # NOTE: OVN driver uses genve tunneling for SNAT traffic."},{"line_number":282,"context_line":"        # So use geneve network mtu for all network types."},{"line_number":283,"context_line":"        if context.current[\u0027mtu\u0027] \u003e 1450:"},{"line_number":284,"context_line":"            context.current[\u0027mtu\u0027] \u003d 1450"},{"line_number":285,"context_line":"        db_rev.create_initial_revision("},{"line_number":286,"context_line":"            context.current[\u0027id\u0027], ovn_const.TYPE_NETWORKS,"},{"line_number":287,"context_line":"            context._plugin_context.session)"}],"source_content_type":"text/x-python","patch_set":1,"id":"9f6a8fd7_1338ffec","line":284,"range":{"start_line":283,"start_character":0,"end_line":284,"end_character":41},"in_reply_to":"9f6a8fd7_33e2e3a1","updated":"2018-04-20 10:27:35.000000000","message":"Good point, maybe a comment about why 1450 would be useful here as well.","commit_id":"c780976f7f2d71192c9b4bfcd10d7d7acbe5338a"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7160c2b2a72d8d2c419805df71affa0d33c8b41d","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        of the current transaction."},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # TODO(anilvenkata): Bug #1765691. OVN driver uses geneve tunneling"},{"line_number":282,"context_line":"        # for SNAT traffic. As OVN driver is proxying traffic intended for vlan"},{"line_number":283,"context_line":"        # tenant networks through a geneve tunnel, tunneling overhead need to"},{"line_number":284,"context_line":"        # be considered. As a temporary solution use geneve network mtu for"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_c4807fc2","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":29},"updated":"2018-04-20 12:27:11.000000000","message":"I\u0027d remove the TODO part... :) it\u0027s good to keep the reference to the bug .","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"2c26ec1ce8b7dd701f6246132ed4d4bfab3491a9","unresolved":false,"context_lines":[{"line_number":278,"context_line":"        of the current transaction."},{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # TODO(anilvenkata): Bug #1765691. OVN driver uses geneve tunneling"},{"line_number":282,"context_line":"        # for SNAT traffic. As OVN driver is proxying traffic intended for vlan"},{"line_number":283,"context_line":"        # tenant networks through a geneve tunnel, tunneling overhead need to"},{"line_number":284,"context_line":"        # be considered. As a temporary solution use geneve network mtu for"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_442c6fab","line":281,"range":{"start_line":281,"start_character":8,"end_line":281,"end_character":29},"in_reply_to":"9f6a8fd7_c4807fc2","updated":"2018-04-20 12:32:10.000000000","message":"sure","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7160c2b2a72d8d2c419805df71affa0d33c8b41d","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        # for SNAT traffic. As OVN driver is proxying traffic intended for vlan"},{"line_number":283,"context_line":"        # tenant networks through a geneve tunnel, tunneling overhead need to"},{"line_number":284,"context_line":"        # be considered. As a temporary solution use geneve network mtu for"},{"line_number":285,"context_line":"        # all network types. Remove this once it is fixed in OVN driver."},{"line_number":286,"context_line":"        try:"},{"line_number":287,"context_line":"            type_driver \u003d self._plugin.type_manager.drivers["},{"line_number":288,"context_line":"                const.TYPE_GENEVE].obj"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_c4595f8e","line":285,"range":{"start_line":285,"start_character":28,"end_line":285,"end_character":72},"updated":"2018-04-20 12:27:11.000000000","message":"Wouldn\u0027t be OVN driver (that is this file) but core ovn.\n\nBut are we sure that we have a technical solution for that?\n\nI\u0027d live with this limitation at least for now.","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"2c26ec1ce8b7dd701f6246132ed4d4bfab3491a9","unresolved":false,"context_lines":[{"line_number":282,"context_line":"        # for SNAT traffic. As OVN driver is proxying traffic intended for vlan"},{"line_number":283,"context_line":"        # tenant networks through a geneve tunnel, tunneling overhead need to"},{"line_number":284,"context_line":"        # be considered. As a temporary solution use geneve network mtu for"},{"line_number":285,"context_line":"        # all network types. Remove this once it is fixed in OVN driver."},{"line_number":286,"context_line":"        try:"},{"line_number":287,"context_line":"            type_driver \u003d self._plugin.type_manager.drivers["},{"line_number":288,"context_line":"                const.TYPE_GENEVE].obj"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_044e7796","line":285,"range":{"start_line":285,"start_character":28,"end_line":285,"end_character":72},"in_reply_to":"9f6a8fd7_c4595f8e","updated":"2018-04-20 12:32:10.000000000","message":"I will change OVN driver to core ovn. I am also working on core ovn fix.","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"7160c2b2a72d8d2c419805df71affa0d33c8b41d","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            type_driver \u003d self._plugin.type_manager.drivers["},{"line_number":288,"context_line":"                const.TYPE_GENEVE].obj"},{"line_number":289,"context_line":"        except KeyError:"},{"line_number":290,"context_line":"            LOG.warning(\"Failed to get geneve type drive object\")"},{"line_number":291,"context_line":"        else:"},{"line_number":292,"context_line":"            mtu \u003d type_driver.get_mtu()"},{"line_number":293,"context_line":"            if context.current[\u0027mtu\u0027] \u003e mtu:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_04c99724","line":290,"updated":"2018-04-20 12:27:11.000000000","message":"I\u0027d extend the message to say \"while trying to adjust vlan mtu\"","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"18677d29e106eafd820eefca83c3afbd7600306f","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            type_driver \u003d self._plugin.type_manager.drivers["},{"line_number":288,"context_line":"                const.TYPE_GENEVE].obj"},{"line_number":289,"context_line":"        except KeyError:"},{"line_number":290,"context_line":"            LOG.warning(\"Failed to get geneve type drive object\")"},{"line_number":291,"context_line":"        else:"},{"line_number":292,"context_line":"            mtu \u003d type_driver.get_mtu()"},{"line_number":293,"context_line":"            if context.current[\u0027mtu\u0027] \u003e mtu:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_3fb62240","line":290,"in_reply_to":"9f6a8fd7_04c99724","updated":"2018-04-20 12:40:03.000000000","message":"I think we need to log someting more relevant to the people that is reading the logs, which are probably operators. We don\u0027t want people to have to jump in the code to understand what is going on.\n\nFor example, if we say: \"Failed to get geneve type driver object while trying to adjust vlan mtu\". That sounds like an implementation detail, people reading it might think \"So what? What is the consequences of not being able to get that type driver?\"\n\nInstead we should log something like: \"Failed to find the geneve type driver. Skipping adjusting the MTU for network %s to compensate for the geneve tunneling overhead\"\n\nOr something along those lines...","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"2c26ec1ce8b7dd701f6246132ed4d4bfab3491a9","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            type_driver \u003d self._plugin.type_manager.drivers["},{"line_number":288,"context_line":"                const.TYPE_GENEVE].obj"},{"line_number":289,"context_line":"        except KeyError:"},{"line_number":290,"context_line":"            LOG.warning(\"Failed to get geneve type drive object\")"},{"line_number":291,"context_line":"        else:"},{"line_number":292,"context_line":"            mtu \u003d type_driver.get_mtu()"},{"line_number":293,"context_line":"            if context.current[\u0027mtu\u0027] \u003e mtu:"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_c4439f6b","line":290,"in_reply_to":"9f6a8fd7_04c99724","updated":"2018-04-20 12:32:10.000000000","message":"sure","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"14e88d4b222b9311b379b6347c1053649d66a7d8","unresolved":false,"context_lines":[{"line_number":287,"context_line":"            type_driver \u003d self._plugin.type_manager.drivers["},{"line_number":288,"context_line":"                const.TYPE_GENEVE].obj"},{"line_number":289,"context_line":"        except KeyError:"},{"line_number":290,"context_line":"            LOG.warning(\"Failed to get geneve type drive object while \""},{"line_number":291,"context_line":"                        \"trying to adjust vlan mtu.\")"},{"line_number":292,"context_line":"        else:"},{"line_number":293,"context_line":"            mtu \u003d type_driver.get_mtu()"},{"line_number":294,"context_line":"            if context.current[\u0027mtu\u0027] \u003e mtu:"}],"source_content_type":"text/x-python","patch_set":3,"id":"9f6a8fd7_dff5a6ee","line":291,"range":{"start_line":290,"start_character":23,"end_line":291,"end_character":53},"updated":"2018-04-20 12:41:02.000000000","message":"See my comment on the previous patch-set please","commit_id":"825d9b33d4afe48f9f0d0044fb12f563c6181bcd"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"2154b1c9a4fa1ca759785e3e6569574e19fc842f","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # Bug #1765691. OVN driver uses geneve tunneling for SNAT traffic."},{"line_number":282,"context_line":"        # As OVN driver is proxying traffic intended for vlan tenant networks"},{"line_number":283,"context_line":"        # through a geneve tunnel, tunneling overhead need to be considered."},{"line_number":284,"context_line":"        # As a temporary solution use geneve network mtu for all network"},{"line_number":285,"context_line":"        # types. Remove this once it is fixed in OVN driver."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_fa00b803","line":282,"range":{"start_line":282,"start_character":13,"end_line":282,"end_character":23},"updated":"2018-04-20 13:13:39.000000000","message":"OVN driver would be networking-ovn no?\nDo we mean core OVN here?","commit_id":"970b8885255dc118154e28660a24ad11bd7ac26d"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"46bed0a4ad18c2f7037edb00f9180e166e81102c","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # Bug #1765691. OVN driver uses geneve tunneling for SNAT traffic."},{"line_number":282,"context_line":"        # As OVN driver is proxying traffic intended for vlan tenant networks"},{"line_number":283,"context_line":"        # through a geneve tunnel, tunneling overhead need to be considered."},{"line_number":284,"context_line":"        # As a temporary solution use geneve network mtu for all network"},{"line_number":285,"context_line":"        # types. Remove this once it is fixed in OVN driver."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_c2cf0a54","line":282,"range":{"start_line":282,"start_character":13,"end_line":282,"end_character":23},"in_reply_to":"9f6a8fd7_dab4d4d3","updated":"2018-04-20 15:55:10.000000000","message":"still to be changed! it\u0027s nit though :)","commit_id":"970b8885255dc118154e28660a24ad11bd7ac26d"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"8bf67197763181d7d8e79e38a1eba2b47eec9c14","unresolved":false,"context_lines":[{"line_number":279,"context_line":"        \"\"\""},{"line_number":280,"context_line":"        self._validate_network_segments(context.network_segments)"},{"line_number":281,"context_line":"        # Bug #1765691. OVN driver uses geneve tunneling for SNAT traffic."},{"line_number":282,"context_line":"        # As OVN driver is proxying traffic intended for vlan tenant networks"},{"line_number":283,"context_line":"        # through a geneve tunnel, tunneling overhead need to be considered."},{"line_number":284,"context_line":"        # As a temporary solution use geneve network mtu for all network"},{"line_number":285,"context_line":"        # types. Remove this once it is fixed in OVN driver."}],"source_content_type":"text/x-python","patch_set":4,"id":"9f6a8fd7_dab4d4d3","line":282,"range":{"start_line":282,"start_character":13,"end_line":282,"end_character":23},"in_reply_to":"9f6a8fd7_fa00b803","updated":"2018-04-20 13:27:41.000000000","message":"yes, miguel already suggested that I missed :)","commit_id":"970b8885255dc118154e28660a24ad11bd7ac26d"}],"networking_ovn/tests/unit/ml2/test_mech_driver.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"4334948e8db3b67ab60508d6dba4bca9e3b6a20a","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        p.start()"},{"line_number":98,"context_line":"        self.addCleanup(p.stop)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_network_mtu(self):"},{"line_number":101,"context_line":"        arg_list \u003d (pnet.NETWORK_TYPE, pnet.SEGMENTATION_ID,"},{"line_number":102,"context_line":"                    pnet.PHYSICAL_NETWORK,)"},{"line_number":103,"context_line":"        net_arg \u003d {pnet.NETWORK_TYPE: \u0027vlan\u0027, pnet.SEGMENTATION_ID: 100,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_5f5e7612","line":100,"range":{"start_line":100,"start_character":8,"end_line":100,"end_character":24},"updated":"2018-04-20 12:37:30.000000000","message":"can we have a separate test for vlan? I mean.. check that mtu is adjusted for vlan and not for flat for example?\ntest_network_mtu_flat()\ntest_network_mtu_is_adjusted_for_vlan()","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"},{"author":{"_account_id":10267,"name":"venkata anil","email":"anilvenkata@redhat.com","username":"anil"},"change_message_id":"5ba8f0b55fbfb97d4790b2dfafaf2b0a2ba59bf7","unresolved":false,"context_lines":[{"line_number":97,"context_line":"        p.start()"},{"line_number":98,"context_line":"        self.addCleanup(p.stop)"},{"line_number":99,"context_line":""},{"line_number":100,"context_line":"    def test_network_mtu(self):"},{"line_number":101,"context_line":"        arg_list \u003d (pnet.NETWORK_TYPE, pnet.SEGMENTATION_ID,"},{"line_number":102,"context_line":"                    pnet.PHYSICAL_NETWORK,)"},{"line_number":103,"context_line":"        net_arg \u003d {pnet.NETWORK_TYPE: \u0027vlan\u0027, pnet.SEGMENTATION_ID: 100,"}],"source_content_type":"text/x-python","patch_set":2,"id":"9f6a8fd7_5fbaf609","line":100,"range":{"start_line":100,"start_character":8,"end_line":100,"end_character":24},"in_reply_to":"9f6a8fd7_5f5e7612","updated":"2018-04-20 12:43:32.000000000","message":"thanks Daniel. let me add for geneve i.e no change when 1450 is the requested mtu.","commit_id":"de9cc2db67c810d5ba67773cdfe539f282c8c728"}]}