)]}'
{"networking_ovn/common/acl.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"d30af94929d40d6541b25ff5ec92ab3b14a3ec38","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        # If it is a trusted port or port security is disabled, allow all"},{"line_number":353,"context_line":"        # traffic. So don\u0027t add any ACLs."},{"line_number":354,"context_line":"        if utils.is_lsp_trusted(port) or not utils.is_port_security_enabled("},{"line_number":355,"context_line":"                port):"},{"line_number":356,"context_line":"            return acl_list"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        # if port security is enabled, drop all traffic."}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_0e783bf6","line":355,"updated":"2018-05-18 09:01:32.000000000","message":"is_lsp_trusted(port):\n return n_utils.is_port_trusted(port) if port.get(\u0027device_owner\u0027) else False\n\nWouldn\u0027t that make any port which device owner is \"compute\" be treated as \"is_port_security_enabled(port) \u003d\u003d False\"","commit_id":"d97a670257fb67917e2b5da4c944b9e29a5d7855"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"e2f57c57f8fdf03aeefc884139a681c7d71d2b39","unresolved":false,"context_lines":[{"line_number":352,"context_line":"        # If it is a trusted port or port security is disabled, allow all"},{"line_number":353,"context_line":"        # traffic. So don\u0027t add any ACLs."},{"line_number":354,"context_line":"        if utils.is_lsp_trusted(port) or not utils.is_port_security_enabled("},{"line_number":355,"context_line":"                port):"},{"line_number":356,"context_line":"            return acl_list"},{"line_number":357,"context_line":""},{"line_number":358,"context_line":"        # if port security is enabled, drop all traffic."}],"source_content_type":"text/x-python","patch_set":6,"id":"5f7c97a3_cee8037e","line":355,"in_reply_to":"5f7c97a3_0e783bf6","updated":"2018-05-18 09:05:14.000000000","message":"Ignore my comment, my brain ignored the left part of the if \"n_utils.is_port_trusted(port) ....\"","commit_id":"d97a670257fb67917e2b5da4c944b9e29a5d7855"}],"networking_ovn/common/ovn_client.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d2ac7d0011f1446e0c86d02ef10e2f0d783ef0a7","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            is_allowed_ips_updated \u003d (sorted(old_allowed_address_pairs) !\u003d"},{"line_number":421,"context_line":"                                      sorted(new_allowed_address_pairs))"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"            if port_object:"},{"line_number":424,"context_line":"                port_security_changed \u003d ("},{"line_number":425,"context_line":"                    utils.is_port_security_enabled(port_object) !\u003d ("},{"line_number":426,"context_line":"                        utils.is_port_security_enabled(port)))"},{"line_number":427,"context_line":"            else:"},{"line_number":428,"context_line":"                port_security_changed \u003d False"},{"line_number":429,"context_line":"            # Refresh ACLs for changed security groups or fixed IPs."},{"line_number":430,"context_line":"            if detached_sg_ids or attached_sg_ids or is_fixed_ips_updated or ("},{"line_number":431,"context_line":"                    port_security_changed):"}],"source_content_type":"text/x-python","patch_set":4,"id":"5f7c97a3_2a722c7c","line":428,"range":{"start_line":423,"start_character":0,"end_line":428,"end_character":45},"updated":"2018-05-14 10:32:41.000000000","message":"I think we should try to avoid using the \"port_object\" parameter because it was kept just for backwards compatibility with older code.\n\nAlso, perhaps it would be easier to just compare the Neutron object (the \"port\" parameter) with the port in the OVN database (ovn_port variable), for example: \n\nport_security_changed \u003d port_info.port_security !\u003d ovn_port.port_security\n\nWould that work ?","commit_id":"decb8d8aa7115ad4bce86e25c09bdc95015efc78"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"92373fb337be62c94a51c8c1a3d034eb270debe4","unresolved":false,"context_lines":[{"line_number":420,"context_line":"            is_allowed_ips_updated \u003d (sorted(old_allowed_address_pairs) !\u003d"},{"line_number":421,"context_line":"                                      sorted(new_allowed_address_pairs))"},{"line_number":422,"context_line":""},{"line_number":423,"context_line":"            old_port_security \u003d True if ovn_port.port_security else False"},{"line_number":424,"context_line":"            port_security_changed \u003d ("},{"line_number":425,"context_line":"                utils.is_port_security_enabled(port) !\u003d (old_port_security))"},{"line_number":426,"context_line":""}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_6830f49f","line":423,"range":{"start_line":423,"start_character":12,"end_line":423,"end_character":73},"updated":"2018-05-16 12:51:22.000000000","message":"yeah let\u0027s change it :) \nold_port_security \u003d bool(ovn_port.port_security)\n\nand in L425\n\nport_security_changed \u003d utils.is_port_security_enabled(port) !\u003d old_port_security","commit_id":"9f5909c97daf321d8182cb0c4d6de53d7a073a6a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e513f12929ea27e7ee84dbc7fe58b54c836ececf","unresolved":false,"context_lines":[{"line_number":422,"context_line":""},{"line_number":423,"context_line":"            old_port_security \u003d True if ovn_port.port_security else False"},{"line_number":424,"context_line":"            port_security_changed \u003d ("},{"line_number":425,"context_line":"                utils.is_port_security_enabled(port) !\u003d (old_port_security))"},{"line_number":426,"context_line":""},{"line_number":427,"context_line":"            # Refresh ACLs for changed security groups or fixed IPs."},{"line_number":428,"context_line":"            if detached_sg_ids or attached_sg_ids or is_fixed_ips_updated or ("}],"source_content_type":"text/x-python","patch_set":5,"id":"5f7c97a3_2820bc9a","line":425,"range":{"start_line":425,"start_character":56,"end_line":425,"end_character":57},"updated":"2018-05-16 12:32:23.000000000","message":"nit: parathesis around old_port_security is not needed...\n\nSimpler way to do it would be:\n\nport_security_changed \u003d (\n    utils.is_port_security_enabled(port) !\u003d bool(ovn_port.port_security))","commit_id":"9f5909c97daf321d8182cb0c4d6de53d7a073a6a"}]}