)]}'
{"networking_ovn/common/config.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5af75976198da762231f8e98fd5487afc7d5703f","unresolved":false,"context_lines":[{"line_number":75,"context_line":"                      \u0027connection transaction\u0027)),"},{"line_number":76,"context_line":"    cfg.IntOpt(\u0027ovsdb_probe_interval\u0027,"},{"line_number":77,"context_line":"               min\u003d0,"},{"line_number":78,"context_line":"               default\u003d60000,"},{"line_number":79,"context_line":"               help\u003d_(\u0027The probe interval in for the OVSDB session in \u0027"},{"line_number":80,"context_line":"                      \u0027milliseconds. If this is zero, it disables the \u0027"},{"line_number":81,"context_line":"                      \u0027connection keepalive feature. If non-zero the value \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_aa65401f","line":78,"range":{"start_line":78,"start_character":15,"end_line":78,"end_character":29},"updated":"2018-05-22 13:10:28.000000000","message":"Question: Is 60s too long for a probe or it\u0027s good in your tests ?\n\nI know defaults are hard but, I just want to try to get a optimal value here so we do not have to change it again.\n\nFWIW, the default in OVS python library is 5s (I do find 5s very aggressive tho)","commit_id":"0017493bcb12d1eebef76be93685fbe7b973c94f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7fccaf04052e4ab9b49817ff2cbeee5ad403c05c","unresolved":false,"context_lines":[{"line_number":79,"context_line":"               help\u003d_(\u0027The probe interval in for the OVSDB session in \u0027"},{"line_number":80,"context_line":"                      \u0027milliseconds. If this is zero, it disables the \u0027"},{"line_number":81,"context_line":"                      \u0027connection keepalive feature. If non-zero the value \u0027"},{"line_number":82,"context_line":"                      \u0027will be forced to at least 1000 milliseconds. Probing \u0027"},{"line_number":83,"context_line":"                      \u0027is disabled by default.\u0027)),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027neutron_sync_mode\u0027,"},{"line_number":85,"context_line":"               default\u003d\u0027log\u0027,"},{"line_number":86,"context_line":"               choices\u003d(\u0027off\u0027, \u0027log\u0027, \u0027repair\u0027),"}],"source_content_type":"text/x-python","patch_set":1,"id":"5f7c97a3_8aef2486","line":83,"range":{"start_line":82,"start_character":69,"end_line":83,"end_character":47},"updated":"2018-05-22 13:00:17.000000000","message":"It\u0027s not disabled anymore.\n\nAlso, since this is changing a configuration option default, we will need a release note so the users are aware of the change.","commit_id":"0017493bcb12d1eebef76be93685fbe7b973c94f"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cd551c2826a21bd9e1f697ba1e5f1e3ac9a48653","unresolved":false,"context_lines":[{"line_number":80,"context_line":"                      \u0027milliseconds. If this is zero, it disables the \u0027"},{"line_number":81,"context_line":"                      \u0027connection keepalive feature. If non-zero the value \u0027"},{"line_number":82,"context_line":"                      \u0027will be forced to at least 1000 milliseconds. Probing \u0027"},{"line_number":83,"context_line":"                      \u0027is set to 60 seonds by default.\u0027)),"},{"line_number":84,"context_line":"    cfg.StrOpt(\u0027neutron_sync_mode\u0027,"},{"line_number":85,"context_line":"               default\u003d\u0027log\u0027,"},{"line_number":86,"context_line":"               choices\u003d(\u0027off\u0027, \u0027log\u0027, \u0027repair\u0027),"}],"source_content_type":"text/x-python","patch_set":2,"id":"5f7c97a3_2dc06a7c","line":83,"range":{"start_line":83,"start_character":36,"end_line":83,"end_character":42},"updated":"2018-05-22 13:41:09.000000000","message":"seconds\n\nYou can write it as \"... Defaults to 60 seconds.\" To make it shorter as well, if u want to.","commit_id":"8a40a3d18dfa57fb3671de66bad1b1ec03c5f17d"}],"releasenotes/notes/ovsdb-probe-interval-to-60-secs-cb4d3c5ec930f4a8.yaml":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cd551c2826a21bd9e1f697ba1e5f1e3ac9a48653","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ovsdb_probe_interval is changed in the default configuration from 0"},{"line_number":5,"context_line":"    (disabled) to 60 seconds."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_ad39daa3","line":4,"range":{"start_line":4,"start_character":25,"end_line":4,"end_character":27},"updated":"2018-05-22 13:41:09.000000000","message":"was changed\n\nMay I suggest:\n\n\"The default value for ovsdb_probe_inteterval was changed from 0 (disabled) to 60 seconds.\"","commit_id":"8a40a3d18dfa57fb3671de66bad1b1ec03c5f17d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"21de9e124dacb0f5ddd8a1da9dfa265431925c12","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    ovsdb_probe_interval is changed in the default configuration from 0"},{"line_number":5,"context_line":"    (disabled) to 60 seconds."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_0d732e82","line":4,"range":{"start_line":4,"start_character":25,"end_line":4,"end_character":27},"in_reply_to":"5f7c97a3_ad39daa3","updated":"2018-05-22 13:43:53.000000000","message":"Or even, \"for the ovsdb_probe_interval configuration option was changed\"","commit_id":"8a40a3d18dfa57fb3671de66bad1b1ec03c5f17d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cd551c2826a21bd9e1f697ba1e5f1e3ac9a48653","unresolved":false,"context_lines":[{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"},{"line_number":8,"context_line":"    In a HA environment, when OVSDB server fails over to a different"},{"line_number":9,"context_line":"    controller, it is not detected by neither neutron-server nor"},{"line_number":10,"context_line":"    ovn-metadata-agent. In order to fix this issue, a 60 seconds interval"},{"line_number":11,"context_line":"    probe is now sent by OVSDB server clients."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_edb91215","line":9,"range":{"start_line":9,"start_character":16,"end_line":9,"end_character":25},"updated":"2018-05-22 13:41:09.000000000","message":"the connection change is not detect (maybe?)","commit_id":"8a40a3d18dfa57fb3671de66bad1b1ec03c5f17d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9eef8b1dfbfac75a1483a77546b8738caf2df517","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"upgrade:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    For the ovsdb_probe_interval configuration option was changed from"},{"line_number":5,"context_line":"    0 (disabled) to 60 seconds."},{"line_number":6,"context_line":"fixes:"},{"line_number":7,"context_line":"  - |"}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_0d21ee4d","line":4,"range":{"start_line":4,"start_character":4,"end_line":4,"end_character":7},"updated":"2018-05-22 13:49:26.000000000","message":"s/For//\n\nMaybe mention that it was the default value that changed ?","commit_id":"ca71f0aec89caf2eef5cc8a36c42e9a266e6ed1d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"9eef8b1dfbfac75a1483a77546b8738caf2df517","unresolved":false,"context_lines":[{"line_number":8,"context_line":"    In a HA environment, when OVSDB server fails over to a different"},{"line_number":9,"context_line":"    controller, the connection change is not detected by neither"},{"line_number":10,"context_line":"    neutron-server nor ovn-metadata-agent. In order to fix this issue,"},{"line_number":11,"context_line":"    a60 seconds interval probe is now sent by OVSDB server clients."}],"source_content_type":"text/x-yaml","patch_set":3,"id":"5f7c97a3_add55a1d","line":11,"range":{"start_line":11,"start_character":4,"end_line":11,"end_character":7},"updated":"2018-05-22 13:49:26.000000000","message":"a 60 seconds interval probe (by default)","commit_id":"ca71f0aec89caf2eef5cc8a36c42e9a266e6ed1d"}]}
