)]}'
{"migration/tripleo_environment/playbooks/roles/activate-ovn/templates/activate-ovn.sh.j2":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"0a1c24a28cc529db78c13542a3a33766ec850f27","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ovn_container_id\u003d`docker ps | grep ovn-controller | awk \u0027{print $1}\u0027`"},{"line_number":16,"context_line":"docker restart $ovn_container_id"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Delete ovs bridges - br-tun and br-migration"},{"line_number":19,"context_line":"ovs-vsctl --if-exists del-br {{ tunnel_bridge }}"},{"line_number":20,"context_line":"ovs-vsctl --if-exists del-br br-migration"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_ecc87822","line":18,"updated":"2018-06-15 14:10:58.000000000","message":"What about br-trunk if trunk ports was used?","commit_id":"9c8ec19f8fa717805ff053fd715a13c401757350"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"0a62ef8a732b65c4f63fa145d23272ce9b05fd0b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"ovn_container_id\u003d`docker ps | grep ovn-controller | awk \u0027{print $1}\u0027`"},{"line_number":16,"context_line":"docker restart $ovn_container_id"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"# Delete ovs bridges - br-tun and br-migration"},{"line_number":19,"context_line":"ovs-vsctl --if-exists del-br {{ tunnel_bridge }}"},{"line_number":20,"context_line":"ovs-vsctl --if-exists del-br br-migration"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-jinja2","patch_set":1,"id":"5f7c97a3_5c44b547","line":18,"in_reply_to":"5f7c97a3_ecc87822","updated":"2018-06-15 20:54:13.000000000","message":"We\u0027re not handling that in this iteration, may be when we get to re-plug nova ports (from br-trunk to br-int).\n\nBecause we need to update nova/libvirt/etc etc.. \n\nLet\u0027s follow up on that when the standard case is finished.","commit_id":"9c8ec19f8fa717805ff053fd715a13c401757350"}],"migration/tripleo_environment/playbooks/roles/cleanup/tasks/main.yml":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"0a1c24a28cc529db78c13542a3a33766ec850f27","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    if ip netns | egrep -e \"{{ item.value.netns_regex }}\""},{"line_number":18,"context_line":"    then"},{"line_number":19,"context_line":"      echo \"Cleaning up\""},{"line_number":20,"context_line":"      cmd\u003d\"$(paunch debug --file {{ ovn_migration_backups }}/tripleo-config/hashed-docker-container-startup-config-step_4.json \\"},{"line_number":21,"context_line":"                  --action print-cmd --container {{ item.key }} \\"},{"line_number":22,"context_line":"                  --interactive | \\"},{"line_number":23,"context_line":"                  sed \u0027s/--interactive /--volume\u003d\\/tmp\\/cleanup-{{ item.key }}.sh:\\/cleanup.sh:ro /g \u0027 )\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_0c737418","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":19},"updated":"2018-06-15 14:10:58.000000000","message":"I think we can assume that paunch will always be installed?","commit_id":"9c8ec19f8fa717805ff053fd715a13c401757350"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"0a62ef8a732b65c4f63fa145d23272ce9b05fd0b","unresolved":false,"context_lines":[{"line_number":17,"context_line":"    if ip netns | egrep -e \"{{ item.value.netns_regex }}\""},{"line_number":18,"context_line":"    then"},{"line_number":19,"context_line":"      echo \"Cleaning up\""},{"line_number":20,"context_line":"      cmd\u003d\"$(paunch debug --file {{ ovn_migration_backups }}/tripleo-config/hashed-docker-container-startup-config-step_4.json \\"},{"line_number":21,"context_line":"                  --action print-cmd --container {{ item.key }} \\"},{"line_number":22,"context_line":"                  --interactive | \\"},{"line_number":23,"context_line":"                  sed \u0027s/--interactive /--volume\u003d\\/tmp\\/cleanup-{{ item.key }}.sh:\\/cleanup.sh:ro /g \u0027 )\""}],"source_content_type":"text/x-yaml","patch_set":1,"id":"5f7c97a3_1c787d8d","line":20,"range":{"start_line":20,"start_character":13,"end_line":20,"end_character":19},"in_reply_to":"5f7c97a3_0c737418","updated":"2018-06-15 20:54:13.000000000","message":"Yes it\u0027s what they use via paunch apply to setup all the containers, so yes.","commit_id":"9c8ec19f8fa717805ff053fd715a13c401757350"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"de5b867fe26d88efe9638328064db42c6f4de5b5","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  register: out"},{"line_number":13,"context_line":"  changed_when: \"\u0027Security groups cleaned\u0027 in out.stdout\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Cleanup neutron datapath resources"},{"line_number":16,"context_line":"  shell: |"},{"line_number":17,"context_line":"    if ip netns | egrep -e \"{{ item.value.netns_regex }}\""},{"line_number":18,"context_line":"    then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_8b95f3e5","line":15,"updated":"2018-06-19 08:36:49.000000000","message":"I think it is better to move this task above. The reason being that earlier we cleanup the qr and qg interfaces from br-int, better it is. What happens is that these interfaces are present in multiple chassis with iface-id set. So ovn-controller\u0027s keep fighting to bind these ports.\n\nThoughts ?","commit_id":"a0df75da0378c8e3f1e3527c345a3e4c5a0a8227"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"b685c5f85212fe1f3df5bb498a84571240e9e563","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  register: out"},{"line_number":13,"context_line":"  changed_when: \"\u0027Security groups cleaned\u0027 in out.stdout\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Cleanup neutron datapath resources"},{"line_number":16,"context_line":"  shell: |"},{"line_number":17,"context_line":"    if ip netns | egrep -e \"{{ item.value.netns_regex }}\""},{"line_number":18,"context_line":"    then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_919526e6","line":15,"in_reply_to":"5f7c97a3_8b95f3e5","updated":"2018-06-19 09:05:06.000000000","message":"Good one Numan!\n\nWe can may be do a two pass\n\n1) Use the cmdline tools as you did, but only clear the iface-id (before)\n2) Run this. (after)\n\nhow does that sound?","commit_id":"a0df75da0378c8e3f1e3527c345a3e4c5a0a8227"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"7bddf710269e98c1db7a340eb136e27d4623d1d6","unresolved":false,"context_lines":[{"line_number":12,"context_line":"  register: out"},{"line_number":13,"context_line":"  changed_when: \"\u0027Security groups cleaned\u0027 in out.stdout\""},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"- name: Cleanup neutron datapath resources"},{"line_number":16,"context_line":"  shell: |"},{"line_number":17,"context_line":"    if ip netns | egrep -e \"{{ item.value.netns_regex }}\""},{"line_number":18,"context_line":"    then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_f4c24886","line":15,"in_reply_to":"5f7c97a3_919526e6","updated":"2018-06-19 09:21:12.000000000","message":"Agree. Sounds good to me.","commit_id":"a0df75da0378c8e3f1e3527c345a3e4c5a0a8227"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"de5b867fe26d88efe9638328064db42c6f4de5b5","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  with_dict: \"{{ agent_cleanups }}\""},{"line_number":41,"context_line":"  register: out"},{"line_number":42,"context_line":"  changed_when: \"\u0027Cleaning up\u0027 in out.stdout\""},{"line_number":43,"context_line":""},{"line_number":44,"context_line":""},{"line_number":45,"context_line":""},{"line_number":46,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_2b593f8d","line":43,"updated":"2018-06-19 08:36:49.000000000","message":"There seems to be 4 unnecessary new lines.","commit_id":"a0df75da0378c8e3f1e3527c345a3e4c5a0a8227"}]}