)]}'
{"migration/tripleo_environment/playbooks/migrate.yml":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"d42ad9b15e5c3b43d062af5d255a9f5487d7a747","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        # safely, without disrupting the existing neutron ml2/ovs dataplane."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"        OVN_MIG_PREFIX\u003dbr-mig"},{"line_number":15,"context_line":"        OVN_MIGRATION_BACKUPS\u003d{{ ovn_migration_backups }}"},{"line_number":16,"context_line":"        OVN_BR_MIGRATION\u003d${OVN_BR_MIGRATION:-br-migration}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        function recreate_bridge_mappings() {"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_51a19791","line":15,"updated":"2018-07-27 14:29:58.000000000","message":"Where is the param - {{ ovn_migration_backups }} defined ?\n\nIn the activate-ovn.sh.j2 I see that the path used is \"/var/lib/.../ovn_bridge_mappings\"\n\nInstead of storing the original bridge mappings in the file, I suggest storing it in ovs db itself.\n\nlike\novs-vsctl set open . external_ids:ovn-orig-bridge-mappings\u003d$orig_bms\n\nI think it would be safer this way.\n\novn action script can copy from external_ids:ovn-orig-bridge-mappings to external_ids:ovn-bridge-mappins and delete external_ids:ovn-orig-bridge-mappings.","commit_id":"539e50014bd6a941fabbdaf7c0f6c9039607476f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"722eac4e2852a0007c0a044b39525f65a2e9291c","unresolved":false,"context_lines":[{"line_number":12,"context_line":"        # safely, without disrupting the existing neutron ml2/ovs dataplane."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"        OVN_MIG_PREFIX\u003dbr-mig"},{"line_number":15,"context_line":"        OVN_MIGRATION_BACKUPS\u003d{{ ovn_migration_backups }}"},{"line_number":16,"context_line":"        OVN_BR_MIGRATION\u003d${OVN_BR_MIGRATION:-br-migration}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        function recreate_bridge_mappings() {"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_ee498865","line":15,"in_reply_to":"5f7c97a3_51a19791","updated":"2018-08-01 08:44:19.000000000","message":"{{ ovn_migration_backups }} is defined in the inventory file, although I will put all the default vars somewhere in the roles on the follow up refactor I was talking about.\n\n+1 to using an additional variable in the external_ids for saving it :) I\u0027ll change it.","commit_id":"539e50014bd6a941fabbdaf7c0f6c9039607476f"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"d42ad9b15e5c3b43d062af5d255a9f5487d7a747","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        OVN_MIGRATION_BACKUPS\u003d{{ ovn_migration_backups }}"},{"line_number":16,"context_line":"        OVN_BR_MIGRATION\u003d${OVN_BR_MIGRATION:-br-migration}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        function recreate_bridge_mappings() {"},{"line_number":19,"context_line":"                function new_bridge_mappings() {"},{"line_number":20,"context_line":"                    orig_bms\u003d$1"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_d17fe7db","line":18,"updated":"2018-07-27 14:29:58.000000000","message":"I wonder if we really need to create fake \"ovn-mig-x\" bridges. I don\u0027t understand the benefit.\n\nCan\u0027t we just \n 1. Copy external_ids:ovn-bridge-mappings to external_ids:ovn-orig-brdige-mappings\n \n 2. Delete external_ids:ovn-bridge-mappings\n\n 3. Sync dbs\n\n and\n 4. Copy back external_ids:ovn-bridge-mappings.\n\n\nIn your proposed case, ovn-controller will create a patch port from br-migration to br-mig-x and eventually these would be deleted. when ovn-controllers are activated back, they will anyway create bridge mappings from br-int to br-ex (if in case the chassis hosts gw ports of provider bridge ports).\n\nIs your worry is that, ovn-controller will not bind the gateway ports or provider bridge ports if bridge mappings are not present ?\n\nI think even if there is no bridge mapping defined, ovn-controllers still bind the gw router ports. (i.e set the chassis column of these ports in port_bindings table).\n\nCan you please confirm if this is the case ? I will try to verify in my devstack setup.\n\nCertainly there is no harm in your proposed approach. But it would be good if this can be avoided.","commit_id":"539e50014bd6a941fabbdaf7c0f6c9039607476f"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"98a79187b1951faba50d9f81a564e9b783e451cb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        OVN_MIGRATION_BACKUPS\u003d{{ ovn_migration_backups }}"},{"line_number":16,"context_line":"        OVN_BR_MIGRATION\u003d${OVN_BR_MIGRATION:-br-migration}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        function recreate_bridge_mappings() {"},{"line_number":19,"context_line":"                function new_bridge_mappings() {"},{"line_number":20,"context_line":"                    orig_bms\u003d$1"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_cee28cd3","line":18,"in_reply_to":"5f7c97a3_8e3814cb","updated":"2018-08-01 09:03:29.000000000","message":"I didn\u0027t think of VMs directly hooked to the provider network.\n+1 on this approach.","commit_id":"539e50014bd6a941fabbdaf7c0f6c9039607476f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"722eac4e2852a0007c0a044b39525f65a2e9291c","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        OVN_MIGRATION_BACKUPS\u003d{{ ovn_migration_backups }}"},{"line_number":16,"context_line":"        OVN_BR_MIGRATION\u003d${OVN_BR_MIGRATION:-br-migration}"},{"line_number":17,"context_line":""},{"line_number":18,"context_line":"        function recreate_bridge_mappings() {"},{"line_number":19,"context_line":"                function new_bridge_mappings() {"},{"line_number":20,"context_line":"                    orig_bms\u003d$1"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_8e3814cb","line":18,"in_reply_to":"5f7c97a3_d17fe7db","updated":"2018-08-01 08:44:19.000000000","message":"I believe that the closer it is to the final arrangement, the riskless it will be, for example if it needs to activate specific resources based on provider bridges being available or not (for example VM ports which are directly attached to provider networks)..\n\nSo I prefer to keep this way, may be now it could be safe, but I want it to be safe for any future version of ovn too.","commit_id":"539e50014bd6a941fabbdaf7c0f6c9039607476f"},{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"d42ad9b15e5c3b43d062af5d255a9f5487d7a747","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                    echo $final_bm"},{"line_number":45,"context_line":"                }"},{"line_number":46,"context_line":"                ovn_orig_bm\u003d$(ovs-vsctl get open . external_ids:ovn-bridge-mappings)"},{"line_number":47,"context_line":"                ovn_orig_bm\u003d\"datacentre:br-ex\""},{"line_number":48,"context_line":"                new_mapping\u003d$(new_bridge_mappings $ovn_orig_bm)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"                if [[ ! -f $OVN_MIGRATION_BACKUPS/ovn_bridge_mappings ]]; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_f1cea38d","line":47,"updated":"2018-07-27 14:29:58.000000000","message":"confused between L46 and L47. You are hardcoding the value there by overriding the original value read from external_ids:ovn-bridge-mappings.","commit_id":"539e50014bd6a941fabbdaf7c0f6c9039607476f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"722eac4e2852a0007c0a044b39525f65a2e9291c","unresolved":false,"context_lines":[{"line_number":44,"context_line":"                    echo $final_bm"},{"line_number":45,"context_line":"                }"},{"line_number":46,"context_line":"                ovn_orig_bm\u003d$(ovs-vsctl get open . external_ids:ovn-bridge-mappings)"},{"line_number":47,"context_line":"                ovn_orig_bm\u003d\"datacentre:br-ex\""},{"line_number":48,"context_line":"                new_mapping\u003d$(new_bridge_mappings $ovn_orig_bm)"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"                if [[ ! -f $OVN_MIGRATION_BACKUPS/ovn_bridge_mappings ]]; then"}],"source_content_type":"text/x-yaml","patch_set":2,"id":"5f7c97a3_6e66d8f0","line":47,"in_reply_to":"5f7c97a3_f1cea38d","updated":"2018-08-01 08:44:19.000000000","message":"ouch, need to remove 47, I did it during testing because I had destroyed the original bridge mappings :D\n\nChanging it now.","commit_id":"539e50014bd6a941fabbdaf7c0f6c9039607476f"}],"migration/tripleo_environment/playbooks/roles/activate-ovn/templates/activate-ovn.sh.j2":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"d42ad9b15e5c3b43d062af5d255a9f5487d7a747","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# restore bridge mappings"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ovs-vsctl set open . \\"},{"line_number":10,"context_line":"     external_ids:ovn-bridge-mappings\u003d$(cat /var/lib/ovn-migration-backup/ovn_bridge_mappings)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"ovn_bms\u003d$(cat /var/lib/ovn-migration-backup/ovn_bridge_mappings | sed \u0027s/\\\"//g\u0027 | sed \u0027s/,/ /g\u0027)"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_d158478a","line":10,"updated":"2018-07-27 14:29:58.000000000","message":"Please see my comment in other file.","commit_id":"539e50014bd6a941fabbdaf7c0f6c9039607476f"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"722eac4e2852a0007c0a044b39525f65a2e9291c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"# restore bridge mappings"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"ovs-vsctl set open . \\"},{"line_number":10,"context_line":"     external_ids:ovn-bridge-mappings\u003d$(cat /var/lib/ovn-migration-backup/ovn_bridge_mappings)"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":""},{"line_number":13,"context_line":"ovn_bms\u003d$(cat /var/lib/ovn-migration-backup/ovn_bridge_mappings | sed \u0027s/\\\"//g\u0027 | sed \u0027s/,/ /g\u0027)"}],"source_content_type":"text/x-jinja2","patch_set":2,"id":"5f7c97a3_2e5c6018","line":10,"in_reply_to":"5f7c97a3_d158478a","updated":"2018-08-01 08:44:19.000000000","message":"ack, I will use another var in external_ids :)","commit_id":"539e50014bd6a941fabbdaf7c0f6c9039607476f"}],"migration/tripleo_environment/playbooks/roles/clone-dataplane/templates/clone-br-int.sh.j2":[{"author":{"_account_id":10237,"name":"Numan Siddique","email":"nusiddiq@redhat.com","username":"numansiddique"},"change_message_id":"d270fb88e4af7f1fc650135c3799006c88b77f2d","unresolved":false,"context_lines":[{"line_number":9,"context_line":"OVN_BR_MIGRATION\u003d${OVN_BR_MIGRATION:-br-migration}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"function recreate_bridge_mappings() {"},{"line_number":12,"context_line":"\tfunction new_bridge_mappings() {"},{"line_number":13,"context_line":"\t    orig_bms\u003d$1"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\t    if echo $orig_bms | grep $OVN_MIG_PREFIX; then"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_84d747c0","line":12,"updated":"2018-08-07 10:19:08.000000000","message":"Small nitpick - tabs are used here instead of spaces.","commit_id":"8016ee4d31c4b69ebd72a2b3dffc2bdd782936f4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"bebd1ba946b17e99d67550d0d8222d6550077bd2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"OVN_BR_MIGRATION\u003d${OVN_BR_MIGRATION:-br-migration}"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"function recreate_bridge_mappings() {"},{"line_number":12,"context_line":"\tfunction new_bridge_mappings() {"},{"line_number":13,"context_line":"\t    orig_bms\u003d$1"},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"\t    if echo $orig_bms | grep $OVN_MIG_PREFIX; then"}],"source_content_type":"text/x-jinja2","patch_set":6,"id":"3f79a3b5_8400a736","line":12,"in_reply_to":"3f79a3b5_84d747c0","updated":"2018-08-07 10:19:59.000000000","message":"Ohh, damnit, ok, if I need to recheck I will remove the tabs :)\ntabs--\n\nThanks Numans!","commit_id":"8016ee4d31c4b69ebd72a2b3dffc2bdd782936f4"}],"migration/tripleo_environment/playbooks/roles/sync-dbs/tasks/main.yml":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"427673aff1831892698dc8b9ab7253070c6edf48","unresolved":false,"context_lines":[{"line_number":16,"context_line":"               neutron-ovn-db-sync-util --config-file /etc/neutron/neutron.conf"},{"line_number":17,"context_line":"               --config-file /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":18,"context_line":"               --ovn-neutron_sync_mode repair"},{"line_number":19,"context_line":"    - name: Pause and let ovn-controllers settle before doing the final activation (1 minute)"},{"line_number":20,"context_line":"      pause: minutes\u003d5"},{"line_number":21,"context_line":"  when: ovn_central is defined"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_509566e3","line":19,"range":{"start_line":19,"start_character":84,"end_line":19,"end_character":93},"updated":"2018-08-07 12:47:08.000000000","message":"This comment is wrong as we\u0027re stopping 5 minutes :)","commit_id":"8016ee4d31c4b69ebd72a2b3dffc2bdd782936f4"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"335cf43a06c56d9d671492f596950525c6049893","unresolved":false,"context_lines":[{"line_number":16,"context_line":"               neutron-ovn-db-sync-util --config-file /etc/neutron/neutron.conf"},{"line_number":17,"context_line":"               --config-file /etc/neutron/plugins/ml2/ml2_conf.ini"},{"line_number":18,"context_line":"               --ovn-neutron_sync_mode repair"},{"line_number":19,"context_line":"    - name: Pause and let ovn-controllers settle before doing the final activation (1 minute)"},{"line_number":20,"context_line":"      pause: minutes\u003d5"},{"line_number":21,"context_line":"  when: ovn_central is defined"}],"source_content_type":"text/x-yaml","patch_set":6,"id":"3f79a3b5_598fd129","line":19,"range":{"start_line":19,"start_character":84,"end_line":19,"end_character":93},"in_reply_to":"3f79a3b5_509566e3","updated":"2018-08-07 14:31:34.000000000","message":"oops, I will fix it in the follow up refactor, Thank you Daniel!","commit_id":"8016ee4d31c4b69ebd72a2b3dffc2bdd782936f4"}]}
