)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"3ebde41f1bf258e6fd0472b5a191f7a1e5541fc6","unresolved":false,"context_lines":[{"line_number":13,"context_line":"Prior to this patch, it was checked straight away and sometimes it"},{"line_number":14,"context_line":"it didn\u0027t match the expected value."},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"Change-Id: Ia5308cda75571b624f84efa83cffe2acdc04f097"},{"line_number":17,"context_line":"Related-Bug: #1719574"},{"line_number":18,"context_line":"Signed-off-by: Daniel Alvarez \u003cdalvarez@redhat.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"3f79a3b5_e7a9ef77","line":16,"updated":"2018-10-24 16:56:45.000000000","message":"Co-Authored-By: Terry Wilson \u003ctwilson@redhat.com\u003e","commit_id":"429c65c554a75f969fd74cbad07ae713cca9d029"}],"networking_ovn/tests/functional/test_metadata_agent.py":[{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"03680a13720a7f8df37e916f7ee75fe535dfdc53","unresolved":false,"context_lines":[{"line_number":76,"context_line":"                return int(chassis_row[\u0027external_ids\u0027]["},{"line_number":77,"context_line":"                    ovn_const.OVN_AGENT_METADATA_SB_CFG_KEY])"},{"line_number":78,"context_line":"            except KeyError:"},{"line_number":79,"context_line":"                raise self.MetadataSBCFGNotFoundException"},{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        def _check_metadata_sb_cfg_value(expected_val):"},{"line_number":82,"context_line":"            try:"}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_633653eb","line":79,"range":{"start_line":79,"start_character":22,"end_line":79,"end_character":57},"updated":"2018-10-23 14:16:24.000000000","message":"oh, the scope is wrong, not self.MetadataSBCFGNotFoundException ... just MetadataSBCFGNotFoundException :-)\n\nIt\u0027s failing because of that http://logs.openstack.org/60/612660/2/check/networking-ovn-dsvm-functional/b5c41bf/logs/testr_results.html.gz\n\nI\u0027ll update the version right away.","commit_id":"5e365d8615581d4af121a9e97185d832268c77dc"},{"author":{"_account_id":8788,"name":"Miguel Angel Ajo","email":"mangelajo@redhat.com","username":"mangelajo"},"change_message_id":"ededcae8c0f4c2243e69e3224ba37cf62cb62204","unresolved":false,"context_lines":[{"line_number":80,"context_line":""},{"line_number":81,"context_line":"        def _check_metadata_sb_cfg_value(expected_val):"},{"line_number":82,"context_line":"            try:"},{"line_number":83,"context_line":"                return expected_val \u003d\u003d _get_metadata_sb_cfg_value()"},{"line_number":84,"context_line":"            except self.MetadataSBCFGNotFoundException:"},{"line_number":85,"context_line":"                return False"},{"line_number":86,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"3f79a3b5_cf43d06a","line":83,"updated":"2018-10-23 12:17:24.000000000","message":"I\u0027d be happier with a \u003e\u003d so it\u0027s more future proof, but, well, as discussed on irc, the dependencies are only us (networking-ovn) not neutron. this WFM.","commit_id":"5e365d8615581d4af121a9e97185d832268c77dc"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"d400b932c5b8a60af9578a49d01db65629cf8497","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # from the chassis with the nb_cfg, 2 revisions, one for the network"},{"line_number":102,"context_line":"        # transaction another one for the port"},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            n_utils.wait_until_true(_check_metadata_sb_cfg_value_ge(2),"},{"line_number":105,"context_line":"                                    timeout\u003d5)"},{"line_number":106,"context_line":"        except n_utils.WaitTimeout:"},{"line_number":107,"context_line":"            self.fail(\u0027OVN_AGENT_METADATA_SB_CFG_KEY !\u003d 2\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_5923ff06","line":104,"updated":"2018-10-23 20:26:35.000000000","message":"One very clean way to do this is like I did here: https://github.com/openstack/ovsdbapp/blob/62a619024ad332ad088108ece098d90aa5c3e159/ovsdbapp/tests/functional/schema/ovn_southbound/test_impl_idl.py#L25\n\nthat way you just create a RowEvent, watch it, and then can just call wait() on.","commit_id":"f1f6549e46fc4fbe6fceb58c88866caea1522a22"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"6cd354e4ebb15ba1372cb80f84fe361ee2af8ae5","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # from the chassis with the nb_cfg, 2 revisions, one for the network"},{"line_number":102,"context_line":"        # transaction another one for the port"},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            n_utils.wait_until_true(_check_metadata_sb_cfg_value_ge(2),"},{"line_number":105,"context_line":"                                    timeout\u003d5)"},{"line_number":106,"context_line":"        except n_utils.WaitTimeout:"},{"line_number":107,"context_line":"            self.fail(\u0027OVN_AGENT_METADATA_SB_CFG_KEY !\u003d 2\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_dff7e58d","line":104,"in_reply_to":"3f79a3b5_5923ff06","updated":"2018-10-24 09:12:16.000000000","message":"Can I match on a key of a column? [0]\nI\u0027m trying to check a external-id and also now this patch tests for \u0027\u003e\u003d\u0027 while looks like only \u0027\u003d\u0027 and \u0027!\u003d\u0027 conditions are supported [1]\n\n[0] https://github.com/openstack/ovsdbapp/blob/62a619024ad332ad088108ece098d90aa5c3e159/ovsdbapp/backend/ovs_idl/idlutils.py#L173\n[1] https://github.com/openstack/ovsdbapp/blob/62a619024ad332ad088108ece098d90aa5c3e159/ovsdbapp/backend/ovs_idl/idlutils.py#L204","commit_id":"f1f6549e46fc4fbe6fceb58c88866caea1522a22"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"c23045378e8e62cb83a84e5892da0755f8d55940","unresolved":false,"context_lines":[{"line_number":101,"context_line":"        # from the chassis with the nb_cfg, 2 revisions, one for the network"},{"line_number":102,"context_line":"        # transaction another one for the port"},{"line_number":103,"context_line":"        try:"},{"line_number":104,"context_line":"            n_utils.wait_until_true(_check_metadata_sb_cfg_value_ge(2),"},{"line_number":105,"context_line":"                                    timeout\u003d5)"},{"line_number":106,"context_line":"        except n_utils.WaitTimeout:"},{"line_number":107,"context_line":"            self.fail(\u0027OVN_AGENT_METADATA_SB_CFG_KEY !\u003d 2\u0027)"}],"source_content_type":"text/x-python","patch_set":5,"id":"3f79a3b5_76def36b","line":104,"in_reply_to":"3f79a3b5_dff7e58d","updated":"2018-10-24 15:02:52.000000000","message":"You can work around that by overriding RowEvent.matches() to just consider a match whatever you want and don\u0027t use \u0027conditions\u0027.","commit_id":"f1f6549e46fc4fbe6fceb58c88866caea1522a22"}]}