)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"5cbad9ed02b5984b75f6067dc8336527a191e0ea","unresolved":false,"context_lines":[{"line_number":5,"context_line":"CommitDate: 2018-12-14 17:00:32 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Documentation for Octavia\u0027s OVN Driver"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: If6b8623c31a511afb730d86c9917bafb680bd31f"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"3f79a3b5_ba90254e","line":8,"updated":"2018-12-17 14:12:45.000000000","message":"I think the commit message is self explanatory in this case but many times is nicer to have something more descriptive in the body like: this patch is adding a document for the Octavia driver describing advantages, limitations and basic usage of it...","commit_id":"dcf04d35a44b473a87154497b75d52a9c8abd6b1"}],"doc/source/admin/loadbalancer.rst":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"5cbad9ed02b5984b75f6067dc8336527a191e0ea","unresolved":false,"context_lines":[{"line_number":3,"context_line":""},{"line_number":4,"context_line":"Octavia has integrated support for provider drivers where any third party"},{"line_number":5,"context_line":"Load Balancer driver can be integrated with Octavia. Functionality related"},{"line_number":6,"context_line":"to this has been develeoped in OVN and now OVN can now be supported as a"},{"line_number":7,"context_line":"provider driver for Octavia."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVN Provider driver has few advantages when used a provider driver for Octavia"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_bae265fe","line":6,"range":{"start_line":6,"start_character":17,"end_line":6,"end_character":27},"updated":"2018-12-17 14:12:45.000000000","message":"developed","commit_id":"dcf04d35a44b473a87154497b75d52a9c8abd6b1"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"5cbad9ed02b5984b75f6067dc8336527a191e0ea","unresolved":false,"context_lines":[{"line_number":6,"context_line":"to this has been develeoped in OVN and now OVN can now be supported as a"},{"line_number":7,"context_line":"provider driver for Octavia."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVN Provider driver has few advantages when used a provider driver for Octavia"},{"line_number":10,"context_line":"like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* OVN can be deployed without VMs. So there is no additional overhead of VMs as"},{"line_number":13,"context_line":"  is required currently in Octavia (when using Amphora as the driver)."}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_1aad99a3","line":10,"range":{"start_line":9,"start_character":20,"end_line":10,"end_character":5},"updated":"2018-12-17 14:12:45.000000000","message":"This sounds weird to me, advantages over what? Truth is that I\u0027m not native Eng speaker :)","commit_id":"dcf04d35a44b473a87154497b75d52a9c8abd6b1"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"5cbad9ed02b5984b75f6067dc8336527a191e0ea","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Since OVN supports virtual networking for both VMs and containers, OVN as a"},{"line_number":20,"context_line":"  Load Balancer driver can be used succesfully with Kuryr Kubernetes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Limitations of OVN Provider Driver"},{"line_number":23,"context_line":"----------------------------------"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_fac1bd51","line":21,"updated":"2018-12-17 14:12:45.000000000","message":"I think it\u0027s worth mentioning the distributed nature of this implementation?","commit_id":"dcf04d35a44b473a87154497b75d52a9c8abd6b1"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"3d9f2082729c9bd761a1ea0c1af91d9d320a4479","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Since OVN supports virtual networking for both VMs and containers, OVN as a"},{"line_number":20,"context_line":"  Load Balancer driver can be used succesfully with Kuryr Kubernetes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Limitations of OVN Provider Driver"},{"line_number":23,"context_line":"----------------------------------"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_6a6ddc2e","line":21,"in_reply_to":"3f79a3b5_9adbe9e9","updated":"2018-12-17 15:57:52.000000000","message":"OVN load balancers when applied to a logical switch (not to a logical router) are distributed and happens on the ingress pipeline of the logical switch.","commit_id":"dcf04d35a44b473a87154497b75d52a9c8abd6b1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"08862aadfd062c8d634bafb695ec522d584d86d2","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Since OVN supports virtual networking for both VMs and containers, OVN as a"},{"line_number":20,"context_line":"  Load Balancer driver can be used succesfully with Kuryr Kubernetes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Limitations of OVN Provider Driver"},{"line_number":23,"context_line":"----------------------------------"},{"line_number":24,"context_line":""}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_9adbe9e9","line":21,"in_reply_to":"3f79a3b5_fac1bd51","updated":"2018-12-17 14:25:38.000000000","message":"Distributed nature? Not sure about what you meant here :)","commit_id":"dcf04d35a44b473a87154497b75d52a9c8abd6b1"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"5cbad9ed02b5984b75f6067dc8336527a191e0ea","unresolved":false,"context_lines":[{"line_number":36,"context_line":"  and associated Pools i.e. Listener which can handle TCP protocol can only be"},{"line_number":37,"context_line":"  associated with pools associated to TCP protocol. Pools handling UDP protocol"},{"line_number":38,"context_line":"  cannot be linked with TCP based Listeners. This limitation though would be"},{"line_number":39,"context_line":"  handled in the upcoming release."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Creating OVN based Load Balancer"},{"line_number":42,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":4,"id":"3f79a3b5_7a9b6d77","line":39,"updated":"2018-12-17 14:12:45.000000000","message":"you mean networking-ovn major release? core OVM release?","commit_id":"dcf04d35a44b473a87154497b75d52a9c8abd6b1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48f8785bb9fac2c736a8cc324276cdebcac3732a","unresolved":false,"context_lines":[{"line_number":6,"context_line":"to this has been developed in OVN and now OVN can now be supported as a"},{"line_number":7,"context_line":"provider driver for Octavia."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVN Provider driver has few advantages when used a provider driver for Octavia"},{"line_number":10,"context_line":"over Amphora, like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* OVN can be deployed without VMs. So there is no additional overhead of VMs as"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_9b0d28dd","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":51},"updated":"2018-12-17 17:39:32.000000000","message":"nit: used as a","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e508692d23fd922aa2774957ccbefbab4ab3caa0","unresolved":false,"context_lines":[{"line_number":6,"context_line":"to this has been developed in OVN and now OVN can now be supported as a"},{"line_number":7,"context_line":"provider driver for Octavia."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"OVN Provider driver has few advantages when used a provider driver for Octavia"},{"line_number":10,"context_line":"over Amphora, like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* OVN can be deployed without VMs. So there is no additional overhead of VMs as"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_67e2e601","line":9,"range":{"start_line":9,"start_character":39,"end_line":9,"end_character":51},"in_reply_to":"3f79a3b5_9b0d28dd","updated":"2018-12-18 05:58:59.000000000","message":"I think this is correct. This is basically to tell people that you can use OVN +Octavia ( where both exist independently ) or when OVN is used as a driver for Octavia","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48f8785bb9fac2c736a8cc324276cdebcac3732a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"over Amphora, like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* OVN can be deployed without VMs. So there is no additional overhead of VMs as"},{"line_number":13,"context_line":"  is required currently in Octavia (when using Amphora as the driver)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* OVN Load Balancers can be deployed faster than default Load Balancers in"},{"line_number":16,"context_line":"  Octavia (which use Amphora currently) because of no additional deployment"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_bbdd8441","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":69},"updated":"2018-12-17 17:39:32.000000000","message":"may I suggest: \"... as is required when using the default Amphora driver.\"\n\nCause \"Octavia\" itself doesn\u0027t require having the amphora provider driver always enabled, right ?","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e508692d23fd922aa2774957ccbefbab4ab3caa0","unresolved":false,"context_lines":[{"line_number":10,"context_line":"over Amphora, like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* OVN can be deployed without VMs. So there is no additional overhead of VMs as"},{"line_number":13,"context_line":"  is required currently in Octavia (when using Amphora as the driver)."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* OVN Load Balancers can be deployed faster than default Load Balancers in"},{"line_number":16,"context_line":"  Octavia (which use Amphora currently) because of no additional deployment"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_27b62efd","line":13,"range":{"start_line":13,"start_character":5,"end_line":13,"end_character":69},"in_reply_to":"3f79a3b5_bbdd8441","updated":"2018-12-18 05:58:59.000000000","message":"I think I can change it.","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48f8785bb9fac2c736a8cc324276cdebcac3732a","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  requirement."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Since OVN supports virtual networking for both VMs and containers, OVN as a"},{"line_number":20,"context_line":"  Load Balancer driver can be used succesfully with Kuryr Kubernetes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Limitations of OVN Provider Driver"},{"line_number":23,"context_line":"----------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_bbc6e469","line":20,"range":{"start_line":20,"start_character":52,"end_line":20,"end_character":68},"updated":"2018-12-17 17:39:32.000000000","message":"nit: add a link to the kuryr doc ?","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e508692d23fd922aa2774957ccbefbab4ab3caa0","unresolved":false,"context_lines":[{"line_number":17,"context_line":"  requirement."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"* Since OVN supports virtual networking for both VMs and containers, OVN as a"},{"line_number":20,"context_line":"  Load Balancer driver can be used succesfully with Kuryr Kubernetes."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"Limitations of OVN Provider Driver"},{"line_number":23,"context_line":"----------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_27c14efd","line":20,"range":{"start_line":20,"start_character":52,"end_line":20,"end_character":68},"in_reply_to":"3f79a3b5_bbc6e469","updated":"2018-12-18 05:58:59.000000000","message":"Done","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48f8785bb9fac2c736a8cc324276cdebcac3732a","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Limitations of OVN Provider Driver"},{"line_number":23,"context_line":"----------------------------------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"OVN has its own set of limitations , few of which are targetted to be resolved"},{"line_number":26,"context_line":"in the upcoming releases. These include:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* OVN currently supports TCP and UDP. So Layer-7 based Load Balancing is not"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_dbc16052","line":25,"range":{"start_line":25,"start_character":34,"end_line":25,"end_character":35},"updated":"2018-12-17 17:39:32.000000000","message":"extra space","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e508692d23fd922aa2774957ccbefbab4ab3caa0","unresolved":false,"context_lines":[{"line_number":22,"context_line":"Limitations of OVN Provider Driver"},{"line_number":23,"context_line":"----------------------------------"},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"OVN has its own set of limitations , few of which are targetted to be resolved"},{"line_number":26,"context_line":"in the upcoming releases. These include:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* OVN currently supports TCP and UDP. So Layer-7 based Load Balancing is not"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_67bbc6dd","line":25,"range":{"start_line":25,"start_character":34,"end_line":25,"end_character":35},"in_reply_to":"3f79a3b5_dbc16052","updated":"2018-12-18 05:58:59.000000000","message":"Done","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48f8785bb9fac2c736a8cc324276cdebcac3732a","unresolved":false,"context_lines":[{"line_number":26,"context_line":"in the upcoming releases. These include:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* OVN currently supports TCP and UDP. So Layer-7 based Load Balancing is not"},{"line_number":29,"context_line":"  possible with OVN. However, once Layer-7 support is integrated in OVN, this"},{"line_number":30,"context_line":"  issue can be resolved."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* There are no *Health Monitors* currently in OVN\u0027s Driver for Load Balancer."},{"line_number":33,"context_line":"  Therefore Health Checking is not possible with OVN."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_1ba598b3","line":30,"range":{"start_line":29,"start_character":21,"end_line":30,"end_character":24},"updated":"2018-12-17 17:39:32.000000000","message":"sounds a bit redundant since the topic (line 25) already says this will be addressed in the upcoming releases.","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e508692d23fd922aa2774957ccbefbab4ab3caa0","unresolved":false,"context_lines":[{"line_number":26,"context_line":"in the upcoming releases. These include:"},{"line_number":27,"context_line":""},{"line_number":28,"context_line":"* OVN currently supports TCP and UDP. So Layer-7 based Load Balancing is not"},{"line_number":29,"context_line":"  possible with OVN. However, once Layer-7 support is integrated in OVN, this"},{"line_number":30,"context_line":"  issue can be resolved."},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"* There are no *Health Monitors* currently in OVN\u0027s Driver for Load Balancer."},{"line_number":33,"context_line":"  Therefore Health Checking is not possible with OVN."}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_c7a17aa9","line":30,"range":{"start_line":29,"start_character":21,"end_line":30,"end_character":24},"in_reply_to":"3f79a3b5_1ba598b3","updated":"2018-12-18 05:58:59.000000000","message":"I have changed line#25","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48f8785bb9fac2c736a8cc324276cdebcac3732a","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Currently, OVN driver supports 1:1 protocol mapping between Listeners"},{"line_number":36,"context_line":"  and associated Pools i.e. Listener which can handle TCP protocol can only be"},{"line_number":37,"context_line":"  associated with pools associated to TCP protocol. Pools handling UDP protocol"},{"line_number":38,"context_line":"  cannot be linked with TCP based Listeners. This limitation though would be"},{"line_number":39,"context_line":"  handled in the upcoming core OVN release."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Creating OVN based Load Balancer"},{"line_number":42,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_bb8b4421","line":39,"range":{"start_line":38,"start_character":44,"end_line":39,"end_character":43},"updated":"2018-12-17 17:39:32.000000000","message":"same, sounds a bit redundant since the topic (line 25) already says this will be addressed in the upcoming releases.","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e508692d23fd922aa2774957ccbefbab4ab3caa0","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Currently, OVN driver supports 1:1 protocol mapping between Listeners"},{"line_number":36,"context_line":"  and associated Pools i.e. Listener which can handle TCP protocol can only be"},{"line_number":37,"context_line":"  associated with pools associated to TCP protocol. Pools handling UDP protocol"},{"line_number":38,"context_line":"  cannot be linked with TCP based Listeners. This limitation though would be"},{"line_number":39,"context_line":"  handled in the upcoming core OVN release."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Creating OVN based Load Balancer"},{"line_number":42,"context_line":"--------------------------------"}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_e7e3569e","line":39,"range":{"start_line":38,"start_character":44,"end_line":39,"end_character":43},"in_reply_to":"3f79a3b5_bb8b4421","updated":"2018-12-18 05:58:59.000000000","message":"Done","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"48f8785bb9fac2c736a8cc324276cdebcac3732a","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    [[post-config|$OCTAVIA_CONF]]"},{"line_number":70,"context_line":"    [api_settings]"},{"line_number":71,"context_line":"    enabled_provider_drivers \u003d amphora:\u0027Octavia Amphora driver\u0027,ovn:\u0027Octavia OVN driver\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Once DevStack run is complete, you can create a load balancer in Openstack::"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_5b0eb08e","line":71,"updated":"2018-12-17 17:39:32.000000000","message":"I wonder if it would be better to provide a complete .sample file for it ?\n\nWe do have different .sample files for devstack already, for example:\n\nhttps://github.com/openstack/networking-ovn/blob/master/devstack/local.conf.sample\n\nhttps://github.com/openstack/networking-ovn/blob/master/devstack/vtep-local.conf.sample\n\nhttps://github.com/openstack/networking-ovn/blob/master/devstack/db-local.conf.sample","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"e508692d23fd922aa2774957ccbefbab4ab3caa0","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    [[post-config|$OCTAVIA_CONF]]"},{"line_number":70,"context_line":"    [api_settings]"},{"line_number":71,"context_line":"    enabled_provider_drivers \u003d amphora:\u0027Octavia Amphora driver\u0027,ovn:\u0027Octavia OVN driver\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Once DevStack run is complete, you can create a load balancer in Openstack::"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_47956a3d","line":71,"in_reply_to":"3f79a3b5_5b0eb08e","updated":"2018-12-18 05:58:59.000000000","message":"I will add the sample file in a separate patch. This might not be the right patch to add it","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"29dbdfb12b7d3db234aa43972a1bfe4388a4530c","unresolved":false,"context_lines":[{"line_number":68,"context_line":""},{"line_number":69,"context_line":"    [[post-config|$OCTAVIA_CONF]]"},{"line_number":70,"context_line":"    [api_settings]"},{"line_number":71,"context_line":"    enabled_provider_drivers \u003d amphora:\u0027Octavia Amphora driver\u0027,ovn:\u0027Octavia OVN driver\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Once DevStack run is complete, you can create a load balancer in Openstack::"},{"line_number":74,"context_line":""}],"source_content_type":"text/x-rst","patch_set":5,"id":"3f79a3b5_7937eadd","line":71,"in_reply_to":"3f79a3b5_5b0eb08e","updated":"2018-12-18 06:17:05.000000000","message":"https://review.openstack.org/625795","commit_id":"32bd59dd99d07235561607c56c7f83f915efee33"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ef2c82c6c3ae29eb19d188243dbd6aa1324f168c","unresolved":false,"context_lines":[{"line_number":9,"context_line":"OVN Provider driver has few advantages when used a provider driver for Octavia"},{"line_number":10,"context_line":"over Amphora, like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* OVN can be deployed without VMs. So there is no additional overhead of VMs as"},{"line_number":13,"context_line":"  is required currently in Octavia when using  the default Amphora driver."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* OVN Load Balancers can be deployed faster than default Load Balancers in"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_cec42496","line":12,"updated":"2018-12-18 18:59:55.000000000","message":"This could be worded more simply like:\n\nOVN avoids the VM overhead of Octavia\u0027s Amphora driver.","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e27ee4b67de27d7c9106f409d3a92b41dbb20c9","unresolved":false,"context_lines":[{"line_number":9,"context_line":"OVN Provider driver has few advantages when used a provider driver for Octavia"},{"line_number":10,"context_line":"over Amphora, like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* OVN can be deployed without VMs. So there is no additional overhead of VMs as"},{"line_number":13,"context_line":"  is required currently in Octavia when using  the default Amphora driver."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* OVN Load Balancers can be deployed faster than default Load Balancers in"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_8aa92d27","line":12,"in_reply_to":"3f79a3b5_cec42496","updated":"2018-12-19 07:12:24.000000000","message":"I know, but I kept it like that because I wanted to highlight that OVN can be deployed without VMs :)","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ef2c82c6c3ae29eb19d188243dbd6aa1324f168c","unresolved":false,"context_lines":[{"line_number":10,"context_line":"over Amphora, like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* OVN can be deployed without VMs. So there is no additional overhead of VMs as"},{"line_number":13,"context_line":"  is required currently in Octavia when using  the default Amphora driver."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* OVN Load Balancers can be deployed faster than default Load Balancers in"},{"line_number":16,"context_line":"  Octavia (which use Amphora currently) because of no additional deployment"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_ae71a89b","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":47},"updated":"2018-12-18 18:59:55.000000000","message":"two spaces","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e27ee4b67de27d7c9106f409d3a92b41dbb20c9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"over Amphora, like:"},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"* OVN can be deployed without VMs. So there is no additional overhead of VMs as"},{"line_number":13,"context_line":"  is required currently in Octavia when using  the default Amphora driver."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"* OVN Load Balancers can be deployed faster than default Load Balancers in"},{"line_number":16,"context_line":"  Octavia (which use Amphora currently) because of no additional deployment"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_aaa66954","line":13,"range":{"start_line":13,"start_character":45,"end_line":13,"end_character":47},"in_reply_to":"3f79a3b5_ae71a89b","updated":"2018-12-19 07:12:24.000000000","message":"Done","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ef2c82c6c3ae29eb19d188243dbd6aa1324f168c","unresolved":false,"context_lines":[{"line_number":32,"context_line":"* There are no *Health Monitors* currently in OVN\u0027s Driver for Load Balancer."},{"line_number":33,"context_line":"  Therefore Health Checking is not possible with OVN."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Currently, OVN driver supports 1:1 protocol mapping between Listeners"},{"line_number":36,"context_line":"  and associated Pools i.e. Listener which can handle TCP protocol can only be"},{"line_number":37,"context_line":"  associated with pools associated to TCP protocol. Pools handling UDP protocol"},{"line_number":38,"context_line":"  cannot be linked with TCP based Listeners. This limitation though would be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_8e686c89","line":35,"range":{"start_line":35,"start_character":33,"end_line":35,"end_character":54},"updated":"2018-12-18 18:59:55.000000000","message":"either \"supports 1:1 protocol mappings\" or \"supports a 1:1 protocol mapping\"","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e27ee4b67de27d7c9106f409d3a92b41dbb20c9","unresolved":false,"context_lines":[{"line_number":32,"context_line":"* There are no *Health Monitors* currently in OVN\u0027s Driver for Load Balancer."},{"line_number":33,"context_line":"  Therefore Health Checking is not possible with OVN."},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"* Currently, OVN driver supports 1:1 protocol mapping between Listeners"},{"line_number":36,"context_line":"  and associated Pools i.e. Listener which can handle TCP protocol can only be"},{"line_number":37,"context_line":"  associated with pools associated to TCP protocol. Pools handling UDP protocol"},{"line_number":38,"context_line":"  cannot be linked with TCP based Listeners. This limitation though would be"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_8a6e0dfd","line":35,"range":{"start_line":35,"start_character":33,"end_line":35,"end_character":54},"in_reply_to":"3f79a3b5_8e686c89","updated":"2018-12-19 07:12:24.000000000","message":"Done :)","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ef2c82c6c3ae29eb19d188243dbd6aa1324f168c","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Currently, OVN driver supports 1:1 protocol mapping between Listeners"},{"line_number":36,"context_line":"  and associated Pools i.e. Listener which can handle TCP protocol can only be"},{"line_number":37,"context_line":"  associated with pools associated to TCP protocol. Pools handling UDP protocol"},{"line_number":38,"context_line":"  cannot be linked with TCP based Listeners. This limitation though would be"},{"line_number":39,"context_line":"  handled in the upcoming core OVN release."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Creating OVN based Load Balancer"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_2e48382a","line":38,"range":{"start_line":38,"start_character":60,"end_line":38,"end_character":73},"updated":"2018-12-18 18:59:55.000000000","message":"This limitation will be ...","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e27ee4b67de27d7c9106f409d3a92b41dbb20c9","unresolved":false,"context_lines":[{"line_number":35,"context_line":"* Currently, OVN driver supports 1:1 protocol mapping between Listeners"},{"line_number":36,"context_line":"  and associated Pools i.e. Listener which can handle TCP protocol can only be"},{"line_number":37,"context_line":"  associated with pools associated to TCP protocol. Pools handling UDP protocol"},{"line_number":38,"context_line":"  cannot be linked with TCP based Listeners. This limitation though would be"},{"line_number":39,"context_line":"  handled in the upcoming core OVN release."},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"Creating OVN based Load Balancer"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_4a7475ce","line":38,"range":{"start_line":38,"start_character":60,"end_line":38,"end_character":73},"in_reply_to":"3f79a3b5_2e48382a","updated":"2018-12-19 07:12:24.000000000","message":"Done","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ef2c82c6c3ae29eb19d188243dbd6aa1324f168c","unresolved":false,"context_lines":[{"line_number":42,"context_line":"--------------------------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"OVN provider driver can be tested out on DevStack using the below configuration"},{"line_number":45,"context_line":"options. Kindly note that the below configuration allows user to create Load"},{"line_number":46,"context_line":"Balancers of both Amphora and OVN type::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    [[local|localrc]]"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_4ef334e6","line":45,"range":{"start_line":45,"start_character":57,"end_line":45,"end_character":61},"updated":"2018-12-18 18:59:55.000000000","message":"\"users\" or \"the user\"","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e27ee4b67de27d7c9106f409d3a92b41dbb20c9","unresolved":false,"context_lines":[{"line_number":42,"context_line":"--------------------------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"OVN provider driver can be tested out on DevStack using the below configuration"},{"line_number":45,"context_line":"options. Kindly note that the below configuration allows user to create Load"},{"line_number":46,"context_line":"Balancers of both Amphora and OVN type::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    [[local|localrc]]"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_2a49f98b","line":45,"range":{"start_line":45,"start_character":57,"end_line":45,"end_character":61},"in_reply_to":"3f79a3b5_4ef334e6","updated":"2018-12-19 07:12:24.000000000","message":"Done","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ef2c82c6c3ae29eb19d188243dbd6aa1324f168c","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"OVN provider driver can be tested out on DevStack using the below configuration"},{"line_number":45,"context_line":"options. Kindly note that the below configuration allows user to create Load"},{"line_number":46,"context_line":"Balancers of both Amphora and OVN type::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    [[local|localrc]]"},{"line_number":49,"context_line":"    enable_plugin networking-ovn \\ $GIT_BASE/openstack/networking-ovn"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_8eedcc02","line":46,"range":{"start_line":46,"start_character":34,"end_line":46,"end_character":38},"updated":"2018-12-18 18:59:55.000000000","message":"types","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e27ee4b67de27d7c9106f409d3a92b41dbb20c9","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"OVN provider driver can be tested out on DevStack using the below configuration"},{"line_number":45,"context_line":"options. Kindly note that the below configuration allows user to create Load"},{"line_number":46,"context_line":"Balancers of both Amphora and OVN type::"},{"line_number":47,"context_line":""},{"line_number":48,"context_line":"    [[local|localrc]]"},{"line_number":49,"context_line":"    enable_plugin networking-ovn \\ $GIT_BASE/openstack/networking-ovn"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_ea3ea1e0","line":46,"range":{"start_line":46,"start_character":34,"end_line":46,"end_character":38},"in_reply_to":"3f79a3b5_8eedcc02","updated":"2018-12-19 07:12:24.000000000","message":"Done","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ef2c82c6c3ae29eb19d188243dbd6aa1324f168c","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    [api_settings]"},{"line_number":71,"context_line":"    enabled_provider_drivers \u003d amphora:\u0027Octavia Amphora driver\u0027,ovn:\u0027Octavia OVN driver\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Once DevStack run is complete, you can create a load balancer in Openstack::"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    $ openstack loadbalancer create --vip-network-id public --provider ovn"},{"line_number":76,"context_line":"    +---------------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_8e162cf3","line":73,"range":{"start_line":73,"start_character":31,"end_line":73,"end_character":34},"updated":"2018-12-18 18:59:55.000000000","message":"\"the user\" to be consistent with other references to the reader.","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ef2c82c6c3ae29eb19d188243dbd6aa1324f168c","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    [[post-config|$OCTAVIA_CONF]]"},{"line_number":70,"context_line":"    [api_settings]"},{"line_number":71,"context_line":"    enabled_provider_drivers \u003d amphora:\u0027Octavia Amphora driver\u0027,ovn:\u0027Octavia OVN driver\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Once DevStack run is complete, you can create a load balancer in Openstack::"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    $ openstack loadbalancer create --vip-network-id public --provider ovn"},{"line_number":76,"context_line":"    +---------------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_0e2bfc31","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":13},"updated":"2018-12-18 18:59:55.000000000","message":"Once the DevStack run","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e27ee4b67de27d7c9106f409d3a92b41dbb20c9","unresolved":false,"context_lines":[{"line_number":69,"context_line":"    [[post-config|$OCTAVIA_CONF]]"},{"line_number":70,"context_line":"    [api_settings]"},{"line_number":71,"context_line":"    enabled_provider_drivers \u003d amphora:\u0027Octavia Amphora driver\u0027,ovn:\u0027Octavia OVN driver\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Once DevStack run is complete, you can create a load balancer in Openstack::"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    $ openstack loadbalancer create --vip-network-id public --provider ovn"},{"line_number":76,"context_line":"    +---------------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_2a2ed9a9","line":73,"range":{"start_line":72,"start_character":0,"end_line":73,"end_character":13},"in_reply_to":"3f79a3b5_0e2bfc31","updated":"2018-12-19 07:12:24.000000000","message":"Done","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e27ee4b67de27d7c9106f409d3a92b41dbb20c9","unresolved":false,"context_lines":[{"line_number":70,"context_line":"    [api_settings]"},{"line_number":71,"context_line":"    enabled_provider_drivers \u003d amphora:\u0027Octavia Amphora driver\u0027,ovn:\u0027Octavia OVN driver\u0027"},{"line_number":72,"context_line":""},{"line_number":73,"context_line":"Once DevStack run is complete, you can create a load balancer in Openstack::"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"    $ openstack loadbalancer create --vip-network-id public --provider ovn"},{"line_number":76,"context_line":"    +---------------------+--------------------------------------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_0a299da0","line":73,"range":{"start_line":73,"start_character":31,"end_line":73,"end_character":34},"in_reply_to":"3f79a3b5_8e162cf3","updated":"2018-12-19 07:12:24.000000000","message":"Done","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ef2c82c6c3ae29eb19d188243dbd6aa1324f168c","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    | vip_subnet_id       | 3eed0c05-6527-400e-bb80-df6e59d248f1 |"},{"line_number":97,"context_line":"    +---------------------+--------------------------------------+"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"User can see the different types of loadbalancers with their associated"},{"line_number":100,"context_line":"providers as below::"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    +--------------------------------------+------+----------------------------------+-------------+---------------------+----------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_ced5041b","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":4},"updated":"2018-12-18 18:59:55.000000000","message":"The user","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e27ee4b67de27d7c9106f409d3a92b41dbb20c9","unresolved":false,"context_lines":[{"line_number":96,"context_line":"    | vip_subnet_id       | 3eed0c05-6527-400e-bb80-df6e59d248f1 |"},{"line_number":97,"context_line":"    +---------------------+--------------------------------------+"},{"line_number":98,"context_line":""},{"line_number":99,"context_line":"User can see the different types of loadbalancers with their associated"},{"line_number":100,"context_line":"providers as below::"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"    +--------------------------------------+------+----------------------------------+-------------+---------------------+----------+"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_ca2e45a8","line":99,"range":{"start_line":99,"start_character":0,"end_line":99,"end_character":4},"in_reply_to":"3f79a3b5_ced5041b","updated":"2018-12-19 07:12:24.000000000","message":"Done","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"ef2c82c6c3ae29eb19d188243dbd6aa1324f168c","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    protocol            : tcp"},{"line_number":195,"context_line":"    vips                : {}"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Lastly, when a member is created, the OVN\u0027s Load Balancer table is complete::"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    $ openstack loadbalancer member create --address 10.10.10.10 /"},{"line_number":200,"context_line":"    --protocol-port 63015 898be8a2-5185-4f3b-8658-a56457f595a9"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_0e9e9c67","line":197,"range":{"start_line":197,"start_character":34,"end_line":197,"end_character":37},"updated":"2018-12-18 18:59:55.000000000","message":"don\u0027t need \u0027the\u0027","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"2e27ee4b67de27d7c9106f409d3a92b41dbb20c9","unresolved":false,"context_lines":[{"line_number":194,"context_line":"    protocol            : tcp"},{"line_number":195,"context_line":"    vips                : {}"},{"line_number":196,"context_line":""},{"line_number":197,"context_line":"Lastly, when a member is created, the OVN\u0027s Load Balancer table is complete::"},{"line_number":198,"context_line":""},{"line_number":199,"context_line":"    $ openstack loadbalancer member create --address 10.10.10.10 /"},{"line_number":200,"context_line":"    --protocol-port 63015 898be8a2-5185-4f3b-8658-a56457f595a9"}],"source_content_type":"text/x-rst","patch_set":8,"id":"3f79a3b5_ea330110","line":197,"range":{"start_line":197,"start_character":34,"end_line":197,"end_character":37},"in_reply_to":"3f79a3b5_0e9e9c67","updated":"2018-12-19 07:12:24.000000000","message":"Done","commit_id":"a4fa89934cea49d8b8fd315af098ce4c8ffd3a1b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"325d0879cada1cf2a3d842caf34119c33b08faef","unresolved":false,"context_lines":[{"line_number":42,"context_line":"--------------------------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"OVN provider driver can be tested out on DevStack using the configuration"},{"line_number":45,"context_line":"options in :file:`../ovn-octavia-provider.conf.sample`"},{"line_number":46,"context_line":"Kindly note that the configuration allows the user to create"},{"line_number":47,"context_line":"Load Balancers of both Amphora and OVN types."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":11,"id":"3f79a3b5_63db7e4b","line":45,"range":{"start_line":45,"start_character":11,"end_line":45,"end_character":53},"updated":"2018-12-20 11:35:06.000000000","message":"Shouldn\u0027t we add this file as part of this patch ?\n\nOr make this change as part of your other patch that adds such file.","commit_id":"185ac52650a34fb5b52a487130b52fe905a4cea6"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5e27cae009013a56caf37be8eb77b1308aa590e5","unresolved":false,"context_lines":[{"line_number":42,"context_line":"--------------------------------"},{"line_number":43,"context_line":""},{"line_number":44,"context_line":"OVN provider driver can be tested out on DevStack using the configuration"},{"line_number":45,"context_line":"options in :file:`../ovn-octavia-provider.conf.sample`"},{"line_number":46,"context_line":"Kindly note that the configuration allows the user to create"},{"line_number":47,"context_line":"Load Balancers of both Amphora and OVN types."},{"line_number":48,"context_line":""}],"source_content_type":"text/x-rst","patch_set":12,"id":"dfd5e7cf_a882584e","line":45,"updated":"2019-01-07 16:27:07.000000000","message":"It\u0027s not really linking the sample file\n\nhttp://logs.openstack.org/37/624937/12/check/openstack-tox-docs/9a22d7e/html/admin/loadbalancer.html#creating-ovn-based-load-balancer","commit_id":"af471f01459470fda30173b1c7b49b794af8cec8"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"76d330848fc9e3b7284860515f13c07281d53c5d","unresolved":false,"context_lines":[{"line_number":44,"context_line":"OVN provider driver can be tested out on DevStack using the configuration"},{"line_number":45,"context_line":"options in:"},{"line_number":46,"context_line":""},{"line_number":47,"context_line":".. literalinclude:: ../../../devstack/ovn-octavia-provider.conf.sample"},{"line_number":48,"context_line":""},{"line_number":49,"context_line":"Kindly note that the configuration allows the user to create"},{"line_number":50,"context_line":"Load Balancers of both Amphora and OVN types."}],"source_content_type":"text/x-rst","patch_set":13,"id":"dfd5e7cf_ab3fb2d4","line":47,"updated":"2019-01-07 17:57:55.000000000","message":"Now it\u0027s rendering correctly: http://logs.openstack.org/37/624937/13/check/openstack-tox-docs/b199373/html/admin/loadbalancer.html#creating-ovn-based-load-balancer\n\n:D","commit_id":"c82a1a69ea83b5c25c356daaf8a18e4481af9f07"}]}