)]}'
{"networking_ovn/octavia/ovn_driver.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"8dce6ac84f734c57013240b76c73146570aad928","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        else:"},{"line_number":505,"context_line":"            return str(listener_protocol).lower() in ovn_lb.protocol"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def log_exception(self, operation):"},{"line_number":508,"context_line":"        LOG.exception(\"Exception occurred during %s\", operation)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def lb_create(self, loadbalancer):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_bf4d7f9a","line":507,"range":{"start_line":507,"start_character":8,"end_line":507,"end_character":21},"updated":"2019-04-03 08:19:53.000000000","message":"This is just a private method. The convention is to use a leading underscore for its name.\nPlus, it\u0027s not using \u0027self\u0027 at all so at the very least I think it should be static.\nBecause it\u0027s a pretty generic function, I think you can have it at module level.\n\nAlso, it\u0027s not doing anything else than appending two strings so I don\u0027t think it\u0027s buying us a lot. Isn\u0027t it better to not have this at all? At the end of the day, if you don\u0027t use this, one can read from logs something like \"The above exception was the direct cause of the following exception\"plus the traceback. Can you please explain the benefit of having this?","commit_id":"f6760b9db85a90795b7360e732336f247c43540d"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"df14d9d1f6748a1fc3135d5c67d3e174ed50f83b","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        else:"},{"line_number":505,"context_line":"            return str(listener_protocol).lower() in ovn_lb.protocol"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def log_exception(self, operation):"},{"line_number":508,"context_line":"        LOG.exception(\"Exception occurred during %s\", operation)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def lb_create(self, loadbalancer):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_5ab4a9f2","line":507,"range":{"start_line":507,"start_character":8,"end_line":507,"end_character":21},"in_reply_to":"5fc1f717_1a72a17d","updated":"2019-04-03 08:40:11.000000000","message":"re \"avoiding spelling/syntactical mistakes\", what about a constant?","commit_id":"f6760b9db85a90795b7360e732336f247c43540d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"7a03d04f2523c267fb128cdd25629f80e6bf5b8c","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        else:"},{"line_number":505,"context_line":"            return str(listener_protocol).lower() in ovn_lb.protocol"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def log_exception(self, operation):"},{"line_number":508,"context_line":"        LOG.exception(\"Exception occurred during %s\", operation)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def lb_create(self, loadbalancer):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_fabeb5ac","line":507,"range":{"start_line":507,"start_character":8,"end_line":507,"end_character":21},"in_reply_to":"5fc1f717_5ab4a9f2","updated":"2019-04-03 08:49:40.000000000","message":"Yeah usually the way I\u0027ve seem it\u0027s being done is using an constant in a common module. This way u can easily re-use that message across modules (and tests too).\n\nFor example:\n\nUNKNOWN_EXCEPTION_MSG \u003d \"Unknown exception occurred during %s\"\n\n...\n\nLOG.exception(UNKNOWN_EXCEPTION_MSG, \"loadbalancer creation\")","commit_id":"f6760b9db85a90795b7360e732336f247c43540d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"df94456089ddfd92700efd3bc672234a16c0baf2","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        else:"},{"line_number":505,"context_line":"            return str(listener_protocol).lower() in ovn_lb.protocol"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def log_exception(self, operation):"},{"line_number":508,"context_line":"        LOG.exception(\"Exception occurred during %s\", operation)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def lb_create(self, loadbalancer):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_1a72a17d","line":507,"range":{"start_line":507,"start_character":8,"end_line":507,"end_character":21},"in_reply_to":"5fc1f717_bf4d7f9a","updated":"2019-04-03 08:35:34.000000000","message":"a) Yes this can be a private static method and can be at module level itself. there is no question on that.\nb) Yes, it is appending 2 strings together. Its a nit function. Not having the exception statements would not be beneficial. One more way is to copy paste the sentence to the locations where the exceptions should be logged. The benefit of having this function is to avoid writing exception statement for each major operation of the ProviderHelper class.This atleast avoids any spelling/syntactical mistakes in the exception logging.  Its a trivial code, not a major operational change.","commit_id":"f6760b9db85a90795b7360e732336f247c43540d"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"95ca8d99d4da6616605861054a87aa6722cc7125","unresolved":false,"context_lines":[{"line_number":504,"context_line":"        else:"},{"line_number":505,"context_line":"            return str(listener_protocol).lower() in ovn_lb.protocol"},{"line_number":506,"context_line":""},{"line_number":507,"context_line":"    def log_exception(self, operation):"},{"line_number":508,"context_line":"        LOG.exception(\"Exception occurred during %s\", operation)"},{"line_number":509,"context_line":""},{"line_number":510,"context_line":"    def lb_create(self, loadbalancer):"}],"source_content_type":"text/x-python","patch_set":2,"id":"5fc1f717_0ee02226","line":507,"range":{"start_line":507,"start_character":8,"end_line":507,"end_character":21},"in_reply_to":"5fc1f717_fabeb5ac","updated":"2019-04-03 09:41:05.000000000","message":"That sounds good. I can do it","commit_id":"f6760b9db85a90795b7360e732336f247c43540d"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2c59ac0105862f88bc56c1ca60617a64da0c918f","unresolved":false,"context_lines":[{"line_number":678,"context_line":"                operating_status \u003d constants.OFFLINE"},{"line_number":679,"context_line":"            lb_status[\u0027operating_status\u0027] \u003d operating_status"},{"line_number":680,"context_line":"        except Exception:"},{"line_number":681,"context_line":"            LOG.exception(EXCEPTION_MSG, \"updation of loadbalancer\")"},{"line_number":682,"context_line":"            lb_status[\u0027provisioning_status\u0027] \u003d constants.ERROR"},{"line_number":683,"context_line":"            lb_status[\u0027operating_status\u0027] \u003d constants.ERROR"},{"line_number":684,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_e48ff772","line":681,"range":{"start_line":681,"start_character":42,"end_line":681,"end_character":50},"updated":"2019-04-03 11:02:17.000000000","message":"update ?","commit_id":"973abfbb5d1d7c513581ae7c2a41881439aa12c1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"6f00787a6c18f8a3c72a9697c65c1416f85a3cf0","unresolved":false,"context_lines":[{"line_number":678,"context_line":"                operating_status \u003d constants.OFFLINE"},{"line_number":679,"context_line":"            lb_status[\u0027operating_status\u0027] \u003d operating_status"},{"line_number":680,"context_line":"        except Exception:"},{"line_number":681,"context_line":"            LOG.exception(EXCEPTION_MSG, \"updation of loadbalancer\")"},{"line_number":682,"context_line":"            lb_status[\u0027provisioning_status\u0027] \u003d constants.ERROR"},{"line_number":683,"context_line":"            lb_status[\u0027operating_status\u0027] \u003d constants.ERROR"},{"line_number":684,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_b874b09d","line":681,"range":{"start_line":681,"start_character":42,"end_line":681,"end_character":50},"in_reply_to":"5fc1f717_3dd992f3","updated":"2019-04-03 14:04:37.000000000","message":"Yeah but updation is not a real word. I googled a bit about it and all I found was:\n\nThe word \"Updation\" is not recognized either by Oxford dictionary or by Merriam Webster dictionary, neither for US English nor for world english. Also, it is incorrect to say that \"updation\" is used mainly in India ONLY as a substitute to \"updating\".","commit_id":"973abfbb5d1d7c513581ae7c2a41881439aa12c1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3e69df27ce18ef87bf5cc20e33d2b3dc793f6ef8","unresolved":false,"context_lines":[{"line_number":678,"context_line":"                operating_status \u003d constants.OFFLINE"},{"line_number":679,"context_line":"            lb_status[\u0027operating_status\u0027] \u003d operating_status"},{"line_number":680,"context_line":"        except Exception:"},{"line_number":681,"context_line":"            LOG.exception(EXCEPTION_MSG, \"updation of loadbalancer\")"},{"line_number":682,"context_line":"            lb_status[\u0027provisioning_status\u0027] \u003d constants.ERROR"},{"line_number":683,"context_line":"            lb_status[\u0027operating_status\u0027] \u003d constants.ERROR"},{"line_number":684,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_f8446176","line":681,"range":{"start_line":681,"start_character":42,"end_line":681,"end_character":50},"in_reply_to":"5fc1f717_b874b09d","updated":"2019-04-04 10:16:15.000000000","message":"Well, I am Indian :D\nThanks for correcting though :D","commit_id":"973abfbb5d1d7c513581ae7c2a41881439aa12c1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"d794d9875f0ccf1a5b6bfc647930d7054f5d42fb","unresolved":false,"context_lines":[{"line_number":678,"context_line":"                operating_status \u003d constants.OFFLINE"},{"line_number":679,"context_line":"            lb_status[\u0027operating_status\u0027] \u003d operating_status"},{"line_number":680,"context_line":"        except Exception:"},{"line_number":681,"context_line":"            LOG.exception(EXCEPTION_MSG, \"updation of loadbalancer\")"},{"line_number":682,"context_line":"            lb_status[\u0027provisioning_status\u0027] \u003d constants.ERROR"},{"line_number":683,"context_line":"            lb_status[\u0027operating_status\u0027] \u003d constants.ERROR"},{"line_number":684,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_3dd992f3","line":681,"range":{"start_line":681,"start_character":42,"end_line":681,"end_character":50},"in_reply_to":"5fc1f717_e48ff772","updated":"2019-04-03 13:50:55.000000000","message":"All others have an \u0027ion\u0027 at the end, updation sounded correct to me :) But update also works","commit_id":"973abfbb5d1d7c513581ae7c2a41881439aa12c1"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ed5b56205a6a93c297615fa268f649b0d4bbe8c8","unresolved":false,"context_lines":[{"line_number":678,"context_line":"                operating_status \u003d constants.OFFLINE"},{"line_number":679,"context_line":"            lb_status[\u0027operating_status\u0027] \u003d operating_status"},{"line_number":680,"context_line":"        except Exception:"},{"line_number":681,"context_line":"            LOG.exception(EXCEPTION_MSG, \"updation of loadbalancer\")"},{"line_number":682,"context_line":"            lb_status[\u0027provisioning_status\u0027] \u003d constants.ERROR"},{"line_number":683,"context_line":"            lb_status[\u0027operating_status\u0027] \u003d constants.ERROR"},{"line_number":684,"context_line":""}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_c6073f1d","line":681,"range":{"start_line":681,"start_character":42,"end_line":681,"end_character":50},"in_reply_to":"5fc1f717_f8446176","updated":"2019-04-04 15:37:01.000000000","message":"Interestingly https://en.oxforddictionaries.com/definition/updation states that Updation exists in the Oxford dictionary :)","commit_id":"973abfbb5d1d7c513581ae7c2a41881439aa12c1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2c59ac0105862f88bc56c1ca60617a64da0c918f","unresolved":false,"context_lines":[{"line_number":851,"context_line":"                self._refresh_lb_vips(ovn_lb.uuid, external_ids))"},{"line_number":852,"context_line":"            self._execute_commands(commands)"},{"line_number":853,"context_line":"        except Exception:"},{"line_number":854,"context_line":"            LOG.exception(EXCEPTION_MSG, \"updation of listener\")"},{"line_number":855,"context_line":"            status \u003d {"},{"line_number":856,"context_line":"                \u0027listeners\u0027: [{\u0027id\u0027: listener[\u0027id\u0027],"},{"line_number":857,"context_line":"                               \u0027provisioning_status\u0027: constants.ERROR}],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_048b2368","line":854,"range":{"start_line":854,"start_character":42,"end_line":854,"end_character":50},"updated":"2019-04-03 11:02:17.000000000","message":"ditto","commit_id":"973abfbb5d1d7c513581ae7c2a41881439aa12c1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2c59ac0105862f88bc56c1ca60617a64da0c918f","unresolved":false,"context_lines":[{"line_number":1023,"context_line":"                     \u0027provisioning_status\u0027: constants.ACTIVE})"},{"line_number":1024,"context_line":"            status[\u0027listeners\u0027] \u003d listener_status"},{"line_number":1025,"context_line":"        except Exception:"},{"line_number":1026,"context_line":"            LOG.exception(EXCEPTION_MSG, \"updation of pool\")"},{"line_number":1027,"context_line":"            status \u003d {"},{"line_number":1028,"context_line":"                \u0027pools\u0027: [{\"id\": pool[\u0027id\u0027],"},{"line_number":1029,"context_line":"                           \u0027provisioning_status\u0027: constants.ERROR}],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_a4e7af46","line":1026,"range":{"start_line":1026,"start_character":42,"end_line":1026,"end_character":50},"updated":"2019-04-03 11:02:17.000000000","message":"ditto","commit_id":"973abfbb5d1d7c513581ae7c2a41881439aa12c1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2c59ac0105862f88bc56c1ca60617a64da0c918f","unresolved":false,"context_lines":[{"line_number":1188,"context_line":"                     \u0027provisioning_status\u0027: constants.ACTIVE})"},{"line_number":1189,"context_line":"            status[\u0027listeners\u0027] \u003d listener_status"},{"line_number":1190,"context_line":"        except Exception:"},{"line_number":1191,"context_line":"            LOG.exception(EXCEPTION_MSG, \"updation of member\")"},{"line_number":1192,"context_line":"            status \u003d {"},{"line_number":1193,"context_line":"                \u0027pools\u0027: [{\u0027id\u0027: member[\u0027pool_id\u0027],"},{"line_number":1194,"context_line":"                           \u0027provisioning_status\u0027: constants.ACTIVE}],"}],"source_content_type":"text/x-python","patch_set":3,"id":"5fc1f717_c4eafb0c","line":1191,"range":{"start_line":1191,"start_character":42,"end_line":1191,"end_character":50},"updated":"2019-04-03 11:02:17.000000000","message":"ditto","commit_id":"973abfbb5d1d7c513581ae7c2a41881439aa12c1"}]}