)]}'
{"networking_ovn/octavia/ovn_driver.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3d8b369bd4ddf0a670642c39e907c8ebbce4da1d","unresolved":false,"context_lines":[{"line_number":509,"context_line":"            return str(listener_protocol).lower() in ovn_lb.protocol"},{"line_number":510,"context_line":""},{"line_number":511,"context_line":"    def lb_create(self, loadbalancer):"},{"line_number":512,"context_line":"        rollback \u003d {\u0027status\u0027: False, \u0027port_id\u0027: None}"},{"line_number":513,"context_line":"        try:"},{"line_number":514,"context_line":"            # Get the port id of the vip and store it in the external_ids."},{"line_number":515,"context_line":"            # This is required to delete the port when the loadbalancer is"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_545420fe","line":512,"range":{"start_line":512,"start_character":0,"end_line":512,"end_character":53},"updated":"2019-04-19 06:44:36.000000000","message":"I think I can remove this dict and just check Port in Line#565, if the port is updated, then I can remove the VIP port , since exception can occur only if the creation fails, but if Port is not created, then no need to worry about deleting it","commit_id":"532262edcdf6cc34f52aae0d8205ac13ea1801d9"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"3d8b369bd4ddf0a670642c39e907c8ebbce4da1d","unresolved":false,"context_lines":[{"line_number":581,"context_line":"                ovn_lb \u003d self._find_ovn_lb(loadbalancer[\u0027id\u0027])"},{"line_number":582,"context_line":"            except IndexError:"},{"line_number":583,"context_line":"                LOG.warning(\"Loadbalancer not found in OVN Northbound DB.\""},{"line_number":584,"context_line":"                            \"Deleting the Loadbalancer.\")"},{"line_number":585,"context_line":"                return status"},{"line_number":586,"context_line":"            if not ovn_lb:"},{"line_number":587,"context_line":"                return status"}],"source_content_type":"text/x-python","patch_set":2,"id":"3fce034c_74a7dc0c","line":584,"range":{"start_line":584,"start_character":42,"end_line":584,"end_character":54},"updated":"2019-04-19 06:44:36.000000000","message":"This message seems a bit incorrect. If the LoadBalancer doesnt exist in the OVN NorthBoud DB, then the message should be  \" Setting the LoadBalancer status to Deleted in Octavia.\"","commit_id":"532262edcdf6cc34f52aae0d8205ac13ea1801d9"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1465e79d4cbe70daf52bb494d482334726b89021","unresolved":false,"context_lines":[{"line_number":558,"context_line":"            # Any Exception set the status to ERROR"},{"line_number":559,"context_line":"            if isinstance(port, dict):"},{"line_number":560,"context_line":"                self.delete_vip_port(port.get(\u0027id\u0027))"},{"line_number":561,"context_line":"                LOG.warning(\"Deleting the VIP port since LB went into ERROR\")"},{"line_number":562,"context_line":"            status \u003d {"},{"line_number":563,"context_line":"                \u0027loadbalancers\u0027: [{\"id\": loadbalancer[\u0027id\u0027],"},{"line_number":564,"context_line":"                                   \"provisioning_status\": constants.ERROR,"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_cf71960e","line":561,"updated":"2019-06-06 14:30:36.000000000","message":"Let\u0027s add the port ID here, so at least we know which port we are talking about.","commit_id":"c63580804d496888b3fbc471526c36d02d2c65ca"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"1465e79d4cbe70daf52bb494d482334726b89021","unresolved":false,"context_lines":[{"line_number":574,"context_line":"            try:"},{"line_number":575,"context_line":"                ovn_lb \u003d self._find_ovn_lb(loadbalancer[\u0027id\u0027])"},{"line_number":576,"context_line":"            except IndexError:"},{"line_number":577,"context_line":"                LOG.warning(\"Loadbalancer not found in OVN Northbound DB.\""},{"line_number":578,"context_line":"                            \"Setting the Loadbalancer status to DELETED \""},{"line_number":579,"context_line":"                            \"in Octavia\")"},{"line_number":580,"context_line":"                return status"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_ef557a51","line":577,"range":{"start_line":577,"start_character":41,"end_line":577,"end_character":42},"updated":"2019-06-06 14:30:36.000000000","message":"ditto: ID","commit_id":"c63580804d496888b3fbc471526c36d02d2c65ca"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"7badae65650ecfacbcd4bc63dc73261f54cebd86","unresolved":false,"context_lines":[{"line_number":556,"context_line":"        except Exception:"},{"line_number":557,"context_line":"            LOG.exception(EXCEPTION_MSG, \"creation of loadbalancer\")"},{"line_number":558,"context_line":"            # Any Exception set the status to ERROR"},{"line_number":559,"context_line":"            if isinstance(port, dict):"},{"line_number":560,"context_line":"                self.delete_vip_port(port.get(\u0027id\u0027))"},{"line_number":561,"context_line":"                LOG.warning(\"Deleting the VIP port %s since LB went into \""},{"line_number":562,"context_line":"                            \"ERROR state\", str(port.get(\u0027id\u0027)))"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_95fa8340","line":559,"updated":"2019-06-11 16:52:50.000000000","message":"This works, but just as a style nit, instead of port \u003d None / if isinstance(port, dict): I\u0027d probably do port \u003d {} / if port:. Also might as well use port[\u0027id\u0027] since .get() possibly results in passing None to delete_port() which wouldn\u0027t be valid (though neither would having a port dict w/o an id).","commit_id":"970138909d2cda64e09316810af09fa7b5f6e4d0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2de9e0de53826201898b49889ed1be013a7239ec","unresolved":false,"context_lines":[{"line_number":559,"context_line":"            if isinstance(port, dict):"},{"line_number":560,"context_line":"                self.delete_vip_port(port.get(\u0027id\u0027))"},{"line_number":561,"context_line":"                LOG.warning(\"Deleting the VIP port %s since LB went into \""},{"line_number":562,"context_line":"                            \"ERROR state\", str(port.get(\u0027id\u0027)))"},{"line_number":563,"context_line":"            status \u003d {"},{"line_number":564,"context_line":"                \u0027loadbalancers\u0027: [{\"id\": loadbalancer[\u0027id\u0027],"},{"line_number":565,"context_line":"                                   \"provisioning_status\": constants.ERROR,"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_8b236dbd","line":562,"range":{"start_line":562,"start_character":43,"end_line":562,"end_character":47},"updated":"2019-06-08 22:54:57.000000000","message":"nit: str()\u0027s not needed in this case","commit_id":"970138909d2cda64e09316810af09fa7b5f6e4d0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"2de9e0de53826201898b49889ed1be013a7239ec","unresolved":false,"context_lines":[{"line_number":577,"context_line":"            except IndexError:"},{"line_number":578,"context_line":"                LOG.warning(\"Loadbalancer %s not found in OVN Northbound DB.\""},{"line_number":579,"context_line":"                            \"Setting the Loadbalancer status to DELETED \""},{"line_number":580,"context_line":"                            \"in Octavia\", str(loadbalancer[\u0027id\u0027]))"},{"line_number":581,"context_line":"                return status"},{"line_number":582,"context_line":"            if not ovn_lb:"},{"line_number":583,"context_line":"                return status"}],"source_content_type":"text/x-python","patch_set":5,"id":"9fb8cfa7_2b2cc1aa","line":580,"range":{"start_line":580,"start_character":42,"end_line":580,"end_character":46},"updated":"2019-06-08 22:54:57.000000000","message":"ditto","commit_id":"970138909d2cda64e09316810af09fa7b5f6e4d0"}]}