)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"527ad98a908dcb1c2b86095958ab91d7db531e8e","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add concurrency support to os-testr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there seems to be an incompatibility in how"},{"line_number":10,"context_line":"os-testr is being used with stestr-2.3.1, because of which"},{"line_number":11,"context_line":"errors are generated. Till the time the inconsistency is not"},{"line_number":12,"context_line":"resolved, run os-testr with concurrency 0 to avoid this issue."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1251f33a2a93b0d99574dc94ca000b1f4eb9be99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_44da9fe9","line":11,"range":{"start_line":9,"start_character":31,"end_line":11,"end_character":20},"updated":"2019-05-06 05:37:09.000000000","message":"What\u0027s the incompatibility and the error ?\n\nWe probably need a bug for this","commit_id":"b45fa72969aaf73bd4c920565fe63de8bb80a2c2"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"ff461a1043920a4afabaac76c628263180888281","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add concurrency support to os-testr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there seems to be an incompatibility in how"},{"line_number":10,"context_line":"os-testr is being used with stestr-2.3.1, because of which"},{"line_number":11,"context_line":"errors are generated. Till the time the inconsistency is not"},{"line_number":12,"context_line":"resolved, run os-testr with concurrency 0 to avoid this issue."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: I1251f33a2a93b0d99574dc94ca000b1f4eb9be99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dfbec78f_27a8cd1d","line":11,"range":{"start_line":9,"start_character":31,"end_line":11,"end_character":20},"in_reply_to":"dfbec78f_44da9fe9","updated":"2019-05-06 07:31:54.000000000","message":"I should have referenced it with another patch I am working on and where I faced this issue.\nI have logged the bug and would be linking it here","commit_id":"b45fa72969aaf73bd4c920565fe63de8bb80a2c2"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"e68c5d8e8babd43e98df23721e39718d196e91d2","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently there seems to be an incompatibility in how"},{"line_number":10,"context_line":"os-testr is being used with stestr-2.3.1, because of which"},{"line_number":11,"context_line":"errors are generated. Till the time the inconsistency is not"},{"line_number":12,"context_line":"resolved, run os-testr with concurrency 0 to avoid this issue."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1827834"},{"line_number":15,"context_line":"Change-Id: I1251f33a2a93b0d99574dc94ca000b1f4eb9be99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfbec78f_ddef4285","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":61},"updated":"2019-05-06 09:59:27.000000000","message":"It took me a while to understand what this patch does. I had to read os-testr and stestr code and I think this patch is correct, just the wording in the commit message is unfortunate.\n\nThe os-testr documentation says the default concurrency value is number of cpus - which is half-true because it relies on stestr. When passing the value of 0 to stestr, then the concurrency is set to number of cpus.\n\nThus, this commit message should be updated by stating that passing --concurrency\u003d0 to ostestr actually means that tests will run in parallel using the number of local CPUs.\n\nNaturally it feels like --concurrency\u003d0 means \"don\u0027t run tests in parallel\", which is not true.","commit_id":"acbaa6624066bd4247a7010cde35226e0a4693fe"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"13b2e7c538a092c9ef3ab958944a305cd4e77ce5","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Currently there seems to be an incompatibility in how"},{"line_number":10,"context_line":"os-testr is being used with stestr-2.3.1, because of which"},{"line_number":11,"context_line":"errors are generated. Till the time the inconsistency is not"},{"line_number":12,"context_line":"resolved, run os-testr with concurrency 0 to avoid this issue."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Closes-Bug: #1827834"},{"line_number":15,"context_line":"Change-Id: I1251f33a2a93b0d99574dc94ca000b1f4eb9be99"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"dfbec78f_3860ecce","line":12,"range":{"start_line":12,"start_character":10,"end_line":12,"end_character":61},"in_reply_to":"dfbec78f_ddef4285","updated":"2019-05-06 10:30:01.000000000","message":"Okay, would reword the same and add the ToDo for future, as conveyed in the bug information","commit_id":"acbaa6624066bd4247a7010cde35226e0a4693fe"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b3906685db32b43666f2e193f2ffb1bb9b706c79","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Reedip \u003crbanerje@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2019-05-06 10:42:10 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Fix incompatibility between stestr-2.3.1 and ostestr"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Currently there is an incompatibility between stestr-2.3.1 and os-testr,"},{"line_number":10,"context_line":"because of which tox jobs are failing in networking-ovn. This is because"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_d80430c9","line":7,"updated":"2019-05-06 10:45:09.000000000","message":"The summary should be updated too, as the incompatibility is still there :)","commit_id":"3a5fd7a35c95bcfdc320a36f39aec28d500b36be"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b3906685db32b43666f2e193f2ffb1bb9b706c79","unresolved":false,"context_lines":[{"line_number":10,"context_line":"because of which tox jobs are failing in networking-ovn. This is because"},{"line_number":11,"context_line":"ostestr passes --concurrency None to stestr and after [1] merged, stestr"},{"line_number":12,"context_line":"is expecting only integer values. Till [2] is not released in the"},{"line_number":13,"context_line":"updated stestr version, run stestr with --concurrency 0 so that parallel"},{"line_number":14,"context_line":"jobs (number of jobs \u003d number of CPUs) can run with stestr, thus fixing"},{"line_number":15,"context_line":"the issue with tox and the gate failures resulting because of this"},{"line_number":16,"context_line":"inconsistency."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_f83254a7","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":55},"updated":"2019-05-06 10:45:09.000000000","message":"I think you should explicitly and clearly say that setting concurrency to 0 means setting concurrency to the number of CPUs present on the box.","commit_id":"3a5fd7a35c95bcfdc320a36f39aec28d500b36be"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"48b010126592bfd760d242bb5c3a43b2f4de97be","unresolved":false,"context_lines":[{"line_number":10,"context_line":"because of which tox jobs are failing in networking-ovn. This is because"},{"line_number":11,"context_line":"ostestr passes --concurrency None to stestr and after [1] merged, stestr"},{"line_number":12,"context_line":"is expecting only integer values. Till [2] is not released in the"},{"line_number":13,"context_line":"updated stestr version, run stestr with --concurrency 0 so that parallel"},{"line_number":14,"context_line":"jobs (number of jobs \u003d number of CPUs) can run with stestr, thus fixing"},{"line_number":15,"context_line":"the issue with tox and the gate failures resulting because of this"},{"line_number":16,"context_line":"inconsistency."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dfbec78f_181ba81b","line":13,"range":{"start_line":13,"start_character":40,"end_line":13,"end_character":55},"in_reply_to":"dfbec78f_f83254a7","updated":"2019-05-06 12:20:14.000000000","message":"Okay :)","commit_id":"3a5fd7a35c95bcfdc320a36f39aec28d500b36be"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2027e95da7fba3d653b5fce8bbd3901813016aa4","unresolved":false,"context_lines":[{"line_number":12,"context_line":"is expecting only integer values. Till [2] is not released in the"},{"line_number":13,"context_line":"updated stestr version, run stestr with --concurrency 0."},{"line_number":14,"context_line":"--concurrency 0 allows to run as many jobs as there are CPUs in the"},{"line_number":15,"context_line":"system, allowing paralle execution in stestr."},{"line_number":16,"context_line":"This temporarily fixes the issue with tox and the gate failures"},{"line_number":17,"context_line":"resulting because of this inconsistency. Once [2] is released, this"},{"line_number":18,"context_line":"change can be reverted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfbec78f_38d78cf0","line":15,"range":{"start_line":15,"start_character":17,"end_line":15,"end_character":24},"updated":"2019-05-06 11:05:14.000000000","message":"parallel","commit_id":"46c665c74b68e839394ecb6871c4c98fdfc2e56e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"48b010126592bfd760d242bb5c3a43b2f4de97be","unresolved":false,"context_lines":[{"line_number":12,"context_line":"is expecting only integer values. Till [2] is not released in the"},{"line_number":13,"context_line":"updated stestr version, run stestr with --concurrency 0."},{"line_number":14,"context_line":"--concurrency 0 allows to run as many jobs as there are CPUs in the"},{"line_number":15,"context_line":"system, allowing paralle execution in stestr."},{"line_number":16,"context_line":"This temporarily fixes the issue with tox and the gate failures"},{"line_number":17,"context_line":"resulting because of this inconsistency. Once [2] is released, this"},{"line_number":18,"context_line":"change can be reverted."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"dfbec78f_93e69be8","line":15,"range":{"start_line":15,"start_character":17,"end_line":15,"end_character":24},"in_reply_to":"dfbec78f_38d78cf0","updated":"2019-05-06 12:20:14.000000000","message":"Done","commit_id":"46c665c74b68e839394ecb6871c4c98fdfc2e56e"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"47e483db921b6cf251e1ccd9a5544353f123dd0b","unresolved":false,"context_lines":[{"line_number":15,"context_line":"system, allowing parallel execution in stestr."},{"line_number":16,"context_line":"This temporarily fixes the issue with tox and the gate failures"},{"line_number":17,"context_line":"resulting because of this inconsistency. Once [2] is released, this"},{"line_number":18,"context_line":"change can be reverted."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"[1]: https://github.com/mtreinish/stestr/commit/c93bc81"},{"line_number":21,"context_line":"[2]: https://github.com/mtreinish/stestr/commit/ac8dac0"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":6,"id":"dfbec78f_b304ff7c","line":18,"updated":"2019-05-06 12:23:32.000000000","message":"Nice! Thanks for the explanation. I was struggling to understand the problem/fix before.","commit_id":"b04a2341126becbd7b449be6950cfaae4b01a2e5"}],"tools/ostestr_compat_shim.sh":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d5f0c7aee31c46b48b2b3a2cc5654878c12fbd5e","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"# preserve old behavior of using an arg as a regex when \u0027--\u0027 is not present"},{"line_number":4,"context_line":"case $@ in"},{"line_number":5,"context_line":"  (*--*) ostestr --concurrency 0 $@;;"},{"line_number":6,"context_line":"  (\u0027\u0027) ostestr --concurrency 0;;"},{"line_number":7,"context_line":"  (*) ostestr --concurrency 0 --regex \"$@\""},{"line_number":8,"context_line":"esac"}],"source_content_type":"text/x-sh","patch_set":2,"id":"dfbec78f_7d73b6e8","line":5,"updated":"2019-05-06 10:09:04.000000000","message":"Adding a TODO comment stating this is to avoid the issue would be really helpful. We may want to remove it once os-testr/stestr are fixed.","commit_id":"acbaa6624066bd4247a7010cde35226e0a4693fe"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"41c3e144e6a35aa20ed7316b66ffc3e05e4587f6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# ToDo(Reedip) remove --concurrency 0 once stestr is fixed"},{"line_number":3,"context_line":"# preserve old behavior of using an arg as a regex when \u0027--\u0027 is not present"},{"line_number":4,"context_line":"case $@ in"},{"line_number":5,"context_line":"  (*--*) ostestr --concurrency 0 $@;;"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfbec78f_b3139f0d","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":6},"updated":"2019-05-06 12:01:33.000000000","message":"Nit: TODO\nI left this comment in other patches of yours\n[H101] Include your name with TODOs as in # TODO(yourname). This makes it easier to find out who the author of the comment was.\nhttps://docs.openstack.org/hacking/latest/user/hacking.html","commit_id":"46c665c74b68e839394ecb6871c4c98fdfc2e56e"},{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"48b010126592bfd760d242bb5c3a43b2f4de97be","unresolved":false,"context_lines":[{"line_number":1,"context_line":"#!/bin/sh"},{"line_number":2,"context_line":"# ToDo(Reedip) remove --concurrency 0 once stestr is fixed"},{"line_number":3,"context_line":"# preserve old behavior of using an arg as a regex when \u0027--\u0027 is not present"},{"line_number":4,"context_line":"case $@ in"},{"line_number":5,"context_line":"  (*--*) ostestr --concurrency 0 $@;;"}],"source_content_type":"text/x-sh","patch_set":5,"id":"dfbec78f_f3e117d2","line":2,"range":{"start_line":2,"start_character":2,"end_line":2,"end_character":6},"in_reply_to":"dfbec78f_b3139f0d","updated":"2019-05-06 12:20:14.000000000","message":"Done","commit_id":"46c665c74b68e839394ecb6871c4c98fdfc2e56e"}]}