)]}'
{"networking_ovn/common/ovn_client.py":[{"author":{"_account_id":17776,"name":"Reedip","email":"reedip.banerjee@gmail.com","username":"Reedip"},"change_message_id":"11c399438ecbd8f49c70b17e12c6ced9773726a3","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"            \u0027mtu\u0027: str(mtu),"},{"line_number":1525,"context_line":"        }"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"        net_dns_domain \u003d net.get(\u0027dns_domain\u0027, \u0027\u0027).rstrip(\u0027.\u0027)"},{"line_number":1528,"context_line":"        if net_dns_domain:"},{"line_number":1529,"context_line":"            # NOTE(mjozefcz): String field should be with quotes,"},{"line_number":1530,"context_line":"            # otherwise ovn will try to resolve it as variable."}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_82d62427","line":1527,"range":{"start_line":1527,"start_character":25,"end_line":1527,"end_character":28},"updated":"2019-05-22 06:38:51.000000000","message":"should this be n_net?","commit_id":"7768a8e901fa852552b7b49a5db309a36a7b5853"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"15b0b64a93a54a8e655226ad253151ca0b7b132d","unresolved":false,"context_lines":[{"line_number":1524,"context_line":"            \u0027mtu\u0027: str(mtu),"},{"line_number":1525,"context_line":"        }"},{"line_number":1526,"context_line":""},{"line_number":1527,"context_line":"        net_dns_domain \u003d net.get(\u0027dns_domain\u0027, \u0027\u0027).rstrip(\u0027.\u0027)"},{"line_number":1528,"context_line":"        if net_dns_domain:"},{"line_number":1529,"context_line":"            # NOTE(mjozefcz): String field should be with quotes,"},{"line_number":1530,"context_line":"            # otherwise ovn will try to resolve it as variable."}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_42110cac","line":1527,"range":{"start_line":1527,"start_character":25,"end_line":1527,"end_character":28},"in_reply_to":"bfb3d3c7_82d62427","updated":"2019-05-22 06:59:30.000000000","message":"Should be even \u0027network\u0027 :D thanks","commit_id":"7768a8e901fa852552b7b49a5db309a36a7b5853"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"243115e9ef3216c3f53150d7be3a34b4d0ef41f5","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"        if net_dns_domain:"},{"line_number":1529,"context_line":"            # NOTE(mjozefcz): String field should be with quotes,"},{"line_number":1530,"context_line":"            # otherwise ovn will try to resolve it as variable."},{"line_number":1531,"context_line":"            options[\u0027domain_name\u0027] \u003d \u0027\"%s\"\u0027 % net_dns_domain"},{"line_number":1532,"context_line":""},{"line_number":1533,"context_line":"        if subnet[\u0027gateway_ip\u0027]:"},{"line_number":1534,"context_line":"            options[\u0027router\u0027] \u003d subnet[\u0027gateway_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_ff2f403c","line":1531,"updated":"2019-05-24 13:58:58.000000000","message":"We need to update the functional/test_ovn_db_sync.py tests to include the domain_name as part of the expected DHCP options. Here: https://github.com/openstack/networking-ovn/blob/2cba15fc49850625325048eca9792e0874470c06/networking_ovn/tests/functional/test_ovn_db_sync.py#L122\n\nThe functional tests failure in the gate:\n\n2019-05-22 09:43:40.739600 | primary | 2019-05-22 09:43:40.738 |     {\u0027options\u0027: {\u0027router\u0027: u\u002710.0.0.1\u0027, \u0027server_mac\u0027: \u002701:02:03:04:05:06\u0027, \u0027server_id\u0027: \u002710.0.0.1\u0027, \u0027lease_time\u0027: \u002743200\u0027, \u0027classless_static_route\u0027: \u0027{169.254.169.254/32,10.0.0.2, 0.0.0.0/0,10.0.0.1}\u0027, \u0027mtu\u0027: \u00271450\u0027, \u0027dns_server\u0027: \u0027{10.10.10.10}\u0027}, \u0027cidr\u0027: \u002710.0.0.0/24\u0027, \u0027external_ids\u0027: {\u0027neutron:revision_number\u0027: \u00270\u0027, \u0027subnet_id\u0027: u\u00272092b221-1eb4-4fe8-9a38-d24a5c3df241\u0027}}\n\n2019-05-22 09:43:40.759342 | primary | 2019-05-22 09:43:40.758 |     {\u0027options\u0027: {u\u0027router\u0027: u\u002710.0.0.1\u0027, u\u0027dns_server\u0027: u\u0027{10.10.10.10}\u0027, u\u0027server_id\u0027: u\u002710.0.0.1\u0027, u\u0027lease_time\u0027: u\u002743200\u0027, u\u0027domain_name\u0027: u\u0027\"ovn.test\"\u0027, u\u0027classless_static_route\u0027: u\u0027{169.254.169.254/32,10.0.0.2, 0.0.0.0/0,10.0.0.1}\u0027, u\u0027mtu\u0027: u\u00271450\u0027, u\u0027server_mac\u0027: \u002701:02:03:04:05:06\u0027}, \u0027cidr\u0027: u\u002710.0.0.0/24\u0027, \u0027external_ids\u0027: {u\u0027neutron:revision_number\u0027: u\u00270\u0027, u\u0027subnet_id\u0027: u\u00272092b221-1eb4-4fe8-9a38-d24a5c3df241\u0027}}","commit_id":"f8b8a8bd240dec3be52759c099f263180fb7c4d1"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"649b85e98d63ad3cbbc3b0cefa02f28291935fb3","unresolved":false,"context_lines":[{"line_number":1528,"context_line":"        if net_dns_domain:"},{"line_number":1529,"context_line":"            # NOTE(mjozefcz): String field should be with quotes,"},{"line_number":1530,"context_line":"            # otherwise ovn will try to resolve it as variable."},{"line_number":1531,"context_line":"            options[\u0027domain_name\u0027] \u003d \u0027\"%s\"\u0027 % net_dns_domain"},{"line_number":1532,"context_line":""},{"line_number":1533,"context_line":"        if subnet[\u0027gateway_ip\u0027]:"},{"line_number":1534,"context_line":"            options[\u0027router\u0027] \u003d subnet[\u0027gateway_ip\u0027]"}],"source_content_type":"text/x-python","patch_set":3,"id":"bfb3d3c7_ea0c4e42","line":1531,"in_reply_to":"bfb3d3c7_ff2f403c","updated":"2019-05-27 08:40:08.000000000","message":"Ok! Thanks for pointing this out!","commit_id":"f8b8a8bd240dec3be52759c099f263180fb7c4d1"}]}