)]}'
{"networking_ovn/tests/unit/agent/metadata/test_agent.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6e3c35e4ba61638728ef0b478288adadc3919cf5","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            update_chassis.assert_called_once_with(\u00271\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def test_update_chassis_metadata_networks_add(self):"},{"line_number":261,"context_line":"        current_dps \u003d []"},{"line_number":262,"context_line":"        for i in range(0, 3):"},{"line_number":263,"context_line":"            current_dps.append(str(i))"},{"line_number":264,"context_line":"        with mock.patch.object(self.agent.sb_idl,"},{"line_number":265,"context_line":"                               \u0027get_chassis_metadata_networks\u0027,"},{"line_number":266,"context_line":"                               return_value\u003dcurrent_dps) as rdp,\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_4ad55a1b","line":263,"range":{"start_line":261,"start_character":8,"end_line":263,"end_character":38},"updated":"2019-05-27 08:54:35.000000000","message":"current_dps \u003d [str(i) for i in range(3)]","commit_id":"13db3f68d8eb044e963e96970375b27fc6c7c8d3"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"236e8fe9d28266c4251e6ef73ab953031f9491d8","unresolved":false,"context_lines":[{"line_number":258,"context_line":"            update_chassis.assert_called_once_with(\u00271\u0027)"},{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def test_update_chassis_metadata_networks_add(self):"},{"line_number":261,"context_line":"        current_dps \u003d []"},{"line_number":262,"context_line":"        for i in range(0, 3):"},{"line_number":263,"context_line":"            current_dps.append(str(i))"},{"line_number":264,"context_line":"        with mock.patch.object(self.agent.sb_idl,"},{"line_number":265,"context_line":"                               \u0027get_chassis_metadata_networks\u0027,"},{"line_number":266,"context_line":"                               return_value\u003dcurrent_dps) as rdp,\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_25d4d7bc","line":263,"range":{"start_line":261,"start_character":8,"end_line":263,"end_character":38},"in_reply_to":"bfb3d3c7_4ad55a1b","updated":"2019-05-27 10:10:11.000000000","message":"++","commit_id":"13db3f68d8eb044e963e96970375b27fc6c7c8d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6e3c35e4ba61638728ef0b478288adadc3919cf5","unresolved":false,"context_lines":[{"line_number":263,"context_line":"            current_dps.append(str(i))"},{"line_number":264,"context_line":"        with mock.patch.object(self.agent.sb_idl,"},{"line_number":265,"context_line":"                               \u0027get_chassis_metadata_networks\u0027,"},{"line_number":266,"context_line":"                               return_value\u003dcurrent_dps) as rdp,\\"},{"line_number":267,"context_line":"                mock.patch.object(self.agent.sb_idl,"},{"line_number":268,"context_line":"                                  \u0027set_chassis_metadata_networks\u0027,"},{"line_number":269,"context_line":"                                  retrurn_value\u003dTrue) as sdp,\\"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_aaebb6d9","line":266,"range":{"start_line":266,"start_character":60,"end_line":266,"end_character":63},"updated":"2019-05-27 08:54:35.000000000","message":"what does it stand for?","commit_id":"13db3f68d8eb044e963e96970375b27fc6c7c8d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6e3c35e4ba61638728ef0b478288adadc3919cf5","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                mock.patch.object(self.agent.sb_idl,"},{"line_number":271,"context_line":"                                  \u0027create_transaction\u0027) as cdp:"},{"line_number":272,"context_line":"            self.agent.update_chassis_metadata_networks(\u00274\u0027, remove\u003dFalse)"},{"line_number":273,"context_line":"            rdp.remove.assert_not_called()"},{"line_number":274,"context_line":"            sdp.assert_called_once_with(\u0027chassis\u0027, [\u00270\u0027, \u00271\u0027, \u00272\u0027, \u00274\u0027])"},{"line_number":275,"context_line":"            cdp.assert_called_once()"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_4578eb8e","line":273,"range":{"start_line":273,"start_character":12,"end_line":273,"end_character":22},"updated":"2019-05-27 08:54:35.000000000","message":"What\u0027s this supposed to assert? get_chassis_metadata_networks doesn\u0027t have any remove attribute so it can never be called.","commit_id":"13db3f68d8eb044e963e96970375b27fc6c7c8d3"},{"author":{"_account_id":29874,"name":"Taoyunxiang","email":"taoyunxiang_yewu@cmss.chinamobile.com","username":"Yunxiang"},"change_message_id":"bc0e9620762961061b48bd32d5793a1ed37ddc0e","unresolved":false,"context_lines":[{"line_number":270,"context_line":"                mock.patch.object(self.agent.sb_idl,"},{"line_number":271,"context_line":"                                  \u0027create_transaction\u0027) as cdp:"},{"line_number":272,"context_line":"            self.agent.update_chassis_metadata_networks(\u00274\u0027, remove\u003dFalse)"},{"line_number":273,"context_line":"            rdp.remove.assert_not_called()"},{"line_number":274,"context_line":"            sdp.assert_called_once_with(\u0027chassis\u0027, [\u00270\u0027, \u00271\u0027, \u00272\u0027, \u00274\u0027])"},{"line_number":275,"context_line":"            cdp.assert_called_once()"},{"line_number":276,"context_line":""}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_dbdb5a79","line":273,"range":{"start_line":273,"start_character":12,"end_line":273,"end_character":22},"in_reply_to":"bfb3d3c7_4578eb8e","updated":"2019-05-29 01:24:50.000000000","message":"Done","commit_id":"13db3f68d8eb044e963e96970375b27fc6c7c8d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6e3c35e4ba61638728ef0b478288adadc3919cf5","unresolved":false,"context_lines":[{"line_number":271,"context_line":"                                  \u0027create_transaction\u0027) as cdp:"},{"line_number":272,"context_line":"            self.agent.update_chassis_metadata_networks(\u00274\u0027, remove\u003dFalse)"},{"line_number":273,"context_line":"            rdp.remove.assert_not_called()"},{"line_number":274,"context_line":"            sdp.assert_called_once_with(\u0027chassis\u0027, [\u00270\u0027, \u00271\u0027, \u00272\u0027, \u00274\u0027])"},{"line_number":275,"context_line":"            cdp.assert_called_once()"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_update_chassis_metadata_networks_remove(self):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_657def7d","line":274,"range":{"start_line":274,"start_character":40,"end_line":274,"end_character":49},"updated":"2019-05-27 08:54:35.000000000","message":"self.agent.chassis","commit_id":"13db3f68d8eb044e963e96970375b27fc6c7c8d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6e3c35e4ba61638728ef0b478288adadc3919cf5","unresolved":false,"context_lines":[{"line_number":272,"context_line":"            self.agent.update_chassis_metadata_networks(\u00274\u0027, remove\u003dFalse)"},{"line_number":273,"context_line":"            rdp.remove.assert_not_called()"},{"line_number":274,"context_line":"            sdp.assert_called_once_with(\u0027chassis\u0027, [\u00270\u0027, \u00271\u0027, \u00272\u0027, \u00274\u0027])"},{"line_number":275,"context_line":"            cdp.assert_called_once()"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_update_chassis_metadata_networks_remove(self):"},{"line_number":278,"context_line":"        current_dps \u003d []"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_05a3d301","line":275,"range":{"start_line":275,"start_character":0,"end_line":275,"end_character":36},"updated":"2019-05-27 08:54:35.000000000","message":"I think this is not needed. What we can test here is the manipulation of current_dps.","commit_id":"13db3f68d8eb044e963e96970375b27fc6c7c8d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"6e3c35e4ba61638728ef0b478288adadc3919cf5","unresolved":false,"context_lines":[{"line_number":273,"context_line":"            rdp.remove.assert_not_called()"},{"line_number":274,"context_line":"            sdp.assert_called_once_with(\u0027chassis\u0027, [\u00270\u0027, \u00271\u0027, \u00272\u0027, \u00274\u0027])"},{"line_number":275,"context_line":"            cdp.assert_called_once()"},{"line_number":276,"context_line":""},{"line_number":277,"context_line":"    def test_update_chassis_metadata_networks_remove(self):"},{"line_number":278,"context_line":"        current_dps \u003d []"},{"line_number":279,"context_line":"        for i in range(0, 3):"}],"source_content_type":"text/x-python","patch_set":1,"id":"bfb3d3c7_2581374b","line":276,"updated":"2019-05-27 08:54:35.000000000","message":"There are two other test cases that can be added.\n\n 1) update_chassis_metadata_networks is called with remove\u003dTrue but passed datapath is not returned by get_chassis_metadata_networks\n 2) same as 1) but remove\u003dFalse","commit_id":"13db3f68d8eb044e963e96970375b27fc6c7c8d3"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"36a80e3a0ac96430b73e80e631f0de288df55b75","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":3,"id":"bfb3d3c7_8e01d107","line":289,"updated":"2019-05-31 09:29:14.000000000","message":"The other two test cases I meant in PS1 comment would be:  \n\n def _test_update_chassis_metadata_networks_helper(\n     self, dp, remove, expected_dps, txn_called\u003dTrue):\n     ...\n     self.assertEqual(create_txn_mock.called, txn_called)\n\n\n def test_update_chassis_metadata_networks_add_dp_exists(self):\n     dp \u003d \u00272\u0027\n     remove \u003d False\n     expected_dps \u003d [\u00270\u0027, \u00271\u0027, \u00272\u0027]\n     self._test_update_chassis_metadata_networks_helper(\n         dp, remove, expected_dps, txn_called\u003dFalse)\n\n\n def test_update_chassis_metadata_networks_remove_no_dp(self):\n     dp \u003d \u00273\u0027\n     remove \u003d True\n     expected_dps \u003d [\u00270\u0027, \u00271\u0027, \u00272\u0027]\n     self._test_update_chassis_metadata_networks_helper(\n         dp, remove, expected_dps, txn_called\u003dFalse)","commit_id":"2be5d6cfc90d4f53fc2dd3951f9be1d833294ddf"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"85c25c2850ff8dee49d6710000ec69d2cf6d5582","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def _test_update_chassis_metadata_networks_helper("},{"line_number":261,"context_line":"        self, dp, remove, expected_dps, txn_called\u003dTrue):"},{"line_number":262,"context_line":"        current_dps \u003d [str(i) for i in range(3)]"},{"line_number":263,"context_line":"        with mock.patch.object(self.agent.sb_idl,"},{"line_number":264,"context_line":"                               \u0027get_chassis_metadata_networks\u0027,"},{"line_number":265,"context_line":"                               return_value\u003dcurrent_dps),\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_22a9b17a","line":262,"updated":"2019-06-03 14:54:44.000000000","message":"I realize there was already a nit on this, but if this was:\n\n  current_dps \u003d [\u00270\u0027, \u00271\u0027, \u00272\u0027]\n\nit would have been much more obvious (to me) why expected_dps were set below.  It made me think :)","commit_id":"3a5626124c6f4b179e256d561c96954d54e27b32"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"cd26e0bbc315e40fd0dff435e7f5f9b4118e5d60","unresolved":false,"context_lines":[{"line_number":259,"context_line":""},{"line_number":260,"context_line":"    def _test_update_chassis_metadata_networks_helper("},{"line_number":261,"context_line":"        self, dp, remove, expected_dps, txn_called\u003dTrue):"},{"line_number":262,"context_line":"        current_dps \u003d [str(i) for i in range(3)]"},{"line_number":263,"context_line":"        with mock.patch.object(self.agent.sb_idl,"},{"line_number":264,"context_line":"                               \u0027get_chassis_metadata_networks\u0027,"},{"line_number":265,"context_line":"                               return_value\u003dcurrent_dps),\\"}],"source_content_type":"text/x-python","patch_set":4,"id":"9fb8cfa7_42f9457e","line":262,"in_reply_to":"9fb8cfa7_22a9b17a","updated":"2019-06-03 14:57:16.000000000","message":"Done","commit_id":"3a5626124c6f4b179e256d561c96954d54e27b32"}]}