)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"a8678ac15c92f0762cd00872d77f44b5853ac7ef","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"functional: Wait for PB event before binding the port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On busy boxes there is a chance ovn-northd doesn\u0027t create a port binding"},{"line_number":10,"context_line":"entry in the Southbound DB when a new logical switch port is created."},{"line_number":11,"context_line":"This patch adds a one time event and the test waits 5 seconds for the"},{"line_number":12,"context_line":"port binding to be created. Only after that it calls lsp_bind()."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_340ba47d","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":69},"updated":"2019-05-27 14:56:45.000000000","message":"I think he means that there is a chance that ovn-northd doesn\u0027t create the PB entry in SB quick enough :)\nBetter to clarify this sentence if you don\u0027t mind Kuba :)","commit_id":"fc81d23dad333a4ec1e4baef0b3521ad915349dd"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3fd16c4c63c988310c32a4484aae0a13aca4f806","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"functional: Wait for PB event before binding the port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On busy boxes there is a chance ovn-northd doesn\u0027t create a port binding"},{"line_number":10,"context_line":"entry in the Southbound DB when a new logical switch port is created."},{"line_number":11,"context_line":"This patch adds a one time event and the test waits 5 seconds for the"},{"line_number":12,"context_line":"port binding to be created. Only after that it calls lsp_bind()."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_f43f4c22","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":69},"updated":"2019-05-27 14:55:24.000000000","message":"Oh, is it a known issue in core OVN ?","commit_id":"fc81d23dad333a4ec1e4baef0b3521ad915349dd"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cbc17c1bd8aa9b9ee9a054ccef2cc64e720c9198","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"functional: Wait for PB event before binding the port"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"On busy boxes there is a chance ovn-northd doesn\u0027t create a port binding"},{"line_number":10,"context_line":"entry in the Southbound DB when a new logical switch port is created."},{"line_number":11,"context_line":"This patch adds a one time event and the test waits 5 seconds for the"},{"line_number":12,"context_line":"port binding to be created. Only after that it calls lsp_bind()."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"bfb3d3c7_b4731416","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":69},"in_reply_to":"bfb3d3c7_340ba47d","updated":"2019-05-27 14:59:05.000000000","message":"Gotcha, yeah just spoke with Kuba on IRC. Apparently the event may delay a bit due to ovn-northd being busy. Which is fine.\n\n++ to clarify","commit_id":"fc81d23dad333a4ec1e4baef0b3521ad915349dd"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f4f957176542df69a5d80c19876f7aa1f3dba5b2","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ovsdbapp, previously, the exception was swallowed and it made debugging"},{"line_number":20,"context_line":"a lot harder."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"It was required to bump ovsdbapp version from 0.10.0 to 0.14.0 because"},{"line_number":23,"context_line":"that\u0027s the version that implements WaitForPortBindingEvent class."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes bug: #1830221"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_f460ac03","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":65},"updated":"2019-05-27 15:13:43.000000000","message":"I think it\u0027s not needed anymore since we temporarily duplicated the code until the bump happens in the requirements project ?\n\nOr you mean WaitEvent ?","commit_id":"87f31be3a9804b40b1ecbd5e1375f9fd8f69304b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"33ecaecdf2ceb3200632d1d98c5559beda1d3a3f","unresolved":false,"context_lines":[{"line_number":19,"context_line":"ovsdbapp, previously, the exception was swallowed and it made debugging"},{"line_number":20,"context_line":"a lot harder."},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"It was required to bump ovsdbapp version from 0.10.0 to 0.14.0 because"},{"line_number":23,"context_line":"that\u0027s the version that implements WaitForPortBindingEvent class."},{"line_number":24,"context_line":""},{"line_number":25,"context_line":"Closes bug: #1830221"},{"line_number":26,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":4,"id":"bfb3d3c7_b73236f1","line":23,"range":{"start_line":22,"start_character":0,"end_line":23,"end_character":65},"in_reply_to":"bfb3d3c7_f460ac03","updated":"2019-05-27 15:23:06.000000000","message":"Oh, yes. WaitEvent it is.","commit_id":"87f31be3a9804b40b1ecbd5e1375f9fd8f69304b"}],"requirements.txt":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5316331fbc2b1b8a2f9ce7a83e29a641d04976b6","unresolved":false,"context_lines":[{"line_number":8,"context_line":"neutron-lib\u003e\u003d1.25.0 # Apache-2.0"},{"line_number":9,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":10,"context_line":"ovs\u003e\u003d2.8.0 # Apache-2.0"},{"line_number":11,"context_line":"ovsdbapp\u003e\u003d0.14.0 # Apache-2.0"},{"line_number":12,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":13,"context_line":"pyOpenSSL\u003e\u003d17.1.0 # Apache-2.0"},{"line_number":14,"context_line":"tenacity\u003e\u003d4.4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bfb3d3c7_140c603f","line":11,"updated":"2019-05-27 15:18:54.000000000","message":"We need to bump it in the requirements project first[0]. See: http://logs.openstack.org/28/661628/4/check/requirements-check/ae92a92/job-output.txt.gz#_2019-05-27_15_13_50_455737\n\n[0] https://github.com/openstack/requirements/","commit_id":"87f31be3a9804b40b1ecbd5e1375f9fd8f69304b"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"208d0d7a4b46f3d456f02b3568f964e6b314fc57","unresolved":false,"context_lines":[{"line_number":8,"context_line":"neutron-lib\u003e\u003d1.25.0 # Apache-2.0"},{"line_number":9,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":10,"context_line":"ovs\u003e\u003d2.8.0 # Apache-2.0"},{"line_number":11,"context_line":"ovsdbapp\u003e\u003d0.14.0 # Apache-2.0"},{"line_number":12,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":13,"context_line":"pyOpenSSL\u003e\u003d17.1.0 # Apache-2.0"},{"line_number":14,"context_line":"tenacity\u003e\u003d4.4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bfb3d3c7_77003e02","line":11,"in_reply_to":"bfb3d3c7_140c603f","updated":"2019-05-27 15:19:44.000000000","message":"Or bump it in the lower-requirements.txt (in our repo) that may work too.","commit_id":"87f31be3a9804b40b1ecbd5e1375f9fd8f69304b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"33ecaecdf2ceb3200632d1d98c5559beda1d3a3f","unresolved":false,"context_lines":[{"line_number":8,"context_line":"neutron-lib\u003e\u003d1.25.0 # Apache-2.0"},{"line_number":9,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":10,"context_line":"ovs\u003e\u003d2.8.0 # Apache-2.0"},{"line_number":11,"context_line":"ovsdbapp\u003e\u003d0.14.0 # Apache-2.0"},{"line_number":12,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":13,"context_line":"pyOpenSSL\u003e\u003d17.1.0 # Apache-2.0"},{"line_number":14,"context_line":"tenacity\u003e\u003d4.4.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"bfb3d3c7_d7448a49","line":11,"in_reply_to":"bfb3d3c7_77003e02","updated":"2019-05-27 15:23:06.000000000","message":"Yes, probably in our repo. Requirements project doesn\u0027t limit ovsdbapp, only upper-constraints, which is aligned with this patch. Thanks for pointing that out.","commit_id":"87f31be3a9804b40b1ecbd5e1375f9fd8f69304b"}],"test-requirements.txt":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"84b58e301d9c21fb05dbde4e2c8c9ba96d5c592b","unresolved":false,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"os-testr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"ovsdbapp\u003e\u003d0.14.0 # Apache-2.0"},{"line_number":14,"context_line":"astroid\u003d\u003d1.6.5;python_version\u003c\"3.0\" # LGPLv2.1"},{"line_number":15,"context_line":"astroid\u003d\u003d2.1.0;python_version\u003e\u003d\"3.0\" # LGPLv2.1"},{"line_number":16,"context_line":"pylint\u003d\u003d1.9.3;python_version\u003c\u00273.0\u0027 # GPLv2"}],"source_content_type":"text/plain","patch_set":3,"id":"bfb3d3c7_d449e8b6","line":13,"updated":"2019-05-27 15:02:40.000000000","message":"Is it needed ? Cause ovsdbapp is part of requirements.txt already.\n\nhttps://github.com/openstack/networking-ovn/blob/e179d3a5c2c4b64a701b5b0ee7c9a0e0dc47d93a/tox.ini#L13-L14","commit_id":"6f7e8d9128d9228567bfb62bb66852c89fbb5c1b"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"76051f743c5f319a9a2c771482022e5c3657c758","unresolved":false,"context_lines":[{"line_number":10,"context_line":"python-subunit\u003e\u003d1.0.0 # Apache-2.0/BSD"},{"line_number":11,"context_line":"oslotest\u003e\u003d3.2.0 # Apache-2.0"},{"line_number":12,"context_line":"os-testr\u003e\u003d1.0.0 # Apache-2.0"},{"line_number":13,"context_line":"ovsdbapp\u003e\u003d0.14.0 # Apache-2.0"},{"line_number":14,"context_line":"astroid\u003d\u003d1.6.5;python_version\u003c\"3.0\" # LGPLv2.1"},{"line_number":15,"context_line":"astroid\u003d\u003d2.1.0;python_version\u003e\u003d\"3.0\" # LGPLv2.1"},{"line_number":16,"context_line":"pylint\u003d\u003d1.9.3;python_version\u003c\u00273.0\u0027 # GPLv2"}],"source_content_type":"text/plain","patch_set":3,"id":"bfb3d3c7_346ac4ec","line":13,"in_reply_to":"bfb3d3c7_d449e8b6","updated":"2019-05-27 15:10:13.000000000","message":"As discussed on irc, it\u0027s better to bump in requirements so we have production code tested with what is required. In case of having test-requirements version different, we won\u0027t be testing what we release.","commit_id":"6f7e8d9128d9228567bfb62bb66852c89fbb5c1b"}]}