)]}'
{"networking_ovn/db/maintenance.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"9c2687e6ea8d8fc27d83c0121f672fbbf85c0f27","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Time (in seconds) used to identify if an entry is new before considering"},{"line_number":27,"context_line":"# it an inconsistency"},{"line_number":28,"context_line":"INCONSISTENCIES_OLDER_THAN \u003d 180"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_inconsistent_resources():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_22a73baa","line":28,"range":{"start_line":28,"start_character":29,"end_line":28,"end_character":32},"updated":"2019-06-20 14:35:53.000000000","message":"This is maybe too much: if the maint task kicks in every 5 mins and we have a hysteresis of 3 minutes, most of the inconsistencies will take two cycles to heal. This is to protect a race condition between the time by the object gets persisted in Neutron DB and it\u0027s created in OVN. Both operations *should* happen really close in time or then we have a super big problem :)\n\nI\u0027d be ok to start safe with this value though but would like to know what others think.","commit_id":"cbb0389577f00aa2e073a24e63af0991637fe364"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3cdc3ec6879a2a1cbc4316c4c5f8c3c8668419ba","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Time (in seconds) used to identify if an entry is new before considering"},{"line_number":27,"context_line":"# it an inconsistency"},{"line_number":28,"context_line":"INCONSISTENCIES_OLDER_THAN \u003d 180"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_inconsistent_resources():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_61d1b057","line":28,"range":{"start_line":28,"start_character":29,"end_line":28,"end_character":32},"in_reply_to":"9fb8cfa7_22a73baa","updated":"2019-06-20 14:45:34.000000000","message":"Good points here. The 180s is very conservative, I tried to look into neutron to see if there\u0027s any config for the timeout on the API side but I couldn\u0027t find it.\n\nIn networking-ovn, we have a timeout of 180s to reconnect to the IDLs (it doesn\u0027t really times out, but it waits until 180, then the next try will be 180s see [0]). So I thought about using the same here.\n\nBut idk, defaults are hard and I\u0027m happy to lower it if people think it would be better.\n\n[0] https://github.com/openstack/networking-ovn/blob/96683a265d27f073c926fb56a39cc5bb63a131ed/networking_ovn/ovsdb/impl_idl_ovn.py#L125","commit_id":"cbb0389577f00aa2e073a24e63af0991637fe364"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5b063efcef5c2a5bf0b9a68a1f9a32e56460913f","unresolved":false,"context_lines":[{"line_number":25,"context_line":""},{"line_number":26,"context_line":"# Time (in seconds) used to identify if an entry is new before considering"},{"line_number":27,"context_line":"# it an inconsistency"},{"line_number":28,"context_line":"INCONSISTENCIES_OLDER_THAN \u003d 180"},{"line_number":29,"context_line":""},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"def get_inconsistent_resources():"}],"source_content_type":"text/x-python","patch_set":1,"id":"9fb8cfa7_f5a8f6d9","line":28,"range":{"start_line":28,"start_character":29,"end_line":28,"end_character":32},"in_reply_to":"9fb8cfa7_61d1b057","updated":"2019-06-20 17:35:40.000000000","message":"I\u0027ve updated the patch to 60s after some discussions on IRC","commit_id":"cbb0389577f00aa2e073a24e63af0991637fe364"}]}