)]}'
{"networking_ovn/common/ovn_client.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"76f46ea113ed80ed5bdd1dc2ced62a1aaa5399d8","unresolved":false,"context_lines":[{"line_number":696,"context_line":"            )"},{"line_number":697,"context_line":"        else:"},{"line_number":698,"context_line":"            LOG.warning(\"LSP for floatingip %s, has not been found! \""},{"line_number":699,"context_line":"                        \"Cannot set FIP on VIP in case of Octavia LB.\","},{"line_number":700,"context_line":"                        floatingip[\u0027id\u0027])"},{"line_number":701,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_22b3f14f","line":699,"range":{"start_line":699,"start_character":47,"end_line":699,"end_character":69},"updated":"2019-07-03 15:46:03.000000000","message":"nit: I would remove this bit here. We are not testing whether Octavia is being running or not right ?\n\nOne would be confused if this gets logged in a deployment were Octavia is not even deployed.","commit_id":"cc76be154588a9286ffd1e93381ec6b1a3a5cba7"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"239c69e84f26be59ff0c36130a7c0d994aae42b3","unresolved":false,"context_lines":[{"line_number":696,"context_line":"            )"},{"line_number":697,"context_line":"        else:"},{"line_number":698,"context_line":"            LOG.warning(\"LSP for floatingip %s, has not been found! \""},{"line_number":699,"context_line":"                        \"Cannot set FIP on VIP in case of Octavia LB.\","},{"line_number":700,"context_line":"                        floatingip[\u0027id\u0027])"},{"line_number":701,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_a6fcdb3e","line":699,"range":{"start_line":699,"start_character":47,"end_line":699,"end_character":69},"in_reply_to":"9fb8cfa7_22b3f14f","updated":"2019-07-04 08:06:17.000000000","message":"Sure, you\u0027re right. I\u0027ll drop it.","commit_id":"cc76be154588a9286ffd1e93381ec6b1a3a5cba7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"76f46ea113ed80ed5bdd1dc2ced62a1aaa5399d8","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                            \u0027external_ids\u0027,"},{"line_number":718,"context_line":"                            (ovn_const.OVN_PORT_FIP_EXT_ID_KEY))"},{"line_number":719,"context_line":"                    )"},{"line_number":720,"context_line":"        except KeyError:"},{"line_number":721,"context_line":"            LOG.debug(\"FIP doesn\u0027t have external_ids\")"},{"line_number":722,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def update_floatingip_status(self, floatingip):"}],"source_content_type":"text/x-python","patch_set":8,"id":"9fb8cfa7_a27281ac","line":721,"range":{"start_line":720,"start_character":0,"end_line":721,"end_character":54},"updated":"2019-07-03 15:46:03.000000000","message":"I don\u0027t think this is needed since you are using get(ovn_const.OVN_FIP_PORT_EXT_ID_KEY) to access this value. If the key does not exist, None will be returned (and it\u0027s being tested at L711)","commit_id":"cc76be154588a9286ffd1e93381ec6b1a3a5cba7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"b3b64982ae4314875581ac2e4c2f122c166d771a","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                            \u0027external_ids\u0027,"},{"line_number":718,"context_line":"                            (ovn_const.OVN_PORT_FIP_EXT_ID_KEY))"},{"line_number":719,"context_line":"                    )"},{"line_number":720,"context_line":"        except KeyError:"},{"line_number":721,"context_line":"            LOG.debug(\"FIP doesn\u0027t have external_ids\")"},{"line_number":722,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def update_floatingip_status(self, floatingip):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_9ced7227","line":721,"range":{"start_line":720,"start_character":0,"end_line":721,"end_character":54},"in_reply_to":"7faddb67_210f752f","updated":"2019-07-04 08:54:38.000000000","message":"Oh I thought external_ids would always be present. Ack thanks for the explanation.\n\nAs another nit then, shall we add the id of the FIP in the LOG message ? Otherwise it\u0027s hard to follow up which one failed while troubleshooting the problem next time.","commit_id":"cc76be154588a9286ffd1e93381ec6b1a3a5cba7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e23ff15a31bb82639ebf135366712611e0917fe","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                            \u0027external_ids\u0027,"},{"line_number":718,"context_line":"                            (ovn_const.OVN_PORT_FIP_EXT_ID_KEY))"},{"line_number":719,"context_line":"                    )"},{"line_number":720,"context_line":"        except KeyError:"},{"line_number":721,"context_line":"            LOG.debug(\"FIP doesn\u0027t have external_ids\")"},{"line_number":722,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def update_floatingip_status(self, floatingip):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_2d2195fc","line":721,"range":{"start_line":720,"start_character":0,"end_line":721,"end_character":54},"in_reply_to":"7faddb67_6d21cd4d","updated":"2019-07-05 13:21:35.000000000","message":"Fair enough! Thanks","commit_id":"cc76be154588a9286ffd1e93381ec6b1a3a5cba7"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"15fca5163d7d021c1cfa6605b95eed5e6bffb0f4","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                            \u0027external_ids\u0027,"},{"line_number":718,"context_line":"                            (ovn_const.OVN_PORT_FIP_EXT_ID_KEY))"},{"line_number":719,"context_line":"                    )"},{"line_number":720,"context_line":"        except KeyError:"},{"line_number":721,"context_line":"            LOG.debug(\"FIP doesn\u0027t have external_ids\")"},{"line_number":722,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def update_floatingip_status(self, floatingip):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_b762c7d7","line":721,"range":{"start_line":720,"start_character":0,"end_line":721,"end_character":54},"in_reply_to":"7faddb67_9ced7227","updated":"2019-07-04 09:41:28.000000000","message":"That\u0027s good idea. Thanks, I\u0027ll add it in the next iteration.","commit_id":"cc76be154588a9286ffd1e93381ec6b1a3a5cba7"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"11f73eaef7ad89fbf9781af86be812fdadca5d57","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                            \u0027external_ids\u0027,"},{"line_number":718,"context_line":"                            (ovn_const.OVN_PORT_FIP_EXT_ID_KEY))"},{"line_number":719,"context_line":"                    )"},{"line_number":720,"context_line":"        except KeyError:"},{"line_number":721,"context_line":"            LOG.debug(\"FIP doesn\u0027t have external_ids\")"},{"line_number":722,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def update_floatingip_status(self, floatingip):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_6d21cd4d","line":721,"range":{"start_line":720,"start_character":0,"end_line":721,"end_character":54},"in_reply_to":"7faddb67_b762c7d7","updated":"2019-07-05 13:17:18.000000000","message":"I\u0027ve seen that this dict has no \u0027id\u0027 key set here. So I\u0027ve decided to log it all.","commit_id":"cc76be154588a9286ffd1e93381ec6b1a3a5cba7"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"239c69e84f26be59ff0c36130a7c0d994aae42b3","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                            \u0027external_ids\u0027,"},{"line_number":718,"context_line":"                            (ovn_const.OVN_PORT_FIP_EXT_ID_KEY))"},{"line_number":719,"context_line":"                    )"},{"line_number":720,"context_line":"        except KeyError:"},{"line_number":721,"context_line":"            LOG.debug(\"FIP doesn\u0027t have external_ids\")"},{"line_number":722,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":723,"context_line":""},{"line_number":724,"context_line":"    def update_floatingip_status(self, floatingip):"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_210f752f","line":721,"range":{"start_line":720,"start_character":0,"end_line":721,"end_character":54},"in_reply_to":"9fb8cfa7_a27281ac","updated":"2019-07-04 08:06:17.000000000","message":"Its about raised KeyError while getting fip[\u0027external_ids\u0027].\nSometimes this key is not set. I found it while debugging functional tests for previous patches here.\nThe same issue happened on kuryr gates:\nhttp://logs.openstack.org/36/604036/27/experimental/kuryr-kubernetes-tempest-containerized-ovn-provider-ovn/e0e645a/controller/logs/screen-q-svc.txt.gz?level\u003dERROR\n\nJul 02 12:59:23.471781 ubuntu-bionic-ovh-gra1-0008593658 neutron-server[8255]: ERROR networking_ovn.common.ovn_client [None req-66a7a626-d62d-4a84-a7b6-f7b4df783bc7 service kuryr] Unable to disassociate floating ip in gateway router. Error: \u0027external_ids\u0027","commit_id":"cc76be154588a9286ffd1e93381ec6b1a3a5cba7"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"3e23ff15a31bb82639ebf135366712611e0917fe","unresolved":false,"context_lines":[{"line_number":696,"context_line":"            )"},{"line_number":697,"context_line":"        else:"},{"line_number":698,"context_line":"            LOG.warning(\"LSP for floatingip %s, has not been found! \""},{"line_number":699,"context_line":"                        \"Cannot set FIP on VIP in case of Octavia LB.\","},{"line_number":700,"context_line":"                        floatingip[\u0027id\u0027])"},{"line_number":701,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_ed785df9","line":699,"range":{"start_line":699,"start_character":47,"end_line":699,"end_character":69},"updated":"2019-07-05 13:21:35.000000000","message":"I still think we should get rid of this octavia reference here since, this code will run with out without octavia and might cause confusion.","commit_id":"0ac4fa32178e4f4ee57f31599a3357ba41678d4c"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"3b00980a7fe4d10a24397a56f6a7e578a69aaf56","unresolved":false,"context_lines":[{"line_number":696,"context_line":"            )"},{"line_number":697,"context_line":"        else:"},{"line_number":698,"context_line":"            LOG.warning(\"LSP for floatingip %s, has not been found! \""},{"line_number":699,"context_line":"                        \"Cannot set FIP on VIP in case of Octavia LB.\","},{"line_number":700,"context_line":"                        floatingip[\u0027id\u0027])"},{"line_number":701,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":702,"context_line":""}],"source_content_type":"text/x-python","patch_set":9,"id":"7faddb67_2de435ac","line":699,"range":{"start_line":699,"start_character":47,"end_line":699,"end_character":69},"in_reply_to":"7faddb67_ed785df9","updated":"2019-07-05 13:32:30.000000000","message":"Ahh sorry forgot about this.","commit_id":"0ac4fa32178e4f4ee57f31599a3357ba41678d4c"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8b3a295c00b6efe8eaa142598942509b2a261531","unresolved":false,"context_lines":[{"line_number":717,"context_line":"                            \u0027external_ids\u0027,"},{"line_number":718,"context_line":"                            (ovn_const.OVN_PORT_FIP_EXT_ID_KEY))"},{"line_number":719,"context_line":"                    )"},{"line_number":720,"context_line":"        except KeyError:"},{"line_number":721,"context_line":"            LOG.debug(\"FIP %s doesn\u0027t have external_ids.\", fip)"},{"line_number":722,"context_line":"        self._transaction(commands, txn\u003dtxn)"},{"line_number":723,"context_line":""}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_b1df9038","line":720,"updated":"2019-07-16 08:33:28.000000000","message":"nit: you could have removed get() on L710 and update the message that fip doesn\u0027t have either external_ids or ovn_const.OVN_FIP_PORT_EXT_ID_KEY and you could avoid the L711","commit_id":"c8e8cdbb4b38afe70ff1d36044bab05e30ddc7e5"}],"networking_ovn/tests/unit/l3/test_l3_ovn.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"8b3a295c00b6efe8eaa142598942509b2a261531","unresolved":false,"context_lines":[{"line_number":942,"context_line":"            \u0027fip-port-id\u0027, \u0027neutron-fip-net-id\u0027)"},{"line_number":943,"context_line":""},{"line_number":944,"context_line":"    @mock.patch(\u0027neutron.db.l3_db.L3_NAT_dbonly_mixin._get_floatingip\u0027)"},{"line_number":945,"context_line":"    def test_create_floatingip_lsp_external_id(self, gf):"},{"line_number":946,"context_line":"        foo_lport \u003d fakes.FakeOvsdbRow.create_one_ovsdb_row()"},{"line_number":947,"context_line":"        foo_lport.uuid \u003d \u0027foo-port\u0027"},{"line_number":948,"context_line":"        self.l3_inst._ovn.get_lswitch_port.return_value \u003d foo_lport"}],"source_content_type":"text/x-python","patch_set":14,"id":"7faddb67_31eba0dc","line":945,"updated":"2019-07-16 08:33:28.000000000","message":"Shall we have another test for update?","commit_id":"c8e8cdbb4b38afe70ff1d36044bab05e30ddc7e5"}]}