)]}'
{"networking_ovn/common/ovn_client.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"14abbb9ded8ba0855919594fe7c060eb360bd7a3","unresolved":false,"context_lines":[{"line_number":867,"context_line":"            # TODO(lucasagomes): Remove this check after OVS 2.8.2 is tagged"},{"line_number":868,"context_line":"            # (prior to that, the external_ids column didn\u0027t exist in this"},{"line_number":869,"context_line":"            # table)."},{"line_number":870,"context_line":"            columns \u003d {}"},{"line_number":871,"context_line":"            if self._nb_idl.is_col_present(\u0027Logical_Router_Static_Route\u0027,"},{"line_number":872,"context_line":"                                           \u0027external_ids\u0027):"},{"line_number":873,"context_line":"                columns[\u0027external_ids\u0027] \u003d {"}],"source_content_type":"text/x-python","patch_set":4,"id":"7faddb67_6f0cb6a4","side":"PARENT","line":870,"updated":"2019-07-17 16:24:39.000000000","message":"Think you still need this :)","commit_id":"2dc614e8700aa587cb7348fe2268a7424ec0016c"}],"networking_ovn/tests/unit/l3/test_l3_ovn.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"437bb7872be693047a6d1681dc0674339a982ad1","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"        super(OVNL3ExtrarouteTests, self). \\"},{"line_number":1254,"context_line":"            test_router_update_gateway_upon_subnet_create_max_ips_ipv6()"},{"line_number":1255,"context_line":"        add_static_route_calls \u003d ["},{"line_number":1256,"context_line":"            mock.call(mock.ANY, ip_prefix\u003d\u00270.0.0.0/0\u0027, nexthop\u003d\u002710.0.0.1\u0027),"},{"line_number":1257,"context_line":"            mock.call(mock.ANY, ip_prefix\u003d\u0027::/0\u0027, nexthop\u003d\u00272001:db8::1\u0027)]"},{"line_number":1258,"context_line":"        self.l3_inst._ovn.add_static_route.assert_has_calls("},{"line_number":1259,"context_line":"            add_static_route_calls, any_order\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_70d1bd2f","line":1257,"range":{"start_line":1256,"start_character":0,"end_line":1257,"end_character":73},"updated":"2019-07-22 12:34:18.000000000","message":"The reason why it\u0027s failing is because now the external_ids column will be set in this call too. Prior to your patch it was ignored because we were checking if that column existed (and is_col_present defaulted to False).","commit_id":"922660802610d4c9a6408e3269401afc68f52543"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"50274dbdf353d98407b1020ead2e27b9b39657de","unresolved":false,"context_lines":[{"line_number":1253,"context_line":"        super(OVNL3ExtrarouteTests, self). \\"},{"line_number":1254,"context_line":"            test_router_update_gateway_upon_subnet_create_max_ips_ipv6()"},{"line_number":1255,"context_line":"        add_static_route_calls \u003d ["},{"line_number":1256,"context_line":"            mock.call(mock.ANY, ip_prefix\u003d\u00270.0.0.0/0\u0027, nexthop\u003d\u002710.0.0.1\u0027),"},{"line_number":1257,"context_line":"            mock.call(mock.ANY, ip_prefix\u003d\u0027::/0\u0027, nexthop\u003d\u00272001:db8::1\u0027)]"},{"line_number":1258,"context_line":"        self.l3_inst._ovn.add_static_route.assert_has_calls("},{"line_number":1259,"context_line":"            add_static_route_calls, any_order\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":7,"id":"7faddb67_30db4550","line":1257,"range":{"start_line":1256,"start_character":0,"end_line":1257,"end_character":73},"in_reply_to":"7faddb67_70d1bd2f","updated":"2019-07-22 12:34:48.000000000","message":"The fix is:\n\n-            mock.call(mock.ANY, ip_prefix\u003d\u00270.0.0.0/0\u0027, nexthop\u003d\u002710.0.0.1\u0027),\n-            mock.call(mock.ANY, ip_prefix\u003d\u0027::/0\u0027, nexthop\u003d\u00272001:db8::1\u0027)]\n+            mock.call(mock.ANY, external_ids\u003dmock.ANY, ip_prefix\u003d\u00270.0.0.0/0\u0027, nexthop\u003d\u002710.0.0.1\u0027),\n+            mock.call(mock.ANY, external_ids\u003dmock.ANY, ip_prefix\u003d\u0027::/0\u0027, nexthop\u003d\u00272001:db8::1\u0027)]","commit_id":"922660802610d4c9a6408e3269401afc68f52543"}],"requirements.txt":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"2b0f851b690327ebbedb28d9f69fda79db47d31c","unresolved":false,"context_lines":[{"line_number":7,"context_line":"SQLAlchemy\u003e\u003d1.2.0 # MIT"},{"line_number":8,"context_line":"neutron-lib\u003e\u003d1.25.0 # Apache-2.0"},{"line_number":9,"context_line":"oslo.config\u003e\u003d5.2.0 # Apache-2.0"},{"line_number":10,"context_line":"ovs\u003e\u003d2.11.0 # Apache-2.0"},{"line_number":11,"context_line":"ovsdbapp\u003e\u003d0.14.0 # Apache-2.0"},{"line_number":12,"context_line":"pbr!\u003d2.1.0,\u003e\u003d2.0.0 # Apache-2.0"},{"line_number":13,"context_line":"pyOpenSSL\u003e\u003d17.1.0 # Apache-2.0"}],"source_content_type":"text/plain","patch_set":4,"id":"7faddb67_1de1d52a","line":10,"updated":"2019-07-16 12:40:22.000000000","message":"Note this is the python library so it doesn\u0027t guarantee the schema is present.","commit_id":"e47af0f5eedcd9b4f8ca44be558dae28bbd8fd64"}]}