)]}'
{"networking_ovn/common/maintenance.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"867c1b4835bb320dda997e2cb96a5c4fc06ab32e","unresolved":false,"context_lines":[{"line_number":242,"context_line":"                if f.resource_type not in c:"},{"line_number":243,"context_line":"                    c[f.resource_type] \u003d 1"},{"line_number":244,"context_line":"                else:"},{"line_number":245,"context_line":"                    c[f.resource_type] +\u003d 1"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"            fail_str \u003d \u0027, \u0027.join(\u0027{}\u003d{}\u0027.format(k, v) for k, v in c.items())"},{"line_number":248,"context_line":"            LOG.debug(\u0027Maintenance task: Number of inconsistencies \u0027"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_4c1bfa71","line":245,"updated":"2019-07-18 09:51:46.000000000","message":"FWIW I wanted to make it more \"pythonic\" but pylint was complaining, so I opted for making it more readable. \n\nnetworking_ovn/common/maintenance.py:241:12: W0106: Expression \"[c.update({f.resource_type: c.get(f.resource_type, 0) + 1}) for f in failures]\" is assigned to nothing (expression-not-assigned)","commit_id":"f95c5c59144bba3d694e74fbf9c78b0f36fb9dad"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"fec9efdadc4cbad4876566ba611ab8df7ed73d20","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"            c \u003d {}"},{"line_number":241,"context_line":"            for f in inconsistencies:"},{"line_number":242,"context_line":"                if f.resource_type not in c:"},{"line_number":243,"context_line":"                    c[f.resource_type] \u003d 1"},{"line_number":244,"context_line":"                else:"},{"line_number":245,"context_line":"                    c[f.resource_type] +\u003d 1"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"            fail_str \u003d \u0027, \u0027.join(\u0027{}\u003d{}\u0027.format(k, v) for k, v in c.items())"},{"line_number":248,"context_line":"            LOG.debug(\u0027Maintenance task: Number of inconsistencies \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_4ce53a37","line":245,"range":{"start_line":242,"start_character":0,"end_line":245,"end_character":43},"updated":"2019-07-18 10:08:33.000000000","message":"You can do:\n\n c[f.resource_type] \u003d c.get(f.resource_type, 0) + 1","commit_id":"f59acf38968ce9c6129f1a1bffd277af8406a2d0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a40677130d1c2f54aaa8d4042afd2afd09264b43","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"            c \u003d {}"},{"line_number":241,"context_line":"            for f in inconsistencies:"},{"line_number":242,"context_line":"                if f.resource_type not in c:"},{"line_number":243,"context_line":"                    c[f.resource_type] \u003d 1"},{"line_number":244,"context_line":"                else:"},{"line_number":245,"context_line":"                    c[f.resource_type] +\u003d 1"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"            fail_str \u003d \u0027, \u0027.join(\u0027{}\u003d{}\u0027.format(k, v) for k, v in c.items())"},{"line_number":248,"context_line":"            LOG.debug(\u0027Maintenance task: Number of inconsistencies \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_ace4ee0d","line":245,"range":{"start_line":242,"start_character":0,"end_line":245,"end_character":43},"in_reply_to":"7faddb67_4ce53a37","updated":"2019-07-18 10:14:30.000000000","message":"Yeah, I had it as:\n\n[c.update({f.resource_type: c.get(f.resource_type, 0) + 1}) for f in failures]\n\nBut pylint was complaining [0] so I decided to go full on the readability. Your example would work tho, I can update it if others think it\u0027s better.\n\n[0] networking_ovn/common/maintenance.py:241:12: W0106: Expression \"[c.update({f.resource_type: c.get(f.resource_type, 0) + 1}) for f in failures]\" is assigned to nothing (expression-not-assigned)","commit_id":"f59acf38968ce9c6129f1a1bffd277af8406a2d0"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"43b0488801a8775fdda0293d248a7e310b7b4f6e","unresolved":false,"context_lines":[{"line_number":239,"context_line":""},{"line_number":240,"context_line":"            c \u003d {}"},{"line_number":241,"context_line":"            for f in inconsistencies:"},{"line_number":242,"context_line":"                if f.resource_type not in c:"},{"line_number":243,"context_line":"                    c[f.resource_type] \u003d 1"},{"line_number":244,"context_line":"                else:"},{"line_number":245,"context_line":"                    c[f.resource_type] +\u003d 1"},{"line_number":246,"context_line":""},{"line_number":247,"context_line":"            fail_str \u003d \u0027, \u0027.join(\u0027{}\u003d{}\u0027.format(k, v) for k, v in c.items())"},{"line_number":248,"context_line":"            LOG.debug(\u0027Maintenance task: Number of inconsistencies \u0027"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_2cbebeb3","line":245,"range":{"start_line":242,"start_character":0,"end_line":245,"end_character":43},"in_reply_to":"7faddb67_ace4ee0d","updated":"2019-07-18 11:54:21.000000000","message":"Nah, it\u0027s fine how it is.","commit_id":"f59acf38968ce9c6129f1a1bffd277af8406a2d0"}]}