)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"08a208038755d6174f9320443dd651c163ebc0ad","unresolved":false,"context_lines":[{"line_number":23,"context_line":"At earlier versions of this patch we thought about having networking-ovn"},{"line_number":24,"context_line":"to discover if this option is supported or not (by issuing that"},{"line_number":25,"context_line":"ovs-appctl command above) but, since networking-ovn doesn\u0027t run in the"},{"line_number":26,"context_line":"network nodes we thought that an upper level tool (such as puppet-ovn or"},{"line_number":27,"context_line":"TripleO) could do a better job at checking if fragmentation is supported"},{"line_number":28,"context_line":"and setting this option accordingly."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-Bug: #1838405"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_c1281634","line":27,"range":{"start_line":26,"start_character":51,"end_line":27,"end_character":7},"updated":"2019-08-05 09:26:18.000000000","message":"Neutron has a sanity-check command [1] which is a simple script that is capable of running various checks on given node. That is used by tripleo-validations [2] to make sure node has functionality required by Neutron. This is just a food for thought, sounds to me like we could re-use that for this purpose. Ofc, not in this patch :)\n\n[1] https://opendev.org/openstack/neutron/src/commit/8a28340628a58f5e80641766a4f9b9806d60a2a8/neutron/cmd/sanity/checks.py\n[2] https://opendev.org/openstack/tripleo-validations/src/commit/0204d7665ccec58d17feae46d9f288a638fad804/roles/neutron-sanity-check/tasks/main.yml#L19","commit_id":"15db4e217f2f6e9b34ae056a47550727069a45b0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c0a2fca74e0a186b3c592724857cd50a95918e9d","unresolved":false,"context_lines":[{"line_number":23,"context_line":"At earlier versions of this patch we thought about having networking-ovn"},{"line_number":24,"context_line":"to discover if this option is supported or not (by issuing that"},{"line_number":25,"context_line":"ovs-appctl command above) but, since networking-ovn doesn\u0027t run in the"},{"line_number":26,"context_line":"network nodes we thought that an upper level tool (such as puppet-ovn or"},{"line_number":27,"context_line":"TripleO) could do a better job at checking if fragmentation is supported"},{"line_number":28,"context_line":"and setting this option accordingly."},{"line_number":29,"context_line":""},{"line_number":30,"context_line":"Closes-Bug: #1838405"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"7faddb67_3f66d4ee","line":27,"range":{"start_line":26,"start_character":51,"end_line":27,"end_character":7},"in_reply_to":"7faddb67_c1281634","updated":"2019-08-09 08:48:41.000000000","message":"Ah cool, something to explore!","commit_id":"15db4e217f2f6e9b34ae056a47550727069a45b0"}],"networking_ovn/common/config.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"785627176b20003f523592b3f6f9ba915b6b28a3","unresolved":false,"context_lines":[{"line_number":319,"context_line":"    return False"},{"line_number":320,"context_line":""},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"@lockutils.synchronized(\u0027ovn_fragmentation_enabled_lock\u0027)"},{"line_number":323,"context_line":"def is_ovn_fragmentation_enabled():"},{"line_number":324,"context_line":"    global _OVN_FRAGMENTATION_ENABLED"},{"line_number":325,"context_line":"    if not _OVN_FRAGMENTATION_ENABLED:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_53e27231","line":322,"range":{"start_line":322,"start_character":0,"end_line":322,"end_character":57},"updated":"2019-07-23 17:20:41.000000000","message":"overkill, not needed","commit_id":"1a224c88ad365d4f3fe85982754c7ddc61f175f5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"785627176b20003f523592b3f6f9ba915b6b28a3","unresolved":false,"context_lines":[{"line_number":322,"context_line":"@lockutils.synchronized(\u0027ovn_fragmentation_enabled_lock\u0027)"},{"line_number":323,"context_line":"def is_ovn_fragmentation_enabled():"},{"line_number":324,"context_line":"    global _OVN_FRAGMENTATION_ENABLED"},{"line_number":325,"context_line":"    if not _OVN_FRAGMENTATION_ENABLED:"},{"line_number":326,"context_line":"        value \u003d cfg.CONF.ovn.ovn_fragmentation_enabled"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"        if value \u003d\u003d \u0027auto\u0027:"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_93d8ea7f","line":325,"range":{"start_line":325,"start_character":4,"end_line":325,"end_character":37},"updated":"2019-07-23 17:20:41.000000000","message":"Should check if _OVN... is None (Otherwise False, which is valid will always enter here)","commit_id":"1a224c88ad365d4f3fe85982754c7ddc61f175f5"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"634fb8b991d112e28a55ce8103cd838da00e5da1","unresolved":false,"context_lines":[{"line_number":28,"context_line":"VLOG_LEVELS \u003d {\u0027CRITICAL\u0027: vlog.CRITICAL, \u0027ERROR\u0027: vlog.ERROR, \u0027WARNING\u0027:"},{"line_number":29,"context_line":"               vlog.WARN, \u0027INFO\u0027: vlog.INFO, \u0027DEBUG\u0027: vlog.DEBUG}"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":""},{"line_number":32,"context_line":"ovn_opts \u003d ["},{"line_number":33,"context_line":"    cfg.StrOpt(\u0027ovn_nb_connection\u0027,"},{"line_number":34,"context_line":"               default\u003d\u0027tcp:127.0.0.1:6641\u0027,"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_7e982374","line":31,"updated":"2019-07-31 09:12:21.000000000","message":"Unintentional change","commit_id":"15db4e217f2f6e9b34ae056a47550727069a45b0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4e62eb689fb9ddcb54d73246ded01d120e430f95","unresolved":false,"context_lines":[{"line_number":186,"context_line":"                help\u003d_(\u0027Enable packet fragmentation support.\\n\u0027"},{"line_number":187,"context_line":"                       \u0027Before enabling this feature make sure that \u0027"},{"line_number":188,"context_line":"                       \u0027fragmentation for OVS is supported by the host kernel \u0027"},{"line_number":189,"context_line":"                       \u0027(version \u003e 5.2 or) by checking the output of the \u0027"},{"line_number":190,"context_line":"                       \u0027following command: \\n\u0027"},{"line_number":191,"context_line":"                       \u0027ovs-appctl -t ovs-vswitchd dpif/show-dp-features \u0027"},{"line_number":192,"context_line":"                       \u0027br-int | grep \"Check pkt length action\".\u0027)),"}],"source_content_type":"text/x-python","patch_set":5,"id":"7faddb67_e8888b71","line":189,"range":{"start_line":189,"start_character":38,"end_line":189,"end_character":42},"updated":"2019-08-05 21:05:40.000000000","message":"s/) or","commit_id":"15db4e217f2f6e9b34ae056a47550727069a45b0"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"facc640772df47a5b18874650722173448dc21fd","unresolved":false,"context_lines":[{"line_number":185,"context_line":"                help\u003d_(\u0027Configure OVN to emit \"need to frag\" packets in \u0027"},{"line_number":186,"context_line":"                       \u0027case of MTU mismatch.\\n\u0027"},{"line_number":187,"context_line":"                       \u0027Before enabling this configuration make sure that \u0027"},{"line_number":188,"context_line":"                       \u0027its supported by the host kernel (version \u003e\u003d 5.2) \u0027"},{"line_number":189,"context_line":"                       \u0027or by checking the output of the following command: \\n\u0027"},{"line_number":190,"context_line":"                       \u0027ovs-appctl -t ovs-vswitchd dpif/show-dp-features \u0027"},{"line_number":191,"context_line":"                       \u0027br-int | grep \"Check pkt length action\".\u0027)),"}],"source_content_type":"text/x-python","patch_set":8,"id":"7faddb67_0ceebeec","line":188,"range":{"start_line":188,"start_character":24,"end_line":188,"end_character":27},"updated":"2019-08-29 19:19:41.000000000","message":"nit: s/it is","commit_id":"44f0a57cbe7b8a188d4208e864c3b1c1fcd93ee7"}],"networking_ovn/common/ovn_client.py":[{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"e375f84f4c69022108e44a817f1a7e3ae1633301","unresolved":false,"context_lines":[{"line_number":1185,"context_line":"        lrouter_port_name \u003d utils.ovn_lrouter_port_name(port[\u0027id\u0027])"},{"line_number":1186,"context_line":"        is_gw_port \u003d const.DEVICE_OWNER_ROUTER_GW \u003d\u003d port.get("},{"line_number":1187,"context_line":"            \u0027device_owner\u0027)"},{"line_number":1188,"context_line":"        columns \u003d {}"},{"line_number":1189,"context_line":"        columns[\u0027options\u0027] \u003d self._gen_router_port_options(port)"},{"line_number":1190,"context_line":""},{"line_number":1191,"context_line":"        if is_gw_port:"}],"source_content_type":"text/x-python","patch_set":8,"id":"5faad753_40e7cb13","line":1188,"updated":"2019-09-10 14:35:47.000000000","message":"stupid nit: could just be\n\n    columns \u003d {\u0027options\u0027: self._gen_router_port_options(port)}\n\nplease ignore unless you have to respin :p","commit_id":"44f0a57cbe7b8a188d4208e864c3b1c1fcd93ee7"}],"releasenotes/notes/fragmentation-support-2860870dc7b8bb6b.yaml":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"4e62eb689fb9ddcb54d73246ded01d120e430f95","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for fragmentation in networking-ovn. A new configuration"},{"line_number":5,"context_line":"    option called \"ovn_fragmentation_enabled\" has been added and it"},{"line_number":6,"context_line":"    defaults to False. Reason being, it requires a specific kernel version"},{"line_number":7,"context_line":"    for fragmentation to works (upstream \u003e\u003d 5.2). It\u0027s also possible to"},{"line_number":8,"context_line":"    find out if fragmentation is supported by running the following"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_0bc3a139","line":5,"range":{"start_line":5,"start_character":19,"end_line":5,"end_character":44},"updated":"2019-08-05 21:05:40.000000000","message":"this should be in `` `` too","commit_id":"15db4e217f2f6e9b34ae056a47550727069a45b0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"c0a2fca74e0a186b3c592724857cd50a95918e9d","unresolved":false,"context_lines":[{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - |"},{"line_number":4,"context_line":"    Adds support for fragmentation in networking-ovn. A new configuration"},{"line_number":5,"context_line":"    option called \"ovn_fragmentation_enabled\" has been added and it"},{"line_number":6,"context_line":"    defaults to False. Reason being, it requires a specific kernel version"},{"line_number":7,"context_line":"    for fragmentation to works (upstream \u003e\u003d 5.2). It\u0027s also possible to"},{"line_number":8,"context_line":"    find out if fragmentation is supported by running the following"}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_f8da4f49","line":5,"range":{"start_line":5,"start_character":19,"end_line":5,"end_character":44},"in_reply_to":"7faddb67_0bc3a139","updated":"2019-08-09 08:48:41.000000000","message":"++","commit_id":"15db4e217f2f6e9b34ae056a47550727069a45b0"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"aaa0f67a35888892c82d7d5a076bf714d3f3ab1e","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    defaults to False. Reason being, it requires a specific kernel version"},{"line_number":7,"context_line":"    for fragmentation to works (upstream \u003e\u003d 5.2). It\u0027s also possible to"},{"line_number":8,"context_line":"    find out if fragmentation is supported by running the following"},{"line_number":9,"context_line":"    command as root: ovs-appctl -t ovs-vswitchd dpif/show-dp-features"},{"line_number":10,"context_line":"    br-int (check for \"Check pkt length action: Yes\")."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_d727a711","line":10,"range":{"start_line":9,"start_character":20,"end_line":10,"end_character":10},"updated":"2019-08-01 09:12:17.000000000","message":"``ovs-appctl -t ovs-vswitchd dpif/show-dp-features br-int``","commit_id":"15db4e217f2f6e9b34ae056a47550727069a45b0"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f9c6e699ab19ede98c0a9bfa62f2c23b3abf5eda","unresolved":false,"context_lines":[{"line_number":6,"context_line":"    defaults to False. Reason being, it requires a specific kernel version"},{"line_number":7,"context_line":"    for fragmentation to works (upstream \u003e\u003d 5.2). It\u0027s also possible to"},{"line_number":8,"context_line":"    find out if fragmentation is supported by running the following"},{"line_number":9,"context_line":"    command as root: ovs-appctl -t ovs-vswitchd dpif/show-dp-features"},{"line_number":10,"context_line":"    br-int (check for \"Check pkt length action: Yes\")."}],"source_content_type":"text/x-yaml","patch_set":5,"id":"7faddb67_d7032741","line":10,"range":{"start_line":9,"start_character":20,"end_line":10,"end_character":10},"in_reply_to":"7faddb67_d727a711","updated":"2019-08-01 09:18:01.000000000","message":"++\n\nYeah that would highlight the command, if I happen to submit a new patch-set I will include this","commit_id":"15db4e217f2f6e9b34ae056a47550727069a45b0"}]}