)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"8ba53efde88cce1d4c74df9899c1c78e7541139b","unresolved":false,"context_lines":[{"line_number":12,"context_line":"The patch includes new functions based on the \"compile_ovs\" one changing"},{"line_number":13,"context_line":"it to OVN."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"If the OVN_BRANCH is set to stable branches the code will fallback to"},{"line_number":16,"context_line":"using the \"compile_ovs\" function like before (since those branches does"},{"line_number":17,"context_line":"not exist in the new OVN repository, only master, which will be the 2.12"},{"line_number":18,"context_line":"version)."},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"Change-Id: I8b99a3481b4460ae32f2258dcf4190db9a8fed89"},{"line_number":21,"context_line":"Signed-off-by: Lucas Alvares Gomes \u003clucasagomes@gmail.com\u003e"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"7faddb67_e89ec005","line":18,"range":{"start_line":15,"start_character":0,"end_line":18,"end_character":9},"updated":"2019-07-29 09:46:06.000000000","message":"Hmm, what if we\u0027ll release Train? Then would do some ifology right?","commit_id":"9a7729cf43cd88e31bfdabebb178adc7dbbed484"}],"devstack/lib/networking-ovn":[{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"8ba53efde88cce1d4c74df9899c1c78e7541139b","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":192,"context_line":"    local ovn_path"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    if [ \"$OVN_BRANCH\" \u003d\u003d \"master\" ] ; then"},{"line_number":195,"context_line":"        ovn_path\u003d${1:-$DEST/$OVN_REPO_NAME}"},{"line_number":196,"context_line":"    else"},{"line_number":197,"context_line":"        ovn_path\u003d${1:-$DEST/$OVS_REPO_NAME}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_e83a40e5","line":194,"range":{"start_line":194,"start_character":4,"end_line":194,"end_character":43},"updated":"2019-07-29 09:46:06.000000000","message":"If Train will be released it would need some ifology ;(.","commit_id":"9a7729cf43cd88e31bfdabebb178adc7dbbed484"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"70c25baec998579b6641c5b7eff1359ef4843a7a","unresolved":false,"context_lines":[{"line_number":191,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":192,"context_line":"    local ovn_path"},{"line_number":193,"context_line":""},{"line_number":194,"context_line":"    if [ \"$OVN_BRANCH\" \u003d\u003d \"master\" ] ; then"},{"line_number":195,"context_line":"        ovn_path\u003d${1:-$DEST/$OVN_REPO_NAME}"},{"line_number":196,"context_line":"    else"},{"line_number":197,"context_line":"        ovn_path\u003d${1:-$DEST/$OVS_REPO_NAME}"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_63e67147","line":194,"range":{"start_line":194,"start_character":4,"end_line":194,"end_character":43},"in_reply_to":"7faddb67_e83a40e5","updated":"2019-07-29 10:02:29.000000000","message":"Yeah I was thinking about it, we need to check for the 2.12 version. I will try to include it here","commit_id":"9a7729cf43cd88e31bfdabebb178adc7dbbed484"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"8ba53efde88cce1d4c74df9899c1c78e7541139b","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    sudo modprobe -r vport_geneve"},{"line_number":312,"context_line":"    sudo modprobe -r openvswitch"},{"line_number":313,"context_line":"    sudo modprobe openvswitch || (dmesg \u0026\u0026 die $LINENO \"FAILED TO LOAD openvswitch\")"},{"line_number":314,"context_line":"    sudo modprobe vport-geneve || (echo \"FAILED TO LOAD vport-geneve\" \u0026\u0026 dmesg)"},{"line_number":315,"context_line":"}"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"# _prepare_for_ovn_compilation() - Fetch the ovn git repository and install"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_281a987c","line":314,"range":{"start_line":314,"start_character":33,"end_line":314,"end_character":79},"updated":"2019-07-29 09:46:06.000000000","message":"Lets have same convention?\n\ndmesg \u0026\u0026 echo \"FAILED TO LOAD vport-geneve\"","commit_id":"9a7729cf43cd88e31bfdabebb178adc7dbbed484"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"70c25baec998579b6641c5b7eff1359ef4843a7a","unresolved":false,"context_lines":[{"line_number":311,"context_line":"    sudo modprobe -r vport_geneve"},{"line_number":312,"context_line":"    sudo modprobe -r openvswitch"},{"line_number":313,"context_line":"    sudo modprobe openvswitch || (dmesg \u0026\u0026 die $LINENO \"FAILED TO LOAD openvswitch\")"},{"line_number":314,"context_line":"    sudo modprobe vport-geneve || (echo \"FAILED TO LOAD vport-geneve\" \u0026\u0026 dmesg)"},{"line_number":315,"context_line":"}"},{"line_number":316,"context_line":""},{"line_number":317,"context_line":"# _prepare_for_ovn_compilation() - Fetch the ovn git repository and install"}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_c3d7254f","line":314,"range":{"start_line":314,"start_character":33,"end_line":314,"end_character":79},"in_reply_to":"7faddb67_281a987c","updated":"2019-07-29 10:02:29.000000000","message":"++","commit_id":"9a7729cf43cd88e31bfdabebb178adc7dbbed484"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"8ba53efde88cce1d4c74df9899c1c78e7541139b","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    # Install ovs python module from ovs source."},{"line_number":456,"context_line":"    if [[ \"$OVN_INSTALL_OVS_PYTHON_MODULE\" \u003d\u003d \"True\" ]]; then"},{"line_number":457,"context_line":"        sudo pip uninstall -y ovs"},{"line_number":458,"context_line":"        sudo pip install -e $DEST/$OVN_REPO_NAME/python"},{"line_number":459,"context_line":"    fi"},{"line_number":460,"context_line":"}"},{"line_number":461,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_030c5d39","line":458,"range":{"start_line":458,"start_character":35,"end_line":458,"end_character":48},"updated":"2019-07-29 09:46:06.000000000","message":"Is this one already moved? Should we use ovs python module from ovn repo?","commit_id":"9a7729cf43cd88e31bfdabebb178adc7dbbed484"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"70c25baec998579b6641c5b7eff1359ef4843a7a","unresolved":false,"context_lines":[{"line_number":455,"context_line":"    # Install ovs python module from ovs source."},{"line_number":456,"context_line":"    if [[ \"$OVN_INSTALL_OVS_PYTHON_MODULE\" \u003d\u003d \"True\" ]]; then"},{"line_number":457,"context_line":"        sudo pip uninstall -y ovs"},{"line_number":458,"context_line":"        sudo pip install -e $DEST/$OVN_REPO_NAME/python"},{"line_number":459,"context_line":"    fi"},{"line_number":460,"context_line":"}"},{"line_number":461,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":2,"id":"7faddb67_03f69dfa","line":458,"range":{"start_line":458,"start_character":35,"end_line":458,"end_character":48},"in_reply_to":"7faddb67_030c5d39","updated":"2019-07-29 10:02:29.000000000","message":"Good point, just asked numan and it should be from OVS (although, the OVN repo now includes the python/ stuff)","commit_id":"9a7729cf43cd88e31bfdabebb178adc7dbbed484"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"a432569a48b508ee143e08ba8f56d28f36ed1331","unresolved":false,"context_lines":[{"line_number":362,"context_line":"        local _pwd\u003d$PWD"},{"line_number":363,"context_line":"        clone_repository $OVS_REPO $OVS_BRANCH"},{"line_number":364,"context_line":"        cd $_pwd"},{"line_number":365,"context_line":"        sudo pip install -e $DEST/$OVN_REPO_NAME/python"},{"line_number":366,"context_line":"    fi"},{"line_number":367,"context_line":"}"},{"line_number":368,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":5,"id":"7faddb67_e6e90cb7","line":365,"range":{"start_line":365,"start_character":34,"end_line":365,"end_character":48},"updated":"2019-07-29 14:27:00.000000000","message":"OVS_REPO_NAME :-(","commit_id":"baefa23dc70e7d7a60dd27511f6986c4e7826704"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e7b8ac9aa0c52d1ceb1ecedabe5a8397a1a3543a","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    rm -f $OVS_DATADIR/*.db"},{"line_number":334,"context_line":"    rm -f $OVS_DATADIR/*.db"},{"line_number":335,"context_line":"    rm -f $OVN_DATADIR/.*.db.~lock~"},{"line_number":336,"context_line":"    rm -f $OVN_DATADIR/.*.db.~lock~"},{"line_number":337,"context_line":"}"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"# install_ovn() - Collect source and prepare"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5faad753_2ee1abff","line":336,"updated":"2019-09-06 00:58:55.000000000","message":"These don\u0027t look right, simple mistake","commit_id":"abfea3d28258da480bdb2cd294547e8001325bf1"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"593d3f7f13cb8e7a575438fe010ad2dcbf65963f","unresolved":false,"context_lines":[{"line_number":333,"context_line":"    rm -f $OVS_DATADIR/*.db"},{"line_number":334,"context_line":"    rm -f $OVS_DATADIR/*.db"},{"line_number":335,"context_line":"    rm -f $OVN_DATADIR/.*.db.~lock~"},{"line_number":336,"context_line":"    rm -f $OVN_DATADIR/.*.db.~lock~"},{"line_number":337,"context_line":"}"},{"line_number":338,"context_line":""},{"line_number":339,"context_line":"# install_ovn() - Collect source and prepare"}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5faad753_57033343","line":336,"in_reply_to":"5faad753_2ee1abff","updated":"2019-09-09 12:39:32.000000000","message":"Done","commit_id":"abfea3d28258da480bdb2cd294547e8001325bf1"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":182,"context_line":"function _cleanup {"},{"line_number":183,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":184,"context_line":"    local path\u003d${1:-$DEST/$OVN_REPO_NAME}"},{"line_number":185,"context_line":"    cd $path"},{"line_number":186,"context_line":"    sudo make uninstall"},{"line_number":187,"context_line":"    sudo make distclean"},{"line_number":188,"context_line":"    cd $_pwd"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_80531039","line":185,"range":{"start_line":185,"start_character":0,"end_line":185,"end_character":12},"updated":"2019-09-16 11:58:45.000000000","message":"You can do:\n\n pushd $path\n \u003cdo stuff here in the directory\u003e\n popd\n\nand you don\u0027t need to store _pwd","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85da70114f03670d2ed4c3f27edf3104d690558a","unresolved":false,"context_lines":[{"line_number":182,"context_line":"function _cleanup {"},{"line_number":183,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":184,"context_line":"    local path\u003d${1:-$DEST/$OVN_REPO_NAME}"},{"line_number":185,"context_line":"    cd $path"},{"line_number":186,"context_line":"    sudo make uninstall"},{"line_number":187,"context_line":"    sudo make distclean"},{"line_number":188,"context_line":"    cd $_pwd"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_83423aaa","line":185,"range":{"start_line":185,"start_character":0,"end_line":185,"end_character":12},"in_reply_to":"5faad753_80531039","updated":"2019-09-16 12:17:09.000000000","message":"++","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":191,"context_line":"# cleanup_ovn() - Remove residual data files, anything left over from previous"},{"line_number":192,"context_line":"# runs that a clean run would need to clean up"},{"line_number":193,"context_line":"function cleanup_ovn {"},{"line_number":194,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":195,"context_line":"    local ovn_path\u003d$DEST/$OVN_REPO_NAME"},{"line_number":196,"context_line":"    local ovs_path\u003d$DEST/$OVS_REPO_NAME"},{"line_number":197,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_201d7c73","line":194,"updated":"2019-09-16 11:58:45.000000000","message":"_pwd is unused","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85da70114f03670d2ed4c3f27edf3104d690558a","unresolved":false,"context_lines":[{"line_number":191,"context_line":"# cleanup_ovn() - Remove residual data files, anything left over from previous"},{"line_number":192,"context_line":"# runs that a clean run would need to clean up"},{"line_number":193,"context_line":"function cleanup_ovn {"},{"line_number":194,"context_line":"    local _pwd\u003d$(pwd)"},{"line_number":195,"context_line":"    local ovn_path\u003d$DEST/$OVN_REPO_NAME"},{"line_number":196,"context_line":"    local ovs_path\u003d$DEST/$OVS_REPO_NAME"},{"line_number":197,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_431a02cc","line":194,"in_reply_to":"5faad753_201d7c73","updated":"2019-09-16 12:17:09.000000000","message":"Good catch!","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    sudo mkdir -p $OVS_RUNDIR"},{"line_number":345,"context_line":"    sudo chown $(whoami) $OVS_RUNDIR"},{"line_number":346,"context_line":"    sudo mkdir -p $OVS_PREFIX/var/log/ovn"},{"line_number":347,"context_line":"    sudo chown $(whoami) $OVS_PREFIX/var/log/ovn"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    # Archive log files and create new"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_c3103251","line":346,"range":{"start_line":346,"start_character":37,"end_line":346,"end_character":41},"updated":"2019-09-16 11:58:45.000000000","message":"don\u0027t we still need openvswitch directory for compiled OVS?","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85da70114f03670d2ed4c3f27edf3104d690558a","unresolved":false,"context_lines":[{"line_number":343,"context_line":""},{"line_number":344,"context_line":"    sudo mkdir -p $OVS_RUNDIR"},{"line_number":345,"context_line":"    sudo chown $(whoami) $OVS_RUNDIR"},{"line_number":346,"context_line":"    sudo mkdir -p $OVS_PREFIX/var/log/ovn"},{"line_number":347,"context_line":"    sudo chown $(whoami) $OVS_PREFIX/var/log/ovn"},{"line_number":348,"context_line":""},{"line_number":349,"context_line":"    # Archive log files and create new"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_e381aec4","line":346,"range":{"start_line":346,"start_character":37,"end_line":346,"end_character":41},"in_reply_to":"5faad753_c3103251","updated":"2019-09-16 12:17:09.000000000","message":"That\u0027s a good point, I thought we would yeah but apparently it\u0027s working without it (the release jobs still uses the old compile_ovs method from Neutron)\n\nI will re-add it just to be on the safe side of things.","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"}],"devstack/lib/ovn":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Set variables for building OVN from source"},{"line_number":17,"context_line":"OVN_REPO\u003d${OVN_REPO:-https://github.com/ovn-org/ovn}"},{"line_number":18,"context_line":"OVN_REPO_NAME\u003d$(basename ${OVN_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":19,"context_line":"OVN_BRANCH\u003d${OVN_BRANCH:-master}"},{"line_number":20,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":6,"id":"7faddb67_db4d699a","line":17,"range":{"start_line":17,"start_character":48,"end_line":17,"end_character":51},"updated":"2019-09-16 11:58:45.000000000","message":"missing .git suffix? I noticed it trying to figure out what the cut command below does :)","commit_id":"139839e3d30a7a66c5f2fba7b70b4ee6e88b5b56"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"e7b8ac9aa0c52d1ceb1ecedabe5a8397a1a3543a","unresolved":false,"context_lines":[{"line_number":125,"context_line":"#                     ovn single machine runtime"},{"line_number":126,"context_line":"function compile_ovn {"},{"line_number":127,"context_line":"    local _pwd\u003d$PWD"},{"line_number":128,"context_line":"    local build_modules\u003d${1:-True}"},{"line_number":129,"context_line":"    local prefix\u003d$2"},{"line_number":130,"context_line":"    local localstatedir\u003d$3"},{"line_number":131,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5faad753_ae9a7b6b","line":128,"updated":"2019-09-06 00:58:55.000000000","message":"I wonder if this should still be True based on a change I proposed to master, as we were only doing it to get conntrack support, which should be present now.","commit_id":"abfea3d28258da480bdb2cd294547e8001325bf1"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"593d3f7f13cb8e7a575438fe010ad2dcbf65963f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"#                     ovn single machine runtime"},{"line_number":126,"context_line":"function compile_ovn {"},{"line_number":127,"context_line":"    local _pwd\u003d$PWD"},{"line_number":128,"context_line":"    local build_modules\u003d${1:-True}"},{"line_number":129,"context_line":"    local prefix\u003d$2"},{"line_number":130,"context_line":"    local localstatedir\u003d$3"},{"line_number":131,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":7,"id":"5faad753_17fdbb39","line":128,"in_reply_to":"5faad753_ae9a7b6b","updated":"2019-09-09 12:39:32.000000000","message":"Done","commit_id":"abfea3d28258da480bdb2cd294547e8001325bf1"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"37b172d8d091c4a0c036c4b25ff26a4785550c46","unresolved":false,"context_lines":[{"line_number":34,"context_line":"    if [ ! -d $REPO_DIR ] ; then"},{"line_number":35,"context_line":"        git_timed clone $repo $REPO_DIR"},{"line_number":36,"context_line":"        cd $REPO_DIR"},{"line_number":37,"context_line":"        git checkout $branch"},{"line_number":38,"context_line":"    else"},{"line_number":39,"context_line":"        # Even though the directory already exists, call git_clone to update it"},{"line_number":40,"context_line":"        # if needed based on the RECLONE option"}],"source_content_type":"application/x-shellscript","patch_set":9,"id":"5faad753_4b362706","line":37,"updated":"2019-09-09 15:53:15.000000000","message":"I thought git_clone took care of all this, but I might be mis-understanding that code.","commit_id":"834f992d15cdf58a4a5b5b37f5d99cce67f15b67"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Set variables for building OVN from source"},{"line_number":17,"context_line":"OVN_REPO\u003d${OVN_REPO:-https://github.com/ovn-org/ovn}"},{"line_number":18,"context_line":"OVN_REPO_NAME\u003d$(basename ${OVN_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":19,"context_line":"OVN_BRANCH\u003d${OVN_BRANCH:-master}"},{"line_number":20,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_43d9a254","line":17,"range":{"start_line":17,"start_character":48,"end_line":17,"end_character":51},"updated":"2019-09-16 11:58:45.000000000","message":"ovn.git ? I don\u0027t know :)","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85da70114f03670d2ed4c3f27edf3104d690558a","unresolved":false,"context_lines":[{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"# Set variables for building OVN from source"},{"line_number":17,"context_line":"OVN_REPO\u003d${OVN_REPO:-https://github.com/ovn-org/ovn}"},{"line_number":18,"context_line":"OVN_REPO_NAME\u003d$(basename ${OVN_REPO} | cut -f1 -d\u0027.\u0027)"},{"line_number":19,"context_line":"OVN_BRANCH\u003d${OVN_BRANCH:-master}"},{"line_number":20,"context_line":""}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_a36f3629","line":17,"range":{"start_line":17,"start_character":48,"end_line":17,"end_character":51},"in_reply_to":"5faad753_43d9a254","updated":"2019-09-16 12:17:09.000000000","message":"¯\\_(ツ)_/¯ let\u0027s add it just to be consistent with the other links","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function use_new_ovn_repository {"},{"line_number":28,"context_line":"    # IF OVN_BRANCH is \"master\" or \u003e\u003d .12, its the new OVN repository"},{"line_number":29,"context_line":"    if [ \"$OVN_BRANCH\" \u003d\u003d \"master\" ] || [ ${OVN_BRANCH:9:12} -ge 12 ]; then"},{"line_number":30,"context_line":"        return 0"},{"line_number":31,"context_line":"    else"},{"line_number":32,"context_line":"        return 1"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_a39ad6b5","line":29,"range":{"start_line":29,"start_character":44,"end_line":29,"end_character":54},"updated":"2019-09-16 11:58:45.000000000","message":"What if we do, for testing purposes, OVN_BRANCH\u003d\u003csome_commit_hash\u003e? It would fail, no? Perhaps we should be more defensive here with something like:\n\n if [ $(echo $OVN_BRANCH | sed \u0027s/branch-\\([0-9]*\\).*/\\1/\u0027) -ge 12 ]","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"198c22cc65571026a58f437ba8923dc0b6c9fed8","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function use_new_ovn_repository {"},{"line_number":28,"context_line":"    # IF OVN_BRANCH is \"master\" or \u003e\u003d .12, its the new OVN repository"},{"line_number":29,"context_line":"    if [ \"$OVN_BRANCH\" \u003d\u003d \"master\" ] || [ ${OVN_BRANCH:9:12} -ge 12 ]; then"},{"line_number":30,"context_line":"        return 0"},{"line_number":31,"context_line":"    else"},{"line_number":32,"context_line":"        return 1"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_86fc88b5","line":29,"range":{"start_line":29,"start_character":44,"end_line":29,"end_character":54},"in_reply_to":"5faad753_4368c21b","updated":"2019-09-16 12:31:07.000000000","message":"I had to modify a bit the sed command there because it was giving me only one digit in my tests:\n\n[lucas@lucas-t460s ~]$ OVN_BRANCH\u003dbranch-2.12\n[lucas@lucas-t460s ~]$ echo $OVN_BRANCH | sed \u0027s/branch-\\([0-9]*\\).*/\\1/\u0027\n\nI\u0027ve changed it to:\n\n[lucas@lucas-t460s ~]$ echo $OVN_BRANCH | sed -e \u0027s/^branch-\\([0-9]*\\)\\.//\u0027\n12","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"9ad88f53c7144d53aa9ca11d3bca6e9199848108","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function use_new_ovn_repository {"},{"line_number":28,"context_line":"    # IF OVN_BRANCH is \"master\" or \u003e\u003d .12, its the new OVN repository"},{"line_number":29,"context_line":"    if [ \"$OVN_BRANCH\" \u003d\u003d \"master\" ] || [ ${OVN_BRANCH:9:12} -ge 12 ]; then"},{"line_number":30,"context_line":"        return 0"},{"line_number":31,"context_line":"    else"},{"line_number":32,"context_line":"        return 1"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_e6a9bc8f","line":29,"range":{"start_line":29,"start_character":44,"end_line":29,"end_character":54},"in_reply_to":"5faad753_86fc88b5","updated":"2019-09-16 12:35:03.000000000","message":"Yeah, sorry. I didn\u0027t test it :) I just wrote it as a wild guess. I\u0027m thinking if we can come up with something even smarter to be able to parse tags like v12.1 and such.","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85da70114f03670d2ed4c3f27edf3104d690558a","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"function use_new_ovn_repository {"},{"line_number":28,"context_line":"    # IF OVN_BRANCH is \"master\" or \u003e\u003d .12, its the new OVN repository"},{"line_number":29,"context_line":"    if [ \"$OVN_BRANCH\" \u003d\u003d \"master\" ] || [ ${OVN_BRANCH:9:12} -ge 12 ]; then"},{"line_number":30,"context_line":"        return 0"},{"line_number":31,"context_line":"    else"},{"line_number":32,"context_line":"        return 1"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_4368c21b","line":29,"range":{"start_line":29,"start_character":44,"end_line":29,"end_character":54},"in_reply_to":"5faad753_a39ad6b5","updated":"2019-09-16 12:17:09.000000000","message":"Good point, yeah in this case I was just checking if the branch was \u003e\u003d.12","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    if [ ! -d $REPO_DIR ] ; then"},{"line_number":45,"context_line":"        git_timed clone $repo $REPO_DIR"},{"line_number":46,"context_line":"        cd $REPO_DIR"},{"line_number":47,"context_line":"        git checkout $branch"},{"line_number":48,"context_line":"    else"},{"line_number":49,"context_line":"        # Even though the directory already exists, call git_clone to update it"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_03596a33","line":46,"updated":"2019-09-16 11:58:45.000000000","message":"it sounds like an unwanted side-effect. I would expect clone_repository to behave like \"git-clone\" command. That way, you won\u0027t need to remember the cwd before calling clone_repository in networking-ovn file.","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85da70114f03670d2ed4c3f27edf3104d690558a","unresolved":false,"context_lines":[{"line_number":43,"context_line":""},{"line_number":44,"context_line":"    if [ ! -d $REPO_DIR ] ; then"},{"line_number":45,"context_line":"        git_timed clone $repo $REPO_DIR"},{"line_number":46,"context_line":"        cd $REPO_DIR"},{"line_number":47,"context_line":"        git checkout $branch"},{"line_number":48,"context_line":"    else"},{"line_number":49,"context_line":"        # Even though the directory already exists, call git_clone to update it"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_035e4a75","line":46,"in_reply_to":"5faad753_03596a33","updated":"2019-09-16 12:17:09.000000000","message":"Yeah perhaps it\u0027s not the best way","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# and install packages needed for the compilation."},{"line_number":58,"context_line":"function _prepare_for_ovs_compilation {"},{"line_number":59,"context_line":"    local build_modules\u003d$1"},{"line_number":60,"context_line":"    clone_repository $OVS_REPO $OVS_BRANCH"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    if [[ \"$build_modules\" \u003d\u003d \"False\" ]]; then"},{"line_number":63,"context_line":"        return"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_83ea3ad5","line":60,"updated":"2019-09-16 11:58:45.000000000","message":"Without the \"cd repo\" inside of clone_repository function, you would do just \n\n cd $OVS_REPO_NAME\n\nhere","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85da70114f03670d2ed4c3f27edf3104d690558a","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# and install packages needed for the compilation."},{"line_number":58,"context_line":"function _prepare_for_ovs_compilation {"},{"line_number":59,"context_line":"    local build_modules\u003d$1"},{"line_number":60,"context_line":"    clone_repository $OVS_REPO $OVS_BRANCH"},{"line_number":61,"context_line":""},{"line_number":62,"context_line":"    if [[ \"$build_modules\" \u003d\u003d \"False\" ]]; then"},{"line_number":63,"context_line":"        return"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_e35a0e81","line":60,"in_reply_to":"5faad753_83ea3ad5","updated":"2019-09-16 12:17:09.000000000","message":"++","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":141,"context_line":"#                   - third optional parameter defines localstatedir for"},{"line_number":142,"context_line":"#                     ovn single machine runtime"},{"line_number":143,"context_line":"function compile_ovn {"},{"line_number":144,"context_line":"    local _pwd\u003d$PWD"},{"line_number":145,"context_line":"    local build_modules\u003d${1:-False}"},{"line_number":146,"context_line":"    local prefix\u003d$2"},{"line_number":147,"context_line":"    local localstatedir\u003d$3"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_c3cef258","line":144,"updated":"2019-09-16 11:58:45.000000000","message":"remove","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85da70114f03670d2ed4c3f27edf3104d690558a","unresolved":false,"context_lines":[{"line_number":141,"context_line":"#                   - third optional parameter defines localstatedir for"},{"line_number":142,"context_line":"#                     ovn single machine runtime"},{"line_number":143,"context_line":"function compile_ovn {"},{"line_number":144,"context_line":"    local _pwd\u003d$PWD"},{"line_number":145,"context_line":"    local build_modules\u003d${1:-False}"},{"line_number":146,"context_line":"    local prefix\u003d$2"},{"line_number":147,"context_line":"    local localstatedir\u003d$3"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_8349dab7","line":144,"in_reply_to":"5faad753_c3cef258","updated":"2019-09-16 12:17:09.000000000","message":"Done","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    fi"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    clone_repository $OVN_REPO $OVN_BRANCH"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    if [ ! -f configure ] ; then"},{"line_number":166,"context_line":"        ./boot.sh"},{"line_number":167,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_a3d3b603","line":164,"updated":"2019-09-16 11:58:45.000000000","message":"pushd $OVN_REPO_NAME","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85da70114f03670d2ed4c3f27edf3104d690558a","unresolved":false,"context_lines":[{"line_number":161,"context_line":"    fi"},{"line_number":162,"context_line":""},{"line_number":163,"context_line":"    clone_repository $OVN_REPO $OVN_BRANCH"},{"line_number":164,"context_line":""},{"line_number":165,"context_line":"    if [ ! -f configure ] ; then"},{"line_number":166,"context_line":"        ./boot.sh"},{"line_number":167,"context_line":"    fi"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_e3cf6e26","line":164,"in_reply_to":"5faad753_a3d3b603","updated":"2019-09-16 12:17:09.000000000","message":"Done","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"bce90e78cd473778dd7ed70eea5a3a60634ee004","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    make -j$[$(nproc) + 1]"},{"line_number":173,"context_line":"    sudo make install"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    cd $_pwd"},{"line_number":176,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_23090695","line":175,"updated":"2019-09-16 11:58:45.000000000","message":"remove","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"85da70114f03670d2ed4c3f27edf3104d690558a","unresolved":false,"context_lines":[{"line_number":172,"context_line":"    make -j$[$(nproc) + 1]"},{"line_number":173,"context_line":"    sudo make install"},{"line_number":174,"context_line":""},{"line_number":175,"context_line":"    cd $_pwd"},{"line_number":176,"context_line":"}"}],"source_content_type":"application/x-shellscript","patch_set":15,"id":"5faad753_43cd222f","line":175,"in_reply_to":"5faad753_23090695","updated":"2019-09-16 12:17:09.000000000","message":"Done","commit_id":"6fc452b943d1309677ef5ef00a2cc1ac99000664"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"3e93605e12ab2ed4eeea672370e3a6e9bbd9822c","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    # IF OVN_BRANCH is \"master\" or branch-2.12 (or higher), use the new"},{"line_number":29,"context_line":"    # OVN repository"},{"line_number":30,"context_line":"    if [ \"$OVN_BRANCH\" \u003d\u003d \"master\" ] || \\"},{"line_number":31,"context_line":"       [ $(echo $OVN_BRANCH | sed -e \u0027s/^branch-\\([0-9]*\\)\\.//\u0027) -ge 12 ]; then"},{"line_number":32,"context_line":"        return 0"},{"line_number":33,"context_line":"    else"},{"line_number":34,"context_line":"        return 1"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"5faad753_c6c92059","line":31,"range":{"start_line":31,"start_character":48,"end_line":31,"end_character":50},"updated":"2019-09-16 12:41:53.000000000","message":"You don\u0027t need the brackets now","commit_id":"0337b2e582fa96c8937794bc5a72ec744e979ad1"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4e05e784c2deaf9b0ab3466e600d1093e673cbb8","unresolved":false,"context_lines":[{"line_number":28,"context_line":"    # IF OVN_BRANCH is \"master\" or branch-2.12 (or higher), use the new"},{"line_number":29,"context_line":"    # OVN repository"},{"line_number":30,"context_line":"    if [ \"$OVN_BRANCH\" \u003d\u003d \"master\" ] || \\"},{"line_number":31,"context_line":"       [ $(echo $OVN_BRANCH | sed -e \u0027s/^branch-\\([0-9]*\\)\\.//\u0027) -ge 12 ]; then"},{"line_number":32,"context_line":"        return 0"},{"line_number":33,"context_line":"    else"},{"line_number":34,"context_line":"        return 1"}],"source_content_type":"application/x-shellscript","patch_set":16,"id":"3fa7e38b_cd2341be","line":31,"range":{"start_line":31,"start_character":48,"end_line":31,"end_character":50},"in_reply_to":"5faad753_c6c92059","updated":"2019-09-16 16:46:34.000000000","message":"Ops... if I happen to submit a new patch-set I will remove it.","commit_id":"0337b2e582fa96c8937794bc5a72ec744e979ad1"}],"networking_ovn/tests/contrib/gate_hook.sh":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"4bbb2df84533d0de052db4e5bb9ff803e8c6aebe","unresolved":false,"context_lines":[{"line_number":36,"context_line":"    remove_ovs_packages"},{"line_number":37,"context_line":"    # compile_ovs expects \"DEST\" to be defined"},{"line_number":38,"context_line":"    DEST\u003d$GATE_DEST"},{"line_number":39,"context_line":"    compile_ovn False /usr/local /var"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"    # Make the workspace owned by GATE_STACK_USER"},{"line_number":42,"context_line":"    sudo chown -R $GATE_STACK_USER:$GATE_STACK_USER $BASE"}],"source_content_type":"text/x-sh","patch_set":4,"id":"7faddb67_63b3ce4e","line":39,"updated":"2019-07-29 13:19:50.000000000","message":"Apparently I will need to split the OVN related functions into a separated module (like we have in devstack/lib/ovs in Neutron) to make it work here.","commit_id":"e20ae3ca2e69692fd2f879be330496d10b03344c"}]}