)]}'
{"networking_ovn/ml2/mech_driver.py":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2d6f663f5861991cc93e71dcfb577885cabfc35","unresolved":false,"context_lines":[{"line_number":576,"context_line":"        # vif-interface-plugged event. This workaround is needed to"},{"line_number":577,"context_line":"        # perform live-migration with live_migration_wait_for_vif_plug\u003dTrue."},{"line_number":578,"context_line":"        if (port[\u0027status\u0027] \u003d\u003d const.PORT_STATUS_DOWN and"},{"line_number":579,"context_line":"            \u0027migrating_to\u0027 in port[portbindings.PROFILE].keys() and"},{"line_number":580,"context_line":"            port[portbindings.VIF_TYPE] \u003d\u003d portbindings.VIF_TYPE_OVS):"},{"line_number":581,"context_line":"            admin_context \u003d n_context.get_admin_context()"},{"line_number":582,"context_line":"            db_port \u003d ml2_db.get_port(admin_context, port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_8e47ea4c","line":579,"range":{"start_line":579,"start_character":13,"end_line":579,"end_character":25},"updated":"2019-07-31 12:34:50.000000000","message":"Not sure if there\u0027s a constant in Neutron for that but would be good to have one (either reuse theirs, if exist or create one in networking-ovn)","commit_id":"e87b5f6c149a4f57747f04007c5cfdf50596c827"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"bff1b88ca21f93e33a2d8818bfa6eb2d4f8fe211","unresolved":false,"context_lines":[{"line_number":576,"context_line":"        # vif-interface-plugged event. This workaround is needed to"},{"line_number":577,"context_line":"        # perform live-migration with live_migration_wait_for_vif_plug\u003dTrue."},{"line_number":578,"context_line":"        if (port[\u0027status\u0027] \u003d\u003d const.PORT_STATUS_DOWN and"},{"line_number":579,"context_line":"            \u0027migrating_to\u0027 in port[portbindings.PROFILE].keys() and"},{"line_number":580,"context_line":"            port[portbindings.VIF_TYPE] \u003d\u003d portbindings.VIF_TYPE_OVS):"},{"line_number":581,"context_line":"            admin_context \u003d n_context.get_admin_context()"},{"line_number":582,"context_line":"            db_port \u003d ml2_db.get_port(admin_context, port[\u0027id\u0027])"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_2ee916b6","line":579,"range":{"start_line":579,"start_character":13,"end_line":579,"end_character":25},"in_reply_to":"7faddb67_8e47ea4c","updated":"2019-07-31 14:14:59.000000000","message":"I\u0027m was trying to find this, and base on codesearch it exists in nova (since nova sets it), so I\u0027m adding this to networking-ovn constants.","commit_id":"e87b5f6c149a4f57747f04007c5cfdf50596c827"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"e2d6f663f5861991cc93e71dcfb577885cabfc35","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            admin_context \u003d n_context.get_admin_context()"},{"line_number":582,"context_line":"            db_port \u003d ml2_db.get_port(admin_context, port[\u0027id\u0027])"},{"line_number":583,"context_line":"            if db_port:"},{"line_number":584,"context_line":"                LOG.warning(\"Setting port %s status from DOWN to UP in order \""},{"line_number":585,"context_line":"                            \"to init vif-interface-plugged event.\","},{"line_number":586,"context_line":"                            port[\u0027id\u0027])"},{"line_number":587,"context_line":"                self._plugin.update_port_status(admin_context, port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_2e591634","line":584,"range":{"start_line":584,"start_character":20,"end_line":584,"end_character":27},"updated":"2019-07-31 12:34:50.000000000","message":"maybe it should be an INFO ? Since that\u0027s what we expect to happen right ?","commit_id":"e87b5f6c149a4f57747f04007c5cfdf50596c827"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"bff1b88ca21f93e33a2d8818bfa6eb2d4f8fe211","unresolved":false,"context_lines":[{"line_number":581,"context_line":"            admin_context \u003d n_context.get_admin_context()"},{"line_number":582,"context_line":"            db_port \u003d ml2_db.get_port(admin_context, port[\u0027id\u0027])"},{"line_number":583,"context_line":"            if db_port:"},{"line_number":584,"context_line":"                LOG.warning(\"Setting port %s status from DOWN to UP in order \""},{"line_number":585,"context_line":"                            \"to init vif-interface-plugged event.\","},{"line_number":586,"context_line":"                            port[\u0027id\u0027])"},{"line_number":587,"context_line":"                self._plugin.update_port_status(admin_context, port[\u0027id\u0027],"}],"source_content_type":"text/x-python","patch_set":1,"id":"7faddb67_eece9e58","line":584,"range":{"start_line":584,"start_character":20,"end_line":584,"end_character":27},"in_reply_to":"7faddb67_2e591634","updated":"2019-07-31 14:14:59.000000000","message":"yes, sure :) Its warning only for visibility, for now","commit_id":"e87b5f6c149a4f57747f04007c5cfdf50596c827"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"699b598ef74af0e1c2552bfea3e4e4ce8b09f342","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # perform live-migration with live_migration_wait_for_vif_plug\u003dTrue."},{"line_number":578,"context_line":"        if ((port[\u0027status\u0027] \u003d\u003d const.PORT_STATUS_DOWN and"},{"line_number":579,"context_line":"             ovn_const.MIGRATING_ATTR in port[portbindings.PROFILE].keys() and"},{"line_number":580,"context_line":"             port[portbindings.VIF_TYPE] \u003d\u003d portbindings.VIF_TYPE_OVS)):"},{"line_number":581,"context_line":"            admin_context \u003d n_context.get_admin_context()"},{"line_number":582,"context_line":"            LOG.info(\"Setting port %s status from DOWN to UP in order \""},{"line_number":583,"context_line":"                     \"to emit vif-interface-plugged event.\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_bff9b2c8","line":580,"updated":"2019-07-31 15:17:17.000000000","message":"nit: extra () here","commit_id":"80e64f67d563b26279870741ab63d12d15a4fc86"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"b50fba9409a372ae2cb39271bcbee77e8a604c69","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # perform live-migration with live_migration_wait_for_vif_plug\u003dTrue."},{"line_number":578,"context_line":"        if ((port[\u0027status\u0027] \u003d\u003d const.PORT_STATUS_DOWN and"},{"line_number":579,"context_line":"             ovn_const.MIGRATING_ATTR in port[portbindings.PROFILE].keys() and"},{"line_number":580,"context_line":"             port[portbindings.VIF_TYPE] \u003d\u003d portbindings.VIF_TYPE_OVS)):"},{"line_number":581,"context_line":"            admin_context \u003d n_context.get_admin_context()"},{"line_number":582,"context_line":"            LOG.info(\"Setting port %s status from DOWN to UP in order \""},{"line_number":583,"context_line":"                     \"to emit vif-interface-plugged event.\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_b430ec57","line":580,"in_reply_to":"7faddb67_70d7e7ef","updated":"2019-08-01 01:25:20.000000000","message":"Right, the other is to increase indent of these 4 spaces, whatever makes pep8 happy.","commit_id":"80e64f67d563b26279870741ab63d12d15a4fc86"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"0119ee3aeee8ed67e14226a664e041cceb8f4f37","unresolved":false,"context_lines":[{"line_number":577,"context_line":"        # perform live-migration with live_migration_wait_for_vif_plug\u003dTrue."},{"line_number":578,"context_line":"        if ((port[\u0027status\u0027] \u003d\u003d const.PORT_STATUS_DOWN and"},{"line_number":579,"context_line":"             ovn_const.MIGRATING_ATTR in port[portbindings.PROFILE].keys() and"},{"line_number":580,"context_line":"             port[portbindings.VIF_TYPE] \u003d\u003d portbindings.VIF_TYPE_OVS)):"},{"line_number":581,"context_line":"            admin_context \u003d n_context.get_admin_context()"},{"line_number":582,"context_line":"            LOG.info(\"Setting port %s status from DOWN to UP in order \""},{"line_number":583,"context_line":"                     \"to emit vif-interface-plugged event.\","}],"source_content_type":"text/x-python","patch_set":3,"id":"7faddb67_70d7e7ef","line":580,"in_reply_to":"7faddb67_bff9b2c8","updated":"2019-07-31 17:37:36.000000000","message":"Without it pep8 fails on:\nE129 visually indented line with same indent as next logical line\n\nOne solution is to add double ().","commit_id":"80e64f67d563b26279870741ab63d12d15a4fc86"}]}