)]}'
{"networking_ovn/common/maintenance.py":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"d90647850436935584fb42f2104f137dc0d39e8a","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                elif type_ and ovn_const.UNKNOWN_ADDR in addresses:"},{"line_number":426,"context_line":"                    addresses.remove(ovn_const.UNKNOWN_ADDR)"},{"line_number":427,"context_line":"            else:"},{"line_number":428,"context_line":"                if type_ and ovn_const.UNKNOWN_ADDR in addresses:"},{"line_number":429,"context_line":"                    addresses.remove(ovn_const.UNKNOWN_ADDR)"},{"line_number":430,"context_line":"                elif not type_ and ovn_const.UNKNOWN_ADDR in addresses:"},{"line_number":431,"context_line":"                    addresses.remove(ovn_const.UNKNOWN_ADDR)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"            self._nb_idl.lsp_set_addresses("},{"line_number":434,"context_line":"                port.name, addresses\u003daddresses).execute(check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_bdb0f0fe","line":431,"range":{"start_line":428,"start_character":0,"end_line":431,"end_character":60},"updated":"2019-08-30 08:37:48.000000000","message":"I know this patch is merged but I\u0027m looking at it just out of curiosity to learn new things - I don\u0027t understand this piece of code, can\u0027t you do just:\n\n if ovn_const.UNKNOWN_ADDR in addresses:\n     addresses.remove() \n\n?","commit_id":"6a89dbfe47ae1f384e08fede3bb6afae2ada7b9c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f63c80a5c64143208d7169fceb8c2cf56b1d1afb","unresolved":false,"context_lines":[{"line_number":425,"context_line":"                elif type_ and ovn_const.UNKNOWN_ADDR in addresses:"},{"line_number":426,"context_line":"                    addresses.remove(ovn_const.UNKNOWN_ADDR)"},{"line_number":427,"context_line":"            else:"},{"line_number":428,"context_line":"                if type_ and ovn_const.UNKNOWN_ADDR in addresses:"},{"line_number":429,"context_line":"                    addresses.remove(ovn_const.UNKNOWN_ADDR)"},{"line_number":430,"context_line":"                elif not type_ and ovn_const.UNKNOWN_ADDR in addresses:"},{"line_number":431,"context_line":"                    addresses.remove(ovn_const.UNKNOWN_ADDR)"},{"line_number":432,"context_line":""},{"line_number":433,"context_line":"            self._nb_idl.lsp_set_addresses("},{"line_number":434,"context_line":"                port.name, addresses\u003daddresses).execute(check_error\u003dTrue)"}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_4cb3484f","line":431,"range":{"start_line":428,"start_character":0,"end_line":431,"end_character":60},"in_reply_to":"7faddb67_bdb0f0fe","updated":"2019-08-30 13:16:50.000000000","message":"Ops indeed, that would be better! My bad here","commit_id":"6a89dbfe47ae1f384e08fede3bb6afae2ada7b9c"}],"networking_ovn/common/ovn_client.py":[{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"6f8f1e02519da72114206eb74d3f88b2a275a21b","unresolved":false,"context_lines":[{"line_number":235,"context_line":""},{"line_number":236,"context_line":"            # The \"unknown\" address should only be set for the normal LSP"},{"line_number":237,"context_line":"            # ports (the ones which type is empty)"},{"line_number":238,"context_line":"            if not port_security and not port_type:"},{"line_number":239,"context_line":"                # Port security is disabled for this port."},{"line_number":240,"context_line":"                # So this port can send traffic with any mac address."},{"line_number":241,"context_line":"                # OVN allows any mac address from a port if \"unknown\""}],"source_content_type":"text/x-python","patch_set":2,"id":"7faddb67_01da524a","line":238,"range":{"start_line":238,"start_character":37,"end_line":238,"end_character":50},"updated":"2019-08-26 08:51:27.000000000","message":"At first I thought it was more clear if we would exclude explicitly \"localnet\", \"localport\" and \"router\" types.\n\nOn the other hand, when core OVN adds new types of ports (virtual, external, ...) we\u0027ll need to add those to this list so it\u0027s best to keep it like this assuming that an empty port type is a regular logical switch port.","commit_id":"6a89dbfe47ae1f384e08fede3bb6afae2ada7b9c"}]}