)]}'
{"networking_ovn/octavia/ovn_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea183f9e1f74a33b8227590556e75d4b3a5c8e7a","unresolved":false,"context_lines":[{"line_number":1705,"context_line":"    # Member"},{"line_number":1706,"context_line":"    def _check_monitor_options(self, member):"},{"line_number":1707,"context_line":"        if ((isinstance(member.monitor_address, o_datamodels.UnsetType) and"},{"line_number":1708,"context_line":"             isinstance(member.monitor_port, o_datamodels.UnsetType))):"},{"line_number":1709,"context_line":"            return False"},{"line_number":1710,"context_line":"        if (member.monitor_address or member.monitor_port):"},{"line_number":1711,"context_line":"            return True"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_86688dba","line":1708,"updated":"2019-10-04 15:51:25.000000000","message":"nit: extra parens here","commit_id":"39e10bd09d883c48254e4477d5f1530b82c0fcf6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea183f9e1f74a33b8227590556e75d4b3a5c8e7a","unresolved":false,"context_lines":[{"line_number":1707,"context_line":"        if ((isinstance(member.monitor_address, o_datamodels.UnsetType) and"},{"line_number":1708,"context_line":"             isinstance(member.monitor_port, o_datamodels.UnsetType))):"},{"line_number":1709,"context_line":"            return False"},{"line_number":1710,"context_line":"        if (member.monitor_address or member.monitor_port):"},{"line_number":1711,"context_line":"            return True"},{"line_number":1712,"context_line":"        return False"},{"line_number":1713,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_a66589e3","line":1710,"updated":"2019-10-04 15:51:25.000000000","message":"and here","commit_id":"39e10bd09d883c48254e4477d5f1530b82c0fcf6"}],"networking_ovn/tests/unit/octavia/test_ovn_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea183f9e1f74a33b8227590556e75d4b3a5c8e7a","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        self.mock_add_request.assert_called_once_with(expected_dict)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def test_pool_create_http(self):"},{"line_number":521,"context_line":"        self.ref_pool.protocol \u003d \u0027HTTP\u0027"},{"line_number":522,"context_line":"        self.assertRaises(exceptions.UnsupportedOptionError,"},{"line_number":523,"context_line":"                          self.driver.pool_create, self.ref_pool)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_86e5ed0c","line":521,"updated":"2019-10-04 15:51:25.000000000","message":"s/constants.PROTOCOL_HTTP","commit_id":"39e10bd09d883c48254e4477d5f1530b82c0fcf6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"97f4c42ee1ca1a028d4981b5cd103190b779ee75","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        self.mock_add_request.assert_called_once_with(expected_dict)"},{"line_number":519,"context_line":""},{"line_number":520,"context_line":"    def test_pool_create_http(self):"},{"line_number":521,"context_line":"        self.ref_pool.protocol \u003d \u0027HTTP\u0027"},{"line_number":522,"context_line":"        self.assertRaises(exceptions.UnsupportedOptionError,"},{"line_number":523,"context_line":"                          self.driver.pool_create, self.ref_pool)"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_8e8c5c36","line":521,"in_reply_to":"3fa7e38b_86e5ed0c","updated":"2019-10-17 21:00:16.000000000","message":"Looks like \u0027HTTP\u0027 is used throughout, so don\u0027t have to fix this here.  Same with below.","commit_id":"39e10bd09d883c48254e4477d5f1530b82c0fcf6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea183f9e1f74a33b8227590556e75d4b3a5c8e7a","unresolved":false,"context_lines":[{"line_number":744,"context_line":"                ovn_driver.LB_EXT_IDS_VIP_PORT_ID_KEY: mock.ANY,"},{"line_number":745,"context_line":"                \u0027enabled\u0027: \u0027False\u0027},"},{"line_number":746,"context_line":"            name\u003dmock.ANY,"},{"line_number":747,"context_line":"            protocol\u003d\u0027tcp\u0027)"},{"line_number":748,"context_line":""},{"line_number":749,"context_line":"    @mock.patch(\u0027networking_ovn.octavia.ovn_driver.get_network_driver\u0027)"},{"line_number":750,"context_line":"    def test_lb_create_enabled(self, net_dr):"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_c6820501","line":747,"range":{"start_line":747,"start_character":21,"end_line":747,"end_character":26},"updated":"2019-10-04 15:51:25.000000000","message":"s/constants.PROTOCOL_TCP","commit_id":"39e10bd09d883c48254e4477d5f1530b82c0fcf6"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"ea183f9e1f74a33b8227590556e75d4b3a5c8e7a","unresolved":false,"context_lines":[{"line_number":762,"context_line":"                ovn_driver.LB_EXT_IDS_VIP_PORT_ID_KEY: mock.ANY,"},{"line_number":763,"context_line":"                \u0027enabled\u0027: \u0027True\u0027},"},{"line_number":764,"context_line":"            name\u003dmock.ANY,"},{"line_number":765,"context_line":"            protocol\u003d\u0027tcp\u0027)"},{"line_number":766,"context_line":""},{"line_number":767,"context_line":"    @mock.patch(\u0027networking_ovn.octavia.ovn_driver.get_network_driver\u0027)"},{"line_number":768,"context_line":"    @mock.patch.object(ovn_driver.OvnProviderHelper, \u0027delete_vip_port\u0027)"}],"source_content_type":"text/x-python","patch_set":16,"id":"3fa7e38b_e687010f","line":765,"range":{"start_line":765,"start_character":21,"end_line":765,"end_character":26},"updated":"2019-10-04 15:51:25.000000000","message":"s/constants.PROTOCOL_TCP","commit_id":"39e10bd09d883c48254e4477d5f1530b82c0fcf6"}]}