)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b5d298323a00acc257812b828dce847b6e9a60eb","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Only notify nova of port status changes if configured"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although notify_nova_on_port_status_changes defaults to true, it"},{"line_number":10,"context_line":"could be to false, making the nova_notifier attribute unsafe to"},{"line_number":11,"context_line":"use without checking. In fact, networking-ovn functional tests"},{"line_number":12,"context_line":"inherit from the neutron base *unit* test which disables this"},{"line_number":13,"context_line":"option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_244a3280","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":11},"updated":"2019-09-16 15:05:26.000000000","message":"I\u0027m just wondering as a non-native speaker and forever English learner, if this is correct or verb like \"set\" is missing between the words :)","commit_id":"5f47f0ed977be6a4ca5a16de1b87f55ae203f40a"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"5e08158ff01a316a1919899fcaabf0d14c9034ea","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Only notify nova of port status changes if configured"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Although notify_nova_on_port_status_changes defaults to true, it"},{"line_number":10,"context_line":"could be to false, making the nova_notifier attribute unsafe to"},{"line_number":11,"context_line":"use without checking. In fact, networking-ovn functional tests"},{"line_number":12,"context_line":"inherit from the neutron base *unit* test which disables this"},{"line_number":13,"context_line":"option."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_c73a40cc","line":10,"range":{"start_line":10,"start_character":6,"end_line":10,"end_character":11},"in_reply_to":"3fa7e38b_244a3280","updated":"2019-09-16 15:11:16.000000000","message":"there is a missing \u0027set\u0027. I am a forever learning English typist.","commit_id":"5f47f0ed977be6a4ca5a16de1b87f55ae203f40a"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"7c3b6a4a414e91468582d982efd50e42e111b7f6","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Although notify_nova_on_port_status_changes defaults to true, it"},{"line_number":10,"context_line":"could be to false, making the nova_notifier attribute unsafe to"},{"line_number":11,"context_line":"use without checking. In fact, networking-ovn functional tests"},{"line_number":12,"context_line":"inherit from the neutron base *unit* test which disables this"},{"line_number":13,"context_line":"option."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch checks both the config option and that the attribute"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5faad753_7699796c","line":12,"range":{"start_line":12,"start_character":30,"end_line":12,"end_character":36},"updated":"2019-09-10 11:33:50.000000000","message":"that\u0027s funny","commit_id":"5f47f0ed977be6a4ca5a16de1b87f55ae203f40a"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"cae0fca5c7e0ca0d6e3ae4bb5ad23f60fbb7cc0e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Although notify_nova_on_port_status_changes defaults to true, it"},{"line_number":10,"context_line":"could be to false, making the nova_notifier attribute unsafe to"},{"line_number":11,"context_line":"use without checking. In fact, networking-ovn functional tests"},{"line_number":12,"context_line":"inherit from the neutron base *unit* test which disables this"},{"line_number":13,"context_line":"option."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch checks both the config option and that the attribute"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_876208d8","line":12,"range":{"start_line":12,"start_character":30,"end_line":12,"end_character":36},"in_reply_to":"5faad753_763bb9ea","updated":"2019-09-16 15:08:17.000000000","message":"/me *cries*","commit_id":"5f47f0ed977be6a4ca5a16de1b87f55ae203f40a"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"2fe9497602aa53c69f58312b4e64e7f871909b8e","unresolved":false,"context_lines":[{"line_number":9,"context_line":"Although notify_nova_on_port_status_changes defaults to true, it"},{"line_number":10,"context_line":"could be to false, making the nova_notifier attribute unsafe to"},{"line_number":11,"context_line":"use without checking. In fact, networking-ovn functional tests"},{"line_number":12,"context_line":"inherit from the neutron base *unit* test which disables this"},{"line_number":13,"context_line":"option."},{"line_number":14,"context_line":""},{"line_number":15,"context_line":"This patch checks both the config option and that the attribute"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"5faad753_763bb9ea","line":12,"range":{"start_line":12,"start_character":30,"end_line":12,"end_character":36},"in_reply_to":"5faad753_7699796c","updated":"2019-09-10 11:58:48.000000000","message":"It was...surprising. ;)","commit_id":"5f47f0ed977be6a4ca5a16de1b87f55ae203f40a"},{"author":{"_account_id":8655,"name":"Jakub Libosvar","email":"libosvar@redhat.com","username":"jlibosva"},"change_message_id":"b5d298323a00acc257812b828dce847b6e9a60eb","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This patch checks both the config option and that the attribute"},{"line_number":16,"context_line":"exists, since the config could be changed after the plugin is"},{"line_number":17,"context_line":"already initialized without the nova_notifier attribute being set."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia89283c1f6569340a891b40c92405941cbda5800"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_e4097a31","line":18,"updated":"2019-09-16 15:05:26.000000000","message":"Is there any bug that describes the problem (also would be helpful if we want to backport the patch). I kinda miss what it tries to solve :)","commit_id":"5f47f0ed977be6a4ca5a16de1b87f55ae203f40a"},{"author":{"_account_id":23804,"name":"Daniel Alvarez","email":"dalvarez@redhat.com","username":"dalvarez"},"change_message_id":"623f4fe75203934465c3c6ae3117d9800a16654e","unresolved":false,"context_lines":[{"line_number":15,"context_line":"This patch checks both the config option and that the attribute"},{"line_number":16,"context_line":"exists, since the config could be changed after the plugin is"},{"line_number":17,"context_line":"already initialized without the nova_notifier attribute being set."},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"Change-Id: Ia89283c1f6569340a891b40c92405941cbda5800"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":5,"id":"3fa7e38b_a78dc47c","line":18,"in_reply_to":"3fa7e38b_e4097a31","updated":"2019-09-16 15:09:29.000000000","message":"I agree with this :) Although I understood after your IRC explanation I think it\u0027d help others if we have a bit deeper description of the problem that it\u0027s trying to solve.\nI got confused at first thinking that we\u0027re fixing production code to accommodate tests but code\u0027s broken also when this setting is set to False.","commit_id":"5f47f0ed977be6a4ca5a16de1b87f55ae203f40a"}],"networking_ovn/ml2/mech_driver.py":[{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"6f522f4a4538e6d306f2605620e83a507bacee93","unresolved":false,"context_lines":[{"line_number":801,"context_line":"    def _should_notify_nova(self, db_port):"},{"line_number":802,"context_line":"        # NOTE(twilson) It is possible for a test to override a config option"},{"line_number":803,"context_line":"        # after the plugin has been initialized so the nova_notifier attribute"},{"line_number":804,"context_line":"        # is not set on the plugin)"},{"line_number":805,"context_line":"        return (cfg.CONF.notify_nova_on_port_status_changes and"},{"line_number":806,"context_line":"                hasattr(self._plugin.nova_notifier) and"},{"line_number":807,"context_line":"                db_port.device_owner.startswith("}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_d785e2ae","line":804,"range":{"start_line":804,"start_character":34,"end_line":804,"end_character":35},"updated":"2019-09-09 13:36:18.000000000","message":"nit: s/. :)\n\nThis is actually broken in the neutron code as well, I\u0027ll fix that.","commit_id":"2ce49d5ec2f4ba626dc5e546d83197cc30f1e5fb"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"c6e97df5ab4e9f3f01d202fbbd248fc46a87bbad","unresolved":false,"context_lines":[{"line_number":803,"context_line":"        # after the plugin has been initialized so the nova_notifier attribute"},{"line_number":804,"context_line":"        # is not set on the plugin)"},{"line_number":805,"context_line":"        return (cfg.CONF.notify_nova_on_port_status_changes and"},{"line_number":806,"context_line":"                hasattr(self._plugin.nova_notifier) and"},{"line_number":807,"context_line":"                db_port.device_owner.startswith("},{"line_number":808,"context_line":"                    const.DEVICE_OWNER_COMPUTE_PREFIX))"},{"line_number":809,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_1a5f1fe3","line":806,"updated":"2019-09-09 13:48:03.000000000","message":"hasattr() takes two arguments, this should be hasattr(self._plugin, \u0027nova_notifier\u0027) - found when fixing neutron.","commit_id":"2ce49d5ec2f4ba626dc5e546d83197cc30f1e5fb"},{"author":{"_account_id":5756,"name":"Terry Wilson","email":"twilson@redhat.com","username":"otherwiseguy"},"change_message_id":"3962a98fa2779cf1909c39aa95f61a2180833b55","unresolved":false,"context_lines":[{"line_number":803,"context_line":"        # after the plugin has been initialized so the nova_notifier attribute"},{"line_number":804,"context_line":"        # is not set on the plugin)"},{"line_number":805,"context_line":"        return (cfg.CONF.notify_nova_on_port_status_changes and"},{"line_number":806,"context_line":"                hasattr(self._plugin.nova_notifier) and"},{"line_number":807,"context_line":"                db_port.device_owner.startswith("},{"line_number":808,"context_line":"                    const.DEVICE_OWNER_COMPUTE_PREFIX))"},{"line_number":809,"context_line":""}],"source_content_type":"text/x-python","patch_set":2,"id":"5faad753_4f214afb","line":806,"in_reply_to":"5faad753_1a5f1fe3","updated":"2019-09-09 23:14:44.000000000","message":"oops! thanks!","commit_id":"2ce49d5ec2f4ba626dc5e546d83197cc30f1e5fb"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"5ab6cf777699bf7aacee33cd156a47eb75289921","unresolved":false,"context_lines":[{"line_number":802,"context_line":"        # NOTE(twilson) It is possible for a test to override a config option"},{"line_number":803,"context_line":"        # after the plugin has been initialized so the nova_notifier attribute"},{"line_number":804,"context_line":"        # is not set on the plugin"},{"line_number":805,"context_line":"        return (cfg.CONF.notify_nova_on_port_status_changes and"},{"line_number":806,"context_line":"                hasattr(self._plugin, \u0027nova_notifier\u0027) and"},{"line_number":807,"context_line":"                db_port.device_owner.startswith("},{"line_number":808,"context_line":"                    const.DEVICE_OWNER_COMPUTE_PREFIX))"}],"source_content_type":"text/x-python","patch_set":5,"id":"3fa7e38b_67034c0f","line":805,"range":{"start_line":805,"start_character":25,"end_line":805,"end_character":59},"updated":"2019-09-16 15:06:28.000000000","message":"Oh right, so this option goes beyond fixing just the tests right ?\n\nSomeone somewhere may be setting this to False in production and networking-ovn should account for it.\n\n(it would be better if the nova_notifier layer itself dealt with it and just returned if this option is false but...¯\\_(ツ)_/¯)","commit_id":"5f47f0ed977be6a4ca5a16de1b87f55ae203f40a"}]}