)]}'
{"devstack/devstackgaterc":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"f7964e7cd6eb6e87b68f6d829e6ddc664bf2ab5f","unresolved":false,"context_lines":[{"line_number":30,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"Q_USE_PROVIDERNET_FOR_PUBLIC\u003dTrue\""},{"line_number":31,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"PHYSICAL_NETWORK\u003dpublic\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [[ \"${OVN_OPTS}\" \u003d\u003d *\"latest-release\"* ]] ; then"},{"line_number":34,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"OVN_BRANCH\u003dbranch-2.11\""},{"line_number":35,"context_line":"else"},{"line_number":36,"context_line":"    echo \"No ovs branch specified, using the default from the devstack plugin\""},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Enable controller to host gateway routers"},{"line_number":40,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_CHASSIS_AS_GW\u003dTrue\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3fa7e38b_1f888dc4","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":2},"updated":"2019-09-17 13:04:03.000000000","message":"nit: This patch makes it defaults to 2.11 [0], maybe we can even get rid of this whole block here.\n\nOR keep the \"master\" conditional and just change the latest from 2.9 to 2.11 in case we want to re-enable master in the stable branch at some point (don\u0027t think it will happen tho)\n\n[0] in devstack/lib/networking-ovn","commit_id":"918e955388c7d9ff3bdefa77f51b004b11a72400"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"d5546f837d695ecde7b40b7920bd1acbdc12fbee","unresolved":false,"context_lines":[{"line_number":30,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"Q_USE_PROVIDERNET_FOR_PUBLIC\u003dTrue\""},{"line_number":31,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"PHYSICAL_NETWORK\u003dpublic\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [[ \"${OVN_OPTS}\" \u003d\u003d *\"latest-release\"* ]] ; then"},{"line_number":34,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"OVN_BRANCH\u003dbranch-2.11\""},{"line_number":35,"context_line":"else"},{"line_number":36,"context_line":"    echo \"No ovs branch specified, using the default from the devstack plugin\""},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Enable controller to host gateway routers"},{"line_number":40,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_CHASSIS_AS_GW\u003dTrue\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3fa7e38b_bf35b9f9","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":2},"in_reply_to":"3fa7e38b_1f888dc4","updated":"2019-09-17 13:05:21.000000000","message":"Yhm, looks like its not needed. Lets wait for the CI results and then drop this code.","commit_id":"918e955388c7d9ff3bdefa77f51b004b11a72400"},{"author":{"_account_id":1131,"name":"Brian Haley","email":"haleyb.dev@gmail.com","username":"brian-haley"},"change_message_id":"94f2433d847dee676588b2110ce18a2107592c07","unresolved":false,"context_lines":[{"line_number":30,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"Q_USE_PROVIDERNET_FOR_PUBLIC\u003dTrue\""},{"line_number":31,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"PHYSICAL_NETWORK\u003dpublic\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [[ \"${OVN_OPTS}\" \u003d\u003d *\"latest-release\"* ]] ; then"},{"line_number":34,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"OVN_BRANCH\u003dbranch-2.11\""},{"line_number":35,"context_line":"else"},{"line_number":36,"context_line":"    echo \"No ovs branch specified, using the default from the devstack plugin\""},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Enable controller to host gateway routers"},{"line_number":40,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_CHASSIS_AS_GW\u003dTrue\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3fa7e38b_f6d91322","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":2},"in_reply_to":"3fa7e38b_bf35b9f9","updated":"2019-09-17 19:27:04.000000000","message":"Were you going to update this review?","commit_id":"918e955388c7d9ff3bdefa77f51b004b11a72400"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"759d29ffb7d0d67bfdbac540783565cd22a127a6","unresolved":false,"context_lines":[{"line_number":30,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"Q_USE_PROVIDERNET_FOR_PUBLIC\u003dTrue\""},{"line_number":31,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"PHYSICAL_NETWORK\u003dpublic\""},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [[ \"${OVN_OPTS}\" \u003d\u003d *\"latest-release\"* ]] ; then"},{"line_number":34,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"OVN_BRANCH\u003dbranch-2.11\""},{"line_number":35,"context_line":"else"},{"line_number":36,"context_line":"    echo \"No ovs branch specified, using the default from the devstack plugin\""},{"line_number":37,"context_line":"fi"},{"line_number":38,"context_line":""},{"line_number":39,"context_line":"# Enable controller to host gateway routers"},{"line_number":40,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_CHASSIS_AS_GW\u003dTrue\""}],"source_content_type":"application/octet-stream","patch_set":5,"id":"3fa7e38b_2c40be35","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":2},"in_reply_to":"3fa7e38b_f6d91322","updated":"2019-09-17 20:48:39.000000000","message":"Done","commit_id":"918e955388c7d9ff3bdefa77f51b004b11a72400"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"e61263f468b2dae4e86bcb62687304bae35df43f","unresolved":false,"context_lines":[{"line_number":37,"context_line":"else"},{"line_number":38,"context_line":"    echo \"No ovs branch specified, using the default from the devstack plugin\""},{"line_number":39,"context_line":"fi"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Enable controller to host gateway routers"},{"line_number":42,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_CHASSIS_AS_GW\u003dTrue\""},{"line_number":43,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":6,"id":"3fa7e38b_77f9967e","side":"PARENT","line":40,"updated":"2019-09-18 09:09:47.000000000","message":"Nit: this change is not in stein backport\nThough this is unused code (if I got it correctly) so good to go","commit_id":"5504b1dc9addfedb5ae1703a124c485d193d4128"}]}