)]}'
{"devstack/devstackgaterc":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"d291bfea3826dab6c33491a65a97eecf22f22ddd","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [[ \"${OVN_OPTS}\" \u003d\u003d *\"latest-release\"* ]] ; then"},{"line_number":34,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"OVN_BRANCH\u003dbranch-2.11\""},{"line_number":35,"context_line":"elif [[ \"${OVN_OPTS}\" \u003d\u003d *\"master\"* ]] ; then"},{"line_number":36,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"OVN_BRANCH\u003dbranch-2.11\""},{"line_number":37,"context_line":"else"},{"line_number":38,"context_line":"    echo \"No ovs branch specified, using the default from the devstack plugin\""},{"line_number":39,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5faad753_7cea610f","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":63},"updated":"2019-09-13 14:31:36.000000000","message":"I think we should just get rid of the master job if its not going to run against the master branch. What do you think ?","commit_id":"f44cb13152cf5f1a0951350d7e7221cf0902894c"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"7e92b6eb19b4b33fe1d06f86575ed6208c057416","unresolved":false,"context_lines":[{"line_number":32,"context_line":""},{"line_number":33,"context_line":"if [[ \"${OVN_OPTS}\" \u003d\u003d *\"latest-release\"* ]] ; then"},{"line_number":34,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"OVN_BRANCH\u003dbranch-2.11\""},{"line_number":35,"context_line":"elif [[ \"${OVN_OPTS}\" \u003d\u003d *\"master\"* ]] ; then"},{"line_number":36,"context_line":"    export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"OVN_BRANCH\u003dbranch-2.11\""},{"line_number":37,"context_line":"else"},{"line_number":38,"context_line":"    echo \"No ovs branch specified, using the default from the devstack plugin\""},{"line_number":39,"context_line":"fi"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5faad753_1f61c405","line":36,"range":{"start_line":35,"start_character":0,"end_line":36,"end_character":63},"in_reply_to":"5faad753_7cea610f","updated":"2019-09-16 10:38:40.000000000","message":"You\u0027re right. Dropping it.","commit_id":"f44cb13152cf5f1a0951350d7e7221cf0902894c"},{"author":{"_account_id":21798,"name":"Bernard Cafarelli","email":"bcafarel@redhat.com","username":"bcafarel"},"change_message_id":"70f2c73423da1a019159687b052f3e9e00041372","unresolved":false,"context_lines":[{"line_number":37,"context_line":"else"},{"line_number":38,"context_line":"    echo \"No ovs branch specified, using the default from the devstack plugin\""},{"line_number":39,"context_line":"fi"},{"line_number":40,"context_line":""},{"line_number":41,"context_line":"# Enable controller to host gateway routers"},{"line_number":42,"context_line":"export DEVSTACK_LOCAL_CONFIG+\u003d$\u0027\\n\u0027\"ENABLE_CHASSIS_AS_GW\u003dTrue\""},{"line_number":43,"context_line":""}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3fa7e38b_374f9ebe","side":"PARENT","line":40,"updated":"2019-09-18 09:11:00.000000000","message":"Same nit as in queens review: this should be cleaned some day in stein (not urgent as code is not used)","commit_id":"aef1c3ef1ed640e269fbb45e067934e7cdbad697"}],"devstack/upgrade/settings":[{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"34ea9392ec73a56dab18f1ffcc046dad0a70242a","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# bug/1648176"},{"line_number":6,"context_line":"UPGRADE_PROJECTS\u003d\"networking-ovn ${UPGRADE_PROJECTS/ networking-ovn/}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"devstack_localrc base enable_plugin networking-ovn http://git.openstack.org/openstack/networking-ovn $BASE_DEVSTACK_BRANCH"},{"line_number":9,"context_line":"devstack_localrc base OVN_BRANCH\u003d\"branch-2.11\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"devstack_localrc target enable_plugin networking-ovn http://git.openstack.org/openstack/networking-ovn"},{"line_number":12,"context_line":"devstack_localrc target OVN_BRANCH\u003d\"branch-2.11\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Common options for both base and target DevStack"},{"line_number":15,"context_line":"for i in base target; do"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5faad753_1cc48d90","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":48},"updated":"2019-09-13 14:32:26.000000000","message":"this doesn\u0027t make much sense, since it\u0027s not upgrading from version X to X+1","commit_id":"f44cb13152cf5f1a0951350d7e7221cf0902894c"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"7e92b6eb19b4b33fe1d06f86575ed6208c057416","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# bug/1648176"},{"line_number":6,"context_line":"UPGRADE_PROJECTS\u003d\"networking-ovn ${UPGRADE_PROJECTS/ networking-ovn/}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"devstack_localrc base enable_plugin networking-ovn http://git.openstack.org/openstack/networking-ovn $BASE_DEVSTACK_BRANCH"},{"line_number":9,"context_line":"devstack_localrc base OVN_BRANCH\u003d\"branch-2.11\""},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"devstack_localrc target enable_plugin networking-ovn http://git.openstack.org/openstack/networking-ovn"},{"line_number":12,"context_line":"devstack_localrc target OVN_BRANCH\u003d\"branch-2.11\""},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"# Common options for both base and target DevStack"},{"line_number":15,"context_line":"for i in base target; do"}],"source_content_type":"application/octet-stream","patch_set":1,"id":"5faad753_df56cc2a","line":12,"range":{"start_line":8,"start_character":0,"end_line":12,"end_character":48},"in_reply_to":"5faad753_1cc48d90","updated":"2019-09-16 10:38:40.000000000","message":"Yes, so I\u0027m dropping this as well.","commit_id":"f44cb13152cf5f1a0951350d7e7221cf0902894c"},{"author":{"_account_id":6773,"name":"Lucas Alvares Gomes","email":"lucasagomes@gmail.com","username":"lucasagomes"},"change_message_id":"ffc46dabe8e58624e6ff6d7fcdade9b4dc41f902","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# bug/1648176"},{"line_number":6,"context_line":"UPGRADE_PROJECTS\u003d\"networking-ovn ${UPGRADE_PROJECTS/ networking-ovn/}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Common options for both base and target DevStack"},{"line_number":9,"context_line":"for i in base target; do"},{"line_number":10,"context_line":"    devstack_localrc $i enable_service q-svc ovn-northd ovn-controller networking-ovn-metadata-agent"},{"line_number":11,"context_line":"    devstack_localrc $i disable_service q-agt q-l3 q-dhcp q-meta n-net"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3fa7e38b_ef64cebb","line":8,"updated":"2019-09-18 11:51:10.000000000","message":"I doesn\u0027t really make much sense to remove those lines from the grenade job, I mean, without those it will always fail (perhaps disabling the job would be better cause it saves gate resources?)","commit_id":"04b3c286313e823cc62342bbe7c0304ee5a5a6c0"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"978fab71321144507029d17993983394551d3a00","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# bug/1648176"},{"line_number":6,"context_line":"UPGRADE_PROJECTS\u003d\"networking-ovn ${UPGRADE_PROJECTS/ networking-ovn/}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Common options for both base and target DevStack"},{"line_number":9,"context_line":"for i in base target; do"},{"line_number":10,"context_line":"    devstack_localrc $i enable_service q-svc ovn-northd ovn-controller networking-ovn-metadata-agent"},{"line_number":11,"context_line":"    devstack_localrc $i disable_service q-agt q-l3 q-dhcp q-meta n-net"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3fa7e38b_3247a94e","line":8,"in_reply_to":"3fa7e38b_8f3afae4","updated":"2019-09-18 12:33:43.000000000","message":"Agreed on IRC that will use branch-2.11 for both base and target.","commit_id":"04b3c286313e823cc62342bbe7c0304ee5a5a6c0"},{"author":{"_account_id":24791,"name":"Maciej Jozefczyk","email":"jeicam.pl@gmail.com","username":"maciej.jozefczyk"},"change_message_id":"345bc08218537e57afc4bd0d94231ed3c10775f0","unresolved":false,"context_lines":[{"line_number":5,"context_line":"# bug/1648176"},{"line_number":6,"context_line":"UPGRADE_PROJECTS\u003d\"networking-ovn ${UPGRADE_PROJECTS/ networking-ovn/}\""},{"line_number":7,"context_line":""},{"line_number":8,"context_line":"# Common options for both base and target DevStack"},{"line_number":9,"context_line":"for i in base target; do"},{"line_number":10,"context_line":"    devstack_localrc $i enable_service q-svc ovn-northd ovn-controller networking-ovn-metadata-agent"},{"line_number":11,"context_line":"    devstack_localrc $i disable_service q-agt q-l3 q-dhcp q-meta n-net"}],"source_content_type":"application/octet-stream","patch_set":3,"id":"3fa7e38b_8f3afae4","line":8,"in_reply_to":"3fa7e38b_ef64cebb","updated":"2019-09-18 12:25:42.000000000","message":"Hm,\nI got the point when we shouldn\u0027t be testing master ovn/ovs in stable jobs, but from the other hand granade jobs are about this upgrading stuff.\n\nSo should it stay untouched, what do you think?","commit_id":"04b3c286313e823cc62342bbe7c0304ee5a5a6c0"}]}